From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06482C433F5 for ; Thu, 14 Apr 2022 05:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239818AbiDNFJI (ORCPT ); Thu, 14 Apr 2022 01:09:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbiDNFJF (ORCPT ); Thu, 14 Apr 2022 01:09:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8444234B8F; Wed, 13 Apr 2022 22:06:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1087B61DC2; Thu, 14 Apr 2022 05:06:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49839C385A5; Thu, 14 Apr 2022 05:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649912801; bh=XBUayzHjBkqDCEo64onfaPK2C0N9kqILfvFCHrESHdE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=clIQkaTXdEXc4neZ1M0PsxrBQ0lcB+Nu30XCBVq57bzKgNDnNGATaJWqsHKtz7OXI N/7E0PKZOavfrpwXbEOSNVc/Tcw6qlCyeVNiEkDE1+I2cVaBL9ZDSXEDsxD8nndPV0 xKKKWfHShHNml4WHOGX1w28zmCMK6eCsmgC6allM= Date: Wed, 13 Apr 2022 22:06:36 -0700 From: Andrew Morton To: Yu Zhao Cc: Stephen Rothwell , linux-mm@kvack.org, Andi Kleen , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, page-reclaim@google.com, x86@kernel.org Subject: Re: [PATCH v10 00/14] Multi-Gen LRU Framework Message-Id: <20220413220636.dd33898d36156bc7339f04e9@linux-foundation.org> In-Reply-To: <20220407031525.2368067-1-yuzhao@google.com> References: <20220407031525.2368067-1-yuzhao@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code uses struct lru_gen_mm_walk *walk in some places and struct mm_walk *walk in others. This is already driving me nuts. Can we please use different identifiers for different types? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9926BC433F5 for ; Thu, 14 Apr 2022 05:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aoDQha/rdjZQ0DBo7ycCbmlfvXLK3CPQGnwEvsHnNVI=; b=h7HlpC6qycPptI Q5h+cbWGwCNpkigNaGirGDmGrfLhL+S3IKdLSA80VJWycSVzpTQUvXEe6KxtYEcOeX4vGqMnJR1bu MfS4J1sKrt/90SK8C4Sm4r8VZWHRFafiMBgRp4GnDnILxLOtw1ccUzh7hAf+VBrPzb957DJ62fbaI +kHp1YmXduuvkV4vrb4Kbnfxo/czjksmmVyY3uiTe04+PLxMc4yAa5hU3YTJYkzx9i75DC/cAOLg3 /AZGvJ+rZi/x8YnRhsBwTEhFVfDgoAdgJYnBx39TWhkK3oJGZnqDoYMe3Z3zUm2WQtHsAT93Evk9h gtdyZUma6A3So6To9zYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nergs-003tCH-Sw; Thu, 14 Apr 2022 05:06:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nergp-003tBV-IG for linux-arm-kernel@lists.infradead.org; Thu, 14 Apr 2022 05:06:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F18F261DEF; Thu, 14 Apr 2022 05:06:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49839C385A5; Thu, 14 Apr 2022 05:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649912801; bh=XBUayzHjBkqDCEo64onfaPK2C0N9kqILfvFCHrESHdE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=clIQkaTXdEXc4neZ1M0PsxrBQ0lcB+Nu30XCBVq57bzKgNDnNGATaJWqsHKtz7OXI N/7E0PKZOavfrpwXbEOSNVc/Tcw6qlCyeVNiEkDE1+I2cVaBL9ZDSXEDsxD8nndPV0 xKKKWfHShHNml4WHOGX1w28zmCMK6eCsmgC6allM= Date: Wed, 13 Apr 2022 22:06:36 -0700 From: Andrew Morton To: Yu Zhao Cc: Stephen Rothwell , linux-mm@kvack.org, Andi Kleen , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, page-reclaim@google.com, x86@kernel.org Subject: Re: [PATCH v10 00/14] Multi-Gen LRU Framework Message-Id: <20220413220636.dd33898d36156bc7339f04e9@linux-foundation.org> In-Reply-To: <20220407031525.2368067-1-yuzhao@google.com> References: <20220407031525.2368067-1-yuzhao@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_220643_701120_2B9EE093 X-CRM114-Status: UNSURE ( 9.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The code uses struct lru_gen_mm_walk *walk in some places and struct mm_walk *walk in others. This is already driving me nuts. Can we please use different identifiers for different types? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel