From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E872EC433FE for ; Thu, 14 Apr 2022 12:31:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3B84983EAF; Thu, 14 Apr 2022 14:31:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="VR6JcOj1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6373583EBD; Thu, 14 Apr 2022 14:31:19 +0200 (CEST) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AA0CA83EAC for ; Thu, 14 Apr 2022 14:31:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id bb38so3403344qtb.3 for ; Thu, 14 Apr 2022 05:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8dMSHuQa8AqiPT+GwdxhP6mkL1xMeeYyGR7hdqSH+HQ=; b=VR6JcOj104FLWkPFz4toIWYwkO8n8ehW4RavVK3Orhr15Tc/TmoJy9bL2S/Kald054 x+QlGaY37qozu+gzuNI6Z6aJ+VheGYSUF4SswMcZSYmLdtmHHSzN7lujYEmbryMkurgQ bvgDE4Soz6f57sVDOZOFMYasiwl+0HNx5+Mjo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8dMSHuQa8AqiPT+GwdxhP6mkL1xMeeYyGR7hdqSH+HQ=; b=f5pk3Glz2ymOrHIhGZDy8+9jXJIoSJYi0Rwe7MpzlyF1aC9PgxonP3J46iz1PsEfBQ T6YKZC8zLL/ja9Dh+TZbKEThIVnjZ5yqSSNOsT6kz6WQ7ht2LcSz8XUiDX2KMpYnZoNO Y+BFvhmVB3Poi5/F7gwzUb/J7m3Sb7hN6SPJQ3WgLuR4iZPfjRbburbAGNWdRbPS5ivg 6Kr1InbQ936hXcFh/hXOkxnvzM8KX1ELoCxuBAg2dOhxy+avf9WqGYgPIeCkWeL3G4kD i+VMnfB66wdbcFYzwFm5XDKxZAULFljdawnZ0s89kN4h4O0GkR7wvZlC4P1c1uOg/zJd A+iA== X-Gm-Message-State: AOAM530egWwd5pD/GNPlkuzeAdZhjKY/9WV20FMAs8nqCSQx70A03+yW jWSJW6qpxtRAKCCBkY1YgQkb+w== X-Google-Smtp-Source: ABdhPJxG6OrrUgkrxsInYmP5/NZNOziQiD6hJpkzAvVLUmGW+uJjurCcCdlcnomPX3Db+UtughH7EQ== X-Received: by 2002:ac8:570e:0:b0:2e2:2963:e2de with SMTP id 14-20020ac8570e000000b002e22963e2demr1481720qtw.123.1649939475169; Thu, 14 Apr 2022 05:31:15 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id u11-20020a05622a14cb00b002e1fd9dce3dsm1059971qtx.60.2022.04.14.05.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 05:31:14 -0700 (PDT) Date: Thu, 14 Apr 2022 08:31:12 -0400 From: Tom Rini To: AKASHI Takahiro , Simon Glass , U-Boot Mailing List Subject: Re: [PATCH v7 09/15] disk: Correct the conditions for SPL Message-ID: <20220414123112.GY14282@bill-the-cat> References: <20220228141657.1388834-1-sjg@chromium.org> <20220228141657.1388834-3-sjg@chromium.org> <20220414082152.GE32435@laputa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9N2P0WcOIPRHQV5z" Content-Disposition: inline In-Reply-To: <20220414082152.GE32435@laputa> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --9N2P0WcOIPRHQV5z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 14, 2022 at 05:21:52PM +0900, AKASHI Takahiro wrote: > Hi Simon, >=20 > On Mon, Feb 28, 2022 at 07:16:51AM -0700, Simon Glass wrote: > > These filesystems may have different settings for SPL and TPL. Use the > > correct Makefile variable to handle this. > >=20 > > Signed-off-by: Simon Glass > > --- > >=20 > > Changes in v7: > > - Add new patch to correct the conditions for SPL > >=20 > > disk/Makefile | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > >=20 > > diff --git a/disk/Makefile b/disk/Makefile > > index 6ce5a687b3..83f5af6069 100644 > > --- a/disk/Makefile > > +++ b/disk/Makefile > > @@ -6,8 +6,8 @@ > > #ccflags-y +=3D -DET_DEBUG -DDEBUG > > =20 > > obj-$(CONFIG_PARTITIONS) +=3D part.o > > -obj-$(CONFIG_$(SPL_)MAC_PARTITION) +=3D part_mac.o > > -obj-$(CONFIG_$(SPL_)DOS_PARTITION) +=3D part_dos.o > > -obj-$(CONFIG_$(SPL_)ISO_PARTITION) +=3D part_iso.o > > -obj-$(CONFIG_$(SPL_)AMIGA_PARTITION) +=3D part_amiga.o > > -obj-$(CONFIG_$(SPL_)EFI_PARTITION) +=3D part_efi.o > > +obj-$(CONFIG_$(SPL_TPL_)MAC_PARTITION) +=3D part_mac.o > > +obj-$(CONFIG_$(SPL_TPL_)DOS_PARTITION) +=3D part_dos.o > > +obj-$(CONFIG_$(SPL_TPL_)ISO_PARTITION) +=3D part_iso.o > > +obj-$(CONFIG_$(SPL_TPL_)AMIGA_PARTITION) +=3D part_amiga.o > > +obj-$(CONFIG_$(SPL_TPL_)EFI_PARTITION) +=3D part_efi.o >=20 > While none of CONFIG_TPL_xxx_PARTITION is defined, > how do those rules work for TPL? The makefile logic means that if the options are added then they would work as intended. With the options not being in Kconfig they'll simply never be evaluated to y. --=20 Tom --9N2P0WcOIPRHQV5z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJYFAYACgkQFHw5/5Y0 tyxZwAv/ZBLBel0rv+QJBH1JubTVbEgP++otnhLuyHPVBzW6TSmGSaPx8UtbNruj Uc+7T0QW9lWoNm+yc5B94B11fIr3cJpuepvpojRfS/VJo0HQ+auKPJSiH3JWV6ny vXxtfzU3ih+9yR+yp60xpFH/GL2p+bwNY1dq1WtHzowVaDam65zoQ0jnfW70sUIh 58ioQutr4avVYDIDYxlIS964cGe0xFzogCb8l9UZQjxmKnHytTLbKRyCEZ63jvHv Q7Sc50s67QP/ibQal4Uz4wN5+zwZ/BL3j8DqYROzdqWPvDPSUPcLpW8kpyewRMkr dvE9eX9qOOPx3hiLRT8jdTJISzfEKO4G/UQ/CLzT+TuVWsvbwXD1qaxqmcDpA/lt FXaLQ3DiQvV2V27UfweCXUnAMzTGkU/5f2HM/skoRm6QOYYe6exliE1M0ObBtNea lUQsD/GyDytAZezrYSlT74uQKyCv+kJvQpElHnFT/q0Gkhlrzm71xbBnqKd7bnmM gQiM3UL6 =Fz/9 -----END PGP SIGNATURE----- --9N2P0WcOIPRHQV5z--