From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89070C433EF for ; Thu, 14 Apr 2022 11:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242746AbiDNL1x (ORCPT ); Thu, 14 Apr 2022 07:27:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238980AbiDNL12 (ORCPT ); Thu, 14 Apr 2022 07:27:28 -0400 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 517243AA4D; Thu, 14 Apr 2022 04:25:02 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id BC95B20003; Thu, 14 Apr 2022 11:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1649935500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CpXnu283Y9BImJWjRcqDTNSCLv7O9zSkjtgobyNWNkk=; b=VFAvo1HKcbMfgjPRb2K9JOxVgtxYM2fmACdTAMdXP0BC1ewA06cPBHbL2LVnWCi+C5Cg26 mEYbILpM2nuTEikkL+qgf+6KRGYPdcSqYhjZz7Ow5ldkr4qodvIFf9Wo9J4XEzxA6L4FEz 4tGL+eHeZKNwe+wyHPqHnHzOSdLYm223GjiKHhl8wLIYojFKrptNVWdqLnmwISxS9H6GwL D/xaoxNPH0hOPaZFrdL+YeGYJ/5b5nWllgRj3/exsblpTuSJ5xtCto2d+iCqdz1tILV7Aa Z+PzrYk9/Yp37RTga3x2OLYx10YZjkWyhV5QM3KscvlE0Yp1h7Sos+XiDcGChA== Date: Thu, 14 Apr 2022 13:24:56 +0200 From: Miquel Raynal To: Geert Uytterhoeven Cc: Stephen Boyd , Gareth Williams , Magnus Damm , Phil Edworthy , Vinod Koul , Linux-Renesas , dmaengine , Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Thomas Petazzoni , Herve Codina , Clement Leger , Michael Turquette , linux-clk , Viresh Kumar , Andy Shevchenko , Ilpo Jarvinen , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH v8 0/9] RZN1 DMA support Message-ID: <20220414132456.30b19306@xps13> In-Reply-To: References: <20220406161856.1669069-1-miquel.raynal@bootlin.com> <20220407004511.3A6D1C385A3@smtp.kernel.org> <20220407101605.7d2a17cc@xps13> <20220412093155.090de9d6@xps13> <20220412094338.382e8754@xps13> <20220412100301.03ccece8@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Geert, geert@linux-m68k.org wrote on Tue, 12 Apr 2022 10:12:41 +0200: > Hi Miquel, >=20 > On Tue, Apr 12, 2022 at 10:03 AM Miquel Raynal > wrote: > > geert@linux-m68k.org wrote on Tue, 12 Apr 2022 09:52:25 +0200: =20 > > > On Tue, Apr 12, 2022 at 9:43 AM Miquel Raynal wrote: =20 > > > > geert@linux-m68k.org wrote on Tue, 12 Apr 2022 09:37:22 +0200: =20 > > > > > So far I've been rather terse in giving feedback on these series, > > > > > as I'm in wait-and-see mode w.r.t. what else you've planned for t= he > > > > > sysctrl DT node[1] and clock/sys controller code... > > > > > > > > > > [1] Did I say I'm not that fond of child nodes? But for the dmamu= x, > > > > > it looks like a good solution to handle this. =20 > > > > > > > > O:-) > > > > > > > > I plan in the coming days to write a proper reset controller driver > > > > that will be queried by the rtc driver (as proposed by Alexandre). = =20 > > > > > > OK. > > > =20 > > > > Which means I'll have to declare this reset controller as a child of > > > > the systrl node. If you disagree with it, you may jump-in, see this > > > > thread : > > > > > > > > Subject: Re: [PATCH 2/7] soc: renesas: rzn1-sysc: Export a > > > > function to enable/disable the RTC > > > > Date: Wed, 6 Apr 2022 10:32:31 +0200 =20 > > > > > > But do you need a child node for that? All(most all) other Renesas > > > clock drivers provide reset functionality, and none of them use a > > > child node for that. =20 > > > > How do you "request" the reset handle from the consumer driver if it's > > not described in the DT? Do you have examples to share? =20 >=20 > I didn't say it does not need to be described in DT ;-) >=20 > Just add "#reset-cells =3D <1>" to the sysctrl node, and nodes can > start referring to it using "resets =3D <&sysctrl N>". > Currently, the sysctrl node is already a clock and power-domain provider. >=20 > Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml > shows an R-Car CPG/MSSR node providing clock, power-domain, and > reset functionalities. While working on implementing a reset controller driver, I realized that almost all the clocks had a reset, which was already managed by the driver as part of a number of additional possible signals (gate reset, gate master idle, gate ready...). So I actually figured out that my issue originated from an incomplete description of the RTC clock gate, which I fulfilled. Now it works without the need for an additional exported symbol. Thanks, Miqu=C3=A8l