All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next v8 0/2] This is a patch series for Ethernet driver of Sunplus SP7021 SoC.
@ 2022-04-13  2:31 Wells Lu
  2022-04-13  2:31 ` [PATCH net-next v8 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021 Wells Lu
  2022-04-13  2:31 ` [PATCH net-next v8 2/2] net: ethernet: Add driver " Wells Lu
  0 siblings, 2 replies; 8+ messages in thread
From: Wells Lu @ 2022-04-13  2:31 UTC (permalink / raw)
  To: davem, kuba, robh+dt, netdev, devicetree, linux-kernel, p.zabel,
	pabeni, krzk+dt, roopa, andrew, edumazet
  Cc: wells.lu, Wells Lu

Sunplus SP7021 is an ARM Cortex A7 (4 cores) based SoC. It integrates
many peripherals (ex: UART, I2C, SPI, SDIO, eMMC, USB, SD card and
etc.) into a single chip. It is designed for industrial control
applications.

Refer to:
https://sunplus.atlassian.net/wiki/spaces/doc/overview
https://tibbo.com/store/plus1.html

Wells Lu (2):
  devicetree: bindings: net: Add bindings doc for Sunplus SP7021.
  net: ethernet: Add driver for Sunplus SP7021

 .../bindings/net/sunplus,sp7021-emac.yaml          | 140 +++++
 MAINTAINERS                                        |   8 +
 drivers/net/ethernet/Kconfig                       |   1 +
 drivers/net/ethernet/Makefile                      |   1 +
 drivers/net/ethernet/sunplus/Kconfig               |  35 ++
 drivers/net/ethernet/sunplus/Makefile              |   6 +
 drivers/net/ethernet/sunplus/spl2sw_define.h       | 271 +++++++++
 drivers/net/ethernet/sunplus/spl2sw_desc.c         | 226 ++++++++
 drivers/net/ethernet/sunplus/spl2sw_desc.h         |  19 +
 drivers/net/ethernet/sunplus/spl2sw_driver.c       | 604 +++++++++++++++++++++
 drivers/net/ethernet/sunplus/spl2sw_driver.h       |  12 +
 drivers/net/ethernet/sunplus/spl2sw_int.c          | 253 +++++++++
 drivers/net/ethernet/sunplus/spl2sw_int.h          |  13 +
 drivers/net/ethernet/sunplus/spl2sw_mac.c          | 346 ++++++++++++
 drivers/net/ethernet/sunplus/spl2sw_mac.h          |  19 +
 drivers/net/ethernet/sunplus/spl2sw_mdio.c         | 126 +++++
 drivers/net/ethernet/sunplus/spl2sw_mdio.h         |  12 +
 drivers/net/ethernet/sunplus/spl2sw_phy.c          |  92 ++++
 drivers/net/ethernet/sunplus/spl2sw_phy.h          |  12 +
 drivers/net/ethernet/sunplus/spl2sw_register.h     |  86 +++
 20 files changed, 2282 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/sunplus,sp7021-emac.yaml
 create mode 100644 drivers/net/ethernet/sunplus/Kconfig
 create mode 100644 drivers/net/ethernet/sunplus/Makefile
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_define.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_desc.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_desc.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_driver.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_driver.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_int.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_int.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mac.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mac.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mdio.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mdio.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_phy.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_phy.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_register.h

-- 
2.7.4


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH net-next v8 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021.
  2022-04-13  2:31 [PATCH net-next v8 0/2] This is a patch series for Ethernet driver of Sunplus SP7021 SoC Wells Lu
@ 2022-04-13  2:31 ` Wells Lu
  2022-04-13  2:31 ` [PATCH net-next v8 2/2] net: ethernet: Add driver " Wells Lu
  1 sibling, 0 replies; 8+ messages in thread
From: Wells Lu @ 2022-04-13  2:31 UTC (permalink / raw)
  To: davem, kuba, robh+dt, netdev, devicetree, linux-kernel, p.zabel,
	pabeni, krzk+dt, roopa, andrew, edumazet
  Cc: wells.lu, Wells Lu

Add bindings documentation for Sunplus SP7021 SoC.

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Wells Lu <wellslutw@gmail.com>
---
Changes in v8
  - None

 .../bindings/net/sunplus,sp7021-emac.yaml          | 140 +++++++++++++++++++++
 MAINTAINERS                                        |   7 ++
 2 files changed, 147 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/sunplus,sp7021-emac.yaml

diff --git a/Documentation/devicetree/bindings/net/sunplus,sp7021-emac.yaml b/Documentation/devicetree/bindings/net/sunplus,sp7021-emac.yaml
new file mode 100644
index 0000000..6dc15cd
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/sunplus,sp7021-emac.yaml
@@ -0,0 +1,140 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) Sunplus Co., Ltd. 2021
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/sunplus,sp7021-emac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sunplus SP7021 Dual Ethernet MAC Device Tree Bindings
+
+maintainers:
+  - Wells Lu <wellslutw@gmail.com>
+
+description: |
+  Sunplus SP7021 dual 10M/100M Ethernet MAC controller.
+  Device node of the controller has following properties.
+
+properties:
+  compatible:
+    const: sunplus,sp7021-emac
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  ethernet-ports:
+    type: object
+    description: Ethernet ports to PHY
+
+    properties:
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 0
+
+    patternProperties:
+      "^port@[0-1]$":
+        type: object
+        description: Port to PHY
+
+        properties:
+          reg:
+            minimum: 0
+            maximum: 1
+
+          phy-handle:
+            maxItems: 1
+
+          phy-mode:
+            maxItems: 1
+
+          nvmem-cells:
+            items:
+              - description: nvmem cell address of MAC address
+
+          nvmem-cell-names:
+            description: names corresponding to the nvmem cells
+            items:
+              - const: mac-address
+
+        required:
+          - reg
+          - phy-handle
+          - phy-mode
+          - nvmem-cells
+          - nvmem-cell-names
+
+  mdio:
+    $ref: mdio.yaml#
+    unevaluatedProperties: false
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - resets
+  - pinctrl-0
+  - pinctrl-names
+  - ethernet-ports
+  - mdio
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    ethernet@9c108000 {
+        compatible = "sunplus,sp7021-emac";
+        reg = <0x9c108000 0x400>;
+        interrupt-parent = <&intc>;
+        interrupts = <66 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&clkc 0xa7>;
+        resets = <&rstc 0x97>;
+        pinctrl-0 = <&emac_demo_board_v3_pins>;
+        pinctrl-names = "default";
+
+        ethernet-ports {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            port@0 {
+                reg = <0>;
+                phy-handle = <&eth_phy0>;
+                phy-mode = "rmii";
+                nvmem-cells = <&mac_addr0>;
+                nvmem-cell-names = "mac-address";
+            };
+
+            port@1 {
+                reg = <1>;
+                phy-handle = <&eth_phy1>;
+                phy-mode = "rmii";
+                nvmem-cells = <&mac_addr1>;
+                nvmem-cell-names = "mac-address";
+            };
+        };
+
+        mdio {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            eth_phy0: ethernet-phy@0 {
+                reg = <0>;
+            };
+
+            eth_phy1: ethernet-phy@1 {
+                reg = <1>;
+            };
+        };
+    };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index fd768d4..1d54292 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18869,6 +18869,13 @@ L:	netdev@vger.kernel.org
 S:	Maintained
 F:	drivers/net/ethernet/dlink/sundance.c
 
+SUNPLUS ETHERNET DRIVER
+M:	Wells Lu <wellslutw@gmail.com>
+L:	netdev@vger.kernel.org
+S:	Maintained
+W:	https://sunplus.atlassian.net/wiki/spaces/doc/overview
+F:	Documentation/devicetree/bindings/net/sunplus,sp7021-emac.yaml
+
 SUNPLUS OCOTP DRIVER
 M:	Vincent Shih <vincent.sunplus@gmail.com>
 S:	Maintained
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH net-next v8 2/2] net: ethernet: Add driver for Sunplus SP7021
  2022-04-13  2:31 [PATCH net-next v8 0/2] This is a patch series for Ethernet driver of Sunplus SP7021 SoC Wells Lu
  2022-04-13  2:31 ` [PATCH net-next v8 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021 Wells Lu
@ 2022-04-13  2:31 ` Wells Lu
  2022-04-14 12:18   ` Jakub Kicinski
  1 sibling, 1 reply; 8+ messages in thread
From: Wells Lu @ 2022-04-13  2:31 UTC (permalink / raw)
  To: davem, kuba, robh+dt, netdev, devicetree, linux-kernel, p.zabel,
	pabeni, krzk+dt, roopa, andrew, edumazet
  Cc: wells.lu, Wells Lu

Add driver for Sunplus SP7021 SoC.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Wells Lu <wellslutw@gmail.com>
---
Changes in v8
  - Fixed "WARNING: unmet direct dependencies detected for PINCTRL_SPPCTL".
    Removed 'select PINCTRL_SPPCTL' in Kconfig.
    Selecting PINCTRL_SPPCTL is not actually a must.

 MAINTAINERS                                    |   1 +
 drivers/net/ethernet/Kconfig                   |   1 +
 drivers/net/ethernet/Makefile                  |   1 +
 drivers/net/ethernet/sunplus/Kconfig           |  35 ++
 drivers/net/ethernet/sunplus/Makefile          |   6 +
 drivers/net/ethernet/sunplus/spl2sw_define.h   | 271 +++++++++++
 drivers/net/ethernet/sunplus/spl2sw_desc.c     | 226 +++++++++
 drivers/net/ethernet/sunplus/spl2sw_desc.h     |  19 +
 drivers/net/ethernet/sunplus/spl2sw_driver.c   | 604 +++++++++++++++++++++++++
 drivers/net/ethernet/sunplus/spl2sw_driver.h   |  12 +
 drivers/net/ethernet/sunplus/spl2sw_int.c      | 253 +++++++++++
 drivers/net/ethernet/sunplus/spl2sw_int.h      |  13 +
 drivers/net/ethernet/sunplus/spl2sw_mac.c      | 346 ++++++++++++++
 drivers/net/ethernet/sunplus/spl2sw_mac.h      |  19 +
 drivers/net/ethernet/sunplus/spl2sw_mdio.c     | 126 ++++++
 drivers/net/ethernet/sunplus/spl2sw_mdio.h     |  12 +
 drivers/net/ethernet/sunplus/spl2sw_phy.c      |  92 ++++
 drivers/net/ethernet/sunplus/spl2sw_phy.h      |  12 +
 drivers/net/ethernet/sunplus/spl2sw_register.h |  86 ++++
 19 files changed, 2135 insertions(+)
 create mode 100644 drivers/net/ethernet/sunplus/Kconfig
 create mode 100644 drivers/net/ethernet/sunplus/Makefile
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_define.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_desc.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_desc.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_driver.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_driver.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_int.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_int.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mac.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mac.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mdio.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mdio.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_phy.c
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_phy.h
 create mode 100644 drivers/net/ethernet/sunplus/spl2sw_register.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 1d54292..0269797 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18875,6 +18875,7 @@ L:	netdev@vger.kernel.org
 S:	Maintained
 W:	https://sunplus.atlassian.net/wiki/spaces/doc/overview
 F:	Documentation/devicetree/bindings/net/sunplus,sp7021-emac.yaml
+F:	drivers/net/ethernet/sunplus/
 
 SUNPLUS OCOTP DRIVER
 M:	Vincent Shih <vincent.sunplus@gmail.com>
diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
index bd4cb9d..8828539 100644
--- a/drivers/net/ethernet/Kconfig
+++ b/drivers/net/ethernet/Kconfig
@@ -179,6 +179,7 @@ source "drivers/net/ethernet/smsc/Kconfig"
 source "drivers/net/ethernet/socionext/Kconfig"
 source "drivers/net/ethernet/stmicro/Kconfig"
 source "drivers/net/ethernet/sun/Kconfig"
+source "drivers/net/ethernet/sunplus/Kconfig"
 source "drivers/net/ethernet/synopsys/Kconfig"
 source "drivers/net/ethernet/tehuti/Kconfig"
 source "drivers/net/ethernet/ti/Kconfig"
diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
index 8ef43e0..9eb0116 100644
--- a/drivers/net/ethernet/Makefile
+++ b/drivers/net/ethernet/Makefile
@@ -90,6 +90,7 @@ obj-$(CONFIG_NET_VENDOR_SMSC) += smsc/
 obj-$(CONFIG_NET_VENDOR_SOCIONEXT) += socionext/
 obj-$(CONFIG_NET_VENDOR_STMICRO) += stmicro/
 obj-$(CONFIG_NET_VENDOR_SUN) += sun/
+obj-$(CONFIG_NET_VENDOR_SUNPLUS) += sunplus/
 obj-$(CONFIG_NET_VENDOR_TEHUTI) += tehuti/
 obj-$(CONFIG_NET_VENDOR_TI) += ti/
 obj-$(CONFIG_NET_VENDOR_TOSHIBA) += toshiba/
diff --git a/drivers/net/ethernet/sunplus/Kconfig b/drivers/net/ethernet/sunplus/Kconfig
new file mode 100644
index 0000000..d0144a2
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/Kconfig
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Sunplus network device configuration
+#
+
+config NET_VENDOR_SUNPLUS
+	bool "Sunplus devices"
+	default y
+	depends on ARCH_SUNPLUS || COMPILE_TEST
+	help
+	  If you have a network (Ethernet) card belonging to this
+	  class, say Y here.
+
+	  Note that the answer to this question doesn't directly
+	  affect the kernel: saying N will just cause the configurator
+	  to skip all the questions about Sunplus cards. If you say Y,
+	  you will be asked for your specific card in the following
+	  questions.
+
+if NET_VENDOR_SUNPLUS
+
+config SP7021_EMAC
+	tristate "Sunplus Dual 10M/100M Ethernet devices"
+	depends on SOC_SP7021 || COMPILE_TEST
+	select PHYLIB
+	select COMMON_CLK_SP7021
+	select RESET_SUNPLUS
+	select NVMEM_SUNPLUS_OCOTP
+	help
+	  If you have Sunplus dual 10M/100M Ethernet devices, say Y.
+	  The network device creates two net-device interfaces.
+	  To compile this driver as a module, choose M here. The
+	  module will be called sp7021_emac.
+
+endif # NET_VENDOR_SUNPLUS
diff --git a/drivers/net/ethernet/sunplus/Makefile b/drivers/net/ethernet/sunplus/Makefile
new file mode 100644
index 0000000..ef7d7d0
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/Makefile
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Makefile for the Sunplus network device drivers.
+#
+obj-$(CONFIG_SP7021_EMAC) += sp7021_emac.o
+sp7021_emac-objs := spl2sw_driver.o spl2sw_int.o spl2sw_desc.o spl2sw_mac.o spl2sw_mdio.o spl2sw_phy.o
diff --git a/drivers/net/ethernet/sunplus/spl2sw_define.h b/drivers/net/ethernet/sunplus/spl2sw_define.h
new file mode 100644
index 0000000..f299bda
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_define.h
@@ -0,0 +1,271 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#ifndef __SPL2SW_DEFINE_H__
+#define __SPL2SW_DEFINE_H__
+
+#define MAX_NETDEV_NUM			2	/* Maximum # of net-device */
+
+/* Interrupt status */
+#define MAC_INT_DAISY_MODE_CHG		BIT(31) /* Daisy Mode Change             */
+#define MAC_INT_IP_CHKSUM_ERR		BIT(23) /* IP Checksum Append Error      */
+#define MAC_INT_WDOG_TIMER1_EXP		BIT(22) /* Watchdog Timer1 Expired       */
+#define MAC_INT_WDOG_TIMER0_EXP		BIT(21) /* Watchdog Timer0 Expired       */
+#define MAC_INT_INTRUDER_ALERT		BIT(20) /* Atruder Alert                 */
+#define MAC_INT_PORT_ST_CHG		BIT(19) /* Port Status Change            */
+#define MAC_INT_BC_STORM		BIT(18) /* Broad Cast Storm              */
+#define MAC_INT_MUST_DROP_LAN		BIT(17) /* Global Queue Exhausted        */
+#define MAC_INT_GLOBAL_QUE_FULL		BIT(16) /* Global Queue Full             */
+#define MAC_INT_TX_SOC_PAUSE_ON		BIT(15) /* Soc Port TX Pause On          */
+#define MAC_INT_RX_SOC_QUE_FULL		BIT(14) /* Soc Port Out Queue Full       */
+#define MAC_INT_TX_LAN1_QUE_FULL	BIT(9)  /* Port 1 Out Queue Full         */
+#define MAC_INT_TX_LAN0_QUE_FULL	BIT(8)  /* Port 0 Out Queue Full         */
+#define MAC_INT_RX_L_DESCF		BIT(7)  /* Low Priority Descriptor Full  */
+#define MAC_INT_RX_H_DESCF		BIT(6)  /* High Priority Descriptor Full */
+#define MAC_INT_RX_DONE_L		BIT(5)  /* RX Low Priority Done          */
+#define MAC_INT_RX_DONE_H		BIT(4)  /* RX High Priority Done         */
+#define MAC_INT_TX_DONE_L		BIT(3)  /* TX Low Priority Done          */
+#define MAC_INT_TX_DONE_H		BIT(2)  /* TX High Priority Done         */
+#define MAC_INT_TX_DES_ERR		BIT(1)  /* TX Descriptor Error           */
+#define MAC_INT_RX_DES_ERR		BIT(0)  /* Rx Descriptor Error           */
+
+#define MAC_INT_RX			(MAC_INT_RX_DONE_H | MAC_INT_RX_DONE_L | \
+					MAC_INT_RX_DES_ERR)
+#define MAC_INT_TX			(MAC_INT_TX_DONE_L | MAC_INT_TX_DONE_H | \
+					MAC_INT_TX_DES_ERR)
+#define MAC_INT_MASK_DEF		(MAC_INT_DAISY_MODE_CHG | MAC_INT_IP_CHKSUM_ERR | \
+					MAC_INT_WDOG_TIMER1_EXP | MAC_INT_WDOG_TIMER0_EXP | \
+					MAC_INT_INTRUDER_ALERT | MAC_INT_PORT_ST_CHG | \
+					MAC_INT_BC_STORM | MAC_INT_MUST_DROP_LAN | \
+					MAC_INT_GLOBAL_QUE_FULL | MAC_INT_TX_SOC_PAUSE_ON | \
+					MAC_INT_RX_SOC_QUE_FULL | MAC_INT_TX_LAN1_QUE_FULL | \
+					MAC_INT_TX_LAN0_QUE_FULL | MAC_INT_RX_L_DESCF | \
+					MAC_INT_RX_H_DESCF)
+
+/* Address table search */
+#define MAC_ADDR_LOOKUP_IDLE		BIT(2)
+#define MAC_SEARCH_NEXT_ADDR		BIT(1)
+#define MAC_BEGIN_SEARCH_ADDR		BIT(0)
+
+/* Address table status */
+#define MAC_HASH_LOOKUP_ADDR		GENMASK(31, 22)
+#define MAC_R_PORT_MAP			GENMASK(13, 12)
+#define MAC_R_CPU_PORT			GENMASK(11, 10)
+#define MAC_R_VID			GENMASK(9, 7)
+#define MAC_R_AGE			GENMASK(6, 4)
+#define MAC_R_PROXY			BIT(3)
+#define MAC_R_MC_INGRESS		BIT(2)
+#define MAC_AT_TABLE_END		BIT(1)
+#define MAC_AT_DATA_READY		BIT(0)
+
+/* Wt mac ad0 */
+#define MAC_W_PORT_MAP			GENMASK(13, 12)
+#define MAC_W_LAN_PORT_1		BIT(13)
+#define MAC_W_LAN_PORT_0		BIT(12)
+#define MAC_W_CPU_PORT			GENMASK(11, 10)
+#define MAC_W_CPU_PORT_1		BIT(11)
+#define MAC_W_CPU_PORT_0		BIT(10)
+#define MAC_W_VID			GENMASK(9, 7)
+#define MAC_W_AGE			GENMASK(6, 4)
+#define MAC_W_PROXY			BIT(3)
+#define MAC_W_MC_INGRESS		BIT(2)
+#define MAC_W_MAC_DONE			BIT(1)
+#define MAC_W_MAC_CMD			BIT(0)
+
+/* W mac 15_0 bus */
+#define MAC_W_MAC_15_0			GENMASK(15, 0)
+
+/* W mac 47_16 bus */
+#define MAC_W_MAC_47_16			GENMASK(31, 0)
+
+/* PVID config 0 */
+#define MAC_P1_PVID			GENMASK(6, 4)
+#define MAC_P0_PVID			GENMASK(2, 0)
+
+/* VLAN member config 0 */
+#define MAC_VLAN_MEMSET_3		GENMASK(27, 24)
+#define MAC_VLAN_MEMSET_2		GENMASK(19, 16)
+#define MAC_VLAN_MEMSET_1		GENMASK(11, 8)
+#define MAC_VLAN_MEMSET_0		GENMASK(3, 0)
+
+/* VLAN member config 1 */
+#define MAC_VLAN_MEMSET_5		GENMASK(11, 8)
+#define MAC_VLAN_MEMSET_4		GENMASK(3, 0)
+
+/* Port ability */
+#define MAC_PORT_ABILITY_LINK_ST	GENMASK(25, 24)
+
+/* CPU control */
+#define MAC_EN_SOC1_AGING		BIT(15)
+#define MAC_EN_SOC0_AGING		BIT(14)
+#define MAC_DIS_LRN_SOC1		BIT(13)
+#define MAC_DIS_LRN_SOC0		BIT(12)
+#define MAC_EN_CRC_SOC1			BIT(9)
+#define MAC_EN_CRC_SOC0			BIT(8)
+#define MAC_DIS_SOC1_CPU		BIT(7)
+#define MAC_DIS_SOC0_CPU		BIT(6)
+#define MAC_DIS_BC2CPU_P1		BIT(5)
+#define MAC_DIS_BC2CPU_P0		BIT(4)
+#define MAC_DIS_MC2CPU			GENMASK(3, 2)
+#define MAC_DIS_MC2CPU_P1		BIT(3)
+#define MAC_DIS_MC2CPU_P0		BIT(2)
+#define MAC_DIS_UN2CPU			GENMASK(1, 0)
+
+/* Port control 0 */
+#define MAC_DIS_PORT			GENMASK(25, 24)
+#define MAC_DIS_PORT1			BIT(25)
+#define MAC_DIS_PORT0			BIT(24)
+#define MAC_DIS_RMC2CPU_P1		BIT(17)
+#define MAC_DIS_RMC2CPU_P0		BIT(16)
+#define MAC_EN_FLOW_CTL_P1		BIT(9)
+#define MAC_EN_FLOW_CTL_P0		BIT(8)
+#define MAC_EN_BACK_PRESS_P1		BIT(1)
+#define MAC_EN_BACK_PRESS_P0		BIT(0)
+
+/* Port control 1 */
+#define MAC_DIS_SA_LRN_P1		BIT(9)
+#define MAC_DIS_SA_LRN_P0		BIT(8)
+
+/* Port control 2 */
+#define MAC_EN_AGING_P1			BIT(9)
+#define MAC_EN_AGING_P0			BIT(8)
+
+/* Switch Global control */
+#define MAC_RMC_TB_FAULT_RULE		GENMASK(26, 25)
+#define MAC_LED_FLASH_TIME		GENMASK(24, 23)
+#define MAC_BC_STORM_PREV		GENMASK(5, 4)
+
+/* LED port 0 */
+#define MAC_LED_ACT_HI			BIT(28)
+
+/* PHY control register 0  */
+#define MAC_CPU_PHY_WT_DATA		GENMASK(31, 16)
+#define MAC_CPU_PHY_CMD			GENMASK(14, 13)
+#define MAC_CPU_PHY_REG_ADDR		GENMASK(12, 8)
+#define MAC_CPU_PHY_ADDR		GENMASK(4, 0)
+
+/* PHY control register 1 */
+#define MAC_CPU_PHY_RD_DATA		GENMASK(31, 16)
+#define MAC_PHY_RD_RDY			BIT(1)
+#define MAC_PHY_WT_DONE			BIT(0)
+
+/* MAC force mode */
+#define MAC_EXT_PHY1_ADDR		GENMASK(28, 24)
+#define MAC_EXT_PHY0_ADDR		GENMASK(20, 16)
+#define MAC_FORCE_RMII_LINK		GENMASK(9, 8)
+#define MAC_FORCE_RMII_EN_1		BIT(7)
+#define MAC_FORCE_RMII_EN_0		BIT(6)
+#define MAC_FORCE_RMII_FC		GENMASK(5, 4)
+#define MAC_FORCE_RMII_DPX		GENMASK(3, 2)
+#define MAC_FORCE_RMII_SPD		GENMASK(1, 0)
+
+/* CPU transmit trigger */
+#define MAC_TRIG_L_SOC0			BIT(1)
+#define MAC_TRIG_H_SOC0			BIT(0)
+
+/* Config descriptor queue */
+#define TX_DESC_NUM			16	/* # of descriptors in TX queue   */
+#define MAC_GUARD_DESC_NUM		2	/* # of descriptors of gap      0 */
+#define RX_QUEUE0_DESC_NUM		16	/* # of descriptors in RX queue 0 */
+#define RX_QUEUE1_DESC_NUM		16	/* # of descriptors in RX queue 1 */
+#define TX_DESC_QUEUE_NUM		1	/* # of TX queue                  */
+#define RX_DESC_QUEUE_NUM		2	/* # of RX queue                  */
+
+#define MAC_RX_LEN_MAX			2047	/* Size of RX buffer       */
+
+/* Tx descriptor */
+/* cmd1 */
+#define TXD_OWN				BIT(31)
+#define TXD_ERR_CODE			GENMASK(29, 26)
+#define TXD_SOP				BIT(25)		/* start of a packet */
+#define TXD_EOP				BIT(24)		/* end of a packet */
+#define TXD_VLAN			GENMASK(17, 12)
+#define TXD_PKT_LEN			GENMASK(10, 0)	/* packet length */
+/* cmd2 */
+#define TXD_EOR				BIT(31)		/* end of ring */
+#define TXD_BUF_LEN2			GENMASK(22, 12)
+#define TXD_BUF_LEN1			GENMASK(10, 0)
+
+/* Rx descriptor */
+/* cmd1 */
+#define RXD_OWN				BIT(31)
+#define RXD_ERR_CODE			GENMASK(29, 26)
+#define RXD_TCP_UDP_CHKSUM		BIT(23)
+#define RXD_PROXY			BIT(22)
+#define RXD_PROTOCOL			GENMASK(21, 20)
+#define RXD_VLAN_TAG			BIT(19)
+#define RXD_IP_CHKSUM			BIT(18)
+#define RXD_ROUTE_TYPE			GENMASK(17, 16)
+#define RXD_PKT_SP			GENMASK(14, 12)	/* packet source port */
+#define RXD_PKT_LEN			GENMASK(10, 0)	/* packet length */
+/* cmd2 */
+#define RXD_EOR				BIT(31)		/* end of ring */
+#define RXD_BUF_LEN2			GENMASK(22, 12)
+#define RXD_BUF_LEN1			GENMASK(10, 0)
+
+/* structure of descriptor */
+struct spl2sw_mac_desc {
+	u32 cmd1;
+	u32 cmd2;
+	u32 addr1;
+	u32 addr2;
+};
+
+struct spl2sw_skb_info {
+	struct sk_buff *skb;
+	u32 mapping;
+	u32 len;
+};
+
+struct spl2sw_common {
+	void __iomem *l2sw_reg_base;
+
+	struct platform_device *pdev;
+	struct reset_control *rstc;
+	struct clk *clk;
+	int irq;
+
+	void *desc_base;
+	dma_addr_t desc_dma;
+	s32 desc_size;
+	struct spl2sw_mac_desc *rx_desc[RX_DESC_QUEUE_NUM];
+	struct spl2sw_skb_info *rx_skb_info[RX_DESC_QUEUE_NUM];
+	u32 rx_pos[RX_DESC_QUEUE_NUM];
+	u32 rx_desc_num[RX_DESC_QUEUE_NUM];
+	u32 rx_desc_buff_size;
+
+	struct spl2sw_mac_desc *tx_desc;
+	struct spl2sw_skb_info tx_temp_skb_info[TX_DESC_NUM];
+	u32 tx_done_pos;
+	u32 tx_pos;
+	u32 tx_desc_full;
+
+	struct net_device *ndev[MAX_NETDEV_NUM];
+	struct mii_bus *mii_bus;
+
+	struct napi_struct rx_napi;
+	struct napi_struct tx_napi;
+
+	spinlock_t rx_lock;	/* spinlock for accessing rx buffer */
+	spinlock_t tx_lock;	/* spinlock for accessing tx buffer */
+	spinlock_t mdio_lock;	/* spinlock for mdio commands */
+
+	u8 enable;
+};
+
+struct spl2sw_mac {
+	struct net_device *ndev;
+	struct spl2sw_common *comm;
+
+	u8 mac_addr[ETH_ALEN];
+	phy_interface_t phy_mode;
+	struct device_node *phy_node;
+
+	u8 lan_port;
+	u8 to_vlan;
+	u8 vlan_id;
+};
+
+#endif
diff --git a/drivers/net/ethernet/sunplus/spl2sw_desc.c b/drivers/net/ethernet/sunplus/spl2sw_desc.c
new file mode 100644
index 0000000..7d237d4
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_desc.c
@@ -0,0 +1,226 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#include <linux/platform_device.h>
+#include <linux/netdevice.h>
+#include <linux/of_mdio.h>
+
+#include "spl2sw_define.h"
+#include "spl2sw_desc.h"
+
+void spl2sw_rx_descs_flush(struct spl2sw_common *comm)
+{
+	struct spl2sw_skb_info *rx_skbinfo;
+	struct spl2sw_mac_desc *rx_desc;
+	u32 i, j;
+
+	for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
+		rx_desc = comm->rx_desc[i];
+		rx_skbinfo = comm->rx_skb_info[i];
+		for (j = 0; j < comm->rx_desc_num[i]; j++) {
+			rx_desc[j].addr1 = rx_skbinfo[j].mapping;
+			rx_desc[j].cmd2 = (j == comm->rx_desc_num[i] - 1) ?
+					  RXD_EOR | comm->rx_desc_buff_size :
+					  comm->rx_desc_buff_size;
+			wmb();	/* Set RXD_OWN after other fields are ready. */
+			rx_desc[j].cmd1 = RXD_OWN;
+		}
+	}
+}
+
+void spl2sw_tx_descs_clean(struct spl2sw_common *comm)
+{
+	u32 i;
+
+	if (!comm->tx_desc)
+		return;
+
+	for (i = 0; i < TX_DESC_NUM; i++) {
+		comm->tx_desc[i].cmd1 = 0;
+		wmb();	/* Clear TXD_OWN and then set other fields. */
+		comm->tx_desc[i].cmd2 = 0;
+		comm->tx_desc[i].addr1 = 0;
+		comm->tx_desc[i].addr2 = 0;
+
+		if (comm->tx_temp_skb_info[i].mapping) {
+			dma_unmap_single(&comm->pdev->dev, comm->tx_temp_skb_info[i].mapping,
+					 comm->tx_temp_skb_info[i].skb->len, DMA_TO_DEVICE);
+			comm->tx_temp_skb_info[i].mapping = 0;
+		}
+
+		if (comm->tx_temp_skb_info[i].skb) {
+			dev_kfree_skb_any(comm->tx_temp_skb_info[i].skb);
+			comm->tx_temp_skb_info[i].skb = NULL;
+		}
+	}
+}
+
+void spl2sw_rx_descs_clean(struct spl2sw_common *comm)
+{
+	struct spl2sw_skb_info *rx_skbinfo;
+	struct spl2sw_mac_desc *rx_desc;
+	u32 i, j;
+
+	for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
+		if (!comm->rx_skb_info[i])
+			continue;
+
+		rx_desc = comm->rx_desc[i];
+		rx_skbinfo = comm->rx_skb_info[i];
+		for (j = 0; j < comm->rx_desc_num[i]; j++) {
+			rx_desc[j].cmd1 = 0;
+			wmb();	/* Clear RXD_OWN and then set other fields. */
+			rx_desc[j].cmd2 = 0;
+			rx_desc[j].addr1 = 0;
+
+			if (rx_skbinfo[j].skb) {
+				dma_unmap_single(&comm->pdev->dev, rx_skbinfo[j].mapping,
+						 comm->rx_desc_buff_size, DMA_FROM_DEVICE);
+				dev_kfree_skb_any(rx_skbinfo[j].skb);
+				rx_skbinfo[j].skb = NULL;
+				rx_skbinfo[j].mapping = 0;
+			}
+		}
+
+		kfree(rx_skbinfo);
+		comm->rx_skb_info[i] = NULL;
+	}
+}
+
+void spl2sw_descs_clean(struct spl2sw_common *comm)
+{
+	spl2sw_rx_descs_clean(comm);
+	spl2sw_tx_descs_clean(comm);
+}
+
+void spl2sw_descs_free(struct spl2sw_common *comm)
+{
+	u32 i;
+
+	spl2sw_descs_clean(comm);
+	comm->tx_desc = NULL;
+	for (i = 0; i < RX_DESC_QUEUE_NUM; i++)
+		comm->rx_desc[i] = NULL;
+
+	/*  Free descriptor area  */
+	if (comm->desc_base) {
+		dma_free_coherent(&comm->pdev->dev, comm->desc_size, comm->desc_base,
+				  comm->desc_dma);
+		comm->desc_base = NULL;
+		comm->desc_dma = 0;
+		comm->desc_size = 0;
+	}
+}
+
+void spl2sw_tx_descs_init(struct spl2sw_common *comm)
+{
+	memset(comm->tx_desc, '\0', sizeof(struct spl2sw_mac_desc) *
+	       (TX_DESC_NUM + MAC_GUARD_DESC_NUM));
+}
+
+int spl2sw_rx_descs_init(struct spl2sw_common *comm)
+{
+	struct spl2sw_skb_info *rx_skbinfo;
+	struct spl2sw_mac_desc *rx_desc;
+	struct sk_buff *skb;
+	u32 i, j;
+
+	for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
+		comm->rx_skb_info[i] = kcalloc(comm->rx_desc_num[i], sizeof(*rx_skbinfo),
+					       GFP_KERNEL | GFP_DMA);
+		if (!comm->rx_skb_info[i])
+			goto mem_alloc_fail;
+
+		rx_skbinfo = comm->rx_skb_info[i];
+		rx_desc = comm->rx_desc[i];
+		for (j = 0; j < comm->rx_desc_num[i]; j++) {
+			skb = netdev_alloc_skb(NULL, comm->rx_desc_buff_size);
+			if (!skb)
+				goto mem_alloc_fail;
+
+			rx_skbinfo[j].skb = skb;
+			rx_skbinfo[j].mapping = dma_map_single(&comm->pdev->dev, skb->data,
+							       comm->rx_desc_buff_size,
+							       DMA_FROM_DEVICE);
+			if (dma_mapping_error(&comm->pdev->dev, rx_skbinfo[j].mapping))
+				goto mem_alloc_fail;
+
+			rx_desc[j].addr1 = rx_skbinfo[j].mapping;
+			rx_desc[j].addr2 = 0;
+			rx_desc[j].cmd2 = (j == comm->rx_desc_num[i] - 1) ?
+					  RXD_EOR | comm->rx_desc_buff_size :
+					  comm->rx_desc_buff_size;
+			wmb();	/* Set RXD_OWN after other fields are effective. */
+			rx_desc[j].cmd1 = RXD_OWN;
+		}
+	}
+
+	return 0;
+
+mem_alloc_fail:
+	spl2sw_rx_descs_clean(comm);
+	return -ENOMEM;
+}
+
+int spl2sw_descs_alloc(struct spl2sw_common *comm)
+{
+	s32 desc_size;
+	u32 i;
+
+	/* Alloc descriptor area  */
+	desc_size = (TX_DESC_NUM + MAC_GUARD_DESC_NUM) * sizeof(struct spl2sw_mac_desc);
+	for (i = 0; i < RX_DESC_QUEUE_NUM; i++)
+		desc_size += comm->rx_desc_num[i] * sizeof(struct spl2sw_mac_desc);
+
+	comm->desc_base = dma_alloc_coherent(&comm->pdev->dev, desc_size, &comm->desc_dma,
+					     GFP_KERNEL);
+	if (!comm->desc_base)
+		return -ENOMEM;
+
+	comm->desc_size = desc_size;
+
+	/* Setup Tx descriptor */
+	comm->tx_desc = comm->desc_base;
+
+	/* Setup Rx descriptor */
+	comm->rx_desc[0] = &comm->tx_desc[TX_DESC_NUM + MAC_GUARD_DESC_NUM];
+	for (i = 1; i < RX_DESC_QUEUE_NUM; i++)
+		comm->rx_desc[i] = comm->rx_desc[i - 1] + comm->rx_desc_num[i - 1];
+
+	return 0;
+}
+
+int spl2sw_descs_init(struct spl2sw_common *comm)
+{
+	u32 i, ret;
+
+	/* Initialize rx descriptor's data */
+	comm->rx_desc_num[0] = RX_QUEUE0_DESC_NUM;
+	comm->rx_desc_num[1] = RX_QUEUE1_DESC_NUM;
+
+	for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
+		comm->rx_desc[i] = NULL;
+		comm->rx_skb_info[i] = NULL;
+		comm->rx_pos[i] = 0;
+	}
+	comm->rx_desc_buff_size = MAC_RX_LEN_MAX;
+
+	/* Initialize tx descriptor's data */
+	comm->tx_done_pos = 0;
+	comm->tx_desc = NULL;
+	comm->tx_pos = 0;
+	comm->tx_desc_full = 0;
+	for (i = 0; i < TX_DESC_NUM; i++)
+		comm->tx_temp_skb_info[i].skb = NULL;
+
+	/* Allocate tx & rx descriptors. */
+	ret = spl2sw_descs_alloc(comm);
+	if (ret)
+		return ret;
+
+	spl2sw_tx_descs_init(comm);
+
+	return spl2sw_rx_descs_init(comm);
+}
diff --git a/drivers/net/ethernet/sunplus/spl2sw_desc.h b/drivers/net/ethernet/sunplus/spl2sw_desc.h
new file mode 100644
index 0000000..f04e2d8
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_desc.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#ifndef __SPL2SW_DESC_H__
+#define __SPL2SW_DESC_H__
+
+void spl2sw_rx_descs_flush(struct spl2sw_common *comm);
+void spl2sw_tx_descs_clean(struct spl2sw_common *comm);
+void spl2sw_rx_descs_clean(struct spl2sw_common *comm);
+void spl2sw_descs_clean(struct spl2sw_common *comm);
+void spl2sw_descs_free(struct spl2sw_common *comm);
+void spl2sw_tx_descs_init(struct spl2sw_common *comm);
+int  spl2sw_rx_descs_init(struct spl2sw_common *comm);
+int  spl2sw_descs_alloc(struct spl2sw_common *comm);
+int  spl2sw_descs_init(struct spl2sw_common *comm);
+
+#endif
diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c
new file mode 100644
index 0000000..89938ba
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c
@@ -0,0 +1,604 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#include <linux/platform_device.h>
+#include <linux/nvmem-consumer.h>
+#include <linux/etherdevice.h>
+#include <linux/netdevice.h>
+#include <linux/of_net.h>
+#include <linux/reset.h>
+#include <linux/clk.h>
+#include <linux/of.h>
+
+#include "spl2sw_register.h"
+#include "spl2sw_define.h"
+#include "spl2sw_driver.h"
+#include "spl2sw_desc.h"
+#include "spl2sw_mdio.h"
+#include "spl2sw_phy.h"
+#include "spl2sw_int.h"
+#include "spl2sw_mac.h"
+
+/* net device operations */
+static int spl2sw_ethernet_open(struct net_device *ndev)
+{
+	struct spl2sw_mac *mac = netdev_priv(ndev);
+	struct spl2sw_common *comm = mac->comm;
+	u32 mask;
+
+	netdev_dbg(ndev, "Open port = %x\n", mac->lan_port);
+
+	comm->enable |= mac->lan_port;
+
+	spl2sw_mac_hw_start(comm);
+
+	/* Enable TX and RX interrupts */
+	mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+	mask &= ~(MAC_INT_TX | MAC_INT_RX);
+	writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+
+	phy_start(ndev->phydev);
+
+	netif_start_queue(ndev);
+
+	return 0;
+}
+
+static int spl2sw_ethernet_stop(struct net_device *ndev)
+{
+	struct spl2sw_mac *mac = netdev_priv(ndev);
+	struct spl2sw_common *comm = mac->comm;
+
+	netif_stop_queue(ndev);
+
+	comm->enable &= ~mac->lan_port;
+
+	phy_stop(ndev->phydev);
+
+	spl2sw_mac_hw_stop(comm);
+
+	return 0;
+}
+
+static int spl2sw_ethernet_start_xmit(struct sk_buff *skb, struct net_device *ndev)
+{
+	struct spl2sw_mac *mac = netdev_priv(ndev);
+	struct spl2sw_common *comm = mac->comm;
+	struct spl2sw_skb_info *skbinfo;
+	struct spl2sw_mac_desc *txdesc;
+	unsigned long flags;
+	u32 tx_pos;
+	u32 cmd1;
+	u32 cmd2;
+
+	if (unlikely(comm->tx_desc_full == 1)) {
+		/* No TX descriptors left. Wait for tx interrupt. */
+		netdev_dbg(ndev, "TX descriptor queue full when xmit!\n");
+		return NETDEV_TX_BUSY;
+	}
+
+	/* If skb size is shorter than ETH_ZLEN (60), pad it with 0. */
+	if (unlikely(skb->len < ETH_ZLEN)) {
+		if (skb_tailroom(skb) >= (ETH_ZLEN - skb->len)) {
+			memset(skb_put(skb, ETH_ZLEN - skb->len), '\0',
+			       ETH_ZLEN - skb->len);
+		} else {
+			struct sk_buff *old_skb = skb;
+
+			skb = netdev_alloc_skb(ndev, ETH_ZLEN);
+			if (skb) {
+				memset(skb->data + old_skb->len, '\0',
+				       ETH_ZLEN - old_skb->len);
+				memcpy(skb->data, old_skb->data, old_skb->len);
+				skb_put(skb, ETH_ZLEN);
+				dev_kfree_skb(old_skb);
+			} else {
+				skb = old_skb;
+			}
+		}
+	}
+
+	spin_lock_irqsave(&comm->tx_lock, flags);
+	tx_pos = comm->tx_pos;
+	txdesc = &comm->tx_desc[tx_pos];
+	skbinfo = &comm->tx_temp_skb_info[tx_pos];
+	skbinfo->len = skb->len;
+	skbinfo->skb = skb;
+	skbinfo->mapping = dma_map_single(&comm->pdev->dev, skb->data,
+					  skb->len, DMA_TO_DEVICE);
+	if (dma_mapping_error(&comm->pdev->dev, skbinfo->mapping)) {
+		ndev->stats.tx_errors++;
+		dev_kfree_skb(skb);
+		skbinfo->mapping = 0;
+		skbinfo->len = 0;
+		skbinfo->skb = NULL;
+		goto xmit_drop;
+	}
+
+	/* Set up a TX descriptor */
+	cmd1 = TXD_OWN | TXD_SOP | TXD_EOP | (mac->to_vlan << 12) |
+	       (skb->len & TXD_PKT_LEN);
+	cmd2 = skb->len & TXD_BUF_LEN1;
+
+	if (tx_pos == (TX_DESC_NUM - 1))
+		cmd2 |= TXD_EOR;
+
+	txdesc->addr1 = skbinfo->mapping;
+	txdesc->cmd2 = cmd2;
+	wmb();	/* Set TXD_OWN after other fields are effective. */
+	txdesc->cmd1 = cmd1;
+
+	/* Move tx_pos to next position */
+	tx_pos = ((tx_pos + 1) == TX_DESC_NUM) ? 0 : tx_pos + 1;
+
+	if (unlikely(tx_pos == comm->tx_done_pos)) {
+		netif_stop_queue(ndev);
+		comm->tx_desc_full = 1;
+	}
+	comm->tx_pos = tx_pos;
+	wmb();		/* make sure settings are effective. */
+
+	/* trigger gmac to transmit */
+	writel(MAC_TRIG_L_SOC0, comm->l2sw_reg_base + L2SW_CPU_TX_TRIG);
+
+xmit_drop:
+	spin_unlock_irqrestore(&comm->tx_lock, flags);
+	return NETDEV_TX_OK;
+}
+
+static void spl2sw_ethernet_set_rx_mode(struct net_device *ndev)
+{
+	struct spl2sw_mac *mac = netdev_priv(ndev);
+
+	spl2sw_mac_rx_mode_set(mac);
+}
+
+static int spl2sw_ethernet_set_mac_address(struct net_device *ndev, void *addr)
+{
+	struct spl2sw_mac *mac = netdev_priv(ndev);
+	int err;
+
+	err = eth_mac_addr(ndev, addr);
+	if (err)
+		return err;
+
+	/* Delete the old MAC address */
+	netdev_dbg(ndev, "Old Ethernet (MAC) address = %pM\n", mac->mac_addr);
+	if (is_valid_ether_addr(mac->mac_addr)) {
+		err = spl2sw_mac_addr_del(mac);
+		if (err)
+			return err;
+	}
+
+	/* Set the MAC address */
+	ether_addr_copy(mac->mac_addr, ndev->dev_addr);
+	return spl2sw_mac_addr_add(mac);
+}
+
+static void spl2sw_ethernet_tx_timeout(struct net_device *ndev, unsigned int txqueue)
+{
+	struct spl2sw_mac *mac = netdev_priv(ndev);
+	struct spl2sw_common *comm = mac->comm;
+	unsigned long flags;
+	int i;
+
+	netdev_err(ndev, "TX timed out!\n");
+	ndev->stats.tx_errors++;
+
+	spin_lock_irqsave(&comm->tx_lock, flags);
+
+	for (i = 0; i < MAX_NETDEV_NUM; i++)
+		if (comm->ndev[i])
+			netif_stop_queue(comm->ndev[i]);
+
+	spl2sw_mac_soft_reset(comm);
+
+	/* Accept TX packets again. */
+	for (i = 0; i < MAX_NETDEV_NUM; i++)
+		if (comm->ndev[i]) {
+			netif_trans_update(comm->ndev[i]);
+			netif_wake_queue(comm->ndev[i]);
+		}
+
+	spin_unlock_irqrestore(&comm->tx_lock, flags);
+}
+
+static const struct net_device_ops netdev_ops = {
+	.ndo_open = spl2sw_ethernet_open,
+	.ndo_stop = spl2sw_ethernet_stop,
+	.ndo_start_xmit = spl2sw_ethernet_start_xmit,
+	.ndo_set_rx_mode = spl2sw_ethernet_set_rx_mode,
+	.ndo_set_mac_address = spl2sw_ethernet_set_mac_address,
+	.ndo_do_ioctl = phy_do_ioctl,
+	.ndo_tx_timeout = spl2sw_ethernet_tx_timeout,
+};
+
+static void spl2sw_check_mac_vendor_id_and_convert(u8 *mac_addr)
+{
+	u8 tmp;
+
+	/* Byte order of MAC address of some samples are reversed.
+	 * Check vendor id and convert byte order if it is wrong.
+	 * OUI of Sunplus: fc:4b:bc
+	 */
+	if (mac_addr[5] == 0xfc && mac_addr[4] == 0x4b && mac_addr[3] == 0xbc &&
+	    (mac_addr[0] != 0xfc || mac_addr[1] != 0x4b || mac_addr[2] != 0xbc)) {
+		/* Swap mac_addr[0] and mac_addr[5] */
+		tmp = mac_addr[0];
+		mac_addr[0] = mac_addr[5];
+		mac_addr[5] = tmp;
+
+		/* Swap mac_addr[1] and mac_addr[4] */
+		tmp = mac_addr[1];
+		mac_addr[1] = mac_addr[4];
+		mac_addr[4] = tmp;
+
+		/* Swap mac_addr[2] and mac_addr[3] */
+		tmp = mac_addr[2];
+		mac_addr[2] = mac_addr[3];
+		mac_addr[3] = tmp;
+	}
+}
+
+static int spl2sw_nvmem_get_mac_address(struct device *dev, struct device_node *np,
+					void *addrbuf)
+{
+	struct nvmem_cell *cell;
+	ssize_t len;
+	u8 *mac;
+
+	/* Get nvmem cell of mac-address from dts. */
+	cell = of_nvmem_cell_get(np, "mac-address");
+	if (IS_ERR(cell))
+		return PTR_ERR(cell);
+
+	/* Read mac address from nvmem cell. */
+	mac = nvmem_cell_read(cell, &len);
+	nvmem_cell_put(cell);
+	if (IS_ERR(mac))
+		return PTR_ERR(mac);
+
+	if (len != ETH_ALEN) {
+		kfree(mac);
+		dev_info(dev, "Invalid length of mac address in nvmem!\n");
+		return -EINVAL;
+	}
+
+	/* Byte order of some samples are reversed.
+	 * Convert byte order here.
+	 */
+	spl2sw_check_mac_vendor_id_and_convert(mac);
+
+	/* Check if mac address is valid */
+	if (!is_valid_ether_addr(mac)) {
+		kfree(mac);
+		dev_info(dev, "Invalid mac address in nvmem (%pM)!\n", mac);
+		return -EINVAL;
+	}
+
+	ether_addr_copy(addrbuf, mac);
+	kfree(mac);
+	return 0;
+}
+
+static u32 spl2sw_init_netdev(struct platform_device *pdev, u8 *mac_addr,
+			      struct net_device **r_ndev)
+{
+	struct net_device *ndev;
+	struct spl2sw_mac *mac;
+	int ret;
+
+	/* Allocate the devices, and also allocate spl2sw_mac,
+	 * we can get it by netdev_priv().
+	 */
+	ndev = devm_alloc_etherdev(&pdev->dev, sizeof(*mac));
+	if (!ndev) {
+		*r_ndev = NULL;
+		return -ENOMEM;
+	}
+	SET_NETDEV_DEV(ndev, &pdev->dev);
+	ndev->netdev_ops = &netdev_ops;
+	mac = netdev_priv(ndev);
+	mac->ndev = ndev;
+	ether_addr_copy(mac->mac_addr, mac_addr);
+
+	eth_hw_addr_set(ndev, mac_addr);
+	dev_info(&pdev->dev, "Ethernet (MAC) address = %pM\n", mac_addr);
+
+	ret = register_netdev(ndev);
+	if (ret) {
+		dev_err(&pdev->dev, "Failed to register net device \"%s\"!\n",
+			ndev->name);
+		free_netdev(ndev);
+		*r_ndev = NULL;
+		return ret;
+	}
+	netdev_dbg(ndev, "Registered net device \"%s\" successfully.\n", ndev->name);
+
+	*r_ndev = ndev;
+	return 0;
+}
+
+static struct device_node *spl2sw_get_eth_child_node(struct device_node *ether_np, int id)
+{
+	struct device_node *port_np;
+	int port_id;
+
+	for_each_child_of_node(ether_np, port_np) {
+		/* It is not a 'port' node, continue. */
+		if (strcmp(port_np->name, "port"))
+			continue;
+
+		if (of_property_read_u32(port_np, "reg", &port_id) < 0)
+			continue;
+
+		if (port_id == id)
+			return port_np;
+	}
+
+	/* Not found! */
+	return NULL;
+}
+
+static int spl2sw_probe(struct platform_device *pdev)
+{
+	struct device_node *eth_ports_np;
+	struct device_node *port_np;
+	struct spl2sw_common *comm;
+	struct device_node *phy_np;
+	phy_interface_t phy_mode;
+	struct net_device *ndev;
+	u8 mac_addr[ETH_ALEN];
+	struct spl2sw_mac *mac;
+	int irq, i;
+	int ret;
+
+	if (platform_get_drvdata(pdev))
+		return -ENODEV;
+
+	/* Allocate memory for 'spl2sw_common' area. */
+	comm = devm_kzalloc(&pdev->dev, sizeof(*comm), GFP_KERNEL);
+	if (!comm)
+		return -ENOMEM;
+	comm->pdev = pdev;
+
+	spin_lock_init(&comm->rx_lock);
+	spin_lock_init(&comm->tx_lock);
+	spin_lock_init(&comm->mdio_lock);
+
+	/* Get memory resource 0 from dts. */
+	comm->l2sw_reg_base = devm_platform_ioremap_resource(pdev, 0);
+	if (IS_ERR(comm->l2sw_reg_base))
+		return PTR_ERR(comm->l2sw_reg_base);
+
+	/* Get irq resource from dts. */
+	ret = platform_get_irq(pdev, 0);
+	if (ret < 0)
+		return ret;
+	irq = ret;
+
+	/* Get clock controller. */
+	comm->clk = devm_clk_get(&pdev->dev, NULL);
+	if (IS_ERR(comm->clk)) {
+		dev_err_probe(&pdev->dev, PTR_ERR(comm->clk),
+			      "Failed to retrieve clock controller!\n");
+		return PTR_ERR(comm->clk);
+	}
+
+	/* Get reset controller. */
+	comm->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
+	if (IS_ERR(comm->rstc)) {
+		dev_err_probe(&pdev->dev, PTR_ERR(comm->rstc),
+			      "Failed to retrieve reset controller!\n");
+		return PTR_ERR(comm->rstc);
+	}
+
+	/* Enable clock. */
+	clk_prepare_enable(comm->clk);
+	udelay(1);
+
+	reset_control_assert(comm->rstc);
+	udelay(1);
+	reset_control_deassert(comm->rstc);
+	udelay(1);
+
+	/* Get child node ethernet-ports. */
+	eth_ports_np = of_get_child_by_name(pdev->dev.of_node, "ethernet-ports");
+	if (!eth_ports_np) {
+		dev_err(&pdev->dev, "No ethernet-ports child node found!\n");
+		ret = -ENODEV;
+		goto out_clk_disable;
+	}
+
+	for (i = 0; i < MAX_NETDEV_NUM; i++) {
+		/* Get port@i of node ethernet-ports. */
+		port_np = spl2sw_get_eth_child_node(eth_ports_np, i);
+		if (!port_np)
+			continue;
+
+		/* Get phy-mode. */
+		if (of_get_phy_mode(port_np, &phy_mode)) {
+			dev_err(&pdev->dev, "Failed to get phy-mode property of port@%d!\n",
+				i);
+			continue;
+		}
+
+		/* Get phy-handle. */
+		phy_np = of_parse_phandle(port_np, "phy-handle", 0);
+		if (!phy_np) {
+			dev_err(&pdev->dev, "Failed to get phy-handle property of port@%d!\n",
+				i);
+			continue;
+		}
+
+		/* Get mac-address from nvmem. */
+		ret = spl2sw_nvmem_get_mac_address(&pdev->dev, port_np, mac_addr);
+		if (ret) {
+			dev_info(&pdev->dev, "Generate a random mac address!\n");
+
+			/* Generate a mac address using OUI of Sunplus Technology
+			 * and random controller number.
+			 */
+			mac_addr[0] = 0xfc; /* OUI of Sunplus: fc:4b:bc */
+			mac_addr[1] = 0x4b;
+			mac_addr[2] = 0xbc;
+			mac_addr[3] = get_random_int() % 256;
+			mac_addr[4] = get_random_int() % 256;
+			mac_addr[5] = get_random_int() % 256;
+		}
+
+		/* Initialize the net device. */
+		ret = spl2sw_init_netdev(pdev, mac_addr, &ndev);
+		if (ret)
+			goto out_unregister_dev;
+
+		ndev->irq = irq;
+		comm->ndev[i] = ndev;
+		mac = netdev_priv(ndev);
+		mac->phy_node = phy_np;
+		mac->phy_mode = phy_mode;
+		mac->comm = comm;
+
+		mac->lan_port = 0x1 << i;	/* forward to port i */
+		mac->to_vlan = 0x1 << i;	/* vlan group: i     */
+		mac->vlan_id = i;		/* vlan group: i     */
+
+		/* Set MAC address */
+		ret = spl2sw_mac_addr_add(mac);
+		if (ret)
+			goto out_unregister_dev;
+
+		spl2sw_mac_rx_mode_set(mac);
+	}
+
+	/* Find first valid net device. */
+	for (i = 0; i < MAX_NETDEV_NUM; i++) {
+		if (comm->ndev[i])
+			break;
+	}
+	if (i >= MAX_NETDEV_NUM) {
+		dev_err(&pdev->dev, "No valid ethernet port!\n");
+		ret = -ENODEV;
+		goto out_clk_disable;
+	}
+
+	/* Save first valid net device */
+	ndev = comm->ndev[i];
+	platform_set_drvdata(pdev, ndev);
+
+	/* Request irq. */
+	ret = devm_request_irq(&pdev->dev, irq, spl2sw_ethernet_interrupt,
+			       0, ndev->name, ndev);
+	if (ret) {
+		netdev_err(ndev, "Failed to request irq #%d for \"%s\"!\n",
+			   irq, ndev->name);
+		goto out_unregister_dev;
+	}
+
+	/* Initialize mdio bus */
+	ret = spl2sw_mdio_init(comm);
+	if (ret) {
+		netdev_err(ndev, "Failed to initialize mdio bus!\n");
+		goto out_unregister_dev;
+	}
+
+	ret = spl2sw_mac_addr_del_all(comm);
+	if (ret)
+		goto out_free_mdio;
+
+	ret = spl2sw_descs_init(comm);
+	if (ret) {
+		dev_err(&comm->pdev->dev, "Fail to initialize mac descriptors!\n");
+		spl2sw_descs_free(comm);
+		goto out_free_mdio;
+	}
+
+	spl2sw_mac_init(comm);
+
+	ret = spl2sw_phy_connect(comm);
+	if (ret) {
+		netdev_err(ndev, "Failed to connect phy!\n");
+		goto out_free_mdio;
+	}
+
+	netif_napi_add(ndev, &comm->rx_napi, spl2sw_rx_poll, SPL2SW_RX_NAPI_WEIGHT);
+	napi_enable(&comm->rx_napi);
+	netif_napi_add(ndev, &comm->tx_napi, spl2sw_tx_poll, SPL2SW_TX_NAPI_WEIGHT);
+	napi_enable(&comm->tx_napi);
+	return 0;
+
+out_free_mdio:
+	spl2sw_mdio_remove(comm);
+
+out_unregister_dev:
+	for (i = 0; i < MAX_NETDEV_NUM; i++)
+		if (comm->ndev[i])
+			unregister_netdev(comm->ndev[i]);
+
+out_clk_disable:
+	clk_disable_unprepare(comm->clk);
+	return ret;
+}
+
+static int spl2sw_remove(struct platform_device *pdev)
+{
+	struct spl2sw_common *comm;
+	struct net_device *ndev;
+	struct spl2sw_mac *mac;
+	int i;
+
+	ndev = platform_get_drvdata(pdev);
+	if (!ndev)
+		return 0;
+
+	mac = netdev_priv(ndev);
+	comm = mac->comm;
+
+	spl2sw_phy_remove(comm);
+
+	/* Unregister and free net device. */
+	for (i = 0; i < MAX_NETDEV_NUM; i++)
+		if (comm->ndev[i])
+			unregister_netdev(comm->ndev[i]);
+
+	comm->enable = 0;
+	spl2sw_mac_hw_stop(comm);
+	spl2sw_descs_free(comm);
+
+	/* Disable and delete napi. */
+	napi_disable(&comm->rx_napi);
+	netif_napi_del(&comm->rx_napi);
+	napi_disable(&comm->tx_napi);
+	netif_napi_del(&comm->tx_napi);
+
+	spl2sw_mdio_remove(comm);
+
+	clk_disable_unprepare(comm->clk);
+
+	return 0;
+}
+
+static const struct of_device_id spl2sw_of_match[] = {
+	{.compatible = "sunplus,sp7021-emac"},
+	{ /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(of, spl2sw_of_match);
+
+static struct platform_driver spl2sw_driver = {
+	.probe = spl2sw_probe,
+	.remove = spl2sw_remove,
+	.driver = {
+		.name = "sp7021_emac",
+		.owner = THIS_MODULE,
+		.of_match_table = spl2sw_of_match,
+	},
+};
+
+module_platform_driver(spl2sw_driver);
+
+MODULE_AUTHOR("Wells Lu <wellslutw@gmail.com>");
+MODULE_DESCRIPTION("Sunplus Dual 10M/100M Ethernet driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.h b/drivers/net/ethernet/sunplus/spl2sw_driver.h
new file mode 100644
index 0000000..5f177b3
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_driver.h
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#ifndef __SPL2SW_DRIVER_H__
+#define __SPL2SW_DRIVER_H__
+
+#define SPL2SW_RX_NAPI_WEIGHT	16
+#define SPL2SW_TX_NAPI_WEIGHT	16
+
+#endif
diff --git a/drivers/net/ethernet/sunplus/spl2sw_int.c b/drivers/net/ethernet/sunplus/spl2sw_int.c
new file mode 100644
index 0000000..b6ab8fe
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_int.c
@@ -0,0 +1,253 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#include <linux/platform_device.h>
+#include <linux/etherdevice.h>
+#include <linux/netdevice.h>
+#include <linux/bitfield.h>
+#include <linux/of_mdio.h>
+
+#include "spl2sw_register.h"
+#include "spl2sw_define.h"
+#include "spl2sw_int.h"
+
+int spl2sw_rx_poll(struct napi_struct *napi, int budget)
+{
+	struct spl2sw_common *comm = container_of(napi, struct spl2sw_common, rx_napi);
+	struct spl2sw_mac_desc *desc, *h_desc;
+	struct net_device_stats *stats;
+	struct sk_buff *skb, *new_skb;
+	struct spl2sw_skb_info *sinfo;
+	u32 rx_pos, pkg_len;
+	u32 num, rx_count;
+	s32 queue;
+	u32 mask;
+	int port;
+	u32 cmd;
+
+	spin_lock(&comm->rx_lock);
+
+	/* Process high-priority queue and then low-priority queue. */
+	for (queue = 0; queue < RX_DESC_QUEUE_NUM; queue++) {
+		rx_pos = comm->rx_pos[queue];
+		rx_count = comm->rx_desc_num[queue];
+
+		for (num = 0; num < rx_count; num++) {
+			sinfo = comm->rx_skb_info[queue] + rx_pos;
+			desc = comm->rx_desc[queue] + rx_pos;
+			cmd = desc->cmd1;
+
+			if (cmd & RXD_OWN)
+				break;
+
+			port = FIELD_GET(RXD_PKT_SP, cmd);
+			if (port < MAX_NETDEV_NUM && comm->ndev[port])
+				stats = &comm->ndev[port]->stats;
+			else
+				goto spl2sw_rx_poll_rec_err;
+
+			pkg_len = FIELD_GET(RXD_PKT_LEN, cmd);
+			if (unlikely((cmd & RXD_ERR_CODE) || pkg_len < ETH_ZLEN + 4)) {
+				stats->rx_length_errors++;
+				stats->rx_dropped++;
+				goto spl2sw_rx_poll_rec_err;
+			}
+
+			if (unlikely(cmd & RXD_IP_CHKSUM)) {
+				stats->rx_crc_errors++;
+				stats->rx_dropped++;
+				goto spl2sw_rx_poll_rec_err;
+			}
+
+			dma_unmap_single(&comm->pdev->dev, sinfo->mapping,
+					 comm->rx_desc_buff_size, DMA_FROM_DEVICE);
+
+			skb = sinfo->skb;
+			skb_put(skb, pkg_len - 4); /* Minus FCS */
+			skb->ip_summed = CHECKSUM_NONE;
+			skb->protocol = eth_type_trans(skb, comm->ndev[port]);
+			netif_receive_skb(skb);
+
+			stats->rx_packets++;
+			stats->rx_bytes += skb->len;
+
+			/* Allocate a new skb for receiving. */
+			new_skb = netdev_alloc_skb(NULL, comm->rx_desc_buff_size);
+			if (unlikely(!new_skb)) {
+				desc->cmd2 = (rx_pos == comm->rx_desc_num[queue] - 1) ?
+					     RXD_EOR : 0;
+				sinfo->skb = NULL;
+				sinfo->mapping = 0;
+				goto spl2sw_rx_poll_alloc_err;
+			}
+
+			sinfo->mapping = dma_map_single(&comm->pdev->dev, new_skb->data,
+							comm->rx_desc_buff_size,
+							DMA_FROM_DEVICE);
+			if (dma_mapping_error(&comm->pdev->dev, sinfo->mapping)) {
+				dev_kfree_skb_irq(new_skb);
+				desc->cmd2 = (rx_pos == comm->rx_desc_num[queue] - 1) ?
+					     RXD_EOR : 0;
+				sinfo->skb = NULL;
+				goto spl2sw_rx_poll_alloc_err;
+			}
+
+			sinfo->skb = new_skb;
+			desc->addr1 = sinfo->mapping;
+
+spl2sw_rx_poll_rec_err:
+			desc->cmd2 = (rx_pos == comm->rx_desc_num[queue] - 1) ?
+				     RXD_EOR | comm->rx_desc_buff_size :
+				     comm->rx_desc_buff_size;
+
+spl2sw_rx_poll_alloc_err:
+			wmb();	/* Set RXD_OWN after other fields are effective. */
+			desc->cmd1 = RXD_OWN;
+
+			/* Move rx_pos to next position */
+			rx_pos = ((rx_pos + 1) == comm->rx_desc_num[queue]) ? 0 : rx_pos + 1;
+
+			/* If there are packets in high-priority queue,
+			 * stop processing low-priority queue.
+			 */
+			if (queue == 1 && !(h_desc->cmd1 & RXD_OWN))
+				break;
+		}
+
+		comm->rx_pos[queue] = rx_pos;
+
+		/* Save pointer to last rx descriptor of high-priority queue. */
+		if (queue == 0)
+			h_desc = comm->rx_desc[queue] + rx_pos;
+	}
+
+	spin_unlock(&comm->rx_lock);
+
+	wmb();	/* make sure settings are effective. */
+	mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+	mask &= ~MAC_INT_RX;
+	writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+
+	napi_complete(napi);
+	return 0;
+}
+
+int spl2sw_tx_poll(struct napi_struct *napi, int budget)
+{
+	struct spl2sw_common *comm = container_of(napi, struct spl2sw_common, tx_napi);
+	struct spl2sw_skb_info *skbinfo;
+	struct net_device_stats *stats;
+	u32 tx_done_pos;
+	u32 mask;
+	u32 cmd;
+	int i;
+
+	spin_lock(&comm->tx_lock);
+
+	tx_done_pos = comm->tx_done_pos;
+	while ((tx_done_pos != comm->tx_pos) || (comm->tx_desc_full == 1)) {
+		cmd = comm->tx_desc[tx_done_pos].cmd1;
+		if (cmd & TXD_OWN)
+			break;
+
+		skbinfo = &comm->tx_temp_skb_info[tx_done_pos];
+		if (unlikely(!skbinfo->skb))
+			goto spl2sw_tx_poll_next;
+
+		i = ffs(FIELD_GET(TXD_VLAN, cmd)) - 1;
+		if (i < MAX_NETDEV_NUM && comm->ndev[i])
+			stats = &comm->ndev[i]->stats;
+		else
+			goto spl2sw_tx_poll_unmap;
+
+		if (unlikely(cmd & (TXD_ERR_CODE))) {
+			stats->tx_errors++;
+		} else {
+			stats->tx_packets++;
+			stats->tx_bytes += skbinfo->len;
+		}
+
+spl2sw_tx_poll_unmap:
+		dma_unmap_single(&comm->pdev->dev, skbinfo->mapping, skbinfo->len,
+				 DMA_TO_DEVICE);
+		skbinfo->mapping = 0;
+		dev_kfree_skb_irq(skbinfo->skb);
+		skbinfo->skb = NULL;
+
+spl2sw_tx_poll_next:
+		/* Move tx_done_pos to next position */
+		tx_done_pos = ((tx_done_pos + 1) == TX_DESC_NUM) ? 0 : tx_done_pos + 1;
+
+		if (comm->tx_desc_full == 1)
+			comm->tx_desc_full = 0;
+	}
+
+	comm->tx_done_pos = tx_done_pos;
+	if (!comm->tx_desc_full)
+		for (i = 0; i < MAX_NETDEV_NUM; i++)
+			if (comm->ndev[i])
+				if (netif_queue_stopped(comm->ndev[i]))
+					netif_wake_queue(comm->ndev[i]);
+
+	spin_unlock(&comm->tx_lock);
+
+	wmb();			/* make sure settings are effective. */
+	mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+	mask &= ~MAC_INT_TX;
+	writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+
+	napi_complete(napi);
+	return 0;
+}
+
+irqreturn_t spl2sw_ethernet_interrupt(int irq, void *dev_id)
+{
+	struct net_device *ndev = (struct net_device *)dev_id;
+	struct spl2sw_mac *mac = netdev_priv(ndev);
+	struct spl2sw_common *comm = mac->comm;
+	u32 status;
+	u32 mask;
+
+	status = readl(comm->l2sw_reg_base + L2SW_SW_INT_STATUS_0);
+	if (unlikely(!status)) {
+		netdev_dbg(ndev, "Interrput status is null!\n");
+		goto spl2sw_ethernet_int_out;
+	}
+	writel(status, comm->l2sw_reg_base + L2SW_SW_INT_STATUS_0);
+
+	if (status & MAC_INT_RX) {
+		/* Disable RX interrupts. */
+		mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+		mask |= MAC_INT_RX;
+		writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+
+		if (unlikely(status & MAC_INT_RX_DES_ERR)) {
+			netdev_dbg(ndev, "Illegal RX Descriptor!\n");
+			ndev->stats.rx_fifo_errors++;
+		}
+
+		napi_schedule(&comm->rx_napi);
+	}
+
+	if (status & MAC_INT_TX) {
+		/* Disable TX interrupts. */
+		mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+		mask |= MAC_INT_TX;
+		writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+
+		if (unlikely(status & MAC_INT_TX_DES_ERR)) {
+			netdev_dbg(ndev, "Illegal TX Descriptor Error\n");
+			ndev->stats.tx_fifo_errors++;
+			mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+			mask &= ~MAC_INT_TX;
+			writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+		} else {
+			napi_schedule(&comm->tx_napi);
+		}
+	}
+
+spl2sw_ethernet_int_out:
+	return IRQ_HANDLED;
+}
diff --git a/drivers/net/ethernet/sunplus/spl2sw_int.h b/drivers/net/ethernet/sunplus/spl2sw_int.h
new file mode 100644
index 0000000..64f6f25
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_int.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#ifndef __SPL2SW_INT_H__
+#define __SPL2SW_INT_H__
+
+int spl2sw_rx_poll(struct napi_struct *napi, int budget);
+int spl2sw_tx_poll(struct napi_struct *napi, int budget);
+irqreturn_t spl2sw_ethernet_interrupt(int irq, void *dev_id);
+
+#endif
diff --git a/drivers/net/ethernet/sunplus/spl2sw_mac.c b/drivers/net/ethernet/sunplus/spl2sw_mac.c
new file mode 100644
index 0000000..e704642
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_mac.c
@@ -0,0 +1,346 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#include <linux/platform_device.h>
+#include <linux/netdevice.h>
+#include <linux/bitfield.h>
+#include <linux/of_mdio.h>
+
+#include "spl2sw_register.h"
+#include "spl2sw_define.h"
+#include "spl2sw_desc.h"
+#include "spl2sw_mac.h"
+
+void spl2sw_mac_hw_stop(struct spl2sw_common *comm)
+{
+	u32 reg;
+
+	if (comm->enable == 0) {
+		/* Mask and clear all interrupts. */
+		writel(0xffffffff, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+		writel(0xffffffff, comm->l2sw_reg_base + L2SW_SW_INT_STATUS_0);
+
+		/* Disable cpu 0 and cpu 1. */
+		reg = readl(comm->l2sw_reg_base + L2SW_CPU_CNTL);
+		reg |= MAC_DIS_SOC1_CPU | MAC_DIS_SOC0_CPU;
+		writel(reg, comm->l2sw_reg_base + L2SW_CPU_CNTL);
+	}
+
+	/* Disable LAN ports. */
+	reg = readl(comm->l2sw_reg_base + L2SW_PORT_CNTL0);
+	reg |= FIELD_PREP(MAC_DIS_PORT, ~comm->enable);
+	writel(reg, comm->l2sw_reg_base + L2SW_PORT_CNTL0);
+}
+
+void spl2sw_mac_hw_start(struct spl2sw_common *comm)
+{
+	u32 reg;
+
+	/* Enable cpu port 0 (6) & CRC padding (8) */
+	reg = readl(comm->l2sw_reg_base + L2SW_CPU_CNTL);
+	reg &= ~MAC_DIS_SOC0_CPU;
+	reg |= MAC_EN_CRC_SOC0;
+	writel(reg, comm->l2sw_reg_base + L2SW_CPU_CNTL);
+
+	/* Enable port 0 & port 1 */
+	reg = readl(comm->l2sw_reg_base + L2SW_PORT_CNTL0);
+	reg &= FIELD_PREP(MAC_DIS_PORT, ~comm->enable) | ~MAC_DIS_PORT;
+	writel(reg, comm->l2sw_reg_base + L2SW_PORT_CNTL0);
+}
+
+int spl2sw_mac_addr_add(struct spl2sw_mac *mac)
+{
+	struct spl2sw_common *comm = mac->comm;
+	u32 reg;
+	int ret;
+
+	/* Write 6-octet MAC address. */
+	writel((mac->mac_addr[0] << 0) + (mac->mac_addr[1] << 8),
+	       comm->l2sw_reg_base + L2SW_W_MAC_15_0);
+	writel((mac->mac_addr[2] << 0) + (mac->mac_addr[3] << 8) +
+	       (mac->mac_addr[4] << 16) + (mac->mac_addr[5] << 24),
+	       comm->l2sw_reg_base + L2SW_W_MAC_47_16);
+
+	/* Set learn port = cpu_port, aging = 1 */
+	reg = MAC_W_CPU_PORT_0 | FIELD_PREP(MAC_W_VID, mac->vlan_id) |
+	      FIELD_PREP(MAC_W_AGE, 1) | MAC_W_MAC_CMD;
+	writel(reg, comm->l2sw_reg_base + L2SW_WT_MAC_AD0);
+
+	/* Wait for completing. */
+	ret = read_poll_timeout(readl, reg, reg & MAC_W_MAC_DONE, 1, 200, true,
+				comm->l2sw_reg_base + L2SW_WT_MAC_AD0);
+	if (ret) {
+		netdev_err(mac->ndev, "Failed to add address to table!\n");
+		return ret;
+	}
+
+	netdev_dbg(mac->ndev, "mac_ad0 = %08x, mac_ad = %08x%04x\n",
+		   readl(comm->l2sw_reg_base + L2SW_WT_MAC_AD0),
+		   (u32)FIELD_GET(MAC_W_MAC_47_16,
+		   readl(comm->l2sw_reg_base + L2SW_W_MAC_47_16)),
+		   (u32)FIELD_GET(MAC_W_MAC_15_0,
+		   readl(comm->l2sw_reg_base + L2SW_W_MAC_15_0)));
+	return 0;
+}
+
+int spl2sw_mac_addr_del(struct spl2sw_mac *mac)
+{
+	struct spl2sw_common *comm = mac->comm;
+	u32 reg;
+	int ret;
+
+	/* Write 6-octet MAC address. */
+	writel((mac->mac_addr[0] << 0) + (mac->mac_addr[1] << 8),
+	       comm->l2sw_reg_base + L2SW_W_MAC_15_0);
+	writel((mac->mac_addr[2] << 0) + (mac->mac_addr[3] << 8) +
+	       (mac->mac_addr[4] << 16) + (mac->mac_addr[5] << 24),
+	       comm->l2sw_reg_base + L2SW_W_MAC_47_16);
+
+	/* Set learn port = lan_port0 and aging = 0
+	 * to wipe (age) out the entry.
+	 */
+	reg = MAC_W_LAN_PORT_0 | FIELD_PREP(MAC_W_VID, mac->vlan_id) | MAC_W_MAC_CMD;
+	writel(reg, comm->l2sw_reg_base + L2SW_WT_MAC_AD0);
+
+	/* Wait for completing. */
+	ret = read_poll_timeout(readl, reg, reg & MAC_W_MAC_DONE, 1, 200, true,
+				comm->l2sw_reg_base + L2SW_WT_MAC_AD0);
+	if (ret) {
+		netdev_err(mac->ndev, "Failed to delete address from table!\n");
+		return ret;
+	}
+
+	netdev_dbg(mac->ndev, "mac_ad0 = %08x, mac_ad = %08x%04x\n",
+		   readl(comm->l2sw_reg_base + L2SW_WT_MAC_AD0),
+		   (u32)FIELD_GET(MAC_W_MAC_47_16,
+		   readl(comm->l2sw_reg_base + L2SW_W_MAC_47_16)),
+		   (u32)FIELD_GET(MAC_W_MAC_15_0,
+		   readl(comm->l2sw_reg_base + L2SW_W_MAC_15_0)));
+	return 0;
+}
+
+int spl2sw_mac_addr_del_all(struct spl2sw_common *comm)
+{
+	u32 reg;
+	int ret;
+
+	/* Wait for address table being idle. */
+	ret = read_poll_timeout(readl, reg, reg & MAC_ADDR_LOOKUP_IDLE, 1, 200, true,
+				comm->l2sw_reg_base + L2SW_ADDR_TBL_SRCH);
+	if (ret)
+		goto spl2sw_mac_addr_del_all_err;
+
+	/* Search address table from start. */
+	writel(MAC_BEGIN_SEARCH_ADDR, comm->l2sw_reg_base + L2SW_ADDR_TBL_SRCH);
+	while (1) {
+		/* Wait for completing. */
+		ret = read_poll_timeout(readl, reg, reg & (MAC_AT_TABLE_END |
+					MAC_AT_DATA_READY), 1, 2000, true,
+					comm->l2sw_reg_base + L2SW_ADDR_TBL_ST);
+		if (ret)
+			goto spl2sw_mac_addr_del_all_err;
+
+		if (reg & MAC_AT_TABLE_END)
+			break;
+
+		dev_dbg(&comm->pdev->dev, "addr_tbl_st = %08x\n", reg);
+		dev_dbg(&comm->pdev->dev, "@AT #%u: port=%01x, cpu=%01x, vid=%u, aging=%u, proxy=%u, mc_ingress=%u\n",
+			(u32)FIELD_GET(MAC_HASH_LOOKUP_ADDR, reg),
+			(u32)FIELD_GET(MAC_R_PORT_MAP, reg),
+			(u32)FIELD_GET(MAC_R_CPU_PORT, reg),
+			(u32)FIELD_GET(MAC_R_VID, reg),
+			(u32)FIELD_GET(MAC_R_AGE, reg),
+			(u32)FIELD_GET(MAC_R_PROXY, reg),
+			(u32)FIELD_GET(MAC_R_MC_INGRESS, reg));
+
+		/* Delete all entries which are learnt from lan ports. */
+		if (reg & MAC_R_PORT_MAP) {
+			writel(readl(comm->l2sw_reg_base + L2SW_MAC_AD_SER0),
+			       comm->l2sw_reg_base + L2SW_W_MAC_15_0);
+			writel(readl(comm->l2sw_reg_base + L2SW_MAC_AD_SER1),
+			       comm->l2sw_reg_base + L2SW_W_MAC_47_16);
+
+			/* Keep VID field, set learn port = lan_port0 and
+			 * aging = 0 to wipe (age) out the entry.
+			 */
+			reg &= MAC_W_VID;
+			reg |= MAC_W_LAN_PORT_0 | MAC_W_MAC_CMD;
+			writel(reg, comm->l2sw_reg_base + L2SW_WT_MAC_AD0);
+
+			/* Wait for completing. */
+			ret = read_poll_timeout(readl, reg, reg & MAC_W_MAC_DONE, 1, 200,
+						true, comm->l2sw_reg_base + L2SW_WT_MAC_AD0);
+			if (ret)
+				goto spl2sw_mac_addr_del_all_err;
+
+			dev_dbg(&comm->pdev->dev, "mac_ad0 = %08x, mac_ad = %08x%04x\n",
+				readl(comm->l2sw_reg_base + L2SW_WT_MAC_AD0),
+				(u32)FIELD_GET(MAC_W_MAC_47_16,
+				readl(comm->l2sw_reg_base + L2SW_W_MAC_47_16)),
+				(u32)FIELD_GET(MAC_W_MAC_15_0,
+				readl(comm->l2sw_reg_base + L2SW_W_MAC_15_0)));
+		}
+
+		/* Search next entry. */
+		writel(MAC_SEARCH_NEXT_ADDR, comm->l2sw_reg_base + L2SW_ADDR_TBL_SRCH);
+	}
+	return 0;
+
+spl2sw_mac_addr_del_all_err:
+	dev_err(&comm->pdev->dev, "Failed to delete all addresses from table!\n");
+	return ret;
+}
+
+void spl2sw_mac_hw_init(struct spl2sw_common *comm)
+{
+	u32 reg;
+
+	/* Disable cpu0 and cpu 1 port. */
+	reg = readl(comm->l2sw_reg_base + L2SW_CPU_CNTL);
+	reg |= MAC_DIS_SOC1_CPU | MAC_DIS_SOC0_CPU;
+	writel(reg, comm->l2sw_reg_base + L2SW_CPU_CNTL);
+
+	/* Set base addresses of TX and RX queues. */
+	writel(comm->desc_dma, comm->l2sw_reg_base + L2SW_TX_LBASE_ADDR_0);
+	writel(comm->desc_dma + sizeof(struct spl2sw_mac_desc) * TX_DESC_NUM,
+	       comm->l2sw_reg_base + L2SW_TX_HBASE_ADDR_0);
+	writel(comm->desc_dma + sizeof(struct spl2sw_mac_desc) * (TX_DESC_NUM +
+	       MAC_GUARD_DESC_NUM), comm->l2sw_reg_base + L2SW_RX_HBASE_ADDR_0);
+	writel(comm->desc_dma + sizeof(struct spl2sw_mac_desc) * (TX_DESC_NUM +
+	       MAC_GUARD_DESC_NUM + RX_QUEUE0_DESC_NUM),
+	       comm->l2sw_reg_base + L2SW_RX_LBASE_ADDR_0);
+
+	/* Fc_rls_th=0x4a, Fc_set_th=0x3a, Drop_rls_th=0x2d, Drop_set_th=0x1d */
+	writel(0x4a3a2d1d, comm->l2sw_reg_base + L2SW_FL_CNTL_TH);
+
+	/* Cpu_rls_th=0x4a, Cpu_set_th=0x3a, Cpu_th=0x12, Port_th=0x12 */
+	writel(0x4a3a1212, comm->l2sw_reg_base + L2SW_CPU_FL_CNTL_TH);
+
+	/* mtcc_lmt=0xf, Pri_th_l=6, Pri_th_h=6, weigh_8x_en=1 */
+	writel(0xf6680000, comm->l2sw_reg_base + L2SW_PRI_FL_CNTL);
+
+	/* High-active LED */
+	reg = readl(comm->l2sw_reg_base + L2SW_LED_PORT0);
+	reg |= MAC_LED_ACT_HI;
+	writel(reg, comm->l2sw_reg_base + L2SW_LED_PORT0);
+
+	/* Disable aging of cpu port 0 & 1.
+	 * Disable SA learning of cpu port 0 & 1.
+	 * Enable UC and MC packets
+	 */
+	reg = readl(comm->l2sw_reg_base + L2SW_CPU_CNTL);
+	reg &= ~(MAC_EN_SOC1_AGING | MAC_EN_SOC0_AGING |
+		 MAC_DIS_BC2CPU_P1 | MAC_DIS_BC2CPU_P0 |
+		 MAC_DIS_MC2CPU_P1 | MAC_DIS_MC2CPU_P0);
+	reg |= MAC_DIS_LRN_SOC1 | MAC_DIS_LRN_SOC0;
+	writel(reg, comm->l2sw_reg_base + L2SW_CPU_CNTL);
+
+	/* Enable RMC2CPU for port 0 & 1
+	 * Enable Flow control for port 0 & 1
+	 * Enable Back pressure for port 0 & 1
+	 */
+	reg = readl(comm->l2sw_reg_base + L2SW_PORT_CNTL0);
+	reg &= ~(MAC_DIS_RMC2CPU_P1 | MAC_DIS_RMC2CPU_P0);
+	reg |= MAC_EN_FLOW_CTL_P1 | MAC_EN_FLOW_CTL_P0 |
+	       MAC_EN_BACK_PRESS_P1 | MAC_EN_BACK_PRESS_P0;
+	writel(reg, comm->l2sw_reg_base + L2SW_PORT_CNTL0);
+
+	/* Disable LAN port SA learning. */
+	reg = readl(comm->l2sw_reg_base + L2SW_PORT_CNTL1);
+	reg |= MAC_DIS_SA_LRN_P1 | MAC_DIS_SA_LRN_P0;
+	writel(reg, comm->l2sw_reg_base + L2SW_PORT_CNTL1);
+
+	/* Enable rmii force mode and
+	 * set both external phy-address to 31.
+	 */
+	reg = readl(comm->l2sw_reg_base + L2SW_MAC_FORCE_MODE);
+	reg &= ~(MAC_EXT_PHY1_ADDR | MAC_EXT_PHY0_ADDR);
+	reg |= FIELD_PREP(MAC_EXT_PHY1_ADDR, 31) | FIELD_PREP(MAC_EXT_PHY0_ADDR, 31);
+	reg |= MAC_FORCE_RMII_EN_1 | MAC_FORCE_RMII_EN_0;
+	writel(reg, comm->l2sw_reg_base + L2SW_MAC_FORCE_MODE);
+
+	/* Port 0: VLAN group 0
+	 * Port 1: VLAN group 1
+	 */
+	reg = FIELD_PREP(MAC_P1_PVID, 1) | FIELD_PREP(MAC_P0_PVID, 0);
+	writel(reg, comm->l2sw_reg_base + L2SW_PVID_CONFIG0);
+
+	/* VLAN group 0: cpu0 (bit3) + port0 (bit0) = 1001 = 0x9
+	 * VLAN group 1: cpu0 (bit3) + port1 (bit1) = 1010 = 0xa
+	 */
+	reg = FIELD_PREP(MAC_VLAN_MEMSET_1, 0xa) | FIELD_PREP(MAC_VLAN_MEMSET_0, 9);
+	writel(reg, comm->l2sw_reg_base + L2SW_VLAN_MEMSET_CONFIG0);
+
+	/* RMC forward: to_cpu (1)
+	 * LED: 60mS (1)
+	 * BC storm prev: 31 BC (1)
+	 */
+	reg = readl(comm->l2sw_reg_base + L2SW_SW_GLB_CNTL);
+	reg &= ~(MAC_RMC_TB_FAULT_RULE | MAC_LED_FLASH_TIME | MAC_BC_STORM_PREV);
+	reg |= FIELD_PREP(MAC_RMC_TB_FAULT_RULE, 1) |
+	       FIELD_PREP(MAC_LED_FLASH_TIME, 1) |
+	       FIELD_PREP(MAC_BC_STORM_PREV, 1);
+	writel(reg, comm->l2sw_reg_base + L2SW_SW_GLB_CNTL);
+
+	writel(MAC_INT_MASK_DEF, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
+}
+
+void spl2sw_mac_rx_mode_set(struct spl2sw_mac *mac)
+{
+	struct spl2sw_common *comm = mac->comm;
+	struct net_device *ndev = mac->ndev;
+	u32 mask, reg, rx_mode;
+
+	netdev_dbg(ndev, "ndev->flags = %08x\n", ndev->flags);
+	mask = FIELD_PREP(MAC_DIS_MC2CPU, mac->lan_port) |
+	       FIELD_PREP(MAC_DIS_UN2CPU, mac->lan_port);
+	reg = readl(comm->l2sw_reg_base + L2SW_CPU_CNTL);
+
+	if (ndev->flags & IFF_PROMISC) {
+		/* Allow MC and unknown UC packets */
+		rx_mode = FIELD_PREP(MAC_DIS_MC2CPU, mac->lan_port) |
+			  FIELD_PREP(MAC_DIS_UN2CPU, mac->lan_port);
+	} else if ((!netdev_mc_empty(ndev) && (ndev->flags & IFF_MULTICAST)) ||
+		   (ndev->flags & IFF_ALLMULTI)) {
+		/* Allow MC packets */
+		rx_mode = FIELD_PREP(MAC_DIS_MC2CPU, mac->lan_port);
+	} else {
+		/* Disable MC and unknown UC packets */
+		rx_mode = 0;
+	}
+
+	writel((reg & (~mask)) | ((~rx_mode) & mask), comm->l2sw_reg_base + L2SW_CPU_CNTL);
+	netdev_dbg(ndev, "cpu_cntl = %08x\n", readl(comm->l2sw_reg_base + L2SW_CPU_CNTL));
+}
+
+void spl2sw_mac_init(struct spl2sw_common *comm)
+{
+	u32 i;
+
+	for (i = 0; i < RX_DESC_QUEUE_NUM; i++)
+		comm->rx_pos[i] = 0;
+	mb();	/* make sure settings are effective. */
+
+	spl2sw_mac_hw_init(comm);
+}
+
+void spl2sw_mac_soft_reset(struct spl2sw_common *comm)
+{
+	u32 i;
+
+	spl2sw_mac_hw_stop(comm);
+
+	spl2sw_rx_descs_flush(comm);
+	comm->tx_pos = 0;
+	comm->tx_done_pos = 0;
+	comm->tx_desc_full = 0;
+
+	for (i = 0; i < RX_DESC_QUEUE_NUM; i++)
+		comm->rx_pos[i] = 0;
+	mb();	/* make sure settings are effective. */
+
+	spl2sw_mac_hw_init(comm);
+	spl2sw_mac_hw_start(comm);
+}
diff --git a/drivers/net/ethernet/sunplus/spl2sw_mac.h b/drivers/net/ethernet/sunplus/spl2sw_mac.h
new file mode 100644
index 0000000..04b6296
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_mac.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#ifndef __SPL2SW_MAC_H__
+#define __SPL2SW_MAC_H__
+
+void spl2sw_mac_hw_stop(struct spl2sw_common *comm);
+void spl2sw_mac_hw_start(struct spl2sw_common *comm);
+int  spl2sw_mac_addr_add(struct spl2sw_mac *mac);
+int  spl2sw_mac_addr_del(struct spl2sw_mac *mac);
+int  spl2sw_mac_addr_del_all(struct spl2sw_common *comm);
+void spl2sw_mac_hw_init(struct spl2sw_common *comm);
+void spl2sw_mac_rx_mode_set(struct spl2sw_mac *mac);
+void spl2sw_mac_init(struct spl2sw_common *comm);
+void spl2sw_mac_soft_reset(struct spl2sw_common *comm);
+
+#endif
diff --git a/drivers/net/ethernet/sunplus/spl2sw_mdio.c b/drivers/net/ethernet/sunplus/spl2sw_mdio.c
new file mode 100644
index 0000000..139ac8f
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_mdio.c
@@ -0,0 +1,126 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#include <linux/platform_device.h>
+#include <linux/netdevice.h>
+#include <linux/bitfield.h>
+#include <linux/of_mdio.h>
+
+#include "spl2sw_register.h"
+#include "spl2sw_define.h"
+#include "spl2sw_mdio.h"
+
+#define SPL2SW_MDIO_READ_CMD           0x02
+#define SPL2SW_MDIO_WRITE_CMD          0x01
+
+static int spl2sw_mdio_access(struct spl2sw_common *comm, u8 cmd, u8 addr, u8 regnum, u16 wdata)
+{
+	u32 reg, reg2;
+	u32 val;
+	int ret;
+
+	/* Note that addr (of phy) should match either ext_phy0_addr
+	 * or ext_phy1_addr, or mdio commands won't be sent out.
+	 */
+	reg = readl(comm->l2sw_reg_base + L2SW_MAC_FORCE_MODE);
+	reg &= ~MAC_EXT_PHY0_ADDR;
+	reg |= FIELD_PREP(MAC_EXT_PHY0_ADDR, addr);
+
+	reg2 = FIELD_PREP(MAC_CPU_PHY_WT_DATA, wdata) | FIELD_PREP(MAC_CPU_PHY_CMD, cmd) |
+	       FIELD_PREP(MAC_CPU_PHY_REG_ADDR, regnum) | FIELD_PREP(MAC_CPU_PHY_ADDR, addr);
+
+	/* Set ext_phy0_addr and then issue mdio command.
+	 * No interrupt is allowed in between.
+	 */
+	spin_lock_irq(&comm->mdio_lock);
+	writel(reg, comm->l2sw_reg_base + L2SW_MAC_FORCE_MODE);
+	writel(reg2, comm->l2sw_reg_base + L2SW_PHY_CNTL_REG0);
+	spin_unlock_irq(&comm->mdio_lock);
+
+	ret = read_poll_timeout(readl, val, val & cmd, 1, 1000, true,
+				comm->l2sw_reg_base + L2SW_PHY_CNTL_REG1);
+
+	/* Set ext_phy0_addr back to 31 to prevent
+	 * from sending mdio command to phy by
+	 * hardware auto-mdio function.
+	 */
+	reg = readl(comm->l2sw_reg_base + L2SW_MAC_FORCE_MODE);
+	reg &= ~MAC_EXT_PHY0_ADDR;
+	reg |= FIELD_PREP(MAC_EXT_PHY0_ADDR, 31);
+	writel(reg, comm->l2sw_reg_base + L2SW_MAC_FORCE_MODE);
+
+	if (ret == 0)
+		return val >> 16;
+	else
+		return ret;
+}
+
+static int spl2sw_mii_read(struct mii_bus *bus, int addr, int regnum)
+{
+	struct spl2sw_common *comm = bus->priv;
+
+	if (regnum & MII_ADDR_C45)
+		return -EOPNOTSUPP;
+
+	return spl2sw_mdio_access(comm, SPL2SW_MDIO_READ_CMD, addr, regnum, 0);
+}
+
+static int spl2sw_mii_write(struct mii_bus *bus, int addr, int regnum, u16 val)
+{
+	struct spl2sw_common *comm = bus->priv;
+	int ret;
+
+	if (regnum & MII_ADDR_C45)
+		return -EOPNOTSUPP;
+
+	ret = spl2sw_mdio_access(comm, SPL2SW_MDIO_WRITE_CMD, addr, regnum, val);
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
+u32 spl2sw_mdio_init(struct spl2sw_common *comm)
+{
+	struct device_node *mdio_np;
+	struct mii_bus *mii_bus;
+	int ret;
+
+	/* Get mdio child node. */
+	mdio_np = of_get_child_by_name(comm->pdev->dev.of_node, "mdio");
+	if (!mdio_np) {
+		dev_err(&comm->pdev->dev, "No mdio child node found!\n");
+		return -ENODEV;
+	}
+
+	/* Allocate and register mdio bus. */
+	mii_bus = devm_mdiobus_alloc(&comm->pdev->dev);
+	if (!mii_bus)
+		return -ENOMEM;
+
+	mii_bus->name = "sunplus_mii_bus";
+	mii_bus->parent = &comm->pdev->dev;
+	mii_bus->priv = comm;
+	mii_bus->read = spl2sw_mii_read;
+	mii_bus->write = spl2sw_mii_write;
+	snprintf(mii_bus->id, MII_BUS_ID_SIZE, "%s-mii", dev_name(&comm->pdev->dev));
+
+	ret = of_mdiobus_register(mii_bus, mdio_np);
+	if (ret) {
+		dev_err(&comm->pdev->dev, "Failed to register mdiobus!\n");
+		return ret;
+	}
+
+	comm->mii_bus = mii_bus;
+	return ret;
+}
+
+void spl2sw_mdio_remove(struct spl2sw_common *comm)
+{
+	if (comm->mii_bus) {
+		mdiobus_unregister(comm->mii_bus);
+		comm->mii_bus = NULL;
+	}
+}
diff --git a/drivers/net/ethernet/sunplus/spl2sw_mdio.h b/drivers/net/ethernet/sunplus/spl2sw_mdio.h
new file mode 100644
index 0000000..8a24c9c
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_mdio.h
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#ifndef __SPL2SW_MDIO_H__
+#define __SPL2SW_MDIO_H__
+
+u32  spl2sw_mdio_init(struct spl2sw_common *comm);
+void spl2sw_mdio_remove(struct spl2sw_common *comm);
+
+#endif
diff --git a/drivers/net/ethernet/sunplus/spl2sw_phy.c b/drivers/net/ethernet/sunplus/spl2sw_phy.c
new file mode 100644
index 0000000..404f508
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_phy.c
@@ -0,0 +1,92 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#include <linux/netdevice.h>
+#include <linux/bitfield.h>
+#include <linux/of_mdio.h>
+
+#include "spl2sw_register.h"
+#include "spl2sw_define.h"
+#include "spl2sw_phy.h"
+
+static void spl2sw_mii_link_change(struct net_device *ndev)
+{
+	struct spl2sw_mac *mac = netdev_priv(ndev);
+	struct phy_device *phydev = ndev->phydev;
+	struct spl2sw_common *comm = mac->comm;
+	u32 reg;
+
+	reg = readl(comm->l2sw_reg_base + L2SW_MAC_FORCE_MODE);
+
+	if (phydev->link) {
+		reg |= FIELD_PREP(MAC_FORCE_RMII_LINK, mac->lan_port);
+
+		if (phydev->speed == 100) {
+			reg |= FIELD_PREP(MAC_FORCE_RMII_SPD, mac->lan_port);
+		} else {
+			reg &= FIELD_PREP(MAC_FORCE_RMII_SPD, ~mac->lan_port) |
+			       ~MAC_FORCE_RMII_SPD;
+		}
+
+		if (phydev->duplex) {
+			reg |= FIELD_PREP(MAC_FORCE_RMII_DPX, mac->lan_port);
+		} else {
+			reg &= FIELD_PREP(MAC_FORCE_RMII_DPX, ~mac->lan_port) |
+			       ~MAC_FORCE_RMII_DPX;
+		}
+
+		if (phydev->pause) {
+			reg |= FIELD_PREP(MAC_FORCE_RMII_FC, mac->lan_port);
+		} else {
+			reg &= FIELD_PREP(MAC_FORCE_RMII_FC, ~mac->lan_port) |
+			       ~MAC_FORCE_RMII_FC;
+		}
+	} else {
+		reg &= FIELD_PREP(MAC_FORCE_RMII_LINK, ~mac->lan_port) |
+		       ~MAC_FORCE_RMII_LINK;
+	}
+
+	writel(reg, comm->l2sw_reg_base + L2SW_MAC_FORCE_MODE);
+
+	phy_print_status(phydev);
+}
+
+int spl2sw_phy_connect(struct spl2sw_common *comm)
+{
+	struct phy_device *phydev;
+	struct net_device *ndev;
+	struct spl2sw_mac *mac;
+	int i;
+
+	for (i = 0; i < MAX_NETDEV_NUM; i++)
+		if (comm->ndev[i]) {
+			ndev = comm->ndev[i];
+			mac = netdev_priv(ndev);
+			phydev = of_phy_connect(ndev, mac->phy_node, spl2sw_mii_link_change,
+						0, mac->phy_mode);
+			if (!phydev)
+				return -ENODEV;
+
+			phy_support_asym_pause(phydev);
+			phy_attached_info(phydev);
+		}
+
+	return 0;
+}
+
+void spl2sw_phy_remove(struct spl2sw_common *comm)
+{
+	struct net_device *ndev;
+	int i;
+
+	for (i = 0; i < MAX_NETDEV_NUM; i++)
+		if (comm->ndev[i]) {
+			ndev = comm->ndev[i];
+			if (ndev) {
+				phy_disconnect(ndev->phydev);
+				ndev->phydev = NULL;
+			}
+		}
+}
diff --git a/drivers/net/ethernet/sunplus/spl2sw_phy.h b/drivers/net/ethernet/sunplus/spl2sw_phy.h
new file mode 100644
index 0000000..3d051a2
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_phy.h
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#ifndef __SPL2SW_PHY_H__
+#define __SPL2SW_PHY_H__
+
+int  spl2sw_phy_connect(struct spl2sw_common *comm);
+void spl2sw_phy_remove(struct spl2sw_common *comm);
+
+#endif
diff --git a/drivers/net/ethernet/sunplus/spl2sw_register.h b/drivers/net/ethernet/sunplus/spl2sw_register.h
new file mode 100644
index 0000000..9718e2e
--- /dev/null
+++ b/drivers/net/ethernet/sunplus/spl2sw_register.h
@@ -0,0 +1,86 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright Sunplus Technology Co., Ltd.
+ *       All rights reserved.
+ */
+
+#ifndef __SPL2SW_REGISTER_H__
+#define __SPL2SW_REGISTER_H__
+
+/* Register L2SW */
+#define L2SW_SW_INT_STATUS_0		0x0
+#define L2SW_SW_INT_MASK_0		0x4
+#define L2SW_FL_CNTL_TH			0x8
+#define L2SW_CPU_FL_CNTL_TH		0xc
+#define L2SW_PRI_FL_CNTL		0x10
+#define L2SW_VLAN_PRI_TH		0x14
+#define L2SW_EN_TOS_BUS			0x18
+#define L2SW_TOS_MAP0			0x1c
+#define L2SW_TOS_MAP1			0x20
+#define L2SW_TOS_MAP2			0x24
+#define L2SW_TOS_MAP3			0x28
+#define L2SW_TOS_MAP4			0x2c
+#define L2SW_TOS_MAP5			0x30
+#define L2SW_TOS_MAP6			0x34
+#define L2SW_TOS_MAP7			0x38
+#define L2SW_GLOBAL_QUE_STATUS		0x3c
+#define L2SW_ADDR_TBL_SRCH		0x40
+#define L2SW_ADDR_TBL_ST		0x44
+#define L2SW_MAC_AD_SER0		0x48
+#define L2SW_MAC_AD_SER1		0x4c
+#define L2SW_WT_MAC_AD0			0x50
+#define L2SW_W_MAC_15_0			0x54
+#define L2SW_W_MAC_47_16		0x58
+#define L2SW_PVID_CONFIG0		0x5c
+#define L2SW_PVID_CONFIG1		0x60
+#define L2SW_VLAN_MEMSET_CONFIG0	0x64
+#define L2SW_VLAN_MEMSET_CONFIG1	0x68
+#define L2SW_PORT_ABILITY		0x6c
+#define L2SW_PORT_ST			0x70
+#define L2SW_CPU_CNTL			0x74
+#define L2SW_PORT_CNTL0			0x78
+#define L2SW_PORT_CNTL1			0x7c
+#define L2SW_PORT_CNTL2			0x80
+#define L2SW_SW_GLB_CNTL		0x84
+#define L2SW_L2SW_SW_RESET		0x88
+#define L2SW_LED_PORT0			0x8c
+#define L2SW_LED_PORT1			0x90
+#define L2SW_LED_PORT2			0x94
+#define L2SW_LED_PORT3			0x98
+#define L2SW_LED_PORT4			0x9c
+#define L2SW_WATCH_DOG_TRIG_RST		0xa0
+#define L2SW_WATCH_DOG_STOP_CPU		0xa4
+#define L2SW_PHY_CNTL_REG0		0xa8
+#define L2SW_PHY_CNTL_REG1		0xac
+#define L2SW_MAC_FORCE_MODE		0xb0
+#define L2SW_VLAN_GROUP_CONFIG0		0xb4
+#define L2SW_VLAN_GROUP_CONFIG1		0xb8
+#define L2SW_FLOW_CTRL_TH3		0xbc
+#define L2SW_QUEUE_STATUS_0		0xc0
+#define L2SW_DEBUG_CNTL			0xc4
+#define L2SW_RESERVED_1			0xc8
+#define L2SW_MEM_TEST_INFO		0xcc
+#define L2SW_SW_INT_STATUS_1		0xd0
+#define L2SW_SW_INT_MASK_1		0xd4
+#define L2SW_SW_GLOBAL_SIGNAL		0xd8
+
+#define L2SW_CPU_TX_TRIG		0x208
+#define L2SW_TX_HBASE_ADDR_0		0x20c
+#define L2SW_TX_LBASE_ADDR_0		0x210
+#define L2SW_RX_HBASE_ADDR_0		0x214
+#define L2SW_RX_LBASE_ADDR_0		0x218
+#define L2SW_TX_HW_ADDR_0		0x21c
+#define L2SW_TX_LW_ADDR_0		0x220
+#define L2SW_RX_HW_ADDR_0		0x224
+#define L2SW_RX_LW_ADDR_0		0x228
+#define L2SW_CPU_PORT_CNTL_REG_0	0x22c
+#define L2SW_TX_HBASE_ADDR_1		0x230
+#define L2SW_TX_LBASE_ADDR_1		0x234
+#define L2SW_RX_HBASE_ADDR_1		0x238
+#define L2SW_RX_LBASE_ADDR_1		0x23c
+#define L2SW_TX_HW_ADDR_1		0x240
+#define L2SW_TX_LW_ADDR_1		0x244
+#define L2SW_RX_HW_ADDR_1		0x248
+#define L2SW_RX_LW_ADDR_1		0x24c
+#define L2SW_CPU_PORT_CNTL_REG_1	0x250
+
+#endif
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH net-next v8 2/2] net: ethernet: Add driver for Sunplus SP7021
  2022-04-13  2:31 ` [PATCH net-next v8 2/2] net: ethernet: Add driver " Wells Lu
@ 2022-04-14 12:18   ` Jakub Kicinski
  2022-04-14 13:36     ` Andrew Lunn
  2022-04-19  9:49     ` Wells Lu 呂芳騰
  0 siblings, 2 replies; 8+ messages in thread
From: Jakub Kicinski @ 2022-04-14 12:18 UTC (permalink / raw)
  To: Wells Lu
  Cc: davem, robh+dt, netdev, devicetree, linux-kernel, p.zabel,
	pabeni, krzk+dt, roopa, andrew, edumazet, wells.lu

On Wed, 13 Apr 2022 10:31:58 +0800 Wells Lu wrote:
> Add driver for Sunplus SP7021 SoC.
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Wells Lu <wellslutw@gmail.com>
> ---
> Changes in v8
>   - Fixed "WARNING: unmet direct dependencies detected for PINCTRL_SPPCTL".
>     Removed 'select PINCTRL_SPPCTL' in Kconfig.
>     Selecting PINCTRL_SPPCTL is not actually a must.
> 
>  MAINTAINERS                                    |   1 +
>  drivers/net/ethernet/Kconfig                   |   1 +
>  drivers/net/ethernet/Makefile                  |   1 +
>  drivers/net/ethernet/sunplus/Kconfig           |  35 ++
>  drivers/net/ethernet/sunplus/Makefile          |   6 +
>  drivers/net/ethernet/sunplus/spl2sw_define.h   | 271 +++++++++++
>  drivers/net/ethernet/sunplus/spl2sw_desc.c     | 226 +++++++++
>  drivers/net/ethernet/sunplus/spl2sw_desc.h     |  19 +
>  drivers/net/ethernet/sunplus/spl2sw_driver.c   | 604 +++++++++++++++++++++++++
>  drivers/net/ethernet/sunplus/spl2sw_driver.h   |  12 +
>  drivers/net/ethernet/sunplus/spl2sw_int.c      | 253 +++++++++++
>  drivers/net/ethernet/sunplus/spl2sw_int.h      |  13 +
>  drivers/net/ethernet/sunplus/spl2sw_mac.c      | 346 ++++++++++++++
>  drivers/net/ethernet/sunplus/spl2sw_mac.h      |  19 +
>  drivers/net/ethernet/sunplus/spl2sw_mdio.c     | 126 ++++++
>  drivers/net/ethernet/sunplus/spl2sw_mdio.h     |  12 +
>  drivers/net/ethernet/sunplus/spl2sw_phy.c      |  92 ++++
>  drivers/net/ethernet/sunplus/spl2sw_phy.h      |  12 +
>  drivers/net/ethernet/sunplus/spl2sw_register.h |  86 ++++
>  19 files changed, 2135 insertions(+)
>  create mode 100644 drivers/net/ethernet/sunplus/Kconfig
>  create mode 100644 drivers/net/ethernet/sunplus/Makefile
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_define.h
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_desc.c
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_desc.h
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_driver.c
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_driver.h
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_int.c
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_int.h
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mac.c
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mac.h
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mdio.c
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mdio.h
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_phy.c
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_phy.h
>  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_register.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1d54292..0269797 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18875,6 +18875,7 @@ L:	netdev@vger.kernel.org
>  S:	Maintained
>  W:	https://sunplus.atlassian.net/wiki/spaces/doc/overview
>  F:	Documentation/devicetree/bindings/net/sunplus,sp7021-emac.yaml
> +F:	drivers/net/ethernet/sunplus/
>  
>  SUNPLUS OCOTP DRIVER
>  M:	Vincent Shih <vincent.sunplus@gmail.com>
> diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
> index bd4cb9d..8828539 100644
> --- a/drivers/net/ethernet/Kconfig
> +++ b/drivers/net/ethernet/Kconfig
> @@ -179,6 +179,7 @@ source "drivers/net/ethernet/smsc/Kconfig"
>  source "drivers/net/ethernet/socionext/Kconfig"
>  source "drivers/net/ethernet/stmicro/Kconfig"
>  source "drivers/net/ethernet/sun/Kconfig"
> +source "drivers/net/ethernet/sunplus/Kconfig"
>  source "drivers/net/ethernet/synopsys/Kconfig"
>  source "drivers/net/ethernet/tehuti/Kconfig"
>  source "drivers/net/ethernet/ti/Kconfig"
> diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
> index 8ef43e0..9eb0116 100644
> --- a/drivers/net/ethernet/Makefile
> +++ b/drivers/net/ethernet/Makefile
> @@ -90,6 +90,7 @@ obj-$(CONFIG_NET_VENDOR_SMSC) += smsc/
>  obj-$(CONFIG_NET_VENDOR_SOCIONEXT) += socionext/
>  obj-$(CONFIG_NET_VENDOR_STMICRO) += stmicro/
>  obj-$(CONFIG_NET_VENDOR_SUN) += sun/
> +obj-$(CONFIG_NET_VENDOR_SUNPLUS) += sunplus/
>  obj-$(CONFIG_NET_VENDOR_TEHUTI) += tehuti/
>  obj-$(CONFIG_NET_VENDOR_TI) += ti/
>  obj-$(CONFIG_NET_VENDOR_TOSHIBA) += toshiba/
> diff --git a/drivers/net/ethernet/sunplus/Kconfig b/drivers/net/ethernet/sunplus/Kconfig
> new file mode 100644
> index 0000000..d0144a2
> --- /dev/null
> +++ b/drivers/net/ethernet/sunplus/Kconfig
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Sunplus network device configuration
> +#
> +
> +config NET_VENDOR_SUNPLUS
> +	bool "Sunplus devices"
> +	default y
> +	depends on ARCH_SUNPLUS || COMPILE_TEST
> +	help
> +	  If you have a network (Ethernet) card belonging to this
> +	  class, say Y here.
> +
> +	  Note that the answer to this question doesn't directly
> +	  affect the kernel: saying N will just cause the configurator
> +	  to skip all the questions about Sunplus cards. If you say Y,
> +	  you will be asked for your specific card in the following
> +	  questions.
> +
> +if NET_VENDOR_SUNPLUS
> +
> +config SP7021_EMAC
> +	tristate "Sunplus Dual 10M/100M Ethernet devices"
> +	depends on SOC_SP7021 || COMPILE_TEST
> +	select PHYLIB
> +	select COMMON_CLK_SP7021
> +	select RESET_SUNPLUS
> +	select NVMEM_SUNPLUS_OCOTP
> +	help
> +	  If you have Sunplus dual 10M/100M Ethernet devices, say Y.
> +	  The network device creates two net-device interfaces.
> +	  To compile this driver as a module, choose M here. The
> +	  module will be called sp7021_emac.
> +
> +endif # NET_VENDOR_SUNPLUS
> diff --git a/drivers/net/ethernet/sunplus/Makefile b/drivers/net/ethernet/sunplus/Makefile
> new file mode 100644
> index 0000000..ef7d7d0
> --- /dev/null
> +++ b/drivers/net/ethernet/sunplus/Makefile
> @@ -0,0 +1,6 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Makefile for the Sunplus network device drivers.
> +#
> +obj-$(CONFIG_SP7021_EMAC) += sp7021_emac.o
> +sp7021_emac-objs := spl2sw_driver.o spl2sw_int.o spl2sw_desc.o spl2sw_mac.o spl2sw_mdio.o spl2sw_phy.o
> diff --git a/drivers/net/ethernet/sunplus/spl2sw_define.h b/drivers/net/ethernet/sunplus/spl2sw_define.h
> new file mode 100644
> index 0000000..f299bda
> --- /dev/null
> +++ b/drivers/net/ethernet/sunplus/spl2sw_define.h
> @@ -0,0 +1,271 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright Sunplus Technology Co., Ltd.
> + *       All rights reserved.
> + */
> +
> +#ifndef __SPL2SW_DEFINE_H__
> +#define __SPL2SW_DEFINE_H__
> +
> +#define MAX_NETDEV_NUM			2	/* Maximum # of net-device */
> +
> +/* Interrupt status */
> +#define MAC_INT_DAISY_MODE_CHG		BIT(31) /* Daisy Mode Change             */
> +#define MAC_INT_IP_CHKSUM_ERR		BIT(23) /* IP Checksum Append Error      */
> +#define MAC_INT_WDOG_TIMER1_EXP		BIT(22) /* Watchdog Timer1 Expired       */
> +#define MAC_INT_WDOG_TIMER0_EXP		BIT(21) /* Watchdog Timer0 Expired       */
> +#define MAC_INT_INTRUDER_ALERT		BIT(20) /* Atruder Alert                 */
> +#define MAC_INT_PORT_ST_CHG		BIT(19) /* Port Status Change            */
> +#define MAC_INT_BC_STORM		BIT(18) /* Broad Cast Storm              */
> +#define MAC_INT_MUST_DROP_LAN		BIT(17) /* Global Queue Exhausted        */
> +#define MAC_INT_GLOBAL_QUE_FULL		BIT(16) /* Global Queue Full             */
> +#define MAC_INT_TX_SOC_PAUSE_ON		BIT(15) /* Soc Port TX Pause On          */
> +#define MAC_INT_RX_SOC_QUE_FULL		BIT(14) /* Soc Port Out Queue Full       */
> +#define MAC_INT_TX_LAN1_QUE_FULL	BIT(9)  /* Port 1 Out Queue Full         */
> +#define MAC_INT_TX_LAN0_QUE_FULL	BIT(8)  /* Port 0 Out Queue Full         */
> +#define MAC_INT_RX_L_DESCF		BIT(7)  /* Low Priority Descriptor Full  */
> +#define MAC_INT_RX_H_DESCF		BIT(6)  /* High Priority Descriptor Full */
> +#define MAC_INT_RX_DONE_L		BIT(5)  /* RX Low Priority Done          */
> +#define MAC_INT_RX_DONE_H		BIT(4)  /* RX High Priority Done         */
> +#define MAC_INT_TX_DONE_L		BIT(3)  /* TX Low Priority Done          */
> +#define MAC_INT_TX_DONE_H		BIT(2)  /* TX High Priority Done         */
> +#define MAC_INT_TX_DES_ERR		BIT(1)  /* TX Descriptor Error           */
> +#define MAC_INT_RX_DES_ERR		BIT(0)  /* Rx Descriptor Error           */
> +
> +#define MAC_INT_RX			(MAC_INT_RX_DONE_H | MAC_INT_RX_DONE_L | \
> +					MAC_INT_RX_DES_ERR)
> +#define MAC_INT_TX			(MAC_INT_TX_DONE_L | MAC_INT_TX_DONE_H | \
> +					MAC_INT_TX_DES_ERR)
> +#define MAC_INT_MASK_DEF		(MAC_INT_DAISY_MODE_CHG | MAC_INT_IP_CHKSUM_ERR | \
> +					MAC_INT_WDOG_TIMER1_EXP | MAC_INT_WDOG_TIMER0_EXP | \
> +					MAC_INT_INTRUDER_ALERT | MAC_INT_PORT_ST_CHG | \
> +					MAC_INT_BC_STORM | MAC_INT_MUST_DROP_LAN | \
> +					MAC_INT_GLOBAL_QUE_FULL | MAC_INT_TX_SOC_PAUSE_ON | \
> +					MAC_INT_RX_SOC_QUE_FULL | MAC_INT_TX_LAN1_QUE_FULL | \
> +					MAC_INT_TX_LAN0_QUE_FULL | MAC_INT_RX_L_DESCF | \
> +					MAC_INT_RX_H_DESCF)
> +
> +/* Address table search */
> +#define MAC_ADDR_LOOKUP_IDLE		BIT(2)
> +#define MAC_SEARCH_NEXT_ADDR		BIT(1)
> +#define MAC_BEGIN_SEARCH_ADDR		BIT(0)
> +
> +/* Address table status */
> +#define MAC_HASH_LOOKUP_ADDR		GENMASK(31, 22)
> +#define MAC_R_PORT_MAP			GENMASK(13, 12)
> +#define MAC_R_CPU_PORT			GENMASK(11, 10)
> +#define MAC_R_VID			GENMASK(9, 7)
> +#define MAC_R_AGE			GENMASK(6, 4)
> +#define MAC_R_PROXY			BIT(3)
> +#define MAC_R_MC_INGRESS		BIT(2)
> +#define MAC_AT_TABLE_END		BIT(1)
> +#define MAC_AT_DATA_READY		BIT(0)
> +
> +/* Wt mac ad0 */
> +#define MAC_W_PORT_MAP			GENMASK(13, 12)
> +#define MAC_W_LAN_PORT_1		BIT(13)
> +#define MAC_W_LAN_PORT_0		BIT(12)
> +#define MAC_W_CPU_PORT			GENMASK(11, 10)
> +#define MAC_W_CPU_PORT_1		BIT(11)
> +#define MAC_W_CPU_PORT_0		BIT(10)
> +#define MAC_W_VID			GENMASK(9, 7)
> +#define MAC_W_AGE			GENMASK(6, 4)
> +#define MAC_W_PROXY			BIT(3)
> +#define MAC_W_MC_INGRESS		BIT(2)
> +#define MAC_W_MAC_DONE			BIT(1)
> +#define MAC_W_MAC_CMD			BIT(0)
> +
> +/* W mac 15_0 bus */
> +#define MAC_W_MAC_15_0			GENMASK(15, 0)
> +
> +/* W mac 47_16 bus */
> +#define MAC_W_MAC_47_16			GENMASK(31, 0)
> +
> +/* PVID config 0 */
> +#define MAC_P1_PVID			GENMASK(6, 4)
> +#define MAC_P0_PVID			GENMASK(2, 0)
> +
> +/* VLAN member config 0 */
> +#define MAC_VLAN_MEMSET_3		GENMASK(27, 24)
> +#define MAC_VLAN_MEMSET_2		GENMASK(19, 16)
> +#define MAC_VLAN_MEMSET_1		GENMASK(11, 8)
> +#define MAC_VLAN_MEMSET_0		GENMASK(3, 0)
> +
> +/* VLAN member config 1 */
> +#define MAC_VLAN_MEMSET_5		GENMASK(11, 8)
> +#define MAC_VLAN_MEMSET_4		GENMASK(3, 0)
> +
> +/* Port ability */
> +#define MAC_PORT_ABILITY_LINK_ST	GENMASK(25, 24)
> +
> +/* CPU control */
> +#define MAC_EN_SOC1_AGING		BIT(15)
> +#define MAC_EN_SOC0_AGING		BIT(14)
> +#define MAC_DIS_LRN_SOC1		BIT(13)
> +#define MAC_DIS_LRN_SOC0		BIT(12)
> +#define MAC_EN_CRC_SOC1			BIT(9)
> +#define MAC_EN_CRC_SOC0			BIT(8)
> +#define MAC_DIS_SOC1_CPU		BIT(7)
> +#define MAC_DIS_SOC0_CPU		BIT(6)
> +#define MAC_DIS_BC2CPU_P1		BIT(5)
> +#define MAC_DIS_BC2CPU_P0		BIT(4)
> +#define MAC_DIS_MC2CPU			GENMASK(3, 2)
> +#define MAC_DIS_MC2CPU_P1		BIT(3)
> +#define MAC_DIS_MC2CPU_P0		BIT(2)
> +#define MAC_DIS_UN2CPU			GENMASK(1, 0)
> +
> +/* Port control 0 */
> +#define MAC_DIS_PORT			GENMASK(25, 24)
> +#define MAC_DIS_PORT1			BIT(25)
> +#define MAC_DIS_PORT0			BIT(24)
> +#define MAC_DIS_RMC2CPU_P1		BIT(17)
> +#define MAC_DIS_RMC2CPU_P0		BIT(16)
> +#define MAC_EN_FLOW_CTL_P1		BIT(9)
> +#define MAC_EN_FLOW_CTL_P0		BIT(8)
> +#define MAC_EN_BACK_PRESS_P1		BIT(1)
> +#define MAC_EN_BACK_PRESS_P0		BIT(0)
> +
> +/* Port control 1 */
> +#define MAC_DIS_SA_LRN_P1		BIT(9)
> +#define MAC_DIS_SA_LRN_P0		BIT(8)
> +
> +/* Port control 2 */
> +#define MAC_EN_AGING_P1			BIT(9)
> +#define MAC_EN_AGING_P0			BIT(8)
> +
> +/* Switch Global control */
> +#define MAC_RMC_TB_FAULT_RULE		GENMASK(26, 25)
> +#define MAC_LED_FLASH_TIME		GENMASK(24, 23)
> +#define MAC_BC_STORM_PREV		GENMASK(5, 4)
> +
> +/* LED port 0 */
> +#define MAC_LED_ACT_HI			BIT(28)
> +
> +/* PHY control register 0  */
> +#define MAC_CPU_PHY_WT_DATA		GENMASK(31, 16)
> +#define MAC_CPU_PHY_CMD			GENMASK(14, 13)
> +#define MAC_CPU_PHY_REG_ADDR		GENMASK(12, 8)
> +#define MAC_CPU_PHY_ADDR		GENMASK(4, 0)
> +
> +/* PHY control register 1 */
> +#define MAC_CPU_PHY_RD_DATA		GENMASK(31, 16)
> +#define MAC_PHY_RD_RDY			BIT(1)
> +#define MAC_PHY_WT_DONE			BIT(0)
> +
> +/* MAC force mode */
> +#define MAC_EXT_PHY1_ADDR		GENMASK(28, 24)
> +#define MAC_EXT_PHY0_ADDR		GENMASK(20, 16)
> +#define MAC_FORCE_RMII_LINK		GENMASK(9, 8)
> +#define MAC_FORCE_RMII_EN_1		BIT(7)
> +#define MAC_FORCE_RMII_EN_0		BIT(6)
> +#define MAC_FORCE_RMII_FC		GENMASK(5, 4)
> +#define MAC_FORCE_RMII_DPX		GENMASK(3, 2)
> +#define MAC_FORCE_RMII_SPD		GENMASK(1, 0)
> +
> +/* CPU transmit trigger */
> +#define MAC_TRIG_L_SOC0			BIT(1)
> +#define MAC_TRIG_H_SOC0			BIT(0)
> +
> +/* Config descriptor queue */
> +#define TX_DESC_NUM			16	/* # of descriptors in TX queue   */
> +#define MAC_GUARD_DESC_NUM		2	/* # of descriptors of gap      0 */
> +#define RX_QUEUE0_DESC_NUM		16	/* # of descriptors in RX queue 0 */
> +#define RX_QUEUE1_DESC_NUM		16	/* # of descriptors in RX queue 1 */
> +#define TX_DESC_QUEUE_NUM		1	/* # of TX queue                  */
> +#define RX_DESC_QUEUE_NUM		2	/* # of RX queue                  */
> +
> +#define MAC_RX_LEN_MAX			2047	/* Size of RX buffer       */
> +
> +/* Tx descriptor */
> +/* cmd1 */
> +#define TXD_OWN				BIT(31)
> +#define TXD_ERR_CODE			GENMASK(29, 26)
> +#define TXD_SOP				BIT(25)		/* start of a packet */
> +#define TXD_EOP				BIT(24)		/* end of a packet */
> +#define TXD_VLAN			GENMASK(17, 12)
> +#define TXD_PKT_LEN			GENMASK(10, 0)	/* packet length */
> +/* cmd2 */
> +#define TXD_EOR				BIT(31)		/* end of ring */
> +#define TXD_BUF_LEN2			GENMASK(22, 12)
> +#define TXD_BUF_LEN1			GENMASK(10, 0)
> +
> +/* Rx descriptor */
> +/* cmd1 */
> +#define RXD_OWN				BIT(31)
> +#define RXD_ERR_CODE			GENMASK(29, 26)
> +#define RXD_TCP_UDP_CHKSUM		BIT(23)
> +#define RXD_PROXY			BIT(22)
> +#define RXD_PROTOCOL			GENMASK(21, 20)
> +#define RXD_VLAN_TAG			BIT(19)
> +#define RXD_IP_CHKSUM			BIT(18)
> +#define RXD_ROUTE_TYPE			GENMASK(17, 16)
> +#define RXD_PKT_SP			GENMASK(14, 12)	/* packet source port */
> +#define RXD_PKT_LEN			GENMASK(10, 0)	/* packet length */
> +/* cmd2 */
> +#define RXD_EOR				BIT(31)		/* end of ring */
> +#define RXD_BUF_LEN2			GENMASK(22, 12)
> +#define RXD_BUF_LEN1			GENMASK(10, 0)
> +
> +/* structure of descriptor */
> +struct spl2sw_mac_desc {
> +	u32 cmd1;
> +	u32 cmd2;
> +	u32 addr1;
> +	u32 addr2;
> +};
> +
> +struct spl2sw_skb_info {
> +	struct sk_buff *skb;
> +	u32 mapping;
> +	u32 len;
> +};
> +
> +struct spl2sw_common {
> +	void __iomem *l2sw_reg_base;
> +
> +	struct platform_device *pdev;
> +	struct reset_control *rstc;
> +	struct clk *clk;
> +	int irq;
> +
> +	void *desc_base;
> +	dma_addr_t desc_dma;
> +	s32 desc_size;
> +	struct spl2sw_mac_desc *rx_desc[RX_DESC_QUEUE_NUM];
> +	struct spl2sw_skb_info *rx_skb_info[RX_DESC_QUEUE_NUM];
> +	u32 rx_pos[RX_DESC_QUEUE_NUM];
> +	u32 rx_desc_num[RX_DESC_QUEUE_NUM];
> +	u32 rx_desc_buff_size;
> +
> +	struct spl2sw_mac_desc *tx_desc;
> +	struct spl2sw_skb_info tx_temp_skb_info[TX_DESC_NUM];
> +	u32 tx_done_pos;
> +	u32 tx_pos;
> +	u32 tx_desc_full;
> +
> +	struct net_device *ndev[MAX_NETDEV_NUM];
> +	struct mii_bus *mii_bus;
> +
> +	struct napi_struct rx_napi;
> +	struct napi_struct tx_napi;
> +
> +	spinlock_t rx_lock;	/* spinlock for accessing rx buffer */
> +	spinlock_t tx_lock;	/* spinlock for accessing tx buffer */
> +	spinlock_t mdio_lock;	/* spinlock for mdio commands */
> +
> +	u8 enable;
> +};
> +
> +struct spl2sw_mac {
> +	struct net_device *ndev;
> +	struct spl2sw_common *comm;
> +
> +	u8 mac_addr[ETH_ALEN];
> +	phy_interface_t phy_mode;
> +	struct device_node *phy_node;
> +
> +	u8 lan_port;
> +	u8 to_vlan;
> +	u8 vlan_id;
> +};
> +
> +#endif
> diff --git a/drivers/net/ethernet/sunplus/spl2sw_desc.c b/drivers/net/ethernet/sunplus/spl2sw_desc.c
> new file mode 100644
> index 0000000..7d237d4
> --- /dev/null
> +++ b/drivers/net/ethernet/sunplus/spl2sw_desc.c
> @@ -0,0 +1,226 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright Sunplus Technology Co., Ltd.
> + *       All rights reserved.
> + */
> +
> +#include <linux/platform_device.h>
> +#include <linux/netdevice.h>
> +#include <linux/of_mdio.h>
> +
> +#include "spl2sw_define.h"
> +#include "spl2sw_desc.h"
> +
> +void spl2sw_rx_descs_flush(struct spl2sw_common *comm)
> +{
> +	struct spl2sw_skb_info *rx_skbinfo;
> +	struct spl2sw_mac_desc *rx_desc;
> +	u32 i, j;
> +
> +	for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
> +		rx_desc = comm->rx_desc[i];
> +		rx_skbinfo = comm->rx_skb_info[i];
> +		for (j = 0; j < comm->rx_desc_num[i]; j++) {
> +			rx_desc[j].addr1 = rx_skbinfo[j].mapping;
> +			rx_desc[j].cmd2 = (j == comm->rx_desc_num[i] - 1) ?
> +					  RXD_EOR | comm->rx_desc_buff_size :
> +					  comm->rx_desc_buff_size;
> +			wmb();	/* Set RXD_OWN after other fields are ready. */
> +			rx_desc[j].cmd1 = RXD_OWN;
> +		}
> +	}
> +}
> +
> +void spl2sw_tx_descs_clean(struct spl2sw_common *comm)
> +{
> +	u32 i;
> +
> +	if (!comm->tx_desc)
> +		return;
> +
> +	for (i = 0; i < TX_DESC_NUM; i++) {
> +		comm->tx_desc[i].cmd1 = 0;
> +		wmb();	/* Clear TXD_OWN and then set other fields. */
> +		comm->tx_desc[i].cmd2 = 0;
> +		comm->tx_desc[i].addr1 = 0;
> +		comm->tx_desc[i].addr2 = 0;
> +
> +		if (comm->tx_temp_skb_info[i].mapping) {
> +			dma_unmap_single(&comm->pdev->dev, comm->tx_temp_skb_info[i].mapping,
> +					 comm->tx_temp_skb_info[i].skb->len, DMA_TO_DEVICE);
> +			comm->tx_temp_skb_info[i].mapping = 0;
> +		}
> +
> +		if (comm->tx_temp_skb_info[i].skb) {
> +			dev_kfree_skb_any(comm->tx_temp_skb_info[i].skb);
> +			comm->tx_temp_skb_info[i].skb = NULL;
> +		}
> +	}
> +}
> +
> +void spl2sw_rx_descs_clean(struct spl2sw_common *comm)
> +{
> +	struct spl2sw_skb_info *rx_skbinfo;
> +	struct spl2sw_mac_desc *rx_desc;
> +	u32 i, j;
> +
> +	for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
> +		if (!comm->rx_skb_info[i])
> +			continue;
> +
> +		rx_desc = comm->rx_desc[i];
> +		rx_skbinfo = comm->rx_skb_info[i];
> +		for (j = 0; j < comm->rx_desc_num[i]; j++) {
> +			rx_desc[j].cmd1 = 0;
> +			wmb();	/* Clear RXD_OWN and then set other fields. */
> +			rx_desc[j].cmd2 = 0;
> +			rx_desc[j].addr1 = 0;
> +
> +			if (rx_skbinfo[j].skb) {
> +				dma_unmap_single(&comm->pdev->dev, rx_skbinfo[j].mapping,
> +						 comm->rx_desc_buff_size, DMA_FROM_DEVICE);
> +				dev_kfree_skb_any(rx_skbinfo[j].skb);
> +				rx_skbinfo[j].skb = NULL;
> +				rx_skbinfo[j].mapping = 0;
> +			}
> +		}
> +
> +		kfree(rx_skbinfo);
> +		comm->rx_skb_info[i] = NULL;
> +	}
> +}
> +
> +void spl2sw_descs_clean(struct spl2sw_common *comm)
> +{
> +	spl2sw_rx_descs_clean(comm);
> +	spl2sw_tx_descs_clean(comm);
> +}
> +
> +void spl2sw_descs_free(struct spl2sw_common *comm)
> +{
> +	u32 i;
> +
> +	spl2sw_descs_clean(comm);
> +	comm->tx_desc = NULL;
> +	for (i = 0; i < RX_DESC_QUEUE_NUM; i++)
> +		comm->rx_desc[i] = NULL;
> +
> +	/*  Free descriptor area  */
> +	if (comm->desc_base) {
> +		dma_free_coherent(&comm->pdev->dev, comm->desc_size, comm->desc_base,
> +				  comm->desc_dma);
> +		comm->desc_base = NULL;
> +		comm->desc_dma = 0;
> +		comm->desc_size = 0;
> +	}
> +}
> +
> +void spl2sw_tx_descs_init(struct spl2sw_common *comm)
> +{
> +	memset(comm->tx_desc, '\0', sizeof(struct spl2sw_mac_desc) *
> +	       (TX_DESC_NUM + MAC_GUARD_DESC_NUM));
> +}
> +
> +int spl2sw_rx_descs_init(struct spl2sw_common *comm)
> +{
> +	struct spl2sw_skb_info *rx_skbinfo;
> +	struct spl2sw_mac_desc *rx_desc;
> +	struct sk_buff *skb;
> +	u32 i, j;
> +
> +	for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
> +		comm->rx_skb_info[i] = kcalloc(comm->rx_desc_num[i], sizeof(*rx_skbinfo),
> +					       GFP_KERNEL | GFP_DMA);
> +		if (!comm->rx_skb_info[i])
> +			goto mem_alloc_fail;
> +
> +		rx_skbinfo = comm->rx_skb_info[i];
> +		rx_desc = comm->rx_desc[i];
> +		for (j = 0; j < comm->rx_desc_num[i]; j++) {
> +			skb = netdev_alloc_skb(NULL, comm->rx_desc_buff_size);
> +			if (!skb)
> +				goto mem_alloc_fail;
> +
> +			rx_skbinfo[j].skb = skb;
> +			rx_skbinfo[j].mapping = dma_map_single(&comm->pdev->dev, skb->data,
> +							       comm->rx_desc_buff_size,
> +							       DMA_FROM_DEVICE);
> +			if (dma_mapping_error(&comm->pdev->dev, rx_skbinfo[j].mapping))
> +				goto mem_alloc_fail;

Can you call spl2sw_rx_descs_clean() here without clearing the skb?
It will try to unmap the error mapping.

> +			rx_desc[j].addr1 = rx_skbinfo[j].mapping;
> +			rx_desc[j].addr2 = 0;
> +			rx_desc[j].cmd2 = (j == comm->rx_desc_num[i] - 1) ?
> +					  RXD_EOR | comm->rx_desc_buff_size :
> +					  comm->rx_desc_buff_size;
> +			wmb();	/* Set RXD_OWN after other fields are effective. */
> +			rx_desc[j].cmd1 = RXD_OWN;
> +		}
> +	}
> +
> +	return 0;
> +
> +mem_alloc_fail:
> +	spl2sw_rx_descs_clean(comm);
> +	return -ENOMEM;
> +}

> +int spl2sw_descs_init(struct spl2sw_common *comm)
> +{
> +	u32 i, ret;
> +
> +	/* Initialize rx descriptor's data */
> +	comm->rx_desc_num[0] = RX_QUEUE0_DESC_NUM;
> +	comm->rx_desc_num[1] = RX_QUEUE1_DESC_NUM;
> +
> +	for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
> +		comm->rx_desc[i] = NULL;
> +		comm->rx_skb_info[i] = NULL;
> +		comm->rx_pos[i] = 0;
> +	}
> +	comm->rx_desc_buff_size = MAC_RX_LEN_MAX;
> +
> +	/* Initialize tx descriptor's data */
> +	comm->tx_done_pos = 0;
> +	comm->tx_desc = NULL;
> +	comm->tx_pos = 0;
> +	comm->tx_desc_full = 0;
> +	for (i = 0; i < TX_DESC_NUM; i++)
> +		comm->tx_temp_skb_info[i].skb = NULL;
> +
> +	/* Allocate tx & rx descriptors. */
> +	ret = spl2sw_descs_alloc(comm);
> +	if (ret)
> +		return ret;
> +
> +	spl2sw_tx_descs_init(comm);
> +
> +	return spl2sw_rx_descs_init(comm);

Don't you have to free whatever spl2sw_descs_alloc() allocated, here?

> +}

> +static int spl2sw_ethernet_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> +{
> +	struct spl2sw_mac *mac = netdev_priv(ndev);
> +	struct spl2sw_common *comm = mac->comm;
> +	struct spl2sw_skb_info *skbinfo;
> +	struct spl2sw_mac_desc *txdesc;
> +	unsigned long flags;
> +	u32 tx_pos;
> +	u32 cmd1;
> +	u32 cmd2;
> +
> +	if (unlikely(comm->tx_desc_full == 1)) {
> +		/* No TX descriptors left. Wait for tx interrupt. */
> +		netdev_dbg(ndev, "TX descriptor queue full when xmit!\n");
> +		return NETDEV_TX_BUSY;
> +	}
> +
> +	/* If skb size is shorter than ETH_ZLEN (60), pad it with 0. */
> +	if (unlikely(skb->len < ETH_ZLEN)) {
> +		if (skb_tailroom(skb) >= (ETH_ZLEN - skb->len)) {
> +			memset(skb_put(skb, ETH_ZLEN - skb->len), '\0',
> +			       ETH_ZLEN - skb->len);
> +		} else {
> +			struct sk_buff *old_skb = skb;
> +
> +			skb = netdev_alloc_skb(ndev, ETH_ZLEN);
> +			if (skb) {
> +				memset(skb->data + old_skb->len, '\0',
> +				       ETH_ZLEN - old_skb->len);
> +				memcpy(skb->data, old_skb->data, old_skb->len);
> +				skb_put(skb, ETH_ZLEN);
> +				dev_kfree_skb(old_skb);
> +			} else {
> +				skb = old_skb;
> +			}
> +		}
> +	}

skb_padto()

> +	spin_lock_irqsave(&comm->tx_lock, flags);
> +	tx_pos = comm->tx_pos;
> +	txdesc = &comm->tx_desc[tx_pos];
> +	skbinfo = &comm->tx_temp_skb_info[tx_pos];
> +	skbinfo->len = skb->len;
> +	skbinfo->skb = skb;
> +	skbinfo->mapping = dma_map_single(&comm->pdev->dev, skb->data,
> +					  skb->len, DMA_TO_DEVICE);
> +	if (dma_mapping_error(&comm->pdev->dev, skbinfo->mapping)) {
> +		ndev->stats.tx_errors++;
> +		dev_kfree_skb(skb);
> +		skbinfo->mapping = 0;
> +		skbinfo->len = 0;
> +		skbinfo->skb = NULL;

Don't init these before dma_map_single() so you won't have to clear
them on failure.

> +		goto xmit_drop;
> +	}
> +
> +	/* Set up a TX descriptor */
> +	cmd1 = TXD_OWN | TXD_SOP | TXD_EOP | (mac->to_vlan << 12) |
> +	       (skb->len & TXD_PKT_LEN);
> +	cmd2 = skb->len & TXD_BUF_LEN1;
> +
> +	if (tx_pos == (TX_DESC_NUM - 1))
> +		cmd2 |= TXD_EOR;
> +
> +	txdesc->addr1 = skbinfo->mapping;
> +	txdesc->cmd2 = cmd2;
> +	wmb();	/* Set TXD_OWN after other fields are effective. */
> +	txdesc->cmd1 = cmd1;
> +
> +	/* Move tx_pos to next position */
> +	tx_pos = ((tx_pos + 1) == TX_DESC_NUM) ? 0 : tx_pos + 1;
> +
> +	if (unlikely(tx_pos == comm->tx_done_pos)) {
> +		netif_stop_queue(ndev);
> +		comm->tx_desc_full = 1;

Why do you maintain this tx_desc_full variable? You could compare pos
to done_pos instead, no?

> +	}
> +	comm->tx_pos = tx_pos;
> +	wmb();		/* make sure settings are effective. */
> +
> +	/* trigger gmac to transmit */
> +	writel(MAC_TRIG_L_SOC0, comm->l2sw_reg_base + L2SW_CPU_TX_TRIG);
> +
> +xmit_drop:
> +	spin_unlock_irqrestore(&comm->tx_lock, flags);
> +	return NETDEV_TX_OK;
> +}

> +static int spl2sw_probe(struct platform_device *pdev)
> +{
> +	struct device_node *eth_ports_np;
> +	struct device_node *port_np;
> +	struct spl2sw_common *comm;
> +	struct device_node *phy_np;
> +	phy_interface_t phy_mode;
> +	struct net_device *ndev;
> +	u8 mac_addr[ETH_ALEN];
> +	struct spl2sw_mac *mac;
> +	int irq, i;
> +	int ret;
> +
> +	if (platform_get_drvdata(pdev))
> +		return -ENODEV;
> +
> +	/* Allocate memory for 'spl2sw_common' area. */
> +	comm = devm_kzalloc(&pdev->dev, sizeof(*comm), GFP_KERNEL);
> +	if (!comm)
> +		return -ENOMEM;
> +	comm->pdev = pdev;
> +
> +	spin_lock_init(&comm->rx_lock);
> +	spin_lock_init(&comm->tx_lock);
> +	spin_lock_init(&comm->mdio_lock);
> +
> +	/* Get memory resource 0 from dts. */
> +	comm->l2sw_reg_base = devm_platform_ioremap_resource(pdev, 0);
> +	if (IS_ERR(comm->l2sw_reg_base))
> +		return PTR_ERR(comm->l2sw_reg_base);
> +
> +	/* Get irq resource from dts. */
> +	ret = platform_get_irq(pdev, 0);
> +	if (ret < 0)
> +		return ret;
> +	irq = ret;
> +
> +	/* Get clock controller. */
> +	comm->clk = devm_clk_get(&pdev->dev, NULL);
> +	if (IS_ERR(comm->clk)) {
> +		dev_err_probe(&pdev->dev, PTR_ERR(comm->clk),
> +			      "Failed to retrieve clock controller!\n");
> +		return PTR_ERR(comm->clk);
> +	}
> +
> +	/* Get reset controller. */
> +	comm->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> +	if (IS_ERR(comm->rstc)) {
> +		dev_err_probe(&pdev->dev, PTR_ERR(comm->rstc),
> +			      "Failed to retrieve reset controller!\n");
> +		return PTR_ERR(comm->rstc);
> +	}
> +
> +	/* Enable clock. */
> +	clk_prepare_enable(comm->clk);

This can fail.

> +	udelay(1);
> +
> +	reset_control_assert(comm->rstc);
> +	udelay(1);
> +	reset_control_deassert(comm->rstc);
> +	udelay(1);
> +
> +	/* Get child node ethernet-ports. */
> +	eth_ports_np = of_get_child_by_name(pdev->dev.of_node, "ethernet-ports");
> +	if (!eth_ports_np) {
> +		dev_err(&pdev->dev, "No ethernet-ports child node found!\n");
> +		ret = -ENODEV;
> +		goto out_clk_disable;
> +	}
> +
> +	for (i = 0; i < MAX_NETDEV_NUM; i++) {
> +		/* Get port@i of node ethernet-ports. */
> +		port_np = spl2sw_get_eth_child_node(eth_ports_np, i);
> +		if (!port_np)
> +			continue;
> +
> +		/* Get phy-mode. */
> +		if (of_get_phy_mode(port_np, &phy_mode)) {
> +			dev_err(&pdev->dev, "Failed to get phy-mode property of port@%d!\n",
> +				i);
> +			continue;
> +		}
> +
> +		/* Get phy-handle. */
> +		phy_np = of_parse_phandle(port_np, "phy-handle", 0);
> +		if (!phy_np) {
> +			dev_err(&pdev->dev, "Failed to get phy-handle property of port@%d!\n",
> +				i);
> +			continue;
> +		}
> +
> +		/* Get mac-address from nvmem. */
> +		ret = spl2sw_nvmem_get_mac_address(&pdev->dev, port_np, mac_addr);
> +		if (ret) {
> +			dev_info(&pdev->dev, "Generate a random mac address!\n");
> +
> +			/* Generate a mac address using OUI of Sunplus Technology
> +			 * and random controller number.
> +			 */
> +			mac_addr[0] = 0xfc; /* OUI of Sunplus: fc:4b:bc */
> +			mac_addr[1] = 0x4b;
> +			mac_addr[2] = 0xbc;
> +			mac_addr[3] = get_random_int() % 256;
> +			mac_addr[4] = get_random_int() % 256;
> +			mac_addr[5] = get_random_int() % 256;

I don't think you can do that. Either you use your OUI and assign the
address at manufacture or you must use a locally administered address.
And if locally administered address is used it better be completely
random to lower the probability of collision to absolute minimum.

> +		}
> +
> +		/* Initialize the net device. */
> +		ret = spl2sw_init_netdev(pdev, mac_addr, &ndev);
> +		if (ret)
> +			goto out_unregister_dev;
> +
> +		ndev->irq = irq;
> +		comm->ndev[i] = ndev;
> +		mac = netdev_priv(ndev);
> +		mac->phy_node = phy_np;
> +		mac->phy_mode = phy_mode;
> +		mac->comm = comm;
> +
> +		mac->lan_port = 0x1 << i;	/* forward to port i */
> +		mac->to_vlan = 0x1 << i;	/* vlan group: i     */
> +		mac->vlan_id = i;		/* vlan group: i     */
> +
> +		/* Set MAC address */
> +		ret = spl2sw_mac_addr_add(mac);
> +		if (ret)
> +			goto out_unregister_dev;
> +
> +		spl2sw_mac_rx_mode_set(mac);
> +	}

> +	/* Request irq. */
> +	ret = devm_request_irq(&pdev->dev, irq, spl2sw_ethernet_interrupt,
> +			       0, ndev->name, ndev);

Why use a netdev pointer as priv for a common IRQ?

> +	if (ret) {
> +		netdev_err(ndev, "Failed to request irq #%d for \"%s\"!\n",
> +			   irq, ndev->name);
> +		goto out_unregister_dev;
> +	}
> +
> +	/* Initialize mdio bus */
> +	ret = spl2sw_mdio_init(comm);
> +	if (ret) {
> +		netdev_err(ndev, "Failed to initialize mdio bus!\n");
> +		goto out_unregister_dev;
> +	}
> +
> +	ret = spl2sw_mac_addr_del_all(comm);
> +	if (ret)
> +		goto out_free_mdio;
> +
> +	ret = spl2sw_descs_init(comm);
> +	if (ret) {
> +		dev_err(&comm->pdev->dev, "Fail to initialize mac descriptors!\n");
> +		spl2sw_descs_free(comm);
> +		goto out_free_mdio;
> +	}
> +
> +	spl2sw_mac_init(comm);
> +
> +	ret = spl2sw_phy_connect(comm);
> +	if (ret) {
> +		netdev_err(ndev, "Failed to connect phy!\n");
> +		goto out_free_mdio;
> +	}

You do all this init after registering the netdev. What prevent the
user space from opening the device and trying to use it before the
probe finished? Seems ripe for crashes. Registering netdevs should
be done very late during probe().

> +	netif_napi_add(ndev, &comm->rx_napi, spl2sw_rx_poll, SPL2SW_RX_NAPI_WEIGHT);
> +	napi_enable(&comm->rx_napi);
> +	netif_napi_add(ndev, &comm->tx_napi, spl2sw_tx_poll, SPL2SW_TX_NAPI_WEIGHT);
> +	napi_enable(&comm->tx_napi);
> +	return 0;
> +
> +out_free_mdio:
> +	spl2sw_mdio_remove(comm);
> +
> +out_unregister_dev:
> +	for (i = 0; i < MAX_NETDEV_NUM; i++)
> +		if (comm->ndev[i])
> +			unregister_netdev(comm->ndev[i]);
> +
> +out_clk_disable:
> +	clk_disable_unprepare(comm->clk);
> +	return ret;
> +}

> new file mode 100644
> index 0000000..5f177b3
> --- /dev/null
> +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.h
> @@ -0,0 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright Sunplus Technology Co., Ltd.
> + *       All rights reserved.
> + */
> +
> +#ifndef __SPL2SW_DRIVER_H__
> +#define __SPL2SW_DRIVER_H__
> +
> +#define SPL2SW_RX_NAPI_WEIGHT	16
> +#define SPL2SW_TX_NAPI_WEIGHT	16
> +
> +#endif
> diff --git a/drivers/net/ethernet/sunplus/spl2sw_int.c b/drivers/net/ethernet/sunplus/spl2sw_int.c
> new file mode 100644
> index 0000000..b6ab8fe
> --- /dev/null
> +++ b/drivers/net/ethernet/sunplus/spl2sw_int.c
> @@ -0,0 +1,253 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright Sunplus Technology Co., Ltd.
> + *       All rights reserved.
> + */
> +
> +#include <linux/platform_device.h>
> +#include <linux/etherdevice.h>
> +#include <linux/netdevice.h>
> +#include <linux/bitfield.h>
> +#include <linux/of_mdio.h>
> +
> +#include "spl2sw_register.h"
> +#include "spl2sw_define.h"
> +#include "spl2sw_int.h"
> +
> +int spl2sw_rx_poll(struct napi_struct *napi, int budget)
> +{
> +	struct spl2sw_common *comm = container_of(napi, struct spl2sw_common, rx_napi);
> +	struct spl2sw_mac_desc *desc, *h_desc;
> +	struct net_device_stats *stats;
> +	struct sk_buff *skb, *new_skb;
> +	struct spl2sw_skb_info *sinfo;
> +	u32 rx_pos, pkg_len;
> +	u32 num, rx_count;
> +	s32 queue;
> +	u32 mask;
> +	int port;
> +	u32 cmd;
> +
> +	spin_lock(&comm->rx_lock);

What purpose does this lock serve?

> +	/* Process high-priority queue and then low-priority queue. */
> +	for (queue = 0; queue < RX_DESC_QUEUE_NUM; queue++) {
> +		rx_pos = comm->rx_pos[queue];
> +		rx_count = comm->rx_desc_num[queue];
> +
> +		for (num = 0; num < rx_count; num++) {
> +			sinfo = comm->rx_skb_info[queue] + rx_pos;
> +			desc = comm->rx_desc[queue] + rx_pos;
> +			cmd = desc->cmd1;
> +
> +			if (cmd & RXD_OWN)
> +				break;
> +
> +			port = FIELD_GET(RXD_PKT_SP, cmd);
> +			if (port < MAX_NETDEV_NUM && comm->ndev[port])
> +				stats = &comm->ndev[port]->stats;
> +			else
> +				goto spl2sw_rx_poll_rec_err;
> +
> +			pkg_len = FIELD_GET(RXD_PKT_LEN, cmd);
> +			if (unlikely((cmd & RXD_ERR_CODE) || pkg_len < ETH_ZLEN + 4)) {
> +				stats->rx_length_errors++;
> +				stats->rx_dropped++;
> +				goto spl2sw_rx_poll_rec_err;
> +			}
> +
> +			if (unlikely(cmd & RXD_IP_CHKSUM)) {

IP chksum as in bad IP header csum? Let that thru, kernel will drop
it. We don't trust HW to parse above L2 and get checksums right.

> +				stats->rx_crc_errors++;
> +				stats->rx_dropped++;
> +				goto spl2sw_rx_poll_rec_err;
> +			}
> +
> +			dma_unmap_single(&comm->pdev->dev, sinfo->mapping,
> +					 comm->rx_desc_buff_size, DMA_FROM_DEVICE);
> +
> +			skb = sinfo->skb;
> +			skb_put(skb, pkg_len - 4); /* Minus FCS */
> +			skb->ip_summed = CHECKSUM_NONE;
> +			skb->protocol = eth_type_trans(skb, comm->ndev[port]);
> +			netif_receive_skb(skb);
> +
> +			stats->rx_packets++;
> +			stats->rx_bytes += skb->len;
> +
> +			/* Allocate a new skb for receiving. */
> +			new_skb = netdev_alloc_skb(NULL, comm->rx_desc_buff_size);
> +			if (unlikely(!new_skb)) {
> +				desc->cmd2 = (rx_pos == comm->rx_desc_num[queue] - 1) ?
> +					     RXD_EOR : 0;
> +				sinfo->skb = NULL;
> +				sinfo->mapping = 0;
> +				goto spl2sw_rx_poll_alloc_err;

How does this work? The device will handle the empty entry somehow?

> +			}
> +
> +			sinfo->mapping = dma_map_single(&comm->pdev->dev, new_skb->data,
> +							comm->rx_desc_buff_size,
> +							DMA_FROM_DEVICE);
> +			if (dma_mapping_error(&comm->pdev->dev, sinfo->mapping)) {
> +				dev_kfree_skb_irq(new_skb);
> +				desc->cmd2 = (rx_pos == comm->rx_desc_num[queue] - 1) ?
> +					     RXD_EOR : 0;
> +				sinfo->skb = NULL;
> +				goto spl2sw_rx_poll_alloc_err;
> +			}
> +
> +			sinfo->skb = new_skb;
> +			desc->addr1 = sinfo->mapping;
> +
> +spl2sw_rx_poll_rec_err:
> +			desc->cmd2 = (rx_pos == comm->rx_desc_num[queue] - 1) ?
> +				     RXD_EOR | comm->rx_desc_buff_size :
> +				     comm->rx_desc_buff_size;
> +
> +spl2sw_rx_poll_alloc_err:
> +			wmb();	/* Set RXD_OWN after other fields are effective. */
> +			desc->cmd1 = RXD_OWN;
> +
> +			/* Move rx_pos to next position */
> +			rx_pos = ((rx_pos + 1) == comm->rx_desc_num[queue]) ? 0 : rx_pos + 1;
> +
> +			/* If there are packets in high-priority queue,
> +			 * stop processing low-priority queue.
> +			 */
> +			if (queue == 1 && !(h_desc->cmd1 & RXD_OWN))
> +				break;
> +		}
> +
> +		comm->rx_pos[queue] = rx_pos;
> +
> +		/* Save pointer to last rx descriptor of high-priority queue. */
> +		if (queue == 0)
> +			h_desc = comm->rx_desc[queue] + rx_pos;

Where do you take budget into account?

> +	}
> +
> +	spin_unlock(&comm->rx_lock);
> +
> +	wmb();	/* make sure settings are effective. */
> +	mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> +	mask &= ~MAC_INT_RX;
> +	writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> +
> +	napi_complete(napi);
> +	return 0;
> +}

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH net-next v8 2/2] net: ethernet: Add driver for Sunplus SP7021
  2022-04-14 12:18   ` Jakub Kicinski
@ 2022-04-14 13:36     ` Andrew Lunn
  2022-04-19 10:07       ` Wells Lu 呂芳騰
  2022-04-19  9:49     ` Wells Lu 呂芳騰
  1 sibling, 1 reply; 8+ messages in thread
From: Andrew Lunn @ 2022-04-14 13:36 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: Wells Lu, davem, robh+dt, netdev, devicetree, linux-kernel,
	p.zabel, pabeni, krzk+dt, roopa, edumazet, wells.lu

> > +		/* Get mac-address from nvmem. */
> > +		ret = spl2sw_nvmem_get_mac_address(&pdev->dev, port_np, mac_addr);
> > +		if (ret) {
> > +			dev_info(&pdev->dev, "Generate a random mac address!\n");
> > +
> > +			/* Generate a mac address using OUI of Sunplus Technology
> > +			 * and random controller number.
> > +			 */
> > +			mac_addr[0] = 0xfc; /* OUI of Sunplus: fc:4b:bc */
> > +			mac_addr[1] = 0x4b;
> > +			mac_addr[2] = 0xbc;
> > +			mac_addr[3] = get_random_int() % 256;
> > +			mac_addr[4] = get_random_int() % 256;
> > +			mac_addr[5] = get_random_int() % 256;
> 
> I don't think you can do that. Either you use your OUI and assign the
> address at manufacture or you must use a locally administered address.
> And if locally administered address is used it better be completely
> random to lower the probability of collision to absolute minimum.

I commented about that in an earlier version of these patches. We
probably need a quote from the 802.1 or 802.3 which says this is O.K.

	 Andrew

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: [PATCH net-next v8 2/2] net: ethernet: Add driver for Sunplus SP7021
  2022-04-14 12:18   ` Jakub Kicinski
  2022-04-14 13:36     ` Andrew Lunn
@ 2022-04-19  9:49     ` Wells Lu 呂芳騰
  1 sibling, 0 replies; 8+ messages in thread
From: Wells Lu 呂芳騰 @ 2022-04-19  9:49 UTC (permalink / raw)
  To: Jakub Kicinski, Wells Lu
  Cc: davem, robh+dt, netdev, devicetree, linux-kernel, p.zabel,
	pabeni, krzk+dt, roopa, andrew, edumazet

> On Wed, 13 Apr 2022 10:31:58 +0800 Wells Lu wrote:
> > Add driver for Sunplus SP7021 SoC.
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > Signed-off-by: Wells Lu <wellslutw@gmail.com>
> > ---
> > Changes in v8
> >   - Fixed "WARNING: unmet direct dependencies detected for PINCTRL_SPPCTL".
> >     Removed 'select PINCTRL_SPPCTL' in Kconfig.
> >     Selecting PINCTRL_SPPCTL is not actually a must.
> >
> >  MAINTAINERS                                    |   1 +
> >  drivers/net/ethernet/Kconfig                   |   1 +
> >  drivers/net/ethernet/Makefile                  |   1 +
> >  drivers/net/ethernet/sunplus/Kconfig           |  35 ++
> >  drivers/net/ethernet/sunplus/Makefile          |   6 +
> >  drivers/net/ethernet/sunplus/spl2sw_define.h   | 271 +++++++++++
> >  drivers/net/ethernet/sunplus/spl2sw_desc.c     | 226 +++++++++
> >  drivers/net/ethernet/sunplus/spl2sw_desc.h     |  19 +
> >  drivers/net/ethernet/sunplus/spl2sw_driver.c   | 604 +++++++++++++++++++++++++
> >  drivers/net/ethernet/sunplus/spl2sw_driver.h   |  12 +
> >  drivers/net/ethernet/sunplus/spl2sw_int.c      | 253 +++++++++++
> >  drivers/net/ethernet/sunplus/spl2sw_int.h      |  13 +
> >  drivers/net/ethernet/sunplus/spl2sw_mac.c      | 346 ++++++++++++++
> >  drivers/net/ethernet/sunplus/spl2sw_mac.h      |  19 +
> >  drivers/net/ethernet/sunplus/spl2sw_mdio.c     | 126 ++++++
> >  drivers/net/ethernet/sunplus/spl2sw_mdio.h     |  12 +
> >  drivers/net/ethernet/sunplus/spl2sw_phy.c      |  92 ++++
> >  drivers/net/ethernet/sunplus/spl2sw_phy.h      |  12 +
> >  drivers/net/ethernet/sunplus/spl2sw_register.h |  86 ++++
> >  19 files changed, 2135 insertions(+)
> >  create mode 100644 drivers/net/ethernet/sunplus/Kconfig
> >  create mode 100644 drivers/net/ethernet/sunplus/Makefile
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_define.h
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_desc.c
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_desc.h
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_driver.c
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_driver.h
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_int.c
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_int.h
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mac.c
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mac.h
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mdio.c
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_mdio.h
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_phy.c
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_phy.h
> >  create mode 100644 drivers/net/ethernet/sunplus/spl2sw_register.h
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1d54292..0269797 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18875,6 +18875,7 @@ L:  netdev@vger.kernel.org
> >  S: Maintained
> >  W: https://sunplus.atlassian.net/wiki/spaces/doc/overview
> >  F: Documentation/devicetree/bindings/net/sunplus,sp7021-emac.yaml
> > +F: drivers/net/ethernet/sunplus/
> >
> >  SUNPLUS OCOTP DRIVER
> >  M: Vincent Shih <vincent.sunplus@gmail.com>
> > diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
> > index bd4cb9d..8828539 100644
> > --- a/drivers/net/ethernet/Kconfig
> > +++ b/drivers/net/ethernet/Kconfig
> > @@ -179,6 +179,7 @@ source "drivers/net/ethernet/smsc/Kconfig"
> >  source "drivers/net/ethernet/socionext/Kconfig"
> >  source "drivers/net/ethernet/stmicro/Kconfig"
> >  source "drivers/net/ethernet/sun/Kconfig"
> > +source "drivers/net/ethernet/sunplus/Kconfig"
> >  source "drivers/net/ethernet/synopsys/Kconfig"
> >  source "drivers/net/ethernet/tehuti/Kconfig"
> >  source "drivers/net/ethernet/ti/Kconfig"
> > diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
> > index 8ef43e0..9eb0116 100644
> > --- a/drivers/net/ethernet/Makefile
> > +++ b/drivers/net/ethernet/Makefile
> > @@ -90,6 +90,7 @@ obj-$(CONFIG_NET_VENDOR_SMSC) += smsc/
> >  obj-$(CONFIG_NET_VENDOR_SOCIONEXT) += socionext/
> >  obj-$(CONFIG_NET_VENDOR_STMICRO) += stmicro/
> >  obj-$(CONFIG_NET_VENDOR_SUN) += sun/
> > +obj-$(CONFIG_NET_VENDOR_SUNPLUS) += sunplus/
> >  obj-$(CONFIG_NET_VENDOR_TEHUTI) += tehuti/
> >  obj-$(CONFIG_NET_VENDOR_TI) += ti/
> >  obj-$(CONFIG_NET_VENDOR_TOSHIBA) += toshiba/
> > diff --git a/drivers/net/ethernet/sunplus/Kconfig
> b/drivers/net/ethernet/sunplus/Kconfig
> > new file mode 100644
> > index 0000000..d0144a2
> > --- /dev/null
> > +++ b/drivers/net/ethernet/sunplus/Kconfig
> > @@ -0,0 +1,35 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +#
> > +# Sunplus network device configuration
> > +#
> > +
> > +config NET_VENDOR_SUNPLUS
> > +   bool "Sunplus devices"
> > +   default y
> > +   depends on ARCH_SUNPLUS || COMPILE_TEST
> > +   help
> > +     If you have a network (Ethernet) card belonging to this
> > +     class, say Y here.
> > +
> > +     Note that the answer to this question doesn't directly
> > +     affect the kernel: saying N will just cause the configurator
> > +     to skip all the questions about Sunplus cards. If you say Y,
> > +     you will be asked for your specific card in the following
> > +     questions.
> > +
> > +if NET_VENDOR_SUNPLUS
> > +
> > +config SP7021_EMAC
> > +   tristate "Sunplus Dual 10M/100M Ethernet devices"
> > +   depends on SOC_SP7021 || COMPILE_TEST
> > +   select PHYLIB
> > +   select COMMON_CLK_SP7021
> > +   select RESET_SUNPLUS
> > +   select NVMEM_SUNPLUS_OCOTP
> > +   help
> > +     If you have Sunplus dual 10M/100M Ethernet devices, say Y.
> > +     The network device creates two net-device interfaces.
> > +     To compile this driver as a module, choose M here. The
> > +     module will be called sp7021_emac.
> > +
> > +endif # NET_VENDOR_SUNPLUS
> > diff --git a/drivers/net/ethernet/sunplus/Makefile
> b/drivers/net/ethernet/sunplus/Makefile
> > new file mode 100644
> > index 0000000..ef7d7d0
> > --- /dev/null
> > +++ b/drivers/net/ethernet/sunplus/Makefile
> > @@ -0,0 +1,6 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +#
> > +# Makefile for the Sunplus network device drivers.
> > +#
> > +obj-$(CONFIG_SP7021_EMAC) += sp7021_emac.o
> > +sp7021_emac-objs := spl2sw_driver.o spl2sw_int.o spl2sw_desc.o spl2sw_mac.o
> spl2sw_mdio.o spl2sw_phy.o
> > diff --git a/drivers/net/ethernet/sunplus/spl2sw_define.h
> b/drivers/net/ethernet/sunplus/spl2sw_define.h
> > new file mode 100644
> > index 0000000..f299bda
> > --- /dev/null
> > +++ b/drivers/net/ethernet/sunplus/spl2sw_define.h
> > @@ -0,0 +1,271 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/* Copyright Sunplus Technology Co., Ltd.
> > + *       All rights reserved.
> > + */
> > +
> > +#ifndef __SPL2SW_DEFINE_H__
> > +#define __SPL2SW_DEFINE_H__
> > +
> > +#define MAX_NETDEV_NUM                     2       /* Maximum # of net-device */
> > +
> > +/* Interrupt status */
> > +#define MAC_INT_DAISY_MODE_CHG             BIT(31) /* Daisy Mode Change             */
> > +#define MAC_INT_IP_CHKSUM_ERR              BIT(23) /* IP Checksum Append Error      */
> > +#define MAC_INT_WDOG_TIMER1_EXP            BIT(22) /* Watchdog Timer1 Expired       */
> > +#define MAC_INT_WDOG_TIMER0_EXP            BIT(21) /* Watchdog Timer0 Expired       */
> > +#define MAC_INT_INTRUDER_ALERT             BIT(20) /* Atruder Alert                 */
> > +#define MAC_INT_PORT_ST_CHG                BIT(19) /* Port Status Change            */
> > +#define MAC_INT_BC_STORM           BIT(18) /* Broad Cast Storm              */
> > +#define MAC_INT_MUST_DROP_LAN              BIT(17) /* Global Queue Exhausted        */
> > +#define MAC_INT_GLOBAL_QUE_FULL            BIT(16) /* Global Queue Full             */
> > +#define MAC_INT_TX_SOC_PAUSE_ON            BIT(15) /* Soc Port TX Pause On          */
> > +#define MAC_INT_RX_SOC_QUE_FULL            BIT(14) /* Soc Port Out Queue Full       */
> > +#define MAC_INT_TX_LAN1_QUE_FULL   BIT(9)  /* Port 1 Out Queue Full         */
> > +#define MAC_INT_TX_LAN0_QUE_FULL   BIT(8)  /* Port 0 Out Queue Full         */
> > +#define MAC_INT_RX_L_DESCF         BIT(7)  /* Low Priority Descriptor Full  */
> > +#define MAC_INT_RX_H_DESCF         BIT(6)  /* High Priority Descriptor Full */
> > +#define MAC_INT_RX_DONE_L          BIT(5)  /* RX Low Priority Done          */
> > +#define MAC_INT_RX_DONE_H          BIT(4)  /* RX High Priority Done         */
> > +#define MAC_INT_TX_DONE_L          BIT(3)  /* TX Low Priority Done          */
> > +#define MAC_INT_TX_DONE_H          BIT(2)  /* TX High Priority Done         */
> > +#define MAC_INT_TX_DES_ERR         BIT(1)  /* TX Descriptor Error           */
> > +#define MAC_INT_RX_DES_ERR         BIT(0)  /* Rx Descriptor Error           */
> > +
> > +#define MAC_INT_RX                 (MAC_INT_RX_DONE_H | MAC_INT_RX_DONE_L | \
> > +                                   MAC_INT_RX_DES_ERR)
> > +#define MAC_INT_TX                 (MAC_INT_TX_DONE_L | MAC_INT_TX_DONE_H | \
> > +                                   MAC_INT_TX_DES_ERR)
> > +#define MAC_INT_MASK_DEF           (MAC_INT_DAISY_MODE_CHG | MAC_INT_IP_CHKSUM_ERR | \
> > +                                   MAC_INT_WDOG_TIMER1_EXP | MAC_INT_WDOG_TIMER0_EXP | \
> > +                                   MAC_INT_INTRUDER_ALERT | MAC_INT_PORT_ST_CHG | \
> > +                                   MAC_INT_BC_STORM | MAC_INT_MUST_DROP_LAN | \
> > +                                   MAC_INT_GLOBAL_QUE_FULL | MAC_INT_TX_SOC_PAUSE_ON | \
> > +                                   MAC_INT_RX_SOC_QUE_FULL | MAC_INT_TX_LAN1_QUE_FULL | \
> > +                                   MAC_INT_TX_LAN0_QUE_FULL | MAC_INT_RX_L_DESCF | \
> > +                                   MAC_INT_RX_H_DESCF)
> > +
> > +/* Address table search */
> > +#define MAC_ADDR_LOOKUP_IDLE               BIT(2)
> > +#define MAC_SEARCH_NEXT_ADDR               BIT(1)
> > +#define MAC_BEGIN_SEARCH_ADDR              BIT(0)
> > +
> > +/* Address table status */
> > +#define MAC_HASH_LOOKUP_ADDR               GENMASK(31, 22)
> > +#define MAC_R_PORT_MAP                     GENMASK(13, 12)
> > +#define MAC_R_CPU_PORT                     GENMASK(11, 10)
> > +#define MAC_R_VID                  GENMASK(9, 7)
> > +#define MAC_R_AGE                  GENMASK(6, 4)
> > +#define MAC_R_PROXY                        BIT(3)
> > +#define MAC_R_MC_INGRESS           BIT(2)
> > +#define MAC_AT_TABLE_END           BIT(1)
> > +#define MAC_AT_DATA_READY          BIT(0)
> > +
> > +/* Wt mac ad0 */
> > +#define MAC_W_PORT_MAP                     GENMASK(13, 12)
> > +#define MAC_W_LAN_PORT_1           BIT(13)
> > +#define MAC_W_LAN_PORT_0           BIT(12)
> > +#define MAC_W_CPU_PORT                     GENMASK(11, 10)
> > +#define MAC_W_CPU_PORT_1           BIT(11)
> > +#define MAC_W_CPU_PORT_0           BIT(10)
> > +#define MAC_W_VID                  GENMASK(9, 7)
> > +#define MAC_W_AGE                  GENMASK(6, 4)
> > +#define MAC_W_PROXY                        BIT(3)
> > +#define MAC_W_MC_INGRESS           BIT(2)
> > +#define MAC_W_MAC_DONE                     BIT(1)
> > +#define MAC_W_MAC_CMD                      BIT(0)
> > +
> > +/* W mac 15_0 bus */
> > +#define MAC_W_MAC_15_0                     GENMASK(15, 0)
> > +
> > +/* W mac 47_16 bus */
> > +#define MAC_W_MAC_47_16                    GENMASK(31, 0)
> > +
> > +/* PVID config 0 */
> > +#define MAC_P1_PVID                        GENMASK(6, 4)
> > +#define MAC_P0_PVID                        GENMASK(2, 0)
> > +
> > +/* VLAN member config 0 */
> > +#define MAC_VLAN_MEMSET_3          GENMASK(27, 24)
> > +#define MAC_VLAN_MEMSET_2          GENMASK(19, 16)
> > +#define MAC_VLAN_MEMSET_1          GENMASK(11, 8)
> > +#define MAC_VLAN_MEMSET_0          GENMASK(3, 0)
> > +
> > +/* VLAN member config 1 */
> > +#define MAC_VLAN_MEMSET_5          GENMASK(11, 8)
> > +#define MAC_VLAN_MEMSET_4          GENMASK(3, 0)
> > +
> > +/* Port ability */
> > +#define MAC_PORT_ABILITY_LINK_ST   GENMASK(25, 24)
> > +
> > +/* CPU control */
> > +#define MAC_EN_SOC1_AGING          BIT(15)
> > +#define MAC_EN_SOC0_AGING          BIT(14)
> > +#define MAC_DIS_LRN_SOC1           BIT(13)
> > +#define MAC_DIS_LRN_SOC0           BIT(12)
> > +#define MAC_EN_CRC_SOC1                    BIT(9)
> > +#define MAC_EN_CRC_SOC0                    BIT(8)
> > +#define MAC_DIS_SOC1_CPU           BIT(7)
> > +#define MAC_DIS_SOC0_CPU           BIT(6)
> > +#define MAC_DIS_BC2CPU_P1          BIT(5)
> > +#define MAC_DIS_BC2CPU_P0          BIT(4)
> > +#define MAC_DIS_MC2CPU                     GENMASK(3, 2)
> > +#define MAC_DIS_MC2CPU_P1          BIT(3)
> > +#define MAC_DIS_MC2CPU_P0          BIT(2)
> > +#define MAC_DIS_UN2CPU                     GENMASK(1, 0)
> > +
> > +/* Port control 0 */
> > +#define MAC_DIS_PORT                       GENMASK(25, 24)
> > +#define MAC_DIS_PORT1                      BIT(25)
> > +#define MAC_DIS_PORT0                      BIT(24)
> > +#define MAC_DIS_RMC2CPU_P1         BIT(17)
> > +#define MAC_DIS_RMC2CPU_P0         BIT(16)
> > +#define MAC_EN_FLOW_CTL_P1         BIT(9)
> > +#define MAC_EN_FLOW_CTL_P0         BIT(8)
> > +#define MAC_EN_BACK_PRESS_P1               BIT(1)
> > +#define MAC_EN_BACK_PRESS_P0               BIT(0)
> > +
> > +/* Port control 1 */
> > +#define MAC_DIS_SA_LRN_P1          BIT(9)
> > +#define MAC_DIS_SA_LRN_P0          BIT(8)
> > +
> > +/* Port control 2 */
> > +#define MAC_EN_AGING_P1                    BIT(9)
> > +#define MAC_EN_AGING_P0                    BIT(8)
> > +
> > +/* Switch Global control */
> > +#define MAC_RMC_TB_FAULT_RULE              GENMASK(26, 25)
> > +#define MAC_LED_FLASH_TIME         GENMASK(24, 23)
> > +#define MAC_BC_STORM_PREV          GENMASK(5, 4)
> > +
> > +/* LED port 0 */
> > +#define MAC_LED_ACT_HI                     BIT(28)
> > +
> > +/* PHY control register 0  */
> > +#define MAC_CPU_PHY_WT_DATA                GENMASK(31, 16)
> > +#define MAC_CPU_PHY_CMD                    GENMASK(14, 13)
> > +#define MAC_CPU_PHY_REG_ADDR               GENMASK(12, 8)
> > +#define MAC_CPU_PHY_ADDR           GENMASK(4, 0)
> > +
> > +/* PHY control register 1 */
> > +#define MAC_CPU_PHY_RD_DATA                GENMASK(31, 16)
> > +#define MAC_PHY_RD_RDY                     BIT(1)
> > +#define MAC_PHY_WT_DONE                    BIT(0)
> > +
> > +/* MAC force mode */
> > +#define MAC_EXT_PHY1_ADDR          GENMASK(28, 24)
> > +#define MAC_EXT_PHY0_ADDR          GENMASK(20, 16)
> > +#define MAC_FORCE_RMII_LINK                GENMASK(9, 8)
> > +#define MAC_FORCE_RMII_EN_1                BIT(7)
> > +#define MAC_FORCE_RMII_EN_0                BIT(6)
> > +#define MAC_FORCE_RMII_FC          GENMASK(5, 4)
> > +#define MAC_FORCE_RMII_DPX         GENMASK(3, 2)
> > +#define MAC_FORCE_RMII_SPD         GENMASK(1, 0)
> > +
> > +/* CPU transmit trigger */
> > +#define MAC_TRIG_L_SOC0                    BIT(1)
> > +#define MAC_TRIG_H_SOC0                    BIT(0)
> > +
> > +/* Config descriptor queue */
> > +#define TX_DESC_NUM                        16      /* # of descriptors in TX queue   */
> > +#define MAC_GUARD_DESC_NUM         2       /* # of descriptors of gap      0 */
> > +#define RX_QUEUE0_DESC_NUM         16      /* # of descriptors in RX queue 0 */
> > +#define RX_QUEUE1_DESC_NUM         16      /* # of descriptors in RX queue 1 */
> > +#define TX_DESC_QUEUE_NUM          1       /* # of TX queue                  */
> > +#define RX_DESC_QUEUE_NUM          2       /* # of RX queue                  */
> > +
> > +#define MAC_RX_LEN_MAX                     2047    /* Size of RX buffer       */
> > +
> > +/* Tx descriptor */
> > +/* cmd1 */
> > +#define TXD_OWN                            BIT(31)
> > +#define TXD_ERR_CODE                       GENMASK(29, 26)
> > +#define TXD_SOP                            BIT(25)         /* start of a packet */
> > +#define TXD_EOP                            BIT(24)         /* end of a packet */
> > +#define TXD_VLAN                   GENMASK(17, 12)
> > +#define TXD_PKT_LEN                        GENMASK(10, 0)  /* packet length */
> > +/* cmd2 */
> > +#define TXD_EOR                            BIT(31)         /* end of ring */
> > +#define TXD_BUF_LEN2                       GENMASK(22, 12)
> > +#define TXD_BUF_LEN1                       GENMASK(10, 0)
> > +
> > +/* Rx descriptor */
> > +/* cmd1 */
> > +#define RXD_OWN                            BIT(31)
> > +#define RXD_ERR_CODE                       GENMASK(29, 26)
> > +#define RXD_TCP_UDP_CHKSUM         BIT(23)
> > +#define RXD_PROXY                  BIT(22)
> > +#define RXD_PROTOCOL                       GENMASK(21, 20)
> > +#define RXD_VLAN_TAG                       BIT(19)
> > +#define RXD_IP_CHKSUM                      BIT(18)
> > +#define RXD_ROUTE_TYPE                     GENMASK(17, 16)
> > +#define RXD_PKT_SP                 GENMASK(14, 12) /* packet source port */
> > +#define RXD_PKT_LEN                        GENMASK(10, 0)  /* packet length */
> > +/* cmd2 */
> > +#define RXD_EOR                            BIT(31)         /* end of ring */
> > +#define RXD_BUF_LEN2                       GENMASK(22, 12)
> > +#define RXD_BUF_LEN1                       GENMASK(10, 0)
> > +
> > +/* structure of descriptor */
> > +struct spl2sw_mac_desc {
> > +   u32 cmd1;
> > +   u32 cmd2;
> > +   u32 addr1;
> > +   u32 addr2;
> > +};
> > +
> > +struct spl2sw_skb_info {
> > +   struct sk_buff *skb;
> > +   u32 mapping;
> > +   u32 len;
> > +};
> > +
> > +struct spl2sw_common {
> > +   void __iomem *l2sw_reg_base;
> > +
> > +   struct platform_device *pdev;
> > +   struct reset_control *rstc;
> > +   struct clk *clk;
> > +   int irq;
> > +
> > +   void *desc_base;
> > +   dma_addr_t desc_dma;
> > +   s32 desc_size;
> > +   struct spl2sw_mac_desc *rx_desc[RX_DESC_QUEUE_NUM];
> > +   struct spl2sw_skb_info *rx_skb_info[RX_DESC_QUEUE_NUM];
> > +   u32 rx_pos[RX_DESC_QUEUE_NUM];
> > +   u32 rx_desc_num[RX_DESC_QUEUE_NUM];
> > +   u32 rx_desc_buff_size;
> > +
> > +   struct spl2sw_mac_desc *tx_desc;
> > +   struct spl2sw_skb_info tx_temp_skb_info[TX_DESC_NUM];
> > +   u32 tx_done_pos;
> > +   u32 tx_pos;
> > +   u32 tx_desc_full;
> > +
> > +   struct net_device *ndev[MAX_NETDEV_NUM];
> > +   struct mii_bus *mii_bus;
> > +
> > +   struct napi_struct rx_napi;
> > +   struct napi_struct tx_napi;
> > +
> > +   spinlock_t rx_lock;     /* spinlock for accessing rx buffer */
> > +   spinlock_t tx_lock;     /* spinlock for accessing tx buffer */
> > +   spinlock_t mdio_lock;   /* spinlock for mdio commands */
> > +
> > +   u8 enable;
> > +};
> > +
> > +struct spl2sw_mac {
> > +   struct net_device *ndev;
> > +   struct spl2sw_common *comm;
> > +
> > +   u8 mac_addr[ETH_ALEN];
> > +   phy_interface_t phy_mode;
> > +   struct device_node *phy_node;
> > +
> > +   u8 lan_port;
> > +   u8 to_vlan;
> > +   u8 vlan_id;
> > +};
> > +
> > +#endif
> > diff --git a/drivers/net/ethernet/sunplus/spl2sw_desc.c
> b/drivers/net/ethernet/sunplus/spl2sw_desc.c
> > new file mode 100644
> > index 0000000..7d237d4
> > --- /dev/null
> > +++ b/drivers/net/ethernet/sunplus/spl2sw_desc.c
> > @@ -0,0 +1,226 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Copyright Sunplus Technology Co., Ltd.
> > + *       All rights reserved.
> > + */
> > +
> > +#include <linux/platform_device.h>
> > +#include <linux/netdevice.h>
> > +#include <linux/of_mdio.h>
> > +
> > +#include "spl2sw_define.h"
> > +#include "spl2sw_desc.h"
> > +
> > +void spl2sw_rx_descs_flush(struct spl2sw_common *comm)
> > +{
> > +   struct spl2sw_skb_info *rx_skbinfo;
> > +   struct spl2sw_mac_desc *rx_desc;
> > +   u32 i, j;
> > +
> > +   for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
> > +           rx_desc = comm->rx_desc[i];
> > +           rx_skbinfo = comm->rx_skb_info[i];
> > +           for (j = 0; j < comm->rx_desc_num[i]; j++) {
> > +                   rx_desc[j].addr1 = rx_skbinfo[j].mapping;
> > +                   rx_desc[j].cmd2 = (j == comm->rx_desc_num[i] - 1) ?
> > +                                     RXD_EOR | comm->rx_desc_buff_size :
> > +                                     comm->rx_desc_buff_size;
> > +                   wmb();  /* Set RXD_OWN after other fields are ready. */
> > +                   rx_desc[j].cmd1 = RXD_OWN;
> > +           }
> > +   }
> > +}
> > +
> > +void spl2sw_tx_descs_clean(struct spl2sw_common *comm)
> > +{
> > +   u32 i;
> > +
> > +   if (!comm->tx_desc)
> > +           return;
> > +
> > +   for (i = 0; i < TX_DESC_NUM; i++) {
> > +           comm->tx_desc[i].cmd1 = 0;
> > +           wmb();  /* Clear TXD_OWN and then set other fields. */
> > +           comm->tx_desc[i].cmd2 = 0;
> > +           comm->tx_desc[i].addr1 = 0;
> > +           comm->tx_desc[i].addr2 = 0;
> > +
> > +           if (comm->tx_temp_skb_info[i].mapping) {
> > +                   dma_unmap_single(&comm->pdev->dev, comm->tx_temp_skb_info[i].mapping,
> > +                                    comm->tx_temp_skb_info[i].skb->len, DMA_TO_DEVICE);
> > +                   comm->tx_temp_skb_info[i].mapping = 0;
> > +           }
> > +
> > +           if (comm->tx_temp_skb_info[i].skb) {
> > +                   dev_kfree_skb_any(comm->tx_temp_skb_info[i].skb);
> > +                   comm->tx_temp_skb_info[i].skb = NULL;
> > +           }
> > +   }
> > +}
> > +
> > +void spl2sw_rx_descs_clean(struct spl2sw_common *comm)
> > +{
> > +   struct spl2sw_skb_info *rx_skbinfo;
> > +   struct spl2sw_mac_desc *rx_desc;
> > +   u32 i, j;
> > +
> > +   for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
> > +           if (!comm->rx_skb_info[i])
> > +                   continue;
> > +
> > +           rx_desc = comm->rx_desc[i];
> > +           rx_skbinfo = comm->rx_skb_info[i];
> > +           for (j = 0; j < comm->rx_desc_num[i]; j++) {
> > +                   rx_desc[j].cmd1 = 0;
> > +                   wmb();  /* Clear RXD_OWN and then set other fields. */
> > +                   rx_desc[j].cmd2 = 0;
> > +                   rx_desc[j].addr1 = 0;
> > +
> > +                   if (rx_skbinfo[j].skb) {
> > +                           dma_unmap_single(&comm->pdev->dev, rx_skbinfo[j].mapping,
> > +                                            comm->rx_desc_buff_size, DMA_FROM_DEVICE);
> > +                           dev_kfree_skb_any(rx_skbinfo[j].skb);
> > +                           rx_skbinfo[j].skb = NULL;
> > +                           rx_skbinfo[j].mapping = 0;
> > +                   }
> > +           }
> > +
> > +           kfree(rx_skbinfo);
> > +           comm->rx_skb_info[i] = NULL;
> > +   }
> > +}
> > +
> > +void spl2sw_descs_clean(struct spl2sw_common *comm)
> > +{
> > +   spl2sw_rx_descs_clean(comm);
> > +   spl2sw_tx_descs_clean(comm);
> > +}
> > +
> > +void spl2sw_descs_free(struct spl2sw_common *comm)
> > +{
> > +   u32 i;
> > +
> > +   spl2sw_descs_clean(comm);
> > +   comm->tx_desc = NULL;
> > +   for (i = 0; i < RX_DESC_QUEUE_NUM; i++)
> > +           comm->rx_desc[i] = NULL;
> > +
> > +   /*  Free descriptor area  */
> > +   if (comm->desc_base) {
> > +           dma_free_coherent(&comm->pdev->dev, comm->desc_size, comm->desc_base,
> > +                             comm->desc_dma);
> > +           comm->desc_base = NULL;
> > +           comm->desc_dma = 0;
> > +           comm->desc_size = 0;
> > +   }
> > +}
> > +
> > +void spl2sw_tx_descs_init(struct spl2sw_common *comm)
> > +{
> > +   memset(comm->tx_desc, '\0', sizeof(struct spl2sw_mac_desc) *
> > +          (TX_DESC_NUM + MAC_GUARD_DESC_NUM));
> > +}
> > +
> > +int spl2sw_rx_descs_init(struct spl2sw_common *comm)
> > +{
> > +   struct spl2sw_skb_info *rx_skbinfo;
> > +   struct spl2sw_mac_desc *rx_desc;
> > +   struct sk_buff *skb;
> > +   u32 i, j;
> > +
> > +   for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
> > +           comm->rx_skb_info[i] = kcalloc(comm->rx_desc_num[i], sizeof(*rx_skbinfo),
> > +                                          GFP_KERNEL | GFP_DMA);
> > +           if (!comm->rx_skb_info[i])
> > +                   goto mem_alloc_fail;
> > +
> > +           rx_skbinfo = comm->rx_skb_info[i];
> > +           rx_desc = comm->rx_desc[i];
> > +           for (j = 0; j < comm->rx_desc_num[i]; j++) {
> > +                   skb = netdev_alloc_skb(NULL, comm->rx_desc_buff_size);
> > +                   if (!skb)
> > +                           goto mem_alloc_fail;
> > +
> > +                   rx_skbinfo[j].skb = skb;
> > +                   rx_skbinfo[j].mapping = dma_map_single(&comm->pdev->dev, skb->data,
> > +                                                          comm->rx_desc_buff_size,
> > +                                                          DMA_FROM_DEVICE);
> > +                   if (dma_mapping_error(&comm->pdev->dev, rx_skbinfo[j].mapping))
> > +                           goto mem_alloc_fail;
>
> Can you call spl2sw_rx_descs_clean() here without clearing the skb?
> It will try to unmap the error mapping.

No, it is wrong.
I will modify the statements as shown below:

        u32 mapping;
                :
                :
        rx_skbinfo[j].skb = skb;
        mapping = dma_map_single(&comm->pdev->dev, skb->data,
                                 comm->rx_desc_buff_size,
                                 DMA_FROM_DEVICE);
        if (dma_mapping_error(&comm->pdev->dev, mapping))
                goto mem_alloc_fail;

        rx_skbinfo[j].mapping = mapping;
        rx_desc[j].addr1 = mapping;
        rx_desc[j].addr2 = 0;
                :


>
> > +                   rx_desc[j].addr1 = rx_skbinfo[j].mapping;
> > +                   rx_desc[j].addr2 = 0;
> > +                   rx_desc[j].cmd2 = (j == comm->rx_desc_num[i] - 1) ?
> > +                                     RXD_EOR | comm->rx_desc_buff_size :
> > +                                     comm->rx_desc_buff_size;
> > +                   wmb();  /* Set RXD_OWN after other fields are effective. */
> > +                   rx_desc[j].cmd1 = RXD_OWN;
> > +           }
> > +   }
> > +
> > +   return 0;
> > +
> > +mem_alloc_fail:
> > +   spl2sw_rx_descs_clean(comm);
> > +   return -ENOMEM;
> > +}
>
> > +int spl2sw_descs_init(struct spl2sw_common *comm)
> > +{
> > +   u32 i, ret;
> > +
> > +   /* Initialize rx descriptor's data */
> > +   comm->rx_desc_num[0] = RX_QUEUE0_DESC_NUM;
> > +   comm->rx_desc_num[1] = RX_QUEUE1_DESC_NUM;
> > +
> > +   for (i = 0; i < RX_DESC_QUEUE_NUM; i++) {
> > +           comm->rx_desc[i] = NULL;
> > +           comm->rx_skb_info[i] = NULL;
> > +           comm->rx_pos[i] = 0;
> > +   }
> > +   comm->rx_desc_buff_size = MAC_RX_LEN_MAX;
> > +
> > +   /* Initialize tx descriptor's data */
> > +   comm->tx_done_pos = 0;
> > +   comm->tx_desc = NULL;
> > +   comm->tx_pos = 0;
> > +   comm->tx_desc_full = 0;
> > +   for (i = 0; i < TX_DESC_NUM; i++)
> > +           comm->tx_temp_skb_info[i].skb = NULL;
> > +
> > +   /* Allocate tx & rx descriptors. */
> > +   ret = spl2sw_descs_alloc(comm);
> > +   if (ret)
> > +           return ret;
> > +
> > +   spl2sw_tx_descs_init(comm);
> > +
> > +   return spl2sw_rx_descs_init(comm);
>
> Don't you have to free whatever spl2sw_descs_alloc() allocated, here?

No, function spl2sw_descs_init() is only called once in spl2sw_probe() function.
No descriptors have been allocated.


>
> > +}
>
> > +static int spl2sw_ethernet_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> > +{
> > +   struct spl2sw_mac *mac = netdev_priv(ndev);
> > +   struct spl2sw_common *comm = mac->comm;
> > +   struct spl2sw_skb_info *skbinfo;
> > +   struct spl2sw_mac_desc *txdesc;
> > +   unsigned long flags;
> > +   u32 tx_pos;
> > +   u32 cmd1;
> > +   u32 cmd2;
> > +
> > +   if (unlikely(comm->tx_desc_full == 1)) {
> > +           /* No TX descriptors left. Wait for tx interrupt. */
> > +           netdev_dbg(ndev, "TX descriptor queue full when xmit!\n");
> > +           return NETDEV_TX_BUSY;
> > +   }
> > +
> > +   /* If skb size is shorter than ETH_ZLEN (60), pad it with 0. */
> > +   if (unlikely(skb->len < ETH_ZLEN)) {
> > +           if (skb_tailroom(skb) >= (ETH_ZLEN - skb->len)) {
> > +                   memset(skb_put(skb, ETH_ZLEN - skb->len), '\0',
> > +                          ETH_ZLEN - skb->len);
> > +           } else {
> > +                   struct sk_buff *old_skb = skb;
> > +
> > +                   skb = netdev_alloc_skb(ndev, ETH_ZLEN);
> > +                   if (skb) {
> > +                           memset(skb->data + old_skb->len, '\0',
> > +                                  ETH_ZLEN - old_skb->len);
> > +                           memcpy(skb->data, old_skb->data, old_skb->len);
> > +                           skb_put(skb, ETH_ZLEN);
> > +                           dev_kfree_skb(old_skb);
> > +                   } else {
> > +                           skb = old_skb;
> > +                   }
> > +           }
> > +   }
>
> skb_padto()

I'll replace the whole "if (unlikely(skb->len < ETH_ZLEN)) { ...} " statement above with:

        if (unlikely(skb->len < ETH_ZLEN) {
                if (skb_padto(skb, ETH_ZLEN))
                        return NETDEV_TX_OK;
                skb_put(skb, ETH_ZLEN - skb->len);
        }


>
> > +   spin_lock_irqsave(&comm->tx_lock, flags);
> > +   tx_pos = comm->tx_pos;
> > +   txdesc = &comm->tx_desc[tx_pos];
> > +   skbinfo = &comm->tx_temp_skb_info[tx_pos];
> > +   skbinfo->len = skb->len;
> > +   skbinfo->skb = skb;
> > +   skbinfo->mapping = dma_map_single(&comm->pdev->dev, skb->data,
> > +                                     skb->len, DMA_TO_DEVICE);
> > +   if (dma_mapping_error(&comm->pdev->dev, skbinfo->mapping)) {
> > +           ndev->stats.tx_errors++;
> > +           dev_kfree_skb(skb);
> > +           skbinfo->mapping = 0;
> > +           skbinfo->len = 0;
> > +           skbinfo->skb = NULL;
>
> Don't init these before dma_map_single() so you won't have to clear
> them on failure.

I'll re-write above code as shown below:

        u32 mapping
                :
                :
        spin_lock_irqsave(&comm->tx_lock, flags);
        mapping = dma_map_single(&comm->pdev->dev, skb->data,
                                 skb->len, DMA_TO_DEVICE);
        if (dma_mapping_error(&comm->pdev->dev, mapping)) {
                ndev->stats.tx_errors++;
                dev_kfree_skb(skb);
                goto xmit_drop;
        }
        tx_pos = comm->tx_pos;
        txdesc = &comm->tx_desc[tx_pos];
        skbinfo = &comm->tx_temp_skb_info[tx_pos];
        skbinfo->len = skb->len;
        skbinfo->skb = skb;


>
> > +           goto xmit_drop;
> > +   }
> > +
> > +   /* Set up a TX descriptor */
> > +   cmd1 = TXD_OWN | TXD_SOP | TXD_EOP | (mac->to_vlan << 12) |
> > +          (skb->len & TXD_PKT_LEN);
> > +   cmd2 = skb->len & TXD_BUF_LEN1;
> > +
> > +   if (tx_pos == (TX_DESC_NUM - 1))
> > +           cmd2 |= TXD_EOR;
> > +
> > +   txdesc->addr1 = skbinfo->mapping;
> > +   txdesc->cmd2 = cmd2;
> > +   wmb();  /* Set TXD_OWN after other fields are effective. */
> > +   txdesc->cmd1 = cmd1;
> > +
> > +   /* Move tx_pos to next position */
> > +   tx_pos = ((tx_pos + 1) == TX_DESC_NUM) ? 0 : tx_pos + 1;
> > +
> > +   if (unlikely(tx_pos == comm->tx_done_pos)) {
> > +           netif_stop_queue(ndev);
> > +           comm->tx_desc_full = 1;
>
> Why do you maintain this tx_desc_full variable? You could compare pos
> to done_pos instead, no?

No, tx descriptors buffer is a ring buffer.
tx_done_pos == tx_pos means buffer full or empty.
We need tx_desc_full to record full status.


>
> > +   }
> > +   comm->tx_pos = tx_pos;
> > +   wmb();          /* make sure settings are effective. */
> > +
> > +   /* trigger gmac to transmit */
> > +   writel(MAC_TRIG_L_SOC0, comm->l2sw_reg_base + L2SW_CPU_TX_TRIG);
> > +
> > +xmit_drop:
> > +   spin_unlock_irqrestore(&comm->tx_lock, flags);
> > +   return NETDEV_TX_OK;
> > +}
>
> > +static int spl2sw_probe(struct platform_device *pdev)
> > +{
> > +   struct device_node *eth_ports_np;
> > +   struct device_node *port_np;
> > +   struct spl2sw_common *comm;
> > +   struct device_node *phy_np;
> > +   phy_interface_t phy_mode;
> > +   struct net_device *ndev;
> > +   u8 mac_addr[ETH_ALEN];
> > +   struct spl2sw_mac *mac;
> > +   int irq, i;
> > +   int ret;
> > +
> > +   if (platform_get_drvdata(pdev))
> > +           return -ENODEV;
> > +
> > +   /* Allocate memory for 'spl2sw_common' area. */
> > +   comm = devm_kzalloc(&pdev->dev, sizeof(*comm), GFP_KERNEL);
> > +   if (!comm)
> > +           return -ENOMEM;
> > +   comm->pdev = pdev;
> > +
> > +   spin_lock_init(&comm->rx_lock);
> > +   spin_lock_init(&comm->tx_lock);
> > +   spin_lock_init(&comm->mdio_lock);
> > +
> > +   /* Get memory resource 0 from dts. */
> > +   comm->l2sw_reg_base = devm_platform_ioremap_resource(pdev, 0);
> > +   if (IS_ERR(comm->l2sw_reg_base))
> > +           return PTR_ERR(comm->l2sw_reg_base);
> > +
> > +   /* Get irq resource from dts. */
> > +   ret = platform_get_irq(pdev, 0);
> > +   if (ret < 0)
> > +           return ret;
> > +   irq = ret;
> > +
> > +   /* Get clock controller. */
> > +   comm->clk = devm_clk_get(&pdev->dev, NULL);
> > +   if (IS_ERR(comm->clk)) {
> > +           dev_err_probe(&pdev->dev, PTR_ERR(comm->clk),
> > +                         "Failed to retrieve clock controller!\n");
> > +           return PTR_ERR(comm->clk);
> > +   }
> > +
> > +   /* Get reset controller. */
> > +   comm->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> > +   if (IS_ERR(comm->rstc)) {
> > +           dev_err_probe(&pdev->dev, PTR_ERR(comm->rstc),
> > +                         "Failed to retrieve reset controller!\n");
> > +           return PTR_ERR(comm->rstc);
> > +   }
> > +
> > +   /* Enable clock. */
> > +   clk_prepare_enable(comm->clk);
>
> This can fail.

I'll add error-handling code as shown below:

        ret = clk_prepare_enable(comm->clk);
        if (ret)
                return ret;


>
> > +   udelay(1);
> > +
> > +   reset_control_assert(comm->rstc);
> > +   udelay(1);
> > +   reset_control_deassert(comm->rstc);
> > +   udelay(1);
> > +
> > +   /* Get child node ethernet-ports. */
> > +   eth_ports_np = of_get_child_by_name(pdev->dev.of_node, "ethernet-ports");
> > +   if (!eth_ports_np) {
> > +           dev_err(&pdev->dev, "No ethernet-ports child node found!\n");
> > +           ret = -ENODEV;
> > +           goto out_clk_disable;
> > +   }
> > +
> > +   for (i = 0; i < MAX_NETDEV_NUM; i++) {
> > +           /* Get port@i of node ethernet-ports. */
> > +           port_np = spl2sw_get_eth_child_node(eth_ports_np, i);
> > +           if (!port_np)
> > +                   continue;
> > +
> > +           /* Get phy-mode. */
> > +           if (of_get_phy_mode(port_np, &phy_mode)) {
> > +                   dev_err(&pdev->dev, "Failed to get phy-mode property of port@%d!\n",
> > +                           i);
> > +                   continue;
> > +           }
> > +
> > +           /* Get phy-handle. */
> > +           phy_np = of_parse_phandle(port_np, "phy-handle", 0);
> > +           if (!phy_np) {
> > +                   dev_err(&pdev->dev, "Failed to get phy-handle property of port@%d!\n",
> > +                           i);
> > +                   continue;
> > +           }
> > +
> > +           /* Get mac-address from nvmem. */
> > +           ret = spl2sw_nvmem_get_mac_address(&pdev->dev, port_np, mac_addr);
> > +           if (ret) {
> > +                   dev_info(&pdev->dev, "Generate a random mac address!\n");
> > +
> > +                   /* Generate a mac address using OUI of Sunplus Technology
> > +                    * and random controller number.
> > +                    */
> > +                   mac_addr[0] = 0xfc; /* OUI of Sunplus: fc:4b:bc */
> > +                   mac_addr[1] = 0x4b;
> > +                   mac_addr[2] = 0xbc;
> > +                   mac_addr[3] = get_random_int() % 256;
> > +                   mac_addr[4] = get_random_int() % 256;
> > +                   mac_addr[5] = get_random_int() % 256;
>
> I don't think you can do that. Either you use your OUI and assign the
> address at manufacture or you must use a locally administered address.
> And if locally administered address is used it better be completely
> random to lower the probability of collision to absolute minimum.

I'll replace above statements with:

        eth_random_addr(mac_addr);

It generates locally administered address.


>
> > +           }
> > +
> > +           /* Initialize the net device. */
> > +           ret = spl2sw_init_netdev(pdev, mac_addr, &ndev);
> > +           if (ret)
> > +                   goto out_unregister_dev;
> > +
> > +           ndev->irq = irq;
> > +           comm->ndev[i] = ndev;
> > +           mac = netdev_priv(ndev);
> > +           mac->phy_node = phy_np;
> > +           mac->phy_mode = phy_mode;
> > +           mac->comm = comm;
> > +
> > +           mac->lan_port = 0x1 << i;       /* forward to port i */
> > +           mac->to_vlan = 0x1 << i;        /* vlan group: i     */
> > +           mac->vlan_id = i;               /* vlan group: i     */
> > +
> > +           /* Set MAC address */
> > +           ret = spl2sw_mac_addr_add(mac);
> > +           if (ret)
> > +                   goto out_unregister_dev;
> > +
> > +           spl2sw_mac_rx_mode_set(mac);
> > +   }
>
> > +   /* Request irq. */
> > +   ret = devm_request_irq(&pdev->dev, irq, spl2sw_ethernet_interrupt,
> > +                          0, ndev->name, ndev);
>
> Why use a netdev pointer as priv for a common IRQ?

I'll modify code to pass 'comm' to private data of devm_request_irq() as shown below:

        ret = devm_request_irq(&pdev->dev, irq, spl2sw_ethernet_interrupt, 0,
                               "spl2sw_emac", comm);


>
> > +   if (ret) {
> > +           netdev_err(ndev, "Failed to request irq #%d for \"%s\"!\n",
> > +                      irq, ndev->name);
> > +           goto out_unregister_dev;
> > +   }
> > +
> > +   /* Initialize mdio bus */
> > +   ret = spl2sw_mdio_init(comm);
> > +   if (ret) {
> > +           netdev_err(ndev, "Failed to initialize mdio bus!\n");
> > +           goto out_unregister_dev;
> > +   }
> > +
> > +   ret = spl2sw_mac_addr_del_all(comm);
> > +   if (ret)
> > +           goto out_free_mdio;
> > +
> > +   ret = spl2sw_descs_init(comm);
> > +   if (ret) {
> > +           dev_err(&comm->pdev->dev, "Fail to initialize mac descriptors!\n");
> > +           spl2sw_descs_free(comm);
> > +           goto out_free_mdio;
> > +   }
> > +
> > +   spl2sw_mac_init(comm);
> > +
> > +   ret = spl2sw_phy_connect(comm);
> > +   if (ret) {
> > +           netdev_err(ndev, "Failed to connect phy!\n");
> > +           goto out_free_mdio;
> > +   }
>
> You do all this init after registering the netdev. What prevent the
> user space from opening the device and trying to use it before the
> probe finished? Seems ripe for crashes. Registering netdevs should
> be done very late during probe().

I'll move "registering net devices" to late spl2sw_probe() as shown below:

        /* Request irq. */
        ret = devm_request_irq(&pdev->dev, irq, spl2sw_ethernet_interrupt, 0,
                                                                dev_name(&pdev->dev), comm);
        if (ret) {
                dev_err(&pdev->dev, "Failed to request irq #%d!\n", irq);
                goto out_clk_disable;
        }

        /* Initialize TX and RX descriptors. */
        ret = spl2sw_descs_init(comm);
        if (ret) {
                dev_err(&pdev->dev, "Fail to initialize mac descriptors!\n");
                spl2sw_descs_free(comm);
                goto out_clk_disable;
        }

        /* Initialize MAC. */
        spl2sw_mac_init(comm);

        /* Initialize mdio bus */
        ret = spl2sw_mdio_init(comm);
        if (ret) {
                dev_err(&pdev->dev, "Failed to initialize mdio bus!\n");
                goto out_clk_disable;
        }

        /* Get child node Ethernet-ports. */
                :
                :
        return 0;

out_unregister_dev:
        for (i = 0; i < MAX_NETDEV_NUM; i++)
                if (comm->ndev[i])
                        unregister_netdev(comm->ndev[i]);

out_free_mdio:
        spl2sw_mdio_remove(comm);

out_clk_disable:
        clk_disable_unprepare(comm->clk);
        return ret;
}


>
> > +   netif_napi_add(ndev, &comm->rx_napi, spl2sw_rx_poll, SPL2SW_RX_NAPI_WEIGHT);
> > +   napi_enable(&comm->rx_napi);
> > +   netif_napi_add(ndev, &comm->tx_napi, spl2sw_tx_poll, SPL2SW_TX_NAPI_WEIGHT);
> > +   napi_enable(&comm->tx_napi);
> > +   return 0;
> > +
> > +out_free_mdio:
> > +   spl2sw_mdio_remove(comm);
> > +
> > +out_unregister_dev:
> > +   for (i = 0; i < MAX_NETDEV_NUM; i++)
> > +           if (comm->ndev[i])
> > +                   unregister_netdev(comm->ndev[i]);
> > +
> > +out_clk_disable:
> > +   clk_disable_unprepare(comm->clk);
> > +   return ret;
> > +}
>
> > new file mode 100644
> > index 0000000..5f177b3
> > --- /dev/null
> > +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.h
> > @@ -0,0 +1,12 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/* Copyright Sunplus Technology Co., Ltd.
> > + *       All rights reserved.
> > + */
> > +
> > +#ifndef __SPL2SW_DRIVER_H__
> > +#define __SPL2SW_DRIVER_H__
> > +
> > +#define SPL2SW_RX_NAPI_WEIGHT      16
> > +#define SPL2SW_TX_NAPI_WEIGHT      16
> > +
> > +#endif
> > diff --git a/drivers/net/ethernet/sunplus/spl2sw_int.c
> b/drivers/net/ethernet/sunplus/spl2sw_int.c
> > new file mode 100644
> > index 0000000..b6ab8fe
> > --- /dev/null
> > +++ b/drivers/net/ethernet/sunplus/spl2sw_int.c
> > @@ -0,0 +1,253 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Copyright Sunplus Technology Co., Ltd.
> > + *       All rights reserved.
> > + */
> > +
> > +#include <linux/platform_device.h>
> > +#include <linux/etherdevice.h>
> > +#include <linux/netdevice.h>
> > +#include <linux/bitfield.h>
> > +#include <linux/of_mdio.h>
> > +
> > +#include "spl2sw_register.h"
> > +#include "spl2sw_define.h"
> > +#include "spl2sw_int.h"
> > +
> > +int spl2sw_rx_poll(struct napi_struct *napi, int budget)
> > +{
> > +   struct spl2sw_common *comm = container_of(napi, struct spl2sw_common, rx_napi);
> > +   struct spl2sw_mac_desc *desc, *h_desc;
> > +   struct net_device_stats *stats;
> > +   struct sk_buff *skb, *new_skb;
> > +   struct spl2sw_skb_info *sinfo;
> > +   u32 rx_pos, pkg_len;
> > +   u32 num, rx_count;
> > +   s32 queue;
> > +   u32 mask;
> > +   int port;
> > +   u32 cmd;
> > +
> > +   spin_lock(&comm->rx_lock);
>
> What purpose does this lock serve?

It was for spl2sw_rx_poll().
I'll remove it as not necessary.


>
> > +   /* Process high-priority queue and then low-priority queue. */
> > +   for (queue = 0; queue < RX_DESC_QUEUE_NUM; queue++) {
> > +           rx_pos = comm->rx_pos[queue];
> > +           rx_count = comm->rx_desc_num[queue];
> > +
> > +           for (num = 0; num < rx_count; num++) {
> > +                   sinfo = comm->rx_skb_info[queue] + rx_pos;
> > +                   desc = comm->rx_desc[queue] + rx_pos;
> > +                   cmd = desc->cmd1;
> > +
> > +                   if (cmd & RXD_OWN)
> > +                           break;
> > +
> > +                   port = FIELD_GET(RXD_PKT_SP, cmd);
> > +                   if (port < MAX_NETDEV_NUM && comm->ndev[port])
> > +                           stats = &comm->ndev[port]->stats;
> > +                   else
> > +                           goto spl2sw_rx_poll_rec_err;
> > +
> > +                   pkg_len = FIELD_GET(RXD_PKT_LEN, cmd);
> > +                   if (unlikely((cmd & RXD_ERR_CODE) || pkg_len < ETH_ZLEN + 4)) {
> > +                           stats->rx_length_errors++;
> > +                           stats->rx_dropped++;
> > +                           goto spl2sw_rx_poll_rec_err;
> > +                   }
> > +
> > +                   if (unlikely(cmd & RXD_IP_CHKSUM)) {
>
> IP chksum as in bad IP header csum? Let that thru, kernel will drop
> it. We don't trust HW to parse above L2 and get checksums right.

I'll remove the whole "if (unlikely(cmd & RXD_IP_CHKSUM)) { .. }" statement.


>
> > +                           stats->rx_crc_errors++;
> > +                           stats->rx_dropped++;
> > +                           goto spl2sw_rx_poll_rec_err;
> > +                   }
> > +
> > +                   dma_unmap_single(&comm->pdev->dev, sinfo->mapping,
> > +                                    comm->rx_desc_buff_size, DMA_FROM_DEVICE);
> > +
> > +                   skb = sinfo->skb;
> > +                   skb_put(skb, pkg_len - 4); /* Minus FCS */
> > +                   skb->ip_summed = CHECKSUM_NONE;
> > +                   skb->protocol = eth_type_trans(skb, comm->ndev[port]);
> > +                   netif_receive_skb(skb);
> > +
> > +                   stats->rx_packets++;
> > +                   stats->rx_bytes += skb->len;
> > +
> > +                   /* Allocate a new skb for receiving. */
> > +                   new_skb = netdev_alloc_skb(NULL, comm->rx_desc_buff_size);
> > +                   if (unlikely(!new_skb)) {
> > +                           desc->cmd2 = (rx_pos == comm->rx_desc_num[queue] - 1) ?
> > +                                        RXD_EOR : 0;
> > +                           sinfo->skb = NULL;
> > +                           sinfo->mapping = 0;
> > +                           goto spl2sw_rx_poll_alloc_err;
>
> How does this work? The device will handle the empty entry somehow?

The size of buffer (in 'cmd2' field) in rx descriptor is set to 0.
Hardware will skip the rx descriptor.

I'll modify code so that the 'empty' rx descriptor still belongs to software.
Software can try to allocate skb again next loop:

Original:
        spl2sw_rx_poll_alloc_err:
                wmb();  /* Set RXD_OWN after other fields are effective. */
                desc->cmd1 = RXD_OWN;

New:
                wmb();  /* Set RXD_OWN after other fields are effective. */
                desc->cmd1 = RXD_OWN;

        spl2sw_rx_poll_alloc_err:
                :


>
> > +                   }
> > +
> > +                   sinfo->mapping = dma_map_single(&comm->pdev->dev, new_skb->data,
> > +                                                   comm->rx_desc_buff_size,
> > +                                                   DMA_FROM_DEVICE);
> > +                   if (dma_mapping_error(&comm->pdev->dev, sinfo->mapping)) {
> > +                           dev_kfree_skb_irq(new_skb);
> > +                           desc->cmd2 = (rx_pos == comm->rx_desc_num[queue] - 1) ?
> > +                                        RXD_EOR : 0;
> > +                           sinfo->skb = NULL;
> > +                           goto spl2sw_rx_poll_alloc_err;
> > +                   }
> > +
> > +                   sinfo->skb = new_skb;
> > +                   desc->addr1 = sinfo->mapping;
> > +
> > +spl2sw_rx_poll_rec_err:
> > +                   desc->cmd2 = (rx_pos == comm->rx_desc_num[queue] - 1) ?
> > +                                RXD_EOR | comm->rx_desc_buff_size :
> > +                                comm->rx_desc_buff_size;
> > +
> > +spl2sw_rx_poll_alloc_err:
> > +                   wmb();  /* Set RXD_OWN after other fields are effective. */
> > +                   desc->cmd1 = RXD_OWN;
> > +
> > +                   /* Move rx_pos to next position */
> > +                   rx_pos = ((rx_pos + 1) == comm->rx_desc_num[queue]) ? 0 : rx_pos + 1;
> > +
> > +                   /* If there are packets in high-priority queue,
> > +                    * stop processing low-priority queue.
> > +                    */
> > +                   if (queue == 1 && !(h_desc->cmd1 & RXD_OWN))
> > +                           break;
> > +           }
> > +
> > +           comm->rx_pos[queue] = rx_pos;
> > +
> > +           /* Save pointer to last rx descriptor of high-priority queue. */
> > +           if (queue == 0)
> > +                   h_desc = comm->rx_desc[queue] + rx_pos;
>
> Where do you take budget into account?

I'll add the following code to take budget into account:

        int budget_left = budget;
                :
                :
        for (num = 0; num < rx_count && budget_left; num++) {
                :
                :
                budget_left--;

                /* If there are packets in high-priority queue,
                 * stop processing low-priority queue.
                 */
                if (queue == 1 && !(h_desc->cmd1 & RXD_OWN))
                        break;
        }

Similar modification will also be done for spl2sw_tx_poll() function.


>
> > +   }
> > +
> > +   spin_unlock(&comm->rx_lock);
> > +
> > +   wmb();  /* make sure settings are effective. */
> > +   mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> > +   mask &= ~MAC_INT_RX;
> > +   writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> > +
> > +   napi_complete(napi);
> > +   return 0;
> > +}

Thank you very much for your review.


Best regards,
Wells

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: [PATCH net-next v8 2/2] net: ethernet: Add driver for Sunplus SP7021
  2022-04-14 13:36     ` Andrew Lunn
@ 2022-04-19 10:07       ` Wells Lu 呂芳騰
  2022-04-19 13:03         ` Andrew Lunn
  0 siblings, 1 reply; 8+ messages in thread
From: Wells Lu 呂芳騰 @ 2022-04-19 10:07 UTC (permalink / raw)
  To: Andrew Lunn, Jakub Kicinski
  Cc: Wells Lu, davem, robh+dt, netdev, devicetree, linux-kernel,
	p.zabel, pabeni, krzk+dt, roopa, edumazet

> > > +		/* Get mac-address from nvmem. */
> > > +		ret = spl2sw_nvmem_get_mac_address(&pdev->dev, port_np, mac_addr);
> > > +		if (ret) {
> > > +			dev_info(&pdev->dev, "Generate a random mac address!\n");
> > > +
> > > +			/* Generate a mac address using OUI of Sunplus Technology
> > > +			 * and random controller number.
> > > +			 */
> > > +			mac_addr[0] = 0xfc; /* OUI of Sunplus: fc:4b:bc */
> > > +			mac_addr[1] = 0x4b;
> > > +			mac_addr[2] = 0xbc;
> > > +			mac_addr[3] = get_random_int() % 256;
> > > +			mac_addr[4] = get_random_int() % 256;
> > > +			mac_addr[5] = get_random_int() % 256;
> >
> > I don't think you can do that. Either you use your OUI and assign the
> > address at manufacture or you must use a locally administered address.
> > And if locally administered address is used it better be completely
> > random to lower the probability of collision to absolute minimum.
> 
> I commented about that in an earlier version of these patches. We probably need a quote
> from the 802.1 or 802.3 which says this is O.K.
> 
> 	 Andrew

Hi Andrew,

I plan to replace above statements with:

	eth_random_addr(mac_addr);

eth_random_addr() generates locally administered (random) address.

Do you mean I can keep use the mac address: "OUI + random number"?
Only need to add comment for it. 
What comment should I add? Which one do you recommend?

Thank you very much for your review.


Best regards,
Wells


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH net-next v8 2/2] net: ethernet: Add driver for Sunplus SP7021
  2022-04-19 10:07       ` Wells Lu 呂芳騰
@ 2022-04-19 13:03         ` Andrew Lunn
  0 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2022-04-19 13:03 UTC (permalink / raw)
  To: Wells Lu 呂芳騰
  Cc: Jakub Kicinski, Wells Lu, davem, robh+dt, netdev, devicetree,
	linux-kernel, p.zabel, pabeni, krzk+dt, roopa, edumazet

On Tue, Apr 19, 2022 at 10:07:55AM +0000, Wells Lu 呂芳騰 wrote:
> > > > +		/* Get mac-address from nvmem. */
> > > > +		ret = spl2sw_nvmem_get_mac_address(&pdev->dev, port_np, mac_addr);
> > > > +		if (ret) {
> > > > +			dev_info(&pdev->dev, "Generate a random mac address!\n");
> > > > +
> > > > +			/* Generate a mac address using OUI of Sunplus Technology
> > > > +			 * and random controller number.
> > > > +			 */
> > > > +			mac_addr[0] = 0xfc; /* OUI of Sunplus: fc:4b:bc */
> > > > +			mac_addr[1] = 0x4b;
> > > > +			mac_addr[2] = 0xbc;
> > > > +			mac_addr[3] = get_random_int() % 256;
> > > > +			mac_addr[4] = get_random_int() % 256;
> > > > +			mac_addr[5] = get_random_int() % 256;
> > >
> > > I don't think you can do that. Either you use your OUI and assign the
> > > address at manufacture or you must use a locally administered address.
> > > And if locally administered address is used it better be completely
> > > random to lower the probability of collision to absolute minimum.
> > 
> > I commented about that in an earlier version of these patches. We probably need a quote
> > from the 802.1 or 802.3 which says this is O.K.
> > 
> > 	 Andrew
> 
> Hi Andrew,
> 
> I plan to replace above statements with:
> 
> 	eth_random_addr(mac_addr);

O.K, that is good.

> Do you mean I can keep use the mac address: "OUI + random number"?

If you can show us text in an IEEE 802.1, IEEE 802.3, or some other
IEEE document which says this is allowed.

> Only need to add comment for it.

Add a comment which points to a document which says you are allowed to
do this. This is very unusual, so questions will be asked, and if you
point people at the answer it will help.

      Andrew

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-04-19 13:03 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13  2:31 [PATCH net-next v8 0/2] This is a patch series for Ethernet driver of Sunplus SP7021 SoC Wells Lu
2022-04-13  2:31 ` [PATCH net-next v8 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021 Wells Lu
2022-04-13  2:31 ` [PATCH net-next v8 2/2] net: ethernet: Add driver " Wells Lu
2022-04-14 12:18   ` Jakub Kicinski
2022-04-14 13:36     ` Andrew Lunn
2022-04-19 10:07       ` Wells Lu 呂芳騰
2022-04-19 13:03         ` Andrew Lunn
2022-04-19  9:49     ` Wells Lu 呂芳騰

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.