From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E8BEC433EF for ; Thu, 14 Apr 2022 15:09:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238968AbiDNPLm (ORCPT ); Thu, 14 Apr 2022 11:11:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242575AbiDNOz2 (ORCPT ); Thu, 14 Apr 2022 10:55:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 422F0DF49E for ; Thu, 14 Apr 2022 07:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649947418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QuJiJFITGoHkwzMAJZMGJPEcNOBJ93d2xdHTYzi4rIU=; b=XDUAH7Hp52kQR05ZzdtD/1jt20EdI5AnlSL+TOo0Oe2104RNMW9O1c6e2Mwa7H1Y8invo+ 0kxkTajNNZqz07xg/jLrHX/xBDME7GCNwQzEfQh0I8gMz0JutgfsA4SB7yEwrKv6Jm9l7z IFcQf6BuThI9AzLNulx6jH83O7+UiQM= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-nMk2NJD6P0q6k1Uor2G6PQ-1; Thu, 14 Apr 2022 10:43:37 -0400 X-MC-Unique: nMk2NJD6P0q6k1Uor2G6PQ-1 Received: by mail-qt1-f197.google.com with SMTP id o2-20020ac86982000000b002f1d71c97b8so1886066qtq.2 for ; Thu, 14 Apr 2022 07:43:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=QuJiJFITGoHkwzMAJZMGJPEcNOBJ93d2xdHTYzi4rIU=; b=oCGmmKFm40y33ZxXMpOnm/QHyPleLhc0n+qzCfs1hGUdKU9tmLwJ1I0RPqQbZvkjD8 FwiI+sIbPoKSlbC99H4Y2aFkwCckffBD/KHHdkOrUeatZAthdo+2fH/Q6bMRuzAVhuOz LQUJjAozqPBf1tf4g6az4LwHObU9bd5X9m21HqxwFG22gc3cNkJfjWazP9HuntXxR5vE 1n68XOm3/R0SiKBWLs79V/8y5fmVXgOvk8qKZYxH68A+0Vnd2knem0xAWqjesTt2P1kD Y3eEtws+2w4Sp2PWPs6kGKYynLqb3PPL4z/7Ma1+0w/2Fg3cik0gn+pUth1OL4gfERpv bTYw== X-Gm-Message-State: AOAM5317fvwpuA8hUQYxrYg5/K2F8mZGaSlCjDVrTon6OlgT/q9gQy6L r2fimQnWVGSYT1rXnj+cgGGgJFMFrZbwDfCfm8+p4r9cDWpWC2O+Dga4hBS1J6/XqdZtfzdomrw JAmZTIqY3QGbhtXN2VA== X-Received: by 2002:a05:6214:19c8:b0:444:32f0:2351 with SMTP id j8-20020a05621419c800b0044432f02351mr13031399qvc.109.1649947416554; Thu, 14 Apr 2022 07:43:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzubj5M+q00GpcegJK6T6HMs+CwCb40vr8nPHINMAqqQZbUICFGJLMTBaK0moSHYgLDR4/qFg== X-Received: by 2002:a05:6214:19c8:b0:444:32f0:2351 with SMTP id j8-20020a05621419c800b0044432f02351mr13031377qvc.109.1649947416257; Thu, 14 Apr 2022 07:43:36 -0700 (PDT) Received: from zlang-mailbox ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id o14-20020a05622a138e00b002e1e78c899fsm1219575qtk.53.2022.04.14.07.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 07:43:35 -0700 (PDT) Date: Thu, 14 Apr 2022 22:43:30 +0800 From: Zorro Lang To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [PATCH 1/4] xfs: make sure syncfs(2) passes back super_operations.sync_fs errors Message-ID: <20220414144330.yby7dsxzqeawekmc@zlang-mailbox> Mail-Followup-To: "Darrick J. Wong" , linux-xfs@vger.kernel.org, fstests@vger.kernel.org References: <164971767143.169983.12905331894414458027.stgit@magnolia> <164971767699.169983.772317637668809854.stgit@magnolia> <20220412093727.5zsuh7mucv2wlwgm@zlang-mailbox> <20220412172853.GG16799@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220412172853.GG16799@magnolia> Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Tue, Apr 12, 2022 at 10:28:53AM -0700, Darrick J. Wong wrote: > On Tue, Apr 12, 2022 at 05:37:27PM +0800, Zorro Lang wrote: > > On Mon, Apr 11, 2022 at 03:54:37PM -0700, Darrick J. Wong wrote: > > > From: Darrick J. Wong > > > > > > This is a regression test to make sure that nonzero error returns from > > > a filesystem's ->sync_fs implementation are actually passed back to > > > userspace when the call stack involves syncfs(2). > > > > > > Signed-off-by: Darrick J. Wong > > > --- > > > tests/xfs/839 | 42 ++++++++++++++++++++++++++++++++++++++++++ > > > tests/xfs/839.out | 2 ++ > > > 2 files changed, 44 insertions(+) > > > create mode 100755 tests/xfs/839 > > > create mode 100644 tests/xfs/839.out > > > > > > > > > diff --git a/tests/xfs/839 b/tests/xfs/839 > > > > This case looks good to me. Just one question, is it possible to be a generic > > case? From the code logic, it doesn't use xfs specified operations, but I'm > > not sure if other filesystems would like to treat sync_fs return value as XFS. > > Other filesystems (ext4 in particular) haven't been fixed to make > ->sync_fs return error codes when the fs has been shut down via > FS_IOC_SHUTDOWN. We'll get there eventually, but for now I'd like to > get this under test for XFS since we've applied those fixes. If other filesystems intend to do that, how about using a generic case failure to remind them they haven't done that :) If they don't intend that, keep this case under xfs is good to me. > > > > new file mode 100755 > > > index 00000000..9bfe93ef > > > --- /dev/null > > > +++ b/tests/xfs/839 > > > @@ -0,0 +1,42 @@ > > > +#! /bin/bash > > > +# SPDX-License-Identifier: GPL-2.0 > > > +# Copyright (c) 2022 Oracle. All Rights Reserved. > > > +# > > > +# FS QA Test No. 839 > > > +# > > > +# Regression test for kernel commits: > > > +# > > > +# 5679897eb104 ("vfs: make sync_filesystem return errors from ->sync_fs") > > > +# 2d86293c7075 ("xfs: return errors in xfs_fs_sync_fs") > > > > BTW, after this change, now can I assume that sync(2) flushes all data and metadata > > to underlying disk, if it returns 0. > > Yes. > > > Sorry, really confused on what these sync things > > really guarantee :) > > No worries -- the history of the sync variants has been very messy and > confusing even to people on fsdevel. > > --D > > > > > Thanks, > > Zorro > > > > > +# > > > +# During a code inspection, I noticed that sync_filesystem ignores the return > > > +# value of the ->sync_fs calls that it makes. sync_filesystem, in turn is used > > > +# by the syncfs(2) syscall to persist filesystem changes to disk. This means > > > +# that syncfs(2) does not capture internal filesystem errors that are neither > > > +# visible from the block device (e.g. media error) nor recorded in s_wb_err. > > > +# XFS historically returned 0 from ->sync_fs even if there were log failures, > > > +# so that had to be corrected as well. > > > +# > > > +# The kernel commits above fix this problem, so this test tries to trigger the > > > +# bug by using the shutdown ioctl on a clean, freshly mounted filesystem in the > > > +# hope that the EIO generated as a result of the filesystem being shut down is > > > +# only visible via ->sync_fs. > > > +# > > > +. ./common/preamble > > > +_begin_fstest auto quick shutdown > > > + > > > +# real QA test starts here > > > + > > > +# Modify as appropriate. > > > +_require_xfs_io_command syncfs > > > +_require_scratch_nocheck > > > +_require_scratch_shutdown > > > + > > > +# Reuse the fs formatted when we checked for the shutdown ioctl, and don't > > > +# bother checking the filesystem afterwards since we never wrote anything. > > > +_scratch_mount > > > +$XFS_IO_PROG -x -c 'shutdown -f ' -c syncfs $SCRATCH_MNT > > > + > > > +# success, all done > > > +status=0 > > > +exit > > > diff --git a/tests/xfs/839.out b/tests/xfs/839.out > > > new file mode 100644 > > > index 00000000..f275cdcc > > > --- /dev/null > > > +++ b/tests/xfs/839.out > > > @@ -0,0 +1,2 @@ > > > +QA output created by 839 > > > +syncfs: Input/output error > > > > > >