All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs/216: handle larger log sizes
Date: Fri, 15 Apr 2022 03:25:31 +0800	[thread overview]
Message-ID: <20220414192531.56hn4igvgqikdryf@zlang-mailbox> (raw)
In-Reply-To: <20220414015149.GD16774@magnolia>

On Wed, Apr 13, 2022 at 06:51:49PM -0700, Darrick J. Wong wrote:
> On Thu, Apr 14, 2022 at 01:44:00AM +0800, Zorro Lang wrote:
> > On Mon, Apr 11, 2022 at 03:55:13PM -0700, Darrick J. Wong wrote:
> > > From: Darrick J. Wong <djwong@kernel.org>
> > > 
> > > mkfs will soon refuse to format a log smaller than 64MB, so update this
> > > test to reflect the new log sizing calculations.
> > > 
> > > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > > ---
> > >  tests/xfs/216.out |   14 +++++++-------
> > >  1 file changed, 7 insertions(+), 7 deletions(-)
> > > 
> > > 
> > > diff --git a/tests/xfs/216.out b/tests/xfs/216.out
> > > index cbd7b652..3c12085f 100644
> > > --- a/tests/xfs/216.out
> > > +++ b/tests/xfs/216.out
> > > @@ -1,10 +1,10 @@
> > >  QA output created by 216
> > > -fssize=1g log      =internal log           bsize=4096   blocks=2560, version=2
> > > -fssize=2g log      =internal log           bsize=4096   blocks=2560, version=2
> > > -fssize=4g log      =internal log           bsize=4096   blocks=2560, version=2
> > > -fssize=8g log      =internal log           bsize=4096   blocks=2560, version=2
> > > -fssize=16g log      =internal log           bsize=4096   blocks=2560, version=2
> > > -fssize=32g log      =internal log           bsize=4096   blocks=4096, version=2
> > > -fssize=64g log      =internal log           bsize=4096   blocks=8192, version=2
> > > +fssize=1g log      =internal log           bsize=4096   blocks=16384, version=2
> > > +fssize=2g log      =internal log           bsize=4096   blocks=16384, version=2
> > > +fssize=4g log      =internal log           bsize=4096   blocks=16384, version=2
> > > +fssize=8g log      =internal log           bsize=4096   blocks=16384, version=2
> > > +fssize=16g log      =internal log           bsize=4096   blocks=16384, version=2
> > > +fssize=32g log      =internal log           bsize=4096   blocks=16384, version=2
> > > +fssize=64g log      =internal log           bsize=4096   blocks=16384, version=2
> > 
> > So this will break downstream kernel testing too, except it follows this new
> > xfs behavior change. Is it possible to get the minimal log size, then help to
> > avoid the failure (if it won't mess up the code:)?
> 
> Hmm.  I suppose we could do a .out.XXX switcheroo type thing, though I
> don't know of a good way to detect which mkfs behavior you've got.

Don't need to take much time to handle it :) How about use a specified filter function,
filter all log blocks number <= 16384, if the number of blocks=$number <= 16384, transform
it to blocks=* or what anything else do you like ?

I think we don't really care how much the log size less than 64M, right? Just hope it
works (can be mounted and read/write)?

Thanks,
Zorro

> 
> --D
> 
> > 
> > >  fssize=128g log      =internal log           bsize=4096   blocks=16384, version=2
> > >  fssize=256g log      =internal log           bsize=4096   blocks=32768, version=2
> > > 
> > 
> 


  reply	other threads:[~2022-04-14 19:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 22:54 [PATCHSET 0/3] fstests: updates for xfsprogs 5.15 Darrick J. Wong
2022-04-11 22:55 ` [PATCH 1/3] common/rc: let xfs_scrub tell us about its unicode checker Darrick J. Wong
2022-04-13 18:07   ` Zorro Lang
2022-04-11 22:55 ` [PATCH 2/3] xfs: test mkfs.xfs config file stack corruption issues Darrick J. Wong
2022-04-13 17:56   ` Zorro Lang
2022-04-11 22:55 ` [PATCH 3/3] xfs/216: handle larger log sizes Darrick J. Wong
2022-04-13 17:44   ` Zorro Lang
2022-04-14  1:51     ` Darrick J. Wong
2022-04-14 19:25       ` Zorro Lang [this message]
2022-04-14 19:36         ` Darrick J. Wong
2022-04-15  3:24           ` Zorro Lang
2022-04-15 15:04   ` [PATCH v1.1 " Darrick J. Wong
2022-04-16 13:35     ` Zorro Lang
2022-04-17 14:42       ` Eryu Guan
2022-04-17 16:39         ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220414192531.56hn4igvgqikdryf@zlang-mailbox \
    --to=zlang@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.