* [PATCH 0/3] Add hdmi Support for BPI-R2-Pro
@ 2022-04-15 10:49 ` Frank Wunderlich
0 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
This Series adds changes to Device tree for Bananapi-R2-Pro to support
HDMI output.
It is based on "drm/rockchip: RK356x VOP2 support"
v10:
https://patchwork.kernel.org/project/linux-rockchip/list/?series=630407
Frank Wunderlich (3):
arm64: dts: rockchip: set display regulators to always-on on
BPI-R2-Pro
arm64: dts: rockchip: enable vop2 and hdmi tx on BPI-R2-Pro
arm64: dts: rockchip: enable the gpu on BPI-R2-Pro
.../boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 57 +++++++++++++++++++
1 file changed, 57 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 0/3] Add hdmi Support for BPI-R2-Pro
@ 2022-04-15 10:49 ` Frank Wunderlich
0 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
This Series adds changes to Device tree for Bananapi-R2-Pro to support
HDMI output.
It is based on "drm/rockchip: RK356x VOP2 support"
v10:
https://patchwork.kernel.org/project/linux-rockchip/list/?series=630407
Frank Wunderlich (3):
arm64: dts: rockchip: set display regulators to always-on on
BPI-R2-Pro
arm64: dts: rockchip: enable vop2 and hdmi tx on BPI-R2-Pro
arm64: dts: rockchip: enable the gpu on BPI-R2-Pro
.../boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 57 +++++++++++++++++++
1 file changed, 57 insertions(+)
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 0/3] Add hdmi Support for BPI-R2-Pro
@ 2022-04-15 10:49 ` Frank Wunderlich
0 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
This Series adds changes to Device tree for Bananapi-R2-Pro to support
HDMI output.
It is based on "drm/rockchip: RK356x VOP2 support"
v10:
https://patchwork.kernel.org/project/linux-rockchip/list/?series=630407
Frank Wunderlich (3):
arm64: dts: rockchip: set display regulators to always-on on
BPI-R2-Pro
arm64: dts: rockchip: enable vop2 and hdmi tx on BPI-R2-Pro
arm64: dts: rockchip: enable the gpu on BPI-R2-Pro
.../boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 57 +++++++++++++++++++
1 file changed, 57 insertions(+)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/3] arm64: dts: rockchip: set display regulators to always-on on BPI-R2-Pro
2022-04-15 10:49 ` Frank Wunderlich
(?)
@ 2022-04-15 10:49 ` Frank Wunderlich
-1 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Set display related regulators to always-on on Banana PI R2 Pro
board.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index 2700fb18a3bc..0950f9659bb4 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -225,6 +225,7 @@ regulator-state-mem {
vdd_gpu: DCDC_REG2 {
regulator-name = "vdd_gpu";
+ regulator-always-on;
regulator-init-microvolt = <900000>;
regulator-initial-mode = <0x2>;
regulator-min-microvolt = <500000>;
@@ -274,6 +275,7 @@ regulator-state-mem {
vdda0v9_image: LDO_REG1 {
regulator-name = "vdda0v9_image";
+ regulator-always-on;
regulator-min-microvolt = <900000>;
regulator-max-microvolt = <900000>;
@@ -369,6 +371,7 @@ regulator-state-mem {
vcca1v8_image: LDO_REG9 {
regulator-name = "vcca1v8_image";
+ regulator-always-on;
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 1/3] arm64: dts: rockchip: set display regulators to always-on on BPI-R2-Pro
@ 2022-04-15 10:49 ` Frank Wunderlich
0 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Set display related regulators to always-on on Banana PI R2 Pro
board.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index 2700fb18a3bc..0950f9659bb4 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -225,6 +225,7 @@ regulator-state-mem {
vdd_gpu: DCDC_REG2 {
regulator-name = "vdd_gpu";
+ regulator-always-on;
regulator-init-microvolt = <900000>;
regulator-initial-mode = <0x2>;
regulator-min-microvolt = <500000>;
@@ -274,6 +275,7 @@ regulator-state-mem {
vdda0v9_image: LDO_REG1 {
regulator-name = "vdda0v9_image";
+ regulator-always-on;
regulator-min-microvolt = <900000>;
regulator-max-microvolt = <900000>;
@@ -369,6 +371,7 @@ regulator-state-mem {
vcca1v8_image: LDO_REG9 {
regulator-name = "vcca1v8_image";
+ regulator-always-on;
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 1/3] arm64: dts: rockchip: set display regulators to always-on on BPI-R2-Pro
@ 2022-04-15 10:49 ` Frank Wunderlich
0 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Set display related regulators to always-on on Banana PI R2 Pro
board.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index 2700fb18a3bc..0950f9659bb4 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -225,6 +225,7 @@ regulator-state-mem {
vdd_gpu: DCDC_REG2 {
regulator-name = "vdd_gpu";
+ regulator-always-on;
regulator-init-microvolt = <900000>;
regulator-initial-mode = <0x2>;
regulator-min-microvolt = <500000>;
@@ -274,6 +275,7 @@ regulator-state-mem {
vdda0v9_image: LDO_REG1 {
regulator-name = "vdda0v9_image";
+ regulator-always-on;
regulator-min-microvolt = <900000>;
regulator-max-microvolt = <900000>;
@@ -369,6 +371,7 @@ regulator-state-mem {
vcca1v8_image: LDO_REG9 {
regulator-name = "vcca1v8_image";
+ regulator-always-on;
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 2/3] arm64: dts: rockchip: enable vop2 and hdmi tx on BPI-R2-Pro
2022-04-15 10:49 ` Frank Wunderlich
(?)
@ 2022-04-15 10:49 ` Frank Wunderlich
-1 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Enable the RK356x Video Output Processor (VOP) 2 on the
BananaPi R2 Pro board.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
.../boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 47 +++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index 0950f9659bb4..cc3591251bab 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -8,6 +8,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
#include "rk3568.dtsi"
/ {
@@ -54,6 +55,17 @@ dc_12v: dc-12v {
regulator-max-microvolt = <12000000>;
};
+ hdmi-con {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi_out_con>;
+ };
+ };
+ };
+
vcc3v3_sys: vcc3v3-sys {
compatible = "regulator-fixed";
regulator-name = "vcc3v3_sys";
@@ -184,6 +196,24 @@ &gmac1m1_rgmii_clk
status = "okay";
};
+&hdmi {
+ avdd-0v9-supply = <&vdda0v9_image>;
+ avdd-1v8-supply = <&vcca1v8_image>;
+ status = "okay";
+};
+
+&hdmi_in {
+ hdmi_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi>;
+ };
+};
+
+&hdmi_out {
+ hdmi_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
&i2c0 {
status = "okay";
@@ -600,3 +630,20 @@ &usb2phy0_otg {
phy-supply = <&vcc5v0_usb_otg>;
status = "okay";
};
+
+&vop {
+ assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;
+ assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi_in_vp0>;
+ };
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 2/3] arm64: dts: rockchip: enable vop2 and hdmi tx on BPI-R2-Pro
@ 2022-04-15 10:49 ` Frank Wunderlich
0 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Enable the RK356x Video Output Processor (VOP) 2 on the
BananaPi R2 Pro board.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
.../boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 47 +++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index 0950f9659bb4..cc3591251bab 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -8,6 +8,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
#include "rk3568.dtsi"
/ {
@@ -54,6 +55,17 @@ dc_12v: dc-12v {
regulator-max-microvolt = <12000000>;
};
+ hdmi-con {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi_out_con>;
+ };
+ };
+ };
+
vcc3v3_sys: vcc3v3-sys {
compatible = "regulator-fixed";
regulator-name = "vcc3v3_sys";
@@ -184,6 +196,24 @@ &gmac1m1_rgmii_clk
status = "okay";
};
+&hdmi {
+ avdd-0v9-supply = <&vdda0v9_image>;
+ avdd-1v8-supply = <&vcca1v8_image>;
+ status = "okay";
+};
+
+&hdmi_in {
+ hdmi_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi>;
+ };
+};
+
+&hdmi_out {
+ hdmi_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
&i2c0 {
status = "okay";
@@ -600,3 +630,20 @@ &usb2phy0_otg {
phy-supply = <&vcc5v0_usb_otg>;
status = "okay";
};
+
+&vop {
+ assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;
+ assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi_in_vp0>;
+ };
+};
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 2/3] arm64: dts: rockchip: enable vop2 and hdmi tx on BPI-R2-Pro
@ 2022-04-15 10:49 ` Frank Wunderlich
0 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Enable the RK356x Video Output Processor (VOP) 2 on the
BananaPi R2 Pro board.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
.../boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 47 +++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index 0950f9659bb4..cc3591251bab 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -8,6 +8,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
#include "rk3568.dtsi"
/ {
@@ -54,6 +55,17 @@ dc_12v: dc-12v {
regulator-max-microvolt = <12000000>;
};
+ hdmi-con {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi_out_con>;
+ };
+ };
+ };
+
vcc3v3_sys: vcc3v3-sys {
compatible = "regulator-fixed";
regulator-name = "vcc3v3_sys";
@@ -184,6 +196,24 @@ &gmac1m1_rgmii_clk
status = "okay";
};
+&hdmi {
+ avdd-0v9-supply = <&vdda0v9_image>;
+ avdd-1v8-supply = <&vcca1v8_image>;
+ status = "okay";
+};
+
+&hdmi_in {
+ hdmi_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi>;
+ };
+};
+
+&hdmi_out {
+ hdmi_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
&i2c0 {
status = "okay";
@@ -600,3 +630,20 @@ &usb2phy0_otg {
phy-supply = <&vcc5v0_usb_otg>;
status = "okay";
};
+
+&vop {
+ assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;
+ assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi_in_vp0>;
+ };
+};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 3/3] arm64: dts: rockchip: enable the gpu on BPI-R2-Pro
2022-04-15 10:49 ` Frank Wunderlich
(?)
@ 2022-04-15 10:49 ` Frank Wunderlich
-1 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Enable the GPU core on the Rockchip RK3568 BananaPi R2 Pro
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index cc3591251bab..10f68d054f76 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -196,6 +196,11 @@ &gmac1m1_rgmii_clk
status = "okay";
};
+&gpu {
+ mali-supply = <&vdd_gpu>;
+ status = "okay";
+};
+
&hdmi {
avdd-0v9-supply = <&vdda0v9_image>;
avdd-1v8-supply = <&vcca1v8_image>;
@@ -566,6 +571,8 @@ &spi3 {
};
&tsadc {
+ rockchip,hw-tshut-mode = <1>;
+ rockchip,hw-tshut-polarity = <0>;
status = "okay";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 3/3] arm64: dts: rockchip: enable the gpu on BPI-R2-Pro
@ 2022-04-15 10:49 ` Frank Wunderlich
0 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Enable the GPU core on the Rockchip RK3568 BananaPi R2 Pro
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index cc3591251bab..10f68d054f76 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -196,6 +196,11 @@ &gmac1m1_rgmii_clk
status = "okay";
};
+&gpu {
+ mali-supply = <&vdd_gpu>;
+ status = "okay";
+};
+
&hdmi {
avdd-0v9-supply = <&vdda0v9_image>;
avdd-1v8-supply = <&vcca1v8_image>;
@@ -566,6 +571,8 @@ &spi3 {
};
&tsadc {
+ rockchip,hw-tshut-mode = <1>;
+ rockchip,hw-tshut-polarity = <0>;
status = "okay";
};
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 3/3] arm64: dts: rockchip: enable the gpu on BPI-R2-Pro
@ 2022-04-15 10:49 ` Frank Wunderlich
0 siblings, 0 replies; 21+ messages in thread
From: Frank Wunderlich @ 2022-04-15 10:49 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Enable the GPU core on the Rockchip RK3568 BananaPi R2 Pro
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index cc3591251bab..10f68d054f76 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -196,6 +196,11 @@ &gmac1m1_rgmii_clk
status = "okay";
};
+&gpu {
+ mali-supply = <&vdd_gpu>;
+ status = "okay";
+};
+
&hdmi {
avdd-0v9-supply = <&vdda0v9_image>;
avdd-1v8-supply = <&vcca1v8_image>;
@@ -566,6 +571,8 @@ &spi3 {
};
&tsadc {
+ rockchip,hw-tshut-mode = <1>;
+ rockchip,hw-tshut-polarity = <0>;
status = "okay";
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH 3/3] arm64: dts: rockchip: enable the gpu on BPI-R2-Pro
2022-04-15 10:49 ` Frank Wunderlich
(?)
@ 2022-05-17 18:47 ` Heiko Stuebner
-1 siblings, 0 replies; 21+ messages in thread
From: Heiko Stuebner @ 2022-05-17 18:47 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Am Freitag, 15. April 2022, 12:49:51 CEST schrieb Frank Wunderlich:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Enable the GPU core on the Rockchip RK3568 BananaPi R2 Pro
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index cc3591251bab..10f68d054f76 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -196,6 +196,11 @@ &gmac1m1_rgmii_clk
> status = "okay";
> };
>
> +&gpu {
> + mali-supply = <&vdd_gpu>;
> + status = "okay";
> +};
> +
> &hdmi {
> avdd-0v9-supply = <&vdda0v9_image>;
> avdd-1v8-supply = <&vcca1v8_image>;
> @@ -566,6 +571,8 @@ &spi3 {
> };
>
> &tsadc {
> + rockchip,hw-tshut-mode = <1>;
> + rockchip,hw-tshut-polarity = <0>;
This is not gpu-specific, so if needed should be a separate patch.
> status = "okay";
> };
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/3] arm64: dts: rockchip: enable the gpu on BPI-R2-Pro
@ 2022-05-17 18:47 ` Heiko Stuebner
0 siblings, 0 replies; 21+ messages in thread
From: Heiko Stuebner @ 2022-05-17 18:47 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Am Freitag, 15. April 2022, 12:49:51 CEST schrieb Frank Wunderlich:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Enable the GPU core on the Rockchip RK3568 BananaPi R2 Pro
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index cc3591251bab..10f68d054f76 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -196,6 +196,11 @@ &gmac1m1_rgmii_clk
> status = "okay";
> };
>
> +&gpu {
> + mali-supply = <&vdd_gpu>;
> + status = "okay";
> +};
> +
> &hdmi {
> avdd-0v9-supply = <&vdda0v9_image>;
> avdd-1v8-supply = <&vcca1v8_image>;
> @@ -566,6 +571,8 @@ &spi3 {
> };
>
> &tsadc {
> + rockchip,hw-tshut-mode = <1>;
> + rockchip,hw-tshut-polarity = <0>;
This is not gpu-specific, so if needed should be a separate patch.
> status = "okay";
> };
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/3] arm64: dts: rockchip: enable the gpu on BPI-R2-Pro
@ 2022-05-17 18:47 ` Heiko Stuebner
0 siblings, 0 replies; 21+ messages in thread
From: Heiko Stuebner @ 2022-05-17 18:47 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Am Freitag, 15. April 2022, 12:49:51 CEST schrieb Frank Wunderlich:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Enable the GPU core on the Rockchip RK3568 BananaPi R2 Pro
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index cc3591251bab..10f68d054f76 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -196,6 +196,11 @@ &gmac1m1_rgmii_clk
> status = "okay";
> };
>
> +&gpu {
> + mali-supply = <&vdd_gpu>;
> + status = "okay";
> +};
> +
> &hdmi {
> avdd-0v9-supply = <&vdda0v9_image>;
> avdd-1v8-supply = <&vcca1v8_image>;
> @@ -566,6 +571,8 @@ &spi3 {
> };
>
> &tsadc {
> + rockchip,hw-tshut-mode = <1>;
> + rockchip,hw-tshut-polarity = <0>;
This is not gpu-specific, so if needed should be a separate patch.
> status = "okay";
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/3] arm64: dts: rockchip: set display regulators to always-on on BPI-R2-Pro
2022-04-15 10:49 ` Frank Wunderlich
(?)
@ 2022-05-17 18:47 ` Heiko Stuebner
-1 siblings, 0 replies; 21+ messages in thread
From: Heiko Stuebner @ 2022-05-17 18:47 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Am Freitag, 15. April 2022, 12:49:49 CEST schrieb Frank Wunderlich:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Set display related regulators to always-on on Banana PI R2 Pro
> board.
Hmm, I'd expect some sort of explanation for the "why" here.
It looks like both the gpu patch as well as the vop patch do
reference the relevant regulators for the gpu+hdmi nodes,
so in theory this shouldn't be necessary anymore?
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 2700fb18a3bc..0950f9659bb4 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -225,6 +225,7 @@ regulator-state-mem {
>
> vdd_gpu: DCDC_REG2 {
> regulator-name = "vdd_gpu";
> + regulator-always-on;
> regulator-init-microvolt = <900000>;
> regulator-initial-mode = <0x2>;
> regulator-min-microvolt = <500000>;
> @@ -274,6 +275,7 @@ regulator-state-mem {
>
> vdda0v9_image: LDO_REG1 {
> regulator-name = "vdda0v9_image";
> + regulator-always-on;
> regulator-min-microvolt = <900000>;
> regulator-max-microvolt = <900000>;
>
> @@ -369,6 +371,7 @@ regulator-state-mem {
>
> vcca1v8_image: LDO_REG9 {
> regulator-name = "vcca1v8_image";
> + regulator-always-on;
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/3] arm64: dts: rockchip: set display regulators to always-on on BPI-R2-Pro
@ 2022-05-17 18:47 ` Heiko Stuebner
0 siblings, 0 replies; 21+ messages in thread
From: Heiko Stuebner @ 2022-05-17 18:47 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Am Freitag, 15. April 2022, 12:49:49 CEST schrieb Frank Wunderlich:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Set display related regulators to always-on on Banana PI R2 Pro
> board.
Hmm, I'd expect some sort of explanation for the "why" here.
It looks like both the gpu patch as well as the vop patch do
reference the relevant regulators for the gpu+hdmi nodes,
so in theory this shouldn't be necessary anymore?
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 2700fb18a3bc..0950f9659bb4 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -225,6 +225,7 @@ regulator-state-mem {
>
> vdd_gpu: DCDC_REG2 {
> regulator-name = "vdd_gpu";
> + regulator-always-on;
> regulator-init-microvolt = <900000>;
> regulator-initial-mode = <0x2>;
> regulator-min-microvolt = <500000>;
> @@ -274,6 +275,7 @@ regulator-state-mem {
>
> vdda0v9_image: LDO_REG1 {
> regulator-name = "vdda0v9_image";
> + regulator-always-on;
> regulator-min-microvolt = <900000>;
> regulator-max-microvolt = <900000>;
>
> @@ -369,6 +371,7 @@ regulator-state-mem {
>
> vcca1v8_image: LDO_REG9 {
> regulator-name = "vcca1v8_image";
> + regulator-always-on;
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/3] arm64: dts: rockchip: set display regulators to always-on on BPI-R2-Pro
@ 2022-05-17 18:47 ` Heiko Stuebner
0 siblings, 0 replies; 21+ messages in thread
From: Heiko Stuebner @ 2022-05-17 18:47 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, Peter Geis,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Am Freitag, 15. April 2022, 12:49:49 CEST schrieb Frank Wunderlich:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Set display related regulators to always-on on Banana PI R2 Pro
> board.
Hmm, I'd expect some sort of explanation for the "why" here.
It looks like both the gpu patch as well as the vop patch do
reference the relevant regulators for the gpu+hdmi nodes,
so in theory this shouldn't be necessary anymore?
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 2700fb18a3bc..0950f9659bb4 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -225,6 +225,7 @@ regulator-state-mem {
>
> vdd_gpu: DCDC_REG2 {
> regulator-name = "vdd_gpu";
> + regulator-always-on;
> regulator-init-microvolt = <900000>;
> regulator-initial-mode = <0x2>;
> regulator-min-microvolt = <500000>;
> @@ -274,6 +275,7 @@ regulator-state-mem {
>
> vdda0v9_image: LDO_REG1 {
> regulator-name = "vdda0v9_image";
> + regulator-always-on;
> regulator-min-microvolt = <900000>;
> regulator-max-microvolt = <900000>;
>
> @@ -369,6 +371,7 @@ regulator-state-mem {
>
> vcca1v8_image: LDO_REG9 {
> regulator-name = "vcca1v8_image";
> + regulator-always-on;
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/3] arm64: dts: rockchip: set display regulators to always-on on BPI-R2-Pro
2022-05-17 18:47 ` Heiko Stuebner
(?)
@ 2022-05-18 22:46 ` Peter Geis
-1 siblings, 0 replies; 21+ messages in thread
From: Peter Geis @ 2022-05-18 22:46 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Frank Wunderlich, Rob Herring,
Krzysztof Kozlowski, devicetree, arm-mail-list,
open list:ARM/Rockchip SoC...,
Linux Kernel Mailing List
On Tue, May 17, 2022 at 2:47 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> Am Freitag, 15. April 2022, 12:49:49 CEST schrieb Frank Wunderlich:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Set display related regulators to always-on on Banana PI R2 Pro
> > board.
>
> Hmm, I'd expect some sort of explanation for the "why" here.
> It looks like both the gpu patch as well as the vop patch do
> reference the relevant regulators for the gpu+hdmi nodes,
> so in theory this shouldn't be necessary anymore?
I agree the hdmi power nodes don't need to be always on, if the hdmi
driver is handling them correctly. Unfortunately the gpu power supply
needs to stay always on until the issues with power-domains not being
regulator aware is resolved. Otherwise we run into issues like the one
mentioned in Lee's email, and issues where the gpu-regulator gets shut
down and we start getting mmu faults.
>
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > index 2700fb18a3bc..0950f9659bb4 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > @@ -225,6 +225,7 @@ regulator-state-mem {
> >
> > vdd_gpu: DCDC_REG2 {
> > regulator-name = "vdd_gpu";
> > + regulator-always-on;
> > regulator-init-microvolt = <900000>;
> > regulator-initial-mode = <0x2>;
> > regulator-min-microvolt = <500000>;
> > @@ -274,6 +275,7 @@ regulator-state-mem {
> >
> > vdda0v9_image: LDO_REG1 {
> > regulator-name = "vdda0v9_image";
> > + regulator-always-on;
> > regulator-min-microvolt = <900000>;
> > regulator-max-microvolt = <900000>;
> >
> > @@ -369,6 +371,7 @@ regulator-state-mem {
> >
> > vcca1v8_image: LDO_REG9 {
> > regulator-name = "vcca1v8_image";
> > + regulator-always-on;
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> >
> >
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/3] arm64: dts: rockchip: set display regulators to always-on on BPI-R2-Pro
@ 2022-05-18 22:46 ` Peter Geis
0 siblings, 0 replies; 21+ messages in thread
From: Peter Geis @ 2022-05-18 22:46 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Frank Wunderlich, Rob Herring,
Krzysztof Kozlowski, devicetree, arm-mail-list,
open list:ARM/Rockchip SoC...,
Linux Kernel Mailing List
On Tue, May 17, 2022 at 2:47 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> Am Freitag, 15. April 2022, 12:49:49 CEST schrieb Frank Wunderlich:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Set display related regulators to always-on on Banana PI R2 Pro
> > board.
>
> Hmm, I'd expect some sort of explanation for the "why" here.
> It looks like both the gpu patch as well as the vop patch do
> reference the relevant regulators for the gpu+hdmi nodes,
> so in theory this shouldn't be necessary anymore?
I agree the hdmi power nodes don't need to be always on, if the hdmi
driver is handling them correctly. Unfortunately the gpu power supply
needs to stay always on until the issues with power-domains not being
regulator aware is resolved. Otherwise we run into issues like the one
mentioned in Lee's email, and issues where the gpu-regulator gets shut
down and we start getting mmu faults.
>
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > index 2700fb18a3bc..0950f9659bb4 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > @@ -225,6 +225,7 @@ regulator-state-mem {
> >
> > vdd_gpu: DCDC_REG2 {
> > regulator-name = "vdd_gpu";
> > + regulator-always-on;
> > regulator-init-microvolt = <900000>;
> > regulator-initial-mode = <0x2>;
> > regulator-min-microvolt = <500000>;
> > @@ -274,6 +275,7 @@ regulator-state-mem {
> >
> > vdda0v9_image: LDO_REG1 {
> > regulator-name = "vdda0v9_image";
> > + regulator-always-on;
> > regulator-min-microvolt = <900000>;
> > regulator-max-microvolt = <900000>;
> >
> > @@ -369,6 +371,7 @@ regulator-state-mem {
> >
> > vcca1v8_image: LDO_REG9 {
> > regulator-name = "vcca1v8_image";
> > + regulator-always-on;
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> >
> >
>
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/3] arm64: dts: rockchip: set display regulators to always-on on BPI-R2-Pro
@ 2022-05-18 22:46 ` Peter Geis
0 siblings, 0 replies; 21+ messages in thread
From: Peter Geis @ 2022-05-18 22:46 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Wunderlich, Frank Wunderlich, Rob Herring,
Krzysztof Kozlowski, devicetree, arm-mail-list,
open list:ARM/Rockchip SoC...,
Linux Kernel Mailing List
On Tue, May 17, 2022 at 2:47 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> Am Freitag, 15. April 2022, 12:49:49 CEST schrieb Frank Wunderlich:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Set display related regulators to always-on on Banana PI R2 Pro
> > board.
>
> Hmm, I'd expect some sort of explanation for the "why" here.
> It looks like both the gpu patch as well as the vop patch do
> reference the relevant regulators for the gpu+hdmi nodes,
> so in theory this shouldn't be necessary anymore?
I agree the hdmi power nodes don't need to be always on, if the hdmi
driver is handling them correctly. Unfortunately the gpu power supply
needs to stay always on until the issues with power-domains not being
regulator aware is resolved. Otherwise we run into issues like the one
mentioned in Lee's email, and issues where the gpu-regulator gets shut
down and we start getting mmu faults.
>
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > index 2700fb18a3bc..0950f9659bb4 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > @@ -225,6 +225,7 @@ regulator-state-mem {
> >
> > vdd_gpu: DCDC_REG2 {
> > regulator-name = "vdd_gpu";
> > + regulator-always-on;
> > regulator-init-microvolt = <900000>;
> > regulator-initial-mode = <0x2>;
> > regulator-min-microvolt = <500000>;
> > @@ -274,6 +275,7 @@ regulator-state-mem {
> >
> > vdda0v9_image: LDO_REG1 {
> > regulator-name = "vdda0v9_image";
> > + regulator-always-on;
> > regulator-min-microvolt = <900000>;
> > regulator-max-microvolt = <900000>;
> >
> > @@ -369,6 +371,7 @@ regulator-state-mem {
> >
> > vcca1v8_image: LDO_REG9 {
> > regulator-name = "vcca1v8_image";
> > + regulator-always-on;
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> >
> >
>
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2022-05-18 22:47 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-15 10:49 [PATCH 0/3] Add hdmi Support for BPI-R2-Pro Frank Wunderlich
2022-04-15 10:49 ` Frank Wunderlich
2022-04-15 10:49 ` Frank Wunderlich
2022-04-15 10:49 ` [PATCH 1/3] arm64: dts: rockchip: set display regulators to always-on on BPI-R2-Pro Frank Wunderlich
2022-04-15 10:49 ` Frank Wunderlich
2022-04-15 10:49 ` Frank Wunderlich
2022-05-17 18:47 ` Heiko Stuebner
2022-05-17 18:47 ` Heiko Stuebner
2022-05-17 18:47 ` Heiko Stuebner
2022-05-18 22:46 ` Peter Geis
2022-05-18 22:46 ` Peter Geis
2022-05-18 22:46 ` Peter Geis
2022-04-15 10:49 ` [PATCH 2/3] arm64: dts: rockchip: enable vop2 and hdmi tx " Frank Wunderlich
2022-04-15 10:49 ` Frank Wunderlich
2022-04-15 10:49 ` Frank Wunderlich
2022-04-15 10:49 ` [PATCH 3/3] arm64: dts: rockchip: enable the gpu " Frank Wunderlich
2022-04-15 10:49 ` Frank Wunderlich
2022-04-15 10:49 ` Frank Wunderlich
2022-05-17 18:47 ` Heiko Stuebner
2022-05-17 18:47 ` Heiko Stuebner
2022-05-17 18:47 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.