From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8D4C433F5 for ; Fri, 15 Apr 2022 16:47:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355977AbiDOQtn (ORCPT ); Fri, 15 Apr 2022 12:49:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355970AbiDOQtk (ORCPT ); Fri, 15 Apr 2022 12:49:40 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37DD2DD966; Fri, 15 Apr 2022 09:47:11 -0700 (PDT) Received: (Authenticated sender: clement.leger@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id E9570C0006; Fri, 15 Apr 2022 16:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650041229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kqx76FGCWY9T5n5gaf7tqiaERTtvIFYRxivjOi7DJAY=; b=VQQ8Xiqp2cyrNI9GijO8dGgMuIEA9uZZMevCeq4Kk4x41bLZRA4yZrXc5DNgKVzCtFfSEf V9pEhQLWxgPvK9g47UAZ4O8MOwn29FgqNbhuF5GyiM3ZyXRCq0HWRWBdIiVqq18+Q5i8BY lLxadXlbVEES0uc4EVOh5cJh/d7L9hRAO+NOtk6eVoYz1VAyboG1o0hyo0PrgLwUXR0iaZ FSeWqsFaz1rBbC7L1I0V6d9MzrrWLEqOwz//c/Epv0LQYy5Z9idsu1KU6YPb+Qd7/XqPoR L/ihZTkUgUcRS8DvD3BSzcNp5ApDefEBGWY9w/US9S1fe8ez5tEKPQXu8GK84A== Date: Fri, 15 Apr 2022 18:45:41 +0200 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Andrew Lunn Cc: Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , Magnus Damm , Heiner Kallweit , Russell King , Thomas Petazzoni , Herve Codina , =?UTF-8?B?TWlxdcOobA==?= Raynal , Milan Stevanovic , Jimmy Lalande , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 09/12] ARM: dts: r9a06g032: describe MII converter Message-ID: <20220415184541.0a6928f5@fixe.home> In-Reply-To: References: <20220414122250.158113-1-clement.leger@bootlin.com> <20220414122250.158113-10-clement.leger@bootlin.com> <20220415102453.1b5b3f77@fixe.home> <20220415163853.683c0b6d@fixe.home> <20220415172954.64e53086@fixe.home> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Fri, 15 Apr 2022 18:19:46 +0200, Andrew Lunn a =C3=A9crit : > > I think it would be good to modify it like this: > >=20 > > eth-miic@44030000 { > > ... > > converters { > > mii_conv0: mii-conv@0 { > > // Even if useless, maybe keeping it for the sake of coherency > > renesas,miic-input =3D ; > > reg =3D <0>; > > }; =20 >=20 > This is not a 'bus', so using reg, and @0, etc is i think wrong. You > just have a collection of properties. Agreed, but this is the same thing that is done for DSA ports (at least I think). It uses reg which describe the port number, this is not a real bus per se, it only refer to port indices. But if you think this should not be done like this, what do you propose then ? These nodes are also reference from "pcs-handle" properties in switch to retrieve the PCS. Would you suggest using something like pcs-handle =3D <ð_miic port_index> and remove the nodes then ? Thanks, --=20 Cl=C3=A9ment L=C3=A9ger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com