From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Cc: "Steven Rostedt (Google)" <rostedt@goodmis.org>
Subject: [PATCH v2 0/7] trace-cmd library: Remove dependency to vsockets
Date: Sun, 17 Apr 2022 14:21:47 -0400 [thread overview]
Message-ID: <20220417182154.1041513-1-rostedt@goodmis.org> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
In an effort to have trace-cmd agent and the time synchronization to
work with networks, the dependency to vsockets needs to be removed. In
fact, libtracecmd should not have any dependency to vsockets, as
everything can be done externally. This simplifies the code, and allows
the use of trace-msg to be used in more scenarios.
I tested host guest tracing to make sure that it did not break the
existing use cases, although there may still be an outlier that I didn't
cover.
Changes since v1: https://lore.kernel.org/r/20220415010007.938408-1-rostedt@goodmis.org
- Consolidated two commits into one, because when I tested each commit, the
separate commits broke the agent. To keep it bisectable, the following was
squashed into one commit:
[6/8] trace-cmd library: Remove dependency on vsocks from tracecmd_tsync_get_session_params()
[7/8] trace-cmd library: Remove vsock dependency from tracecmd_tsync_with_host()
- Fix the NO_VSOCK parameters for the get_vsocket_params() stub prototype.
Steven Rostedt (Google) (7):
trace-cmd: Add NO_VSOCK make option to force vsock code off
trace-cmd library: Remove ports from clock context
trace-cmd library: Remove vsocket dependency on P2P protocol
trace-cmd library: Remove dependency on vsocks for sync identifiers
trace-cmd library: Have tracecmd_tsync_with_guest() not depend on cid/port
trace-cmd library: Remove vsock dependency from tracecmd_tsync_with_host()
trace-cmd: Move vsocket code into its own file
Makefile | 4 +
.../include/private/trace-cmd-private.h | 12 +-
lib/trace-cmd/include/trace-tsync-local.h | 21 +-
lib/trace-cmd/trace-msg.c | 3 +-
lib/trace-cmd/trace-timesync-ptp.c | 25 ++-
lib/trace-cmd/trace-timesync.c | 180 ++----------------
tracecmd/Makefile | 1 +
tracecmd/include/trace-local.h | 48 +++++
tracecmd/trace-agent.c | 96 +++-------
tracecmd/trace-record.c | 94 +--------
tracecmd/trace-vm.c | 2 +-
tracecmd/trace-vsock.c | 156 +++++++++++++++
12 files changed, 302 insertions(+), 340 deletions(-)
create mode 100644 tracecmd/trace-vsock.c
--
2.35.1
next reply other threads:[~2022-04-17 18:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 18:21 Steven Rostedt [this message]
2022-04-17 18:21 ` [PATCH v2 1/7] trace-cmd: Add NO_VSOCK make option to force vsock code off Steven Rostedt
2022-04-17 18:21 ` [PATCH v2 2/7] trace-cmd library: Remove ports from clock context Steven Rostedt
2022-04-17 18:21 ` [PATCH v2 3/7] trace-cmd library: Remove vsocket dependency on P2P protocol Steven Rostedt
2022-04-17 18:21 ` [PATCH v2 4/7] trace-cmd library: Remove dependency on vsocks for sync identifiers Steven Rostedt
2022-04-17 18:21 ` [PATCH v2 5/7] trace-cmd library: Have tracecmd_tsync_with_guest() not depend on cid/port Steven Rostedt
2022-04-17 18:21 ` [PATCH v2 6/7] trace-cmd library: Remove vsock dependency from tracecmd_tsync_with_host() Steven Rostedt
2022-04-17 18:21 ` [PATCH v2 7/7] trace-cmd: Move vsocket code into its own file Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220417182154.1041513-1-rostedt@goodmis.org \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.