From: Aaron Tomlin <atomlin@redhat.com>
To: Xiubo Li <xiubli@redhat.com>
Cc: jlayton@kernel.org, idryomov@gmail.com, vshankar@redhat.com,
ceph-devel@vger.kernel.org
Subject: Re: [PATCH v2] ceph: fix possible NULL pointer dereference for req->r_session
Date: Mon, 18 Apr 2022 15:45:54 +0100 [thread overview]
Message-ID: <20220418144554.i7m6omhtulb2nq22@ava.usersys.com> (raw)
In-Reply-To: <53d24ea4-554b-2df3-e4ee-6761f6ae5c8e@redhat.com>
On Mon 2022-04-18 18:52 +0800, Xiubo Li wrote:
> Hi Aaron,
Hi Xiubo,
> Thanks very much for you testing.
No problem!
> BTW, did you test this by using Livepatch or something else ?
I mostly followed your suggestion here [1] by modifying/or patching the
kernel to increase the race window so that unsafe_request_wait() may more
reliably see a newly registered request with an unprepared session pointer
i.e. 'req->r_session == NULL'.
Indeed, with this patch we simply skip such a request while traversing the
Ceph inode's unsafe directory list in the context of unsafe_request_wait().
[1]: https://tracker.ceph.com/issues/55329
Kind regards,
--
Aaron Tomlin
next prev parent reply other threads:[~2022-04-18 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 1:44 [PATCH v2] ceph: fix possible NULL pointer dereference for req->r_session Xiubo Li
2022-04-18 9:54 ` Jeff Layton
2022-04-18 10:41 ` Aaron Tomlin
2022-04-18 10:43 ` Aaron Tomlin
2022-04-18 10:52 ` Xiubo Li
2022-04-18 14:45 ` Aaron Tomlin [this message]
2022-04-19 1:01 ` Xiubo Li
2022-04-25 9:03 ` Ilya Dryomov
2022-04-25 9:23 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220418144554.i7m6omhtulb2nq22@ava.usersys.com \
--to=atomlin@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=vshankar@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.