From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F77CC433EF for ; Mon, 18 Apr 2022 17:13:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232268AbiDRRP7 (ORCPT ); Mon, 18 Apr 2022 13:15:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239486AbiDRRP4 (ORCPT ); Mon, 18 Apr 2022 13:15:56 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 592ED2B18E for ; Mon, 18 Apr 2022 10:13:13 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id 203so938419pgb.3 for ; Mon, 18 Apr 2022 10:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BvtRLSGlIqgoZJw83CHbKmm9w5RaBORQkePsPwp3Jcs=; b=X4HUkGNZmS19IamCaufLPwvkr3VU3muJTy0uqV5g7ZncQwXZXwPRIPzafxazChGNEO ybOPX5th1MG/Yh4Yz1AYYEXYUO1Km9yplsj4dJUgklqGMwCcUAJo+voR9rMmHwE28Lm/ TIHSSMmO6CjeQWVmvdyA9zhyPjvF5wnXzN01hFDq8nqhN4iJW+KLB58OFFV91GkgEig8 38brj/8xk4X5b7UkhN2nVvDuccfkk7KvvWk+JROL/vggq0uL2noWR2Zxih8fX6AdYzxh Iq4Ye/qp4Z4iCOcRuFSskjr57JNOXttTftidMDZGNvCaK3+CvUxVdqWpFHuQadh2LhUI GWHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BvtRLSGlIqgoZJw83CHbKmm9w5RaBORQkePsPwp3Jcs=; b=QofYfHH/srh+6uqMQq3nfeQo0VTvSb9M9luQ3fcdXc5UNoE43FHcTtLpuAiKazC7gD uWyHIU2WjqGYvpNXLN5wA2VGAmtZlUhieJzaOBcjS7Qhg2RKUNsb8CVFrpsx52l5Y+K/ jIxPHZ1ca+3DWvMmP9sZxdJIkv11joGC/h9yqKpVcEJXMN7B97R8rPXmFHmrtovrzhr1 9QE7DzrMczAWbnBXNJJv49dV/nWy4MggPbjMdgog6uz38t+q0grPQLI1Giv3X87YNamX 2F3YC4FFsiNRXIAog2Q+bgbrJJqTmmIZcQOD86OoY8uwgaEcb2jsd5F/LUjTCm/UIfc+ nWDQ== X-Gm-Message-State: AOAM531vgUWpfjPhZq/ekjr1uDUpg7Uy+B2/ysSvO7lgCshDKSQyYx3X Wc5tb8k+m+t1gSnkNCcUSGY65g== X-Google-Smtp-Source: ABdhPJx+xxEgbzOInBcT6iUBxz+NtIWz/XvFoiE0lFt8D8qcoTK1TxWsyQtJDP8JzSBdLixiTYwdjw== X-Received: by 2002:a62:1c8d:0:b0:4fa:8dcb:6da2 with SMTP id c135-20020a621c8d000000b004fa8dcb6da2mr13217641pfc.19.1650301992571; Mon, 18 Apr 2022 10:13:12 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id u26-20020a63471a000000b003aa1ad643bdsm1809062pga.47.2022.04.18.10.13.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 10:13:10 -0700 (PDT) Date: Mon, 18 Apr 2022 11:13:08 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: bjorn.andersson@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V4] remoteproc: imx_rproc: Ignore create mem entry for resource table Message-ID: <20220418171308.GA952787@p14s> References: <20220415025737.1561976-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220415025737.1561976-1-peng.fan@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Fri, Apr 15, 2022 at 10:57:37AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Resource table is used by Linux to get information published by > remote processor. It should be not be used for memory allocation, so > not create rproc mem entry. > > Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook") > Signed-off-by: Peng Fan > --- > > V4: > Typo fix > use strcmp, not strncmp > > V3: > Update commit log > Update Fixes tag > > V2: > Add Fixes tag > Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/ > Address typo > > > drivers/remoteproc/imx_rproc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 7a096f1891e6..91eb037089ef 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc) > if (!strcmp(it.node->name, "vdev0buffer")) > continue; > > + if (!strcmp(it.node->name, "rsc-table")) > + continue; > + Applied. Thanks, Mathieu > rmem = of_reserved_mem_lookup(it.node); > if (!rmem) { > dev_err(priv->dev, "unable to acquire memory-region\n"); > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D1B6C433F5 for ; Mon, 18 Apr 2022 17:14:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x0LClPdlC27JCMHttL435EJJyKINgnIz2iGuYEP6RCs=; b=VIBU0l9S38cQtQ Elm0movCWlGyWss5mpQd+Cy30ZTuSS3WkZZdUQkXa/cGD78qlV4fI7p98cUqnRCTxxtADlMas202Y Uo5K15CJ+64U4gLBJBeU7emdtjEyEYSo6+EYbg+/G0SQMQRTm+MPdBj6clIMHq0+UtU1AJahg6Ddw JvE7/FMSsqMggb53HJrT/gr40O+PSfSoJBz02NFjlupLAYQvB71IJluFl0T4xt99xw47hxxqfE9pl V85Xg37dQRNiyb95SqAWaCbTFRJ+wKH/q+1mXuF2mX8A0kJy4593dd+1ZR7ovspfj+MZxZeTiSRR/ jo0i3E96YgmtsRixKUbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngUwA-000Efe-K3; Mon, 18 Apr 2022 17:13:18 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngUw6-000Eef-Vj for linux-arm-kernel@lists.infradead.org; Mon, 18 Apr 2022 17:13:16 +0000 Received: by mail-pg1-x530.google.com with SMTP id h5so19956168pgc.7 for ; Mon, 18 Apr 2022 10:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BvtRLSGlIqgoZJw83CHbKmm9w5RaBORQkePsPwp3Jcs=; b=X4HUkGNZmS19IamCaufLPwvkr3VU3muJTy0uqV5g7ZncQwXZXwPRIPzafxazChGNEO ybOPX5th1MG/Yh4Yz1AYYEXYUO1Km9yplsj4dJUgklqGMwCcUAJo+voR9rMmHwE28Lm/ TIHSSMmO6CjeQWVmvdyA9zhyPjvF5wnXzN01hFDq8nqhN4iJW+KLB58OFFV91GkgEig8 38brj/8xk4X5b7UkhN2nVvDuccfkk7KvvWk+JROL/vggq0uL2noWR2Zxih8fX6AdYzxh Iq4Ye/qp4Z4iCOcRuFSskjr57JNOXttTftidMDZGNvCaK3+CvUxVdqWpFHuQadh2LhUI GWHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BvtRLSGlIqgoZJw83CHbKmm9w5RaBORQkePsPwp3Jcs=; b=FXasKqEnpcl0TAmVo7ovCVF+bu3h+s8MeNia2P7nHFRlYCPM1VDH9bgMyx9HTB8tnE tVzPqRbgf54JgHRIYqGbfT8QKUPDbTA0NUXTRTebIAFOv65Q711z5hW0XgNWsh9FVdel Kb9OSivKpDtFQb2M81mRPlo+8uAH2TC4JKT6Oqc5yNnTIwIDCl3nU3FdlpwiIfQXlxi2 yUTXA3sbeB+LGrhfHqCgZEMnpqloEn9CkocnQiN1S4uD6NuNM0n4XKl+GDJ+NeTuazOg CZcqJmPK6OgYV6vWH8QChGS3A2jYcamcgn0koOXyMdYSmNtGL0fO8uf4t77GHy2fJLOm etBQ== X-Gm-Message-State: AOAM530t3HfiIJXVA6RPb9JY80w7Sok3hh5m2mYWYq47jcKUlQ/uqXmv virdkKXml4NvthURTaO4VXbeCNKhXL72Xw== X-Google-Smtp-Source: ABdhPJx+xxEgbzOInBcT6iUBxz+NtIWz/XvFoiE0lFt8D8qcoTK1TxWsyQtJDP8JzSBdLixiTYwdjw== X-Received: by 2002:a62:1c8d:0:b0:4fa:8dcb:6da2 with SMTP id c135-20020a621c8d000000b004fa8dcb6da2mr13217641pfc.19.1650301992571; Mon, 18 Apr 2022 10:13:12 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id u26-20020a63471a000000b003aa1ad643bdsm1809062pga.47.2022.04.18.10.13.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 10:13:10 -0700 (PDT) Date: Mon, 18 Apr 2022 11:13:08 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: bjorn.andersson@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V4] remoteproc: imx_rproc: Ignore create mem entry for resource table Message-ID: <20220418171308.GA952787@p14s> References: <20220415025737.1561976-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220415025737.1561976-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220418_101315_087103_19614D9A X-CRM114-Status: GOOD ( 18.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 15, 2022 at 10:57:37AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Resource table is used by Linux to get information published by > remote processor. It should be not be used for memory allocation, so > not create rproc mem entry. > > Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook") > Signed-off-by: Peng Fan > --- > > V4: > Typo fix > use strcmp, not strncmp > > V3: > Update commit log > Update Fixes tag > > V2: > Add Fixes tag > Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/ > Address typo > > > drivers/remoteproc/imx_rproc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 7a096f1891e6..91eb037089ef 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc) > if (!strcmp(it.node->name, "vdev0buffer")) > continue; > > + if (!strcmp(it.node->name, "rsc-table")) > + continue; > + Applied. Thanks, Mathieu > rmem = of_reserved_mem_lookup(it.node); > if (!rmem) { > dev_err(priv->dev, "unable to acquire memory-region\n"); > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel