* drivers/cpufreq/intel_pstate.c:1790:9: warning: Division by zero [clang-analyzer-core.DivideZero]
@ 2022-04-18 19:44 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-04-18 19:44 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 15125 bytes --]
CC: llvm(a)lists.linux.dev
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: "Rafael J. Wysocki" <rjw@rjwysocki.net>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b2d229d4ddb17db541098b83524d901257e93845
commit: 46573fd6369f098f15e11768850b6430f374905f cpufreq: intel_pstate: hybrid: Rework HWP calibration
date: 7 months ago
:::::: branch date: 23 hours ago
:::::: commit date: 7 months ago
config: x86_64-randconfig-c007-20220418 (https://download.01.org/0day-ci/archive/20220419/202204190359.if6OtMYX-lkp(a)intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b27430f9f46b88bcd54d992debc8d72e131e1bd0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=46573fd6369f098f15e11768850b6430f374905f
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 46573fd6369f098f15e11768850b6430f374905f
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:90:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 16, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '&&' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:91:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 17, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '&&' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:92:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 18, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '&&' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:93:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 19, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '||' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:74:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
( CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 0, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:2: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: '?' condition is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:3: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
drivers/cpufreq/intel_pstate.c:742:6: note: Assuming the condition is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/cpufeature.h:122:3: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:742:2: note: Taking false branch
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
drivers/cpufreq/intel_pstate.c:758:7: note: Assuming the condition is true
if (epp == -EINVAL)
^~~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:758:3: note: Taking true branch
if (epp == -EINVAL)
^
drivers/cpufreq/intel_pstate.c:759:27: note: The result of the left shift is undefined because the left operand is negative
epp = (pref_index - 1) << 2;
~~~~~~~~~~~~~~~~ ^
>> drivers/cpufreq/intel_pstate.c:1790:9: warning: Division by zero [clang-analyzer-core.DivideZero]
return DIV_ROUND_UP(core_get_scaling() * hybrid_ref_perf,
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:54: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
~~~~~~~~~~~~~~~~^~~~~
drivers/cpufreq/intel_pstate.c:1791:8: note: Calling 'intel_pstate_cppc_nominal'
intel_pstate_cppc_nominal(cpu));
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:57: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
^
drivers/cpufreq/intel_pstate.c:393:6: note: Assuming the condition is true
if (cppc_get_nominal_perf(cpu, &nominal_perf))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:393:2: note: Taking true branch
if (cppc_get_nominal_perf(cpu, &nominal_perf))
^
drivers/cpufreq/intel_pstate.c:394:3: note: Returning zero
return 0;
^~~~~~~~
drivers/cpufreq/intel_pstate.c:1791:8: note: Returning from 'intel_pstate_cppc_nominal'
intel_pstate_cppc_nominal(cpu));
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:57: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
^
drivers/cpufreq/intel_pstate.c:1790:9: note: Division by zero
return DIV_ROUND_UP(core_get_scaling() * hybrid_ref_perf,
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:54: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
~~~~~~~~~~~~~~~~^~~~~
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
mm/memfd.c:281:2: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy]
strcpy(name, MFD_NAME_PREFIX);
^~~~~~
mm/memfd.c:281:2: note: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119
strcpy(name, MFD_NAME_PREFIX);
^~~~~~
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
8 warnings generated.
Suppressed 8 warnings (8 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
8 warnings generated.
Suppressed 8 warnings (8 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
8 warnings generated.
Suppressed 8 warnings (8 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
8 warnings generated.
Suppressed 8 warnings (8 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
8 warnings generated.
Suppressed 8 warnings (8 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
drivers/i2c/i2c-core-smbus.c:109:2: warning: Undefined or garbage value returned to caller [clang-analyzer-core.uninitialized.UndefReturn]
return (status < 0) ? status : data.byte;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/i2c/i2c-core-smbus.c:106:11: note: Calling 'i2c_smbus_xfer'
status = i2c_smbus_xfer(client->adapter, client->addr, client->flags,
vim +1790 drivers/cpufreq/intel_pstate.c
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1787
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1788 static int hybrid_get_cpu_scaling(int cpu)
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1789 {
46573fd6369f09 Rafael J. Wysocki 2021-09-04 @1790 return DIV_ROUND_UP(core_get_scaling() * hybrid_ref_perf,
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1791 intel_pstate_cppc_nominal(cpu));
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1792 }
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1793
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/cpufreq/intel_pstate.c:1790:9: warning: Division by zero [clang-analyzer-core.DivideZero]
@ 2022-04-22 6:11 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-04-22 6:11 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 14436 bytes --]
CC: llvm(a)lists.linux.dev
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: "Rafael J. Wysocki" <rjw@rjwysocki.net>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d569e86915b7f2f9795588591c8d5ea0b66481cb
commit: 46573fd6369f098f15e11768850b6430f374905f cpufreq: intel_pstate: hybrid: Rework HWP calibration
date: 8 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 8 months ago
config: x86_64-randconfig-c007-20220418 (https://download.01.org/0day-ci/archive/20220422/202204221418.KNC7bNZT-lkp(a)intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b27430f9f46b88bcd54d992debc8d72e131e1bd0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=46573fd6369f098f15e11768850b6430f374905f
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 46573fd6369f098f15e11768850b6430f374905f
# save the config file
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:90:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 16, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '&&' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:91:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 17, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '&&' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:92:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 18, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '&&' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:93:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 19, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '||' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:74:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
( CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 0, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:2: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: '?' condition is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:3: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
drivers/cpufreq/intel_pstate.c:742:6: note: Assuming the condition is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/cpufeature.h:122:3: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:742:2: note: Taking false branch
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
drivers/cpufreq/intel_pstate.c:758:7: note: Assuming the condition is true
if (epp == -EINVAL)
^~~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:758:3: note: Taking true branch
if (epp == -EINVAL)
^
drivers/cpufreq/intel_pstate.c:759:27: note: The result of the left shift is undefined because the left operand is negative
epp = (pref_index - 1) << 2;
~~~~~~~~~~~~~~~~ ^
>> drivers/cpufreq/intel_pstate.c:1790:9: warning: Division by zero [clang-analyzer-core.DivideZero]
return DIV_ROUND_UP(core_get_scaling() * hybrid_ref_perf,
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:54: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
~~~~~~~~~~~~~~~~^~~~~
drivers/cpufreq/intel_pstate.c:1791:8: note: Calling 'intel_pstate_cppc_nominal'
intel_pstate_cppc_nominal(cpu));
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:57: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
^
drivers/cpufreq/intel_pstate.c:393:6: note: Assuming the condition is true
if (cppc_get_nominal_perf(cpu, &nominal_perf))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:393:2: note: Taking true branch
if (cppc_get_nominal_perf(cpu, &nominal_perf))
^
drivers/cpufreq/intel_pstate.c:394:3: note: Returning zero
return 0;
^~~~~~~~
drivers/cpufreq/intel_pstate.c:1791:8: note: Returning from 'intel_pstate_cppc_nominal'
intel_pstate_cppc_nominal(cpu));
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:57: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
^
drivers/cpufreq/intel_pstate.c:1790:9: note: Division by zero
return DIV_ROUND_UP(core_get_scaling() * hybrid_ref_perf,
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:54: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
~~~~~~~~~~~~~~~~^~~~~
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
net/caif/cfveil.c:84:14: warning: Access to field 'transmit' results in a dereference of a null pointer (loaded from field 'dn') [clang-analyzer-core.NullDereference]
caif_assert(layr->dn->transmit != NULL);
^
include/net/caif/caif_layer.h:29:8: note: expanded from macro 'caif_assert'
if (!(assert)) { \
^~~~~~
net/caif/cfveil.c:80:27: note: Left side of '&&' is false
struct cfsrvl *service = container_obj(layr);
^
net/caif/cfveil.c:21:29: note: expanded from macro 'container_obj'
#define container_obj(layr) container_of(layr, struct cfsrvl, layer)
^
include/linux/kernel.h:495:61: note: expanded from macro 'container_of'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^
net/caif/cfveil.c:80:27: note: Taking false branch
struct cfsrvl *service = container_obj(layr);
^
net/caif/cfveil.c:21:29: note: expanded from macro 'container_obj'
#define container_obj(layr) container_of(layr, struct cfsrvl, layer)
^
include/linux/kernel.h:495:2: note: expanded from macro 'container_of'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^
include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^
include/linux/compiler_types.h:328:2: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^
include/linux/compiler_types.h:316:2: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^
include/linux/compiler_types.h:308:3: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^
net/caif/cfveil.c:80:27: note: Loop condition is false. Exiting loop
struct cfsrvl *service = container_obj(layr);
^
net/caif/cfveil.c:21:29: note: expanded from macro 'container_obj'
#define container_obj(layr) container_of(layr, struct cfsrvl, layer)
^
include/linux/kernel.h:495:2: note: expanded from macro 'container_of'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
vim +1790 drivers/cpufreq/intel_pstate.c
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1787
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1788 static int hybrid_get_cpu_scaling(int cpu)
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1789 {
46573fd6369f09 Rafael J. Wysocki 2021-09-04 @1790 return DIV_ROUND_UP(core_get_scaling() * hybrid_ref_perf,
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1791 intel_pstate_cppc_nominal(cpu));
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1792 }
46573fd6369f09 Rafael J. Wysocki 2021-09-04 1793
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/cpufreq/intel_pstate.c:1790:9: warning: Division by zero [clang-analyzer-core.DivideZero]
@ 2022-04-21 6:44 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-04-21 6:44 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 14413 bytes --]
CC: llvm(a)lists.linux.dev
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: "Rafael J. Wysocki" <rjw@rjwysocki.net>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b253435746d9a4a701b5f09211b9c14d3370d0da
commit: 46573fd6369f098f15e11768850b6430f374905f cpufreq: intel_pstate: hybrid: Rework HWP calibration
date: 8 months ago
:::::: branch date: 6 hours ago
:::::: commit date: 8 months ago
config: x86_64-randconfig-c007-20220418 (https://download.01.org/0day-ci/archive/20220421/202204210901.gi6tW0kO-lkp(a)intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b27430f9f46b88bcd54d992debc8d72e131e1bd0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=46573fd6369f098f15e11768850b6430f374905f
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 46573fd6369f098f15e11768850b6430f374905f
# save the config file
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:90:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 16, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '&&' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:91:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 17, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '&&' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:92:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 18, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '&&' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:93:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 19, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:22: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: Left side of '||' is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:32: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
arch/x86/include/asm/cpufeature.h:74:5: note: expanded from macro 'REQUIRED_MASK_BIT_SET'
( CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 0, feature_bit) || \
^
arch/x86/include/asm/cpufeature.h:64:2: note: expanded from macro 'CHECK_BIT_IN_MASK_WORD'
(((bit)>>5)==(word) && (1UL<<((bit)&31) & maskname##word ))
^
drivers/cpufreq/intel_pstate.c:742:6: note: '?' condition is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^
arch/x86/include/asm/cpufeature.h:122:3: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^
drivers/cpufreq/intel_pstate.c:742:6: note: Assuming the condition is false
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
arch/x86/include/asm/cpufeature.h:141:27: note: expanded from macro 'boot_cpu_has'
#define boot_cpu_has(bit) cpu_has(&boot_cpu_data, bit)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/cpufeature.h:122:3: note: expanded from macro 'cpu_has'
(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
^~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:742:2: note: Taking false branch
if (boot_cpu_has(X86_FEATURE_HWP_EPP)) {
^
drivers/cpufreq/intel_pstate.c:758:7: note: Assuming the condition is true
if (epp == -EINVAL)
^~~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:758:3: note: Taking true branch
if (epp == -EINVAL)
^
drivers/cpufreq/intel_pstate.c:759:27: note: The result of the left shift is undefined because the left operand is negative
epp = (pref_index - 1) << 2;
~~~~~~~~~~~~~~~~ ^
>> drivers/cpufreq/intel_pstate.c:1790:9: warning: Division by zero [clang-analyzer-core.DivideZero]
return DIV_ROUND_UP(core_get_scaling() * hybrid_ref_perf,
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:54: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
~~~~~~~~~~~~~~~~^~~~~
drivers/cpufreq/intel_pstate.c:1791:8: note: Calling 'intel_pstate_cppc_nominal'
intel_pstate_cppc_nominal(cpu));
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:57: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
^
drivers/cpufreq/intel_pstate.c:393:6: note: Assuming the condition is true
if (cppc_get_nominal_perf(cpu, &nominal_perf))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/intel_pstate.c:393:2: note: Taking true branch
if (cppc_get_nominal_perf(cpu, &nominal_perf))
^
drivers/cpufreq/intel_pstate.c:394:3: note: Returning zero
return 0;
^~~~~~~~
drivers/cpufreq/intel_pstate.c:1791:8: note: Returning from 'intel_pstate_cppc_nominal'
intel_pstate_cppc_nominal(cpu));
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:57: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
^
drivers/cpufreq/intel_pstate.c:1790:9: note: Division by zero
return DIV_ROUND_UP(core_get_scaling() * hybrid_ref_perf,
^
include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP'
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
include/uapi/linux/const.h:34:54: note: expanded from macro '__KERNEL_DIV_ROUND_UP'
#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
~~~~~~~~~~~~~~~~^~~~~
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
mm/memblock.c:1158:36: warning: The result of the '<<' expression is undefined [clang-analyzer-core.UndefinedBinaryOperatorResult]
*idx = (u32)idx_a | (u64)idx_b << 32;
~~~~~~~~~~~^~~~~
mm/memblock.c:1096:16: note: Assuming the condition is false
if (WARN_ONCE(nid == MAX_NUMNODES, "Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead\n"))
^
include/asm-generic/bug.h:150:18: note: expanded from macro 'WARN_ONCE'
DO_ONCE_LITE_IF(condition, WARN, 1, format)
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/once_lite.h:15:27: note: expanded from macro 'DO_ONCE_LITE_IF'
bool __ret_do_once = !!(condition); \
^~~~~~~~~
mm/memblock.c:1096:6: note: '__ret_do_once' is false
if (WARN_ONCE(nid == MAX_NUMNODES, "Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead\n"))
^
include/asm-generic/bug.h:150:2: note: expanded from macro 'WARN_ONCE'
DO_ONCE_LITE_IF(condition, WARN, 1, format)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/once_lite.h:17:16: note: expanded from macro 'DO_ONCE_LITE_IF'
if (unlikely(__ret_do_once && !__already_done)) { \
^~~~~~~~~~~~~
include/linux/compiler.h:78:42: note: expanded from macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
mm/memblock.c:1096:6: note: Left side of '&&' is false
if (WARN_ONCE(nid == MAX_NUMNODES, "Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead\n"))
^
include/asm-generic/bug.h:150:2: note: expanded from macro 'WARN_ONCE'
DO_ONCE_LITE_IF(condition, WARN, 1, format)
^
include/linux/once_lite.h:17:30: note: expanded from macro 'DO_ONCE_LITE_IF'
if (unlikely(__ret_do_once && !__already_done)) { \
^
mm/memblock.c:1096:6: note: Taking false branch
if (WARN_ONCE(nid == MAX_NUMNODES, "Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead\n"))
^
include/asm-generic/bug.h:150:2: note: expanded from macro 'WARN_ONCE'
DO_ONCE_LITE_IF(condition, WARN, 1, format)
^
include/linux/once_lite.h:17:3: note: expanded from macro 'DO_ONCE_LITE_IF'
if (unlikely(__ret_do_once && !__already_done)) { \
^
mm/memblock.c:1096:2: note: Taking false branch
if (WARN_ONCE(nid == MAX_NUMNODES, "Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead\n"))
^
mm/memblock.c:1099:6: note: Assuming the condition is false
if (*idx == (u64)ULLONG_MAX) {
^~~~~~~~~~~~~~~~~~~~~~~
mm/memblock.c:1099:2: note: Taking false branch
if (*idx == (u64)ULLONG_MAX) {
vim +1790 drivers/cpufreq/intel_pstate.c
46573fd6369f098 Rafael J. Wysocki 2021-09-04 1787
46573fd6369f098 Rafael J. Wysocki 2021-09-04 1788 static int hybrid_get_cpu_scaling(int cpu)
46573fd6369f098 Rafael J. Wysocki 2021-09-04 1789 {
46573fd6369f098 Rafael J. Wysocki 2021-09-04 @1790 return DIV_ROUND_UP(core_get_scaling() * hybrid_ref_perf,
46573fd6369f098 Rafael J. Wysocki 2021-09-04 1791 intel_pstate_cppc_nominal(cpu));
46573fd6369f098 Rafael J. Wysocki 2021-09-04 1792 }
46573fd6369f098 Rafael J. Wysocki 2021-09-04 1793
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-22 6:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-18 19:44 drivers/cpufreq/intel_pstate.c:1790:9: warning: Division by zero [clang-analyzer-core.DivideZero] kernel test robot
2022-04-21 6:44 kernel test robot
2022-04-22 6:11 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.