From: kernel test robot <lkp@intel.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Justin Sanders <justin@coraid.com>, Jens Axboe <axboe@kernel.dk>
Cc: kbuild-all@lists.01.org, linux-block <linux-block@vger.kernel.org>
Subject: Re: [PATCH] aoe: Avoid flush_scheduled_work() usage
Date: Tue, 19 Apr 2022 06:58:37 +0800 [thread overview]
Message-ID: <202204190659.PmftNpOE-lkp@intel.com> (raw)
In-Reply-To: <9d1759e0-2f93-d49f-48b3-12b8d47e95cd@I-love.SAKURA.ne.jp>
Hi Tetsuo,
I love your patch! Yet something to improve:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on v5.18-rc3 next-20220414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Tetsuo-Handa/aoe-Avoid-flush_scheduled_work-usage/20220418-231118
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: arc-randconfig-r023-20220419 (https://download.01.org/0day-ci/archive/20220419/202204190659.PmftNpOE-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/b1ae05b7bd5a2a2abad4aba03f55e7f4b4599789
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Tetsuo-Handa/aoe-Avoid-flush_scheduled_work-usage/20220418-231118
git checkout b1ae05b7bd5a2a2abad4aba03f55e7f4b4599789
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arceb-elf-ld: drivers/block/aoe/aoeblk.o: in function `queue_work':
>> include/linux/workqueue.h:502: undefined reference to `aoe_wq'
>> arceb-elf-ld: include/linux/workqueue.h:502: undefined reference to `aoe_wq'
arceb-elf-ld: drivers/block/aoe/aoecmd.o: in function `queue_work':
>> include/linux/workqueue.h:502: undefined reference to `aoe_wq'
>> arceb-elf-ld: include/linux/workqueue.h:502: undefined reference to `aoe_wq'
arceb-elf-ld: drivers/block/aoe/aoedev.o: in function `flush':
>> drivers/block/aoe/aoedev.c:324: undefined reference to `aoe_wq'
arceb-elf-ld: drivers/block/aoe/aoedev.o:drivers/block/aoe/aoedev.c:324: more undefined references to `aoe_wq' follow
vim +502 include/linux/workqueue.h
dcd989cb73ab0f Tejun Heo 2010-06-29 475
8425e3d5bdbe8e Tejun Heo 2013-03-13 476 /**
8425e3d5bdbe8e Tejun Heo 2013-03-13 477 * queue_work - queue work on a workqueue
8425e3d5bdbe8e Tejun Heo 2013-03-13 478 * @wq: workqueue to use
8425e3d5bdbe8e Tejun Heo 2013-03-13 479 * @work: work to queue
8425e3d5bdbe8e Tejun Heo 2013-03-13 480 *
8425e3d5bdbe8e Tejun Heo 2013-03-13 481 * Returns %false if @work was already on a queue, %true otherwise.
8425e3d5bdbe8e Tejun Heo 2013-03-13 482 *
8425e3d5bdbe8e Tejun Heo 2013-03-13 483 * We queue the work to the CPU on which it was submitted, but if the CPU dies
8425e3d5bdbe8e Tejun Heo 2013-03-13 484 * it can be processed by another CPU.
dbb92f88648d62 Andrea Parri 2020-01-22 485 *
dbb92f88648d62 Andrea Parri 2020-01-22 486 * Memory-ordering properties: If it returns %true, guarantees that all stores
dbb92f88648d62 Andrea Parri 2020-01-22 487 * preceding the call to queue_work() in the program order will be visible from
dbb92f88648d62 Andrea Parri 2020-01-22 488 * the CPU which will execute @work by the time such work executes, e.g.,
dbb92f88648d62 Andrea Parri 2020-01-22 489 *
dbb92f88648d62 Andrea Parri 2020-01-22 490 * { x is initially 0 }
dbb92f88648d62 Andrea Parri 2020-01-22 491 *
dbb92f88648d62 Andrea Parri 2020-01-22 492 * CPU0 CPU1
dbb92f88648d62 Andrea Parri 2020-01-22 493 *
dbb92f88648d62 Andrea Parri 2020-01-22 494 * WRITE_ONCE(x, 1); [ @work is being executed ]
dbb92f88648d62 Andrea Parri 2020-01-22 495 * r0 = queue_work(wq, work); r1 = READ_ONCE(x);
dbb92f88648d62 Andrea Parri 2020-01-22 496 *
dbb92f88648d62 Andrea Parri 2020-01-22 497 * Forbids: r0 == true && r1 == 0
8425e3d5bdbe8e Tejun Heo 2013-03-13 498 */
8425e3d5bdbe8e Tejun Heo 2013-03-13 499 static inline bool queue_work(struct workqueue_struct *wq,
8425e3d5bdbe8e Tejun Heo 2013-03-13 500 struct work_struct *work)
8425e3d5bdbe8e Tejun Heo 2013-03-13 501 {
8425e3d5bdbe8e Tejun Heo 2013-03-13 @502 return queue_work_on(WORK_CPU_UNBOUND, wq, work);
8425e3d5bdbe8e Tejun Heo 2013-03-13 503 }
8425e3d5bdbe8e Tejun Heo 2013-03-13 504
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-04-18 22:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 14:03 [PATCH] aoe: Avoid flush_scheduled_work() usage Tetsuo Handa
2022-04-18 22:58 ` kernel test robot [this message]
2022-04-18 23:31 ` [PATCH v2] " Tetsuo Handa
2022-05-01 4:09 ` Tetsuo Handa
2022-05-01 12:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204190659.PmftNpOE-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=justin@coraid.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.