Re: [PATCH v3 3/8] firmware_loader: Split sysfs support from fallback

From: kernel test robot <lkp@intel.com>
To: Russ Weight <russell.h.weight@intel.com>,
	mcgrof@kernel.org, rafael@kernel.org,
	linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, trix@redhat.com, lgoncalv@redhat.com,
	yilun.xu@intel.com, hao.wu@intel.com,
	matthew.gerlach@linux.intel.com,
	basheer.ahmed.muddebihal@intel.com, tianfei.zhang@intel.com,
	Russ Weight <russell.h.weight@intel.com>
Subject: Re: [PATCH v3 3/8] firmware_loader: Split sysfs support from fallback
Date: Tue, 19 Apr 2022 08:41:02 +0800	[thread overview]
Message-ID: <202204190831.KrZOnvww-lkp@intel.com> (raw)
In-Reply-To: <20220418223753.639058-4-russell.h.weight@intel.com>

Hi Russ,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on shuah-kselftest/next mcgrof/sysctl-next linus/master v5.18-rc3 next-20220414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Russ-Weight/Extend-FW-framework-for-user-FW-uploads/20220419-064126
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 3123109284176b1532874591f7c81f3837bbdc17
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220419/202204190831.KrZOnvww-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/7fb618c8a43c6350d4f11246daf3a62cd2c2843d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Russ-Weight/Extend-FW-framework-for-user-FW-uploads/20220419-064126
        git checkout 7fb618c8a43c6350d4f11246daf3a62cd2c2843d
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/base/firmware_loader/fallback.h:9,
                    from drivers/base/firmware_loader/main.c:44:
   drivers/base/firmware_loader/sysfs.h: In function '__firmware_loading_timeout':
>> drivers/base/firmware_loader/sysfs.h:74:34: error: invalid use of undefined type 'struct firmware_fallback_config'
      74 |         return fw_fallback_config.loading_timeout;
         |                                  ^
   drivers/base/firmware_loader/sysfs.h: In function '__fw_fallback_set_timeout':
   drivers/base/firmware_loader/sysfs.h:80:27: error: invalid use of undefined type 'struct firmware_fallback_config'
      80 |         fw_fallback_config.loading_timeout = timeout;
         |                           ^

vim +74 drivers/base/firmware_loader/sysfs.h

    70	
    71	/* These getters are vetted to use int properly */
    72	static inline int __firmware_loading_timeout(void)
    73	{
  > 74		return fw_fallback_config.loading_timeout;
    75	}
    76	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp