All of
 help / color / mirror / Atom feed
From: kernel test robot <>
To: Russ Weight <>,,,
	Russ Weight <>
Subject: Re: [PATCH v3 3/8] firmware_loader: Split sysfs support from fallback
Date: Tue, 19 Apr 2022 08:41:02 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Russ,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on shuah-kselftest/next mcgrof/sysctl-next linus/master v5.18-rc3 next-20220414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: 3123109284176b1532874591f7c81f3837bbdc17
config: um-i386_defconfig (
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
        git remote add linux-review
        git fetch --no-tags linux-review Russ-Weight/Extend-FW-framework-for-user-FW-uploads/20220419-064126
        git checkout 7fb618c8a43c6350d4f11246daf3a62cd2c2843d
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All errors (new ones prefixed by >>):

   In file included from drivers/base/firmware_loader/fallback.h:9,
                    from drivers/base/firmware_loader/main.c:44:
   drivers/base/firmware_loader/sysfs.h: In function '__firmware_loading_timeout':
>> drivers/base/firmware_loader/sysfs.h:74:34: error: invalid use of undefined type 'struct firmware_fallback_config'
      74 |         return fw_fallback_config.loading_timeout;
         |                                  ^
   drivers/base/firmware_loader/sysfs.h: In function '__fw_fallback_set_timeout':
   drivers/base/firmware_loader/sysfs.h:80:27: error: invalid use of undefined type 'struct firmware_fallback_config'
      80 |         fw_fallback_config.loading_timeout = timeout;
         |                           ^

vim +74 drivers/base/firmware_loader/sysfs.h

    71	/* These getters are vetted to use int properly */
    72	static inline int __firmware_loading_timeout(void)
    73	{
  > 74		return fw_fallback_config.loading_timeout;
    75	}

0-DAY CI Kernel Test Service

  reply	other threads:[~2022-04-19  0:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18 22:37 [PATCH v3 0/8] Extend FW framework for user FW uploads Russ Weight
2022-04-18 22:37 ` [PATCH v3 1/8] firmware_loader: Clear data and size in fw_free_paged_buf Russ Weight
2022-04-18 22:37 ` [PATCH v3 2/8] firmware_loader: Check fw_state_is_done in loading_store Russ Weight
2022-04-18 22:37 ` [PATCH v3 3/8] firmware_loader: Split sysfs support from fallback Russ Weight
2022-04-19  0:41   ` kernel test robot [this message]
2022-04-18 22:37 ` [PATCH v3 4/8] firmware_loader: Add firmware-upload support Russ Weight
2022-04-19 15:23   ` kernel test robot
2022-04-18 22:37 ` [PATCH v3 5/8] firmware_loader: Add sysfs nodes to monitor fw_upload Russ Weight
2022-04-18 22:37 ` [PATCH v3 6/8] test_firmware: Add test support for firmware upload Russ Weight
2022-04-18 22:37 ` [PATCH v3 7/8] test_firmware: Error injection " Russ Weight
2022-04-18 22:37 ` [PATCH v3 8/8] selftests: firmware: Add firmware upload selftests Russ Weight
2022-04-19  8:44 ` [PATCH v3 0/8] Extend FW framework for user FW uploads Zhang, Tianfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.