* [Buildroot] [PATCH 1/1] boot/shim: disable on mips64el
@ 2022-04-19 12:14 Fabrice Fontaine
2022-04-19 19:36 ` Thomas Petazzoni via buildroot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2022-04-19 12:14 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Fix the following build failure on mips64el raised since commit
11b347c03ab0b38389ec11b48f63236a3b4d6547:
In file included from shim.h:47,
from shim.c:14:
/nvmedata/autobuild/instance-17/output-1/build/shim-15.4/include/system/stdarg.h:72:2: error: #error what arch is this
72 | #error what arch is this
| ^~~~~
Fixes:
- http://autobuild.buildroot.org/results/74f4f1d010cfde6978fd614195ef0006f0acb45a
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
boot/shim/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/boot/shim/Config.in b/boot/shim/Config.in
index 2f74d6f332..b0e549a51b 100644
--- a/boot/shim/Config.in
+++ b/boot/shim/Config.in
@@ -2,6 +2,7 @@ config BR2_TARGET_SHIM
bool "shim"
# it includes gnu-efi
depends on BR2_PACKAGE_GNU_EFI_ARCH_SUPPORTS
+ depends on !BR2_mips64el
help
Boot loader to chain-load signed boot loaders under Secure
Boot.
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] boot/shim: disable on mips64el
2022-04-19 12:14 [Buildroot] [PATCH 1/1] boot/shim: disable on mips64el Fabrice Fontaine
@ 2022-04-19 19:36 ` Thomas Petazzoni via buildroot
2022-04-19 19:48 ` Peter Korsgaard
2022-05-22 10:29 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-04-19 19:36 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
On Tue, 19 Apr 2022 14:14:09 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the following build failure on mips64el raised since commit
> 11b347c03ab0b38389ec11b48f63236a3b4d6547:
>
> In file included from shim.h:47,
> from shim.c:14:
> /nvmedata/autobuild/instance-17/output-1/build/shim-15.4/include/system/stdarg.h:72:2: error: #error what arch is this
> 72 | #error what arch is this
> | ^~~~~
As usual, I don't like this kind of fixes that consist in simply "let's
disable in the specific case that causes problem". If you look at that
include/system/stdarg.h, you see:
#if defined(__aarch64__) || defined(__arm__) || defined(__i386__) || \
defined(__i486__) || defined(__i686__)
...
#elif defined(__x86_64__)
...
#else
#error what arch is this
#endif
So basically, any architecture other than the ones listed above is
going to raise this build issue, not just mips64el.
Yes, BR2_PACKAGE_GNU_EFI_ARCH_SUPPORTS already disables on most CPU
architectures, but shim also has its own list of CPU architectures it
supports. So we probably want a BR2_TARGET_SHIM_ARCH_SUPPORTS, which
depends on BR2_PACKAGE_GNU_EFI_ARCH_SUPPORTS and then adds an explicit
list of architectures that shim supports.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] boot/shim: disable on mips64el
2022-04-19 12:14 [Buildroot] [PATCH 1/1] boot/shim: disable on mips64el Fabrice Fontaine
2022-04-19 19:36 ` Thomas Petazzoni via buildroot
@ 2022-04-19 19:48 ` Peter Korsgaard
2022-05-22 10:29 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-04-19 19:48 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fix the following build failure on mips64el raised since commit
> 11b347c03ab0b38389ec11b48f63236a3b4d6547:
> In file included from shim.h:47,
> from shim.c:14:
> /nvmedata/autobuild/instance-17/output-1/build/shim-15.4/include/system/stdarg.h:72:2: error: #error what arch is this
> 72 | #error what arch is this
> | ^~~~~
> Fixes:
> - http://autobuild.buildroot.org/results/74f4f1d010cfde6978fd614195ef0006f0acb45a
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] boot/shim: disable on mips64el
2022-04-19 12:14 [Buildroot] [PATCH 1/1] boot/shim: disable on mips64el Fabrice Fontaine
2022-04-19 19:36 ` Thomas Petazzoni via buildroot
2022-04-19 19:48 ` Peter Korsgaard
@ 2022-05-22 10:29 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-05-22 10:29 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fix the following build failure on mips64el raised since commit
> 11b347c03ab0b38389ec11b48f63236a3b4d6547:
> In file included from shim.h:47,
> from shim.c:14:
> /nvmedata/autobuild/instance-17/output-1/build/shim-15.4/include/system/stdarg.h:72:2: error: #error what arch is this
> 72 | #error what arch is this
> | ^~~~~
> Fixes:
> - http://autobuild.buildroot.org/results/74f4f1d010cfde6978fd614195ef0006f0acb45a
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-22 10:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-19 12:14 [Buildroot] [PATCH 1/1] boot/shim: disable on mips64el Fabrice Fontaine
2022-04-19 19:36 ` Thomas Petazzoni via buildroot
2022-04-19 19:48 ` Peter Korsgaard
2022-05-22 10:29 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.