Re: [PATCH ethtool-next] ethtool: netlink: add support to get/set tx push by ethtool -G/g

From: Michal Kubecek <mkubecek@suse.cz>
To: Guangbin Huang <huangguangbin2@huawei.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
	lipeng321@huawei.com
Subject: Re: [PATCH ethtool-next] ethtool: netlink: add support to get/set tx push by ethtool -G/g
Date: Tue, 19 Apr 2022 15:07:02 +0200	[thread overview]
Message-ID: <20220419130702.xlnodeeeycn6jja6@lion.mk-sys.cz> (raw)
In-Reply-To: <20220419125030.3230-1-huangguangbin2@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

On Tue, Apr 19, 2022 at 08:50:30PM +0800, Guangbin Huang wrote:
> From: Jie Wang <wangjie125@huawei.com>
> 
> Currently tx push is a standard feature for NICs such as Mellanox, HNS3.
> But there is no command to set or get this feature.
> 
> So this patch adds support for "ethtool -G <dev> tx-push on|off" and
> "ethtool -g <dev>" to set/get tx push mode.
> 
> Signed-off-by: Jie Wang <wangjie125@huawei.com>
> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
> ---
[...]
> diff --git a/uapi/linux/ethtool_netlink.h b/uapi/linux/ethtool_netlink.h
> index d8b19cf98003..79fe0bf686f3 100644
> --- a/uapi/linux/ethtool_netlink.h
> +++ b/uapi/linux/ethtool_netlink.h
> @@ -330,6 +330,7 @@ enum {
>  	ETHTOOL_A_RINGS_RX_JUMBO,			/* u32 */
>  	ETHTOOL_A_RINGS_TX,				/* u32 */
>  	ETHTOOL_A_RINGS_RX_BUF_LEN,                     /* u32 */
> +	ETHTOOL_A_RINGS_TX_PUSH = 13,			/* u8  */
>  
>  	/* add new constants above here */
>  	__ETHTOOL_A_RINGS_CNT,

Please update the uapi headers from sanitized kernel headers as
described here:

  https://www.kernel.org/pub/software/network/ethtool/devel.html

(the paragraph starting "If you need new or updated definitions..." near
the end of the page).

Michal

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]