Disable duktape with BR2_OPTIMIZE_FAST to fix the following build failure: In file included from content/handlers/javascript/duktape/duktape.h:195, from build/Linux-framebuffer/duktape/application_cache.c:21: content/handlers/javascript/duktape/duk_config.h:2861:2: error: #error __FAST_MATH__ defined, refusing to compile 2861 | #error __FAST_MATH__ defined, refusing to compile | ^~~~~ Fixes: - http://autobuild.buildroot.org/results/2f1b42e2be3aa76cbacd84f3d0ad8b13edce6982 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/netsurf/netsurf.mk | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk index 1064698c12..574c1423df 100644 --- a/package/netsurf/netsurf.mk +++ b/package/netsurf/netsurf.mk @@ -14,6 +14,17 @@ NETSURF_CPE_ID_VENDOR = netsurf-browser NETSURF_DEPENDENCIES = expat jpeg libpng \ host-bison host-flex host-gperf host-pkgconf host-vim +# internal duktape doesn't build with BR2_OPTIMIZE_FAST +ifeq ($(BR2_OPTIMIZE_FAST),y) +define NETSURF_DUKTAPE_CONFIGURE_CMDS + echo "override NETSURF_USE_DUKTAPE := NO" >> $(@D)/netsurf/Makefile.config +endef +else +define NETSURF_DUKTAPE_CONFIGURE_CMDS + echo "override NETSURF_USE_DUKTAPE := YES" >> $(@D)/netsurf/Makefile.config +endef +endif + ifeq ($(BR2_PACKAGE_NETSURF_GTK),y) NETSURF_DEPENDENCIES += libgtk2 NETSURF_FRONTEND = gtk2 @@ -77,6 +88,7 @@ endef endif define NETSURF_CONFIGURE_CMDS + $(NETSURF_DUKTAPE_CONFIGURE_CMDS) $(NETSURF_ICONV_CONFIGURE_CMDS) $(NETSURF_SVG_CONFIGURE_CMDS) $(NETSURF_FONTLIB_CONFIGURE_CMDS) -- 2.35.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot
Use HOSTCC_NOCCACHE instead of HOSTCC to fix the following build failure: /home/autobuild/autobuild/instance-11/output-1/build/netsurf-3.10/tmpusr/share/netsurf-buildsystem/makefiles/Makefile.tools:413: *** Unable to detect toolchain. Stop. Fixes: - http://autobuild.buildroot.org/results/b4ba19d7dcff1b0ee2b1546598b5ae6e9257a16d Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/netsurf/netsurf.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk index 574c1423df..b61372bb78 100644 --- a/package/netsurf/netsurf.mk +++ b/package/netsurf/netsurf.mk @@ -106,7 +106,7 @@ NETSURF_MAKE_OPTS = \ BISON="$(HOST_DIR)/bin/bison" \ FLEX="$(HOST_DIR)/bin/flex" \ PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \ - BUILD_CC="$(HOSTCC)" \ + BUILD_CC="$(HOSTCC_NOCCACHE)" \ CC="$(TARGET_CC)" \ AR="$(TARGET_AR)" \ TMP_PREFIX=$(@D)/tmpusr \ -- 2.35.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot
On 19/04/2022 15:28, Fabrice Fontaine wrote: > Use HOSTCC_NOCCACHE instead of HOSTCC to fix the following build Rather than this workaround, let's fix the real issue. The offending code is (I think, untested): $(MAKE) install --directory=$1 HOST=$(BUILD) CC=$(BUILD_CC) ... in top-level Makefile. Since BUILD_CC may contain spaces, this is going to be parsed incorrectly by the shell. Just adding quotes should be enough. Regards, Arnout > failure: > > /home/autobuild/autobuild/instance-11/output-1/build/netsurf-3.10/tmpusr/share/netsurf-buildsystem/makefiles/Makefile.tools:413: *** Unable to detect toolchain. Stop. > > Fixes: > - http://autobuild.buildroot.org/results/b4ba19d7dcff1b0ee2b1546598b5ae6e9257a16d > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/netsurf/netsurf.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk > index 574c1423df..b61372bb78 100644 > --- a/package/netsurf/netsurf.mk > +++ b/package/netsurf/netsurf.mk > @@ -106,7 +106,7 @@ NETSURF_MAKE_OPTS = \ > BISON="$(HOST_DIR)/bin/bison" \ > FLEX="$(HOST_DIR)/bin/flex" \ > PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \ > - BUILD_CC="$(HOSTCC)" \ > + BUILD_CC="$(HOSTCC_NOCCACHE)" \ > CC="$(TARGET_CC)" \ > AR="$(TARGET_AR)" \ > TMP_PREFIX=$(@D)/tmpusr \ _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot