From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C93BC433FE for ; Tue, 19 Apr 2022 13:29:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243834AbiDSNbm (ORCPT ); Tue, 19 Apr 2022 09:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243736AbiDSNbk (ORCPT ); Tue, 19 Apr 2022 09:31:40 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8550D21E1C; Tue, 19 Apr 2022 06:28:58 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id e62-20020a17090a6fc400b001d2cd8e9b0aso1750331pjk.5; Tue, 19 Apr 2022 06:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Gt27EbYhS9qJA9bFo3ES5TQ+M3mPhDrTTHCzoFmARGI=; b=TTITMF5ldzsjryyA1haYULWZJcPqXxNnxjg6fUuS4q+E+uNztjSeFm4paslPCdU0jl igaZQz3FSbN5pJAn9HDmXgRFlNZHLb7pdQuVaiNzCkYJXMPPsTRvlrURIrhIy4f2Mr61 maW3029xdqGfPgmZ5lPQqeUuxy+01b5JPdF0imZ5Vtbf781uDccF3xvUaS99bZ7AUCCr +5765Eq6OP5kSX1kgpjCdDsWztWt3dv2nBq5DJvkqmCpEeNM+w794/gYgait+tSTggE5 DyuMiwtz7R0IGqma+H+kPPu6ebQl68B75LB2iXtNSR8TsiBiRqSqAdwDvcr/B+S1S3W2 TFSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Gt27EbYhS9qJA9bFo3ES5TQ+M3mPhDrTTHCzoFmARGI=; b=VBEsezcnYj1oKLCX9opKyyddhcottZx5nud5ObYr8VbXwWJS+r++RwKZ9znZg6oFRI nOqFpjYUUavXE6mlJTF4rf7c9CW9VS0wXJasOMhYrJBODgssocechRLojiApuFQYzvH2 ObJooPlqeUzZ+syaJwt+sz1W/yEaTBTNtCHbbglp1cK4/AntRdVLlFcViuum2mUisFpy GJLRUkAgDFlQ3CLIMy8majO7qYsfR88DNz8MTL4U6coRjtkGT1z0SZ5ULl0bzLd1mSSu wezlp5Gp4+ox8VRkBDjVCYVi81nnGLv8EKJe0qSKVzik3QnfFRnC0bbiKSIQShxjxGXi RZJg== X-Gm-Message-State: AOAM530uSFAb/LU/GxwRk082tF5Ob7wXsqtLUnN+muFGPIhShwE4zRHM Cacq7lJaIUWBtzKiX9SohQ0= X-Google-Smtp-Source: ABdhPJy6cH5/4e6XZZ4pT4pDqRzujdx8zF5e9ofQmq+fjlHAC4ig/75jn3fViJjD1vhmejDhoMsn2g== X-Received: by 2002:a17:902:8483:b0:158:f833:b7a4 with SMTP id c3-20020a170902848300b00158f833b7a4mr10702309plo.100.1650374938037; Tue, 19 Apr 2022 06:28:58 -0700 (PDT) Received: from hoboy.vegasvil.org ([2601:640:8200:33:e2d5:5eff:fea5:802f]) by smtp.gmail.com with ESMTPSA id j16-20020a634a50000000b003a82190a495sm10071714pgl.62.2022.04.19.06.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 06:28:56 -0700 (PDT) Date: Tue, 19 Apr 2022 06:28:53 -0700 From: Richard Cochran To: Tan Tee Min Cc: Jakub Kicinski , Tan Tee Min , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Paolo Abeni , Maxime Coquelin , Rayagond Kokatanur , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Voon Wei Feng , Wong Vee Khee , Song Yoong Siang , Alexandre Torgue Subject: Re: [PATCH net 1/1] net: stmmac: add fsleep() in HW Rx timestamp checking loop Message-ID: <20220419132853.GA19386@hoboy.vegasvil.org> References: <20220413040115.2351987-1-tee.min.tan@intel.com> <20220413125915.GA667752@hoboy.vegasvil.org> <20220414072934.GA10025@linux.intel.com> <20220414104259.0b928249@kernel.org> <20220419005220.GA17634@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220419005220.GA17634@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2022 at 08:52:20AM +0800, Tan Tee Min wrote: > I agree that the fsleep(1) (=1us) is a big hammer. > Thus in order to improve this, I’ve figured out a smaller delay > time that is enough for the context descriptor to be ready which > is ndelay(500) (=500ns). Why isn't the context descriptor ready? I mean, the frame already belongs to the CPU, right? Thanks, Richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 727EFC433EF for ; Tue, 19 Apr 2022 14:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bs3dDDNCk0QSVT11imN150YmIRJLYDjO7evX2filJ6o=; b=hHZvOHT3yYDPBC yYrgBS6i0/sKJ7wH3dNa7r/4VGAFRqj3zeB9qYb8jsHMH35NXn61UH667zJHpH5ZIISEfUjIA7Kss v2aQvRBzUFyYh3lNqrzyjBzMm7dR23RyC7ThzSZdsuqy0ZP68iIw/kyAp8A5kXWrnFlfza5KuLlpF 8lAIwLywOjG2dFuxjKzgpBnInCv0QpMzhPz9x8HkFdTwPS4XAOWrMqrHQIgbCZ9JK17X/aU37qQDu 83mcGJe3B7zOOfoBKSsrR7xo3/1fJ5XUSkUi3GPDtd2qUu7F7V3+ZbFnRGxNoyB/57UGdhLSxbVbq b+UfSyBS/t6A16N3F/Uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngoOg-00454R-2z; Tue, 19 Apr 2022 14:00:03 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngnuf-003qYS-Rk for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2022 13:29:03 +0000 Received: by mail-pj1-x1035.google.com with SMTP id n33-20020a17090a5aa400b001d28f5ee3f9so1862829pji.4 for ; Tue, 19 Apr 2022 06:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Gt27EbYhS9qJA9bFo3ES5TQ+M3mPhDrTTHCzoFmARGI=; b=TTITMF5ldzsjryyA1haYULWZJcPqXxNnxjg6fUuS4q+E+uNztjSeFm4paslPCdU0jl igaZQz3FSbN5pJAn9HDmXgRFlNZHLb7pdQuVaiNzCkYJXMPPsTRvlrURIrhIy4f2Mr61 maW3029xdqGfPgmZ5lPQqeUuxy+01b5JPdF0imZ5Vtbf781uDccF3xvUaS99bZ7AUCCr +5765Eq6OP5kSX1kgpjCdDsWztWt3dv2nBq5DJvkqmCpEeNM+w794/gYgait+tSTggE5 DyuMiwtz7R0IGqma+H+kPPu6ebQl68B75LB2iXtNSR8TsiBiRqSqAdwDvcr/B+S1S3W2 TFSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Gt27EbYhS9qJA9bFo3ES5TQ+M3mPhDrTTHCzoFmARGI=; b=oJ2NSES/+mHXE63FmkK5q4+75NqdsYdkv+pGsqY0BJgudx3zv+20XcD+pz5hSuNENa Xx143yjWGjU6sLxTPpLKGl2LhfUZ98UYH74MyP0FHgLTxqGLUj/LXUL3JbWJ4NiuVbsA ExF9E+0R+qbUS5LknZD74hnI1uEILGHvLNSW5HKjjWVK0xqmkyaiHWd62gn1mF0zNwKT HWiSGuQkO/7ZyIYsAw0S0WmjigPsAYaBqoEIeJ7XhTSS781EdFFGZxJbQH7D9+ZUw2W/ 8AijWqARuoAcbWt8hLW33yJu13Z6IsntOGg6XIxCgzWr1KAZeKwmcJM0/siPgdtiEE6s TEhg== X-Gm-Message-State: AOAM532mtf05bWsEJjEVApgVPEoJfboVdhpyhfYcNe4fyJHnwcZVg/tJ T+4rytjoksdsj5fgcNFFuUA= X-Google-Smtp-Source: ABdhPJy6cH5/4e6XZZ4pT4pDqRzujdx8zF5e9ofQmq+fjlHAC4ig/75jn3fViJjD1vhmejDhoMsn2g== X-Received: by 2002:a17:902:8483:b0:158:f833:b7a4 with SMTP id c3-20020a170902848300b00158f833b7a4mr10702309plo.100.1650374938037; Tue, 19 Apr 2022 06:28:58 -0700 (PDT) Received: from hoboy.vegasvil.org ([2601:640:8200:33:e2d5:5eff:fea5:802f]) by smtp.gmail.com with ESMTPSA id j16-20020a634a50000000b003a82190a495sm10071714pgl.62.2022.04.19.06.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 06:28:56 -0700 (PDT) Date: Tue, 19 Apr 2022 06:28:53 -0700 From: Richard Cochran To: Tan Tee Min Cc: Jakub Kicinski , Tan Tee Min , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Paolo Abeni , Maxime Coquelin , Rayagond Kokatanur , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Voon Wei Feng , Wong Vee Khee , Song Yoong Siang , Alexandre Torgue Subject: Re: [PATCH net 1/1] net: stmmac: add fsleep() in HW Rx timestamp checking loop Message-ID: <20220419132853.GA19386@hoboy.vegasvil.org> References: <20220413040115.2351987-1-tee.min.tan@intel.com> <20220413125915.GA667752@hoboy.vegasvil.org> <20220414072934.GA10025@linux.intel.com> <20220414104259.0b928249@kernel.org> <20220419005220.GA17634@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220419005220.GA17634@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_062901_969202_A164D427 X-CRM114-Status: GOOD ( 10.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMTksIDIwMjIgYXQgMDg6NTI6MjBBTSArMDgwMCwgVGFuIFRlZSBNaW4gd3Jv dGU6Cgo+IEkgYWdyZWUgdGhhdCB0aGUgZnNsZWVwKDEpICg9MXVzKSBpcyBhIGJpZyBoYW1tZXIu Cj4gVGh1cyBpbiBvcmRlciB0byBpbXByb3ZlIHRoaXMsIEnigJl2ZSBmaWd1cmVkIG91dCBhIHNt YWxsZXIgZGVsYXkKPiB0aW1lIHRoYXQgaXMgZW5vdWdoIGZvciB0aGUgY29udGV4dCBkZXNjcmlw dG9yIHRvIGJlIHJlYWR5IHdoaWNoCj4gaXMgbmRlbGF5KDUwMCkgKD01MDBucykuCgpXaHkgaXNu J3QgdGhlIGNvbnRleHQgZGVzY3JpcHRvciByZWFkeT8KCkkgbWVhbiwgdGhlIGZyYW1lIGFscmVh ZHkgYmVsb25ncyB0byB0aGUgQ1BVLCByaWdodD8KClRoYW5rcywKUmljaGFyZAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=