From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CD97A for ; Tue, 19 Apr 2022 14:02:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58788C385A5; Tue, 19 Apr 2022 14:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650376946; bh=sqRutsWahsHt6cigK4f/6dAwTpOvdRR3j3VJDDTTT3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PPiHCRBR9A9r8gkTiMDE9GS5JlTwXlsgUBFVeqIOEtI8jBZ4oIBvIBp/JbFgzZ2aa TlozkkqcyWXZ3jr15aantTnmLnT/WnbUP3V6VhJjkKefqI3AuT8RBBfJsDxzpRZnYR F11TJty84zVoGOS+vQQEp56xcNl17IycDPLg6aMR6oQh2XDzK0gIURJcZyGfMVb273 1NROG81D5OFReoDGTY6ABBkYJtIAqnIultYyRlVzv9lLohlWVylJjsBLVlflUS/vjI SULfyiwUp5/LyXYTuyKu5h2h9g/strGps6Re0o4JRL9Y+65GmKeUeBHRYBT9dhCnLS O+NSdOZ2t5XMg== Date: Tue, 19 Apr 2022 16:02:20 +0200 From: Christian Brauner To: Yang Xu Cc: linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, viro@zeniv.linux.org.uk, david@fromorbit.com, djwong@kernel.org, jlayton@kernel.org, ntfs3@lists.linux.dev, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v4 5/8] f2fs: Remove useless NULL assign value for acl and default_acl Message-ID: <20220419140220.bfziilnj47vdgsef@wittgenstein> References: <1650368834-2420-1-git-send-email-xuyang2018.jy@fujitsu.com> <1650368834-2420-5-git-send-email-xuyang2018.jy@fujitsu.com> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1650368834-2420-5-git-send-email-xuyang2018.jy@fujitsu.com> On Tue, Apr 19, 2022 at 07:47:11PM +0800, Yang Xu wrote: > Like other use ${fs}_init_acl and posix_acl_create filesystem, we don't > need to assign NULL for acl and default_acl pointer because f2fs_acl_create > will do this job. So remove it. > > Signed-off-by: Yang Xu > --- > fs/f2fs/acl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c > index eaa240b21f07..9ae2d2fec58b 100644 > --- a/fs/f2fs/acl.c > +++ b/fs/f2fs/acl.c > @@ -412,7 +412,7 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode, > int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage, > struct page *dpage) > { > - struct posix_acl *default_acl = NULL, *acl = NULL; > + struct posix_acl *default_acl, *acl; Hm, patches like this have nothing to do with the theme of this patch series. They can go as completely independent patches to the relevant fses. Imho, they don't belong with this series at all. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6731C433EF for ; Tue, 19 Apr 2022 14:02:42 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1ngoRE-0000SN-6W; Tue, 19 Apr 2022 14:02:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ngoRD-0000SB-Ab for linux-f2fs-devel@lists.sourceforge.net; Tue, 19 Apr 2022 14:02:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hUa6elZetNNxbm0IThTr2fT4SGK51SdOhCAt7KyfOs4=; b=W8WA+1t8EQZDxptr8x5hhZqcku Q+acB6sEkZGChIiLBW0jcks3Le/4ooj7vakou/BUs4nrKo5bnNwLLtwfNhYYCtUphU7w8w52tqglz dXNy5x5ghCBedDzUXGgVbh2Nhco8aGiCO2n4FJu8zUSL5soTvTMjVCEJIwoSvoJCpDqU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hUa6elZetNNxbm0IThTr2fT4SGK51SdOhCAt7KyfOs4=; b=d+3fMQsiGvYPm+D1Gq7dPoVT+a zZ3ghxFyD8NVhUiQt8M7oskRaTS1Y+ALUVhaPfMAsYQUgsXHQkDHRa2stH3hG5X4XArGKZ7lXBMZ1 miPtK+tV7c6850N6x3VH88c6BvKO8A5fdHjGCDKvzdxYeQnyHIuWI8lIMJe/cr61l8kY=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1ngoR7-00035H-RD for linux-f2fs-devel@lists.sourceforge.net; Tue, 19 Apr 2022 14:02:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 882C0616C3; Tue, 19 Apr 2022 14:02:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58788C385A5; Tue, 19 Apr 2022 14:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650376946; bh=sqRutsWahsHt6cigK4f/6dAwTpOvdRR3j3VJDDTTT3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PPiHCRBR9A9r8gkTiMDE9GS5JlTwXlsgUBFVeqIOEtI8jBZ4oIBvIBp/JbFgzZ2aa TlozkkqcyWXZ3jr15aantTnmLnT/WnbUP3V6VhJjkKefqI3AuT8RBBfJsDxzpRZnYR F11TJty84zVoGOS+vQQEp56xcNl17IycDPLg6aMR6oQh2XDzK0gIURJcZyGfMVb273 1NROG81D5OFReoDGTY6ABBkYJtIAqnIultYyRlVzv9lLohlWVylJjsBLVlflUS/vjI SULfyiwUp5/LyXYTuyKu5h2h9g/strGps6Re0o4JRL9Y+65GmKeUeBHRYBT9dhCnLS O+NSdOZ2t5XMg== Date: Tue, 19 Apr 2022 16:02:20 +0200 From: Christian Brauner To: Yang Xu Message-ID: <20220419140220.bfziilnj47vdgsef@wittgenstein> References: <1650368834-2420-1-git-send-email-xuyang2018.jy@fujitsu.com> <1650368834-2420-5-git-send-email-xuyang2018.jy@fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1650368834-2420-5-git-send-email-xuyang2018.jy@fujitsu.com> X-Headers-End: 1ngoR7-00035H-RD Subject: Re: [f2fs-dev] [PATCH v4 5/8] f2fs: Remove useless NULL assign value for acl and default_acl X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nfs@vger.kernel.org, djwong@kernel.org, david@fromorbit.com, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, jlayton@kernel.org, ceph-devel@vger.kernel.org, ntfs3@lists.linux.dev Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Apr 19, 2022 at 07:47:11PM +0800, Yang Xu wrote: > Like other use ${fs}_init_acl and posix_acl_create filesystem, we don't > need to assign NULL for acl and default_acl pointer because f2fs_acl_create > will do this job. So remove it. > > Signed-off-by: Yang Xu > --- > fs/f2fs/acl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c > index eaa240b21f07..9ae2d2fec58b 100644 > --- a/fs/f2fs/acl.c > +++ b/fs/f2fs/acl.c > @@ -412,7 +412,7 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode, > int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage, > struct page *dpage) > { > - struct posix_acl *default_acl = NULL, *acl = NULL; > + struct posix_acl *default_acl, *acl; Hm, patches like this have nothing to do with the theme of this patch series. They can go as completely independent patches to the relevant fses. Imho, they don't belong with this series at all. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel