From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 149E5C433EF for ; Tue, 19 Apr 2022 15:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353802AbiDSP2Y (ORCPT ); Tue, 19 Apr 2022 11:28:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354260AbiDSP2S (ORCPT ); Tue, 19 Apr 2022 11:28:18 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E9ABDEDD; Tue, 19 Apr 2022 08:25:34 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 59F30FF80D; Tue, 19 Apr 2022 15:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650381932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bq9PeeGKcHRkxdXVgUr01rmzSL3+CeljQ3EucZX0P7Y=; b=D5GBhDkyZrK5yvyrOhTnlTFai3nybJgtqeJ4Btz8MX+iAYbIB8QguBUEXby9NcFEsox2Ay nEBVao0mKpzibIZwXRjI+fegNSQSw7yP0VTNq2TEF9zGIcyMj40seUL5zSgEDw6yP0fImV lJF05G0KenAPpCFxgqJkSYhSYBiG/PZ/bVpCHQ4t0OlvyMid9HQRfk/ROI9Kgcj6DyTUMD xvSthEuLiZuwLSoV+spy5qdHex3A5uN+vsMGrjnOmyQmI94UOSi1NIfHY47bk0U1gnoFxS +z+RfEv5dQrJmZydxKRtn5ikkNVGrQpVuMaMw2rcPP/XoxZz0Iya3GbS7msmUg== Date: Tue, 19 Apr 2022 17:25:28 +0200 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220419172528.2dd75e7b@xps13> In-Reply-To: <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> <20220419102629.1c77aa2a@xps13> <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, liang.yang@amlogic.com wrote on Tue, 19 Apr 2022 17:17:48 +0800: > Hello Miquel, >=20 > On 2022/4/19 16:26, Miquel Raynal wrote: > > [ EXTERNAL EMAIL ] > >=20 > > Hello, > >=20 > > liang.yang@amlogic.com wrote on Mon, 18 Apr 2022 11:40:10 +0800: > > =20 > >> Hi Miquel, > >> > >> i have some confusion when i prepare the patches. for DT compatibility= , it falls back to the old DT when failed to get resource by the new DT, bu= t there is some points: > >> a. old DT depends on MMC sub clock driver, but it never be merged, so = it can't work. =20 > >=20 > > I don't get what you mean here, sorry. I believe there is a new way to > > describe this clock but grabbing the one from the MMC still works, does > > not it? > > =20 >=20 > No, it doesn't. after the NFC driver using the MMC sub clock framework wa= s merged into the mainline of kernel, we didn't continue to submit the seri= es of patches about MMC sub clock after v9. when i found that, we made a di= scussion to decide whether to recover the series of patches about MMC sub c= lock framework, finally, see the description from cover letter, we plan to = abandon it and adopt the new clock scheme in this series of patches. I am not sure to follow. Is the current code completely broken? I believe it is not, so I don't understand your issue. Can you please summarize the situation? >=20 > Thanks. >=20 > >> b. if it falls back to the old DT, beside the regmap lookup below, it = seems that we have to preserve the code of the old clock setting in nfc_clk= _init(). =20 > >=20 > > Yes, probably. > > =20 > >> do we still need to avoid break DT compatibility? =20 > >=20 > > We should try our best to avoid breaking the DT, yes. > > =20 > >> > >> Thanks. > >> > >> On 2022/4/11 10:40, Liang Yang wrote: =20 > >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 nfc->dev =3D dev; > >>>>> -=C2=A0=C2=A0=C2=A0 res =3D platform_get_resource(pdev, IORESOURCE_= MEM, 0); > >>>>> -=C2=A0=C2=A0=C2=A0 nfc->reg_base =3D devm_ioremap_resource(dev, re= s); > >>>>> +=C2=A0=C2=A0=C2=A0 nfc->reg_base =3D devm_platform_ioremap_resourc= e_byname(pdev, "nfc"); =20 > >>>> > >>>> This change seems unrelated. =20 > >>> > >>> To be consistent with the following > devm_platform_ioremap_resource_= byname(pdev, "emmc"). do you mean that we > don't need it?> =20 > >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (IS_ERR(nfc->reg_base)) > >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return PTR_= ERR(nfc->reg_base); > >>>>> -=C2=A0=C2=A0=C2=A0 nfc->reg_clk =3D > >>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 syscon_regmap_lookup_by= _phandle(dev->of_node, > >>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "a= mlogic,mmc-syscon"); > >>>>> -=C2=A0=C2=A0=C2=A0 if (IS_ERR(nfc->reg_clk)) { > >>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dev_err(dev, "Failed to= lookup clock base\n"); > >>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return PTR_ERR(nfc->reg= _clk); > >>>>> -=C2=A0=C2=A0=C2=A0 } > >>>>> +=C2=A0=C2=A0=C2=A0 nfc->sd_emmc_clock =3D devm_platform_ioremap_re= source_byname(pdev, >>> "emmc"); > >>>>> +=C2=A0=C2=A0=C2=A0 if (IS_ERR(nfc->sd_emmc_clock)) > >>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return PTR_ERR(nfc->sd_= emmc_clock); =20 > >>>> > >>>> While I agree this is much better than the previous solution, we can= not > >>>> break DT compatibility, so you need to try getting the emmc clock, b= ut > >>>> if it fails you should fallback to the regmap lookup. =20 > >>> > >>> ok, i will fix it next version. thanks. =20 > >>> >>>> >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 irq =3D platform_get_= irq(pdev, 0); =20 > >=20 > >=20 > > Thanks, > > Miqu=C3=A8l > >=20 > > . =20 Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E424AC433EF for ; Tue, 19 Apr 2022 15:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fRsUBO2irSDfcAnSbjA+w1TTCLr5SLlT00pk7pdaFGc=; b=kZ2Lkjq2a5XbPx e8mvScjbuaPDYLSbPRXCDIUDsaNVQRGcZmM+IKJJ4rcS00BPIbSNcHzzD5NEbvIUMGwuN+Oinpro0 O6nETA78EzIdLrEgwuX1eVGx0QGScTHERHMuJS1b2KpzJyiGpHFXaTCNiVOuj1pn9mm8JsnZOaB4D 3//rLwz8QM5Rth7IvdTFys+Iyj3UMT0kw+bv8lbawVZAbPM+0k9KKMRv/0dXHGBAdDVUZB4EIP4TG W2Sty+xUbWpe2U9TjTGr9Gb7pRQ6FBfzDz5+Iyih2BrKKvpTr6+FsSIfYkntw0Ph+4B3LvEJEh8kj xzuV5LnhCY/Dl40FT36A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngpy2-004k4I-M1; Tue, 19 Apr 2022 15:40:38 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngpjW-004dIV-2q; Tue, 19 Apr 2022 15:25:40 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 59F30FF80D; Tue, 19 Apr 2022 15:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650381932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bq9PeeGKcHRkxdXVgUr01rmzSL3+CeljQ3EucZX0P7Y=; b=D5GBhDkyZrK5yvyrOhTnlTFai3nybJgtqeJ4Btz8MX+iAYbIB8QguBUEXby9NcFEsox2Ay nEBVao0mKpzibIZwXRjI+fegNSQSw7yP0VTNq2TEF9zGIcyMj40seUL5zSgEDw6yP0fImV lJF05G0KenAPpCFxgqJkSYhSYBiG/PZ/bVpCHQ4t0OlvyMid9HQRfk/ROI9Kgcj6DyTUMD xvSthEuLiZuwLSoV+spy5qdHex3A5uN+vsMGrjnOmyQmI94UOSi1NIfHY47bk0U1gnoFxS +z+RfEv5dQrJmZydxKRtn5ikkNVGrQpVuMaMw2rcPP/XoxZz0Iya3GbS7msmUg== Date: Tue, 19 Apr 2022 17:25:28 +0200 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220419172528.2dd75e7b@xps13> In-Reply-To: <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> <20220419102629.1c77aa2a@xps13> <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_082538_501216_AB2181F0 X-CRM114-Status: GOOD ( 28.16 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIFR1ZSwgMTkgQXByIDIwMjIg MTc6MTc6NDggKzA4MDA6Cgo+IEhlbGxvIE1pcXVlbCwKPiAKPiBPbiAyMDIyLzQvMTkgMTY6MjYs IE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBbIEVYVEVSTkFMIEVNQUlMIF0KPiA+IAo+ID4gSGVs bG8sCj4gPiAKPiA+IGxpYW5nLnlhbmdAYW1sb2dpYy5jb20gd3JvdGUgb24gTW9uLCAxOCBBcHIg MjAyMiAxMTo0MDoxMCArMDgwMDoKPiA+ICAgCj4gPj4gSGkgTWlxdWVsLAo+ID4+Cj4gPj4gaSBo YXZlIHNvbWUgY29uZnVzaW9uIHdoZW4gaSBwcmVwYXJlIHRoZSBwYXRjaGVzLiBmb3IgRFQgY29t cGF0aWJpbGl0eSwgaXQgZmFsbHMgYmFjayB0byB0aGUgb2xkIERUIHdoZW4gZmFpbGVkIHRvIGdl dCByZXNvdXJjZSBieSB0aGUgbmV3IERULCBidXQgdGhlcmUgaXMgc29tZSBwb2ludHM6Cj4gPj4g YS4gb2xkIERUIGRlcGVuZHMgb24gTU1DIHN1YiBjbG9jayBkcml2ZXIsIGJ1dCBpdCBuZXZlciBi ZSBtZXJnZWQsIHNvIGl0IGNhbid0IHdvcmsuICAKPiA+IAo+ID4gSSBkb24ndCBnZXQgd2hhdCB5 b3UgbWVhbiBoZXJlLCBzb3JyeS4gSSBiZWxpZXZlIHRoZXJlIGlzIGEgbmV3IHdheSB0bwo+ID4g ZGVzY3JpYmUgdGhpcyBjbG9jayBidXQgZ3JhYmJpbmcgdGhlIG9uZSBmcm9tIHRoZSBNTUMgc3Rp bGwgd29ya3MsIGRvZXMKPiA+IG5vdCBpdD8KPiA+ICAgCj4gCj4gTm8sIGl0IGRvZXNuJ3QuIGFm dGVyIHRoZSBORkMgZHJpdmVyIHVzaW5nIHRoZSBNTUMgc3ViIGNsb2NrIGZyYW1ld29yayB3YXMg bWVyZ2VkIGludG8gdGhlIG1haW5saW5lIG9mIGtlcm5lbCwgd2UgZGlkbid0IGNvbnRpbnVlIHRv IHN1Ym1pdCB0aGUgc2VyaWVzIG9mIHBhdGNoZXMgYWJvdXQgTU1DIHN1YiBjbG9jayBhZnRlciB2 OS4gd2hlbiBpIGZvdW5kIHRoYXQsIHdlIG1hZGUgYSBkaXNjdXNzaW9uIHRvIGRlY2lkZSB3aGV0 aGVyIHRvIHJlY292ZXIgdGhlIHNlcmllcyBvZiBwYXRjaGVzIGFib3V0IE1NQyBzdWIgY2xvY2sg ZnJhbWV3b3JrLCBmaW5hbGx5LCBzZWUgdGhlIGRlc2NyaXB0aW9uIGZyb20gY292ZXIgbGV0dGVy LCB3ZSBwbGFuIHRvIGFiYW5kb24gaXQgYW5kIGFkb3B0IHRoZSBuZXcgY2xvY2sgc2NoZW1lIGlu IHRoaXMgc2VyaWVzIG9mIHBhdGNoZXMuCgpJIGFtIG5vdCBzdXJlIHRvIGZvbGxvdy4gSXMgdGhl IGN1cnJlbnQgY29kZSBjb21wbGV0ZWx5IGJyb2tlbj8gSQpiZWxpZXZlIGl0IGlzIG5vdCwgc28g SSBkb24ndCB1bmRlcnN0YW5kIHlvdXIgaXNzdWUuCgpDYW4geW91IHBsZWFzZSBzdW1tYXJpemUg dGhlIHNpdHVhdGlvbj8KCj4gCj4gVGhhbmtzLgo+IAo+ID4+IGIuIGlmIGl0IGZhbGxzIGJhY2sg dG8gdGhlIG9sZCBEVCwgYmVzaWRlIHRoZSByZWdtYXAgbG9va3VwIGJlbG93LCBpdCBzZWVtcyB0 aGF0IHdlIGhhdmUgdG8gcHJlc2VydmUgdGhlIGNvZGUgb2YgdGhlIG9sZCBjbG9jayBzZXR0aW5n IGluIG5mY19jbGtfaW5pdCgpLiAgCj4gPiAKPiA+IFllcywgcHJvYmFibHkuCj4gPiAgIAo+ID4+ IGRvIHdlIHN0aWxsIG5lZWQgdG8gYXZvaWQgYnJlYWsgRFQgY29tcGF0aWJpbGl0eT8gIAo+ID4g Cj4gPiBXZSBzaG91bGQgdHJ5IG91ciBiZXN0IHRvIGF2b2lkIGJyZWFraW5nIHRoZSBEVCwgeWVz Lgo+ID4gICAKPiA+Pgo+ID4+IFRoYW5rcy4KPiA+Pgo+ID4+IE9uIDIwMjIvNC8xMSAxMDo0MCwg TGlhbmcgWWFuZyB3cm90ZTogIAo+ID4+Pj4+ICDCoMKgwqDCoMKgIG5mYy0+ZGV2ID0gZGV2Owo+ ID4+Pj4+IC3CoMKgwqAgcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VS Q0VfTUVNLCAwKTsKPiA+Pj4+PiAtwqDCoMKgIG5mYy0+cmVnX2Jhc2UgPSBkZXZtX2lvcmVtYXBf cmVzb3VyY2UoZGV2LCByZXMpOwo+ID4+Pj4+ICvCoMKgwqAgbmZjLT5yZWdfYmFzZSA9IGRldm1f cGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZV9ieW5hbWUocGRldiwgIm5mYyIpOyAgCj4gPj4+Pgo+ ID4+Pj4gVGhpcyBjaGFuZ2Ugc2VlbXMgdW5yZWxhdGVkLiAgCj4gPj4+Cj4gPj4+IFRvIGJlIGNv bnNpc3RlbnQgd2l0aCB0aGUgZm9sbG93aW5nID4gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291 cmNlX2J5bmFtZShwZGV2LCAiZW1tYyIpLiBkbyB5b3UgbWVhbiB0aGF0IHdlID4gZG9uJ3QgbmVl ZCBpdD8+ICAKPiA+Pj4+PiAgwqDCoMKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2Jhc2UpKQo+ ID4+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfYmFzZSk7 Cj4gPj4+Pj4gLcKgwqDCoCBuZmMtPnJlZ19jbGsgPQo+ID4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBz eXNjb25fcmVnbWFwX2xvb2t1cF9ieV9waGFuZGxlKGRldi0+b2Zfbm9kZSwKPiA+Pj4+PiAtwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiYW1sb2dpYyxtbWMt c3lzY29uIik7Cj4gPj4+Pj4gLcKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2NsaykpIHsKPiA+ Pj4+PiAtwqDCoMKgwqDCoMKgwqAgZGV2X2VycihkZXYsICJGYWlsZWQgdG8gbG9va3VwIGNsb2Nr IGJhc2VcbiIpOwo+ID4+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXR1cm4gUFRSX0VSUihuZmMtPnJl Z19jbGspOwo+ID4+Pj4+IC3CoMKgwqAgfQo+ID4+Pj4+ICvCoMKgwqAgbmZjLT5zZF9lbW1jX2Ns b2NrID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCA+Pj4gImVt bWMiKTsKPiA+Pj4+PiArwqDCoMKgIGlmIChJU19FUlIobmZjLT5zZF9lbW1jX2Nsb2NrKSkKPiA+ Pj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5zZF9lbW1jX2Nsb2NrKTsg IAo+ID4+Pj4KPiA+Pj4+IFdoaWxlIEkgYWdyZWUgdGhpcyBpcyBtdWNoIGJldHRlciB0aGFuIHRo ZSBwcmV2aW91cyBzb2x1dGlvbiwgd2UgY2Fubm90Cj4gPj4+PiBicmVhayBEVCBjb21wYXRpYmls aXR5LCBzbyB5b3UgbmVlZCB0byB0cnkgZ2V0dGluZyB0aGUgZW1tYyBjbG9jaywgYnV0Cj4gPj4+ PiBpZiBpdCBmYWlscyB5b3Ugc2hvdWxkIGZhbGxiYWNrIHRvIHRoZSByZWdtYXAgbG9va3VwLiAg Cj4gPj4+Cj4gPj4+IG9rLCBpIHdpbGwgZml4IGl0IG5leHQgdmVyc2lvbi4gdGhhbmtzLiAgCj4g Pj4+ICAgID4+Pj4gICA+Pj4+PiAgwqDCoMKgwqDCoCBpcnEgPSBwbGF0Zm9ybV9nZXRfaXJxKHBk ZXYsIDApOyAgCj4gPiAKPiA+IAo+ID4gVGhhbmtzLAo+ID4gTWlxdcOobAo+ID4gCj4gPiAuICAK CgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFtbG9naWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0907C433F5 for ; Tue, 19 Apr 2022 15:41:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ngUlK4rkMqFqqpaCJZ42Eg4eedQ/mtVKN0ZTlkmw1/o=; b=q/DKsG8y2qtEvf MlTDM1z84KAMt9nEfJtWtyt8ZlfD4KS7GKceDZmKMM1EoMoFiVTh8Pg3LPrzNs1nh6nZACgc5QXNB 7AdpxVeALsomxMlXKOgCvQmyt+4aRaecvzdM4qhqFnoMdrWsCFV4xf+/VKwIyE7wcQyzXjgtm5ZHw HRQF9KxXG8sZ76/bdXWgOpjy1lJ1lpziF7CLPl698Fto/2tIaRe3qJMSWxKWriuoOB2iEE7EWIh4H l+0Gv8FH3y+Ua0ZfdNmAW/ghnioCGdtZJYExYRXNwvw+nXPa55xKQ01N+xCzbBnvBP5l4I9TT5lOZ /0DbjPhj8tmNazJvjO1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngpye-004kLt-SV; Tue, 19 Apr 2022 15:41:16 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngpjW-004dIV-2q; Tue, 19 Apr 2022 15:25:40 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 59F30FF80D; Tue, 19 Apr 2022 15:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650381932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bq9PeeGKcHRkxdXVgUr01rmzSL3+CeljQ3EucZX0P7Y=; b=D5GBhDkyZrK5yvyrOhTnlTFai3nybJgtqeJ4Btz8MX+iAYbIB8QguBUEXby9NcFEsox2Ay nEBVao0mKpzibIZwXRjI+fegNSQSw7yP0VTNq2TEF9zGIcyMj40seUL5zSgEDw6yP0fImV lJF05G0KenAPpCFxgqJkSYhSYBiG/PZ/bVpCHQ4t0OlvyMid9HQRfk/ROI9Kgcj6DyTUMD xvSthEuLiZuwLSoV+spy5qdHex3A5uN+vsMGrjnOmyQmI94UOSi1NIfHY47bk0U1gnoFxS +z+RfEv5dQrJmZydxKRtn5ikkNVGrQpVuMaMw2rcPP/XoxZz0Iya3GbS7msmUg== Date: Tue, 19 Apr 2022 17:25:28 +0200 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220419172528.2dd75e7b@xps13> In-Reply-To: <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> <20220419102629.1c77aa2a@xps13> <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_082538_501216_AB2181F0 X-CRM114-Status: GOOD ( 28.16 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIFR1ZSwgMTkgQXByIDIwMjIg MTc6MTc6NDggKzA4MDA6Cgo+IEhlbGxvIE1pcXVlbCwKPiAKPiBPbiAyMDIyLzQvMTkgMTY6MjYs IE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBbIEVYVEVSTkFMIEVNQUlMIF0KPiA+IAo+ID4gSGVs bG8sCj4gPiAKPiA+IGxpYW5nLnlhbmdAYW1sb2dpYy5jb20gd3JvdGUgb24gTW9uLCAxOCBBcHIg MjAyMiAxMTo0MDoxMCArMDgwMDoKPiA+ICAgCj4gPj4gSGkgTWlxdWVsLAo+ID4+Cj4gPj4gaSBo YXZlIHNvbWUgY29uZnVzaW9uIHdoZW4gaSBwcmVwYXJlIHRoZSBwYXRjaGVzLiBmb3IgRFQgY29t cGF0aWJpbGl0eSwgaXQgZmFsbHMgYmFjayB0byB0aGUgb2xkIERUIHdoZW4gZmFpbGVkIHRvIGdl dCByZXNvdXJjZSBieSB0aGUgbmV3IERULCBidXQgdGhlcmUgaXMgc29tZSBwb2ludHM6Cj4gPj4g YS4gb2xkIERUIGRlcGVuZHMgb24gTU1DIHN1YiBjbG9jayBkcml2ZXIsIGJ1dCBpdCBuZXZlciBi ZSBtZXJnZWQsIHNvIGl0IGNhbid0IHdvcmsuICAKPiA+IAo+ID4gSSBkb24ndCBnZXQgd2hhdCB5 b3UgbWVhbiBoZXJlLCBzb3JyeS4gSSBiZWxpZXZlIHRoZXJlIGlzIGEgbmV3IHdheSB0bwo+ID4g ZGVzY3JpYmUgdGhpcyBjbG9jayBidXQgZ3JhYmJpbmcgdGhlIG9uZSBmcm9tIHRoZSBNTUMgc3Rp bGwgd29ya3MsIGRvZXMKPiA+IG5vdCBpdD8KPiA+ICAgCj4gCj4gTm8sIGl0IGRvZXNuJ3QuIGFm dGVyIHRoZSBORkMgZHJpdmVyIHVzaW5nIHRoZSBNTUMgc3ViIGNsb2NrIGZyYW1ld29yayB3YXMg bWVyZ2VkIGludG8gdGhlIG1haW5saW5lIG9mIGtlcm5lbCwgd2UgZGlkbid0IGNvbnRpbnVlIHRv IHN1Ym1pdCB0aGUgc2VyaWVzIG9mIHBhdGNoZXMgYWJvdXQgTU1DIHN1YiBjbG9jayBhZnRlciB2 OS4gd2hlbiBpIGZvdW5kIHRoYXQsIHdlIG1hZGUgYSBkaXNjdXNzaW9uIHRvIGRlY2lkZSB3aGV0 aGVyIHRvIHJlY292ZXIgdGhlIHNlcmllcyBvZiBwYXRjaGVzIGFib3V0IE1NQyBzdWIgY2xvY2sg ZnJhbWV3b3JrLCBmaW5hbGx5LCBzZWUgdGhlIGRlc2NyaXB0aW9uIGZyb20gY292ZXIgbGV0dGVy LCB3ZSBwbGFuIHRvIGFiYW5kb24gaXQgYW5kIGFkb3B0IHRoZSBuZXcgY2xvY2sgc2NoZW1lIGlu IHRoaXMgc2VyaWVzIG9mIHBhdGNoZXMuCgpJIGFtIG5vdCBzdXJlIHRvIGZvbGxvdy4gSXMgdGhl IGN1cnJlbnQgY29kZSBjb21wbGV0ZWx5IGJyb2tlbj8gSQpiZWxpZXZlIGl0IGlzIG5vdCwgc28g SSBkb24ndCB1bmRlcnN0YW5kIHlvdXIgaXNzdWUuCgpDYW4geW91IHBsZWFzZSBzdW1tYXJpemUg dGhlIHNpdHVhdGlvbj8KCj4gCj4gVGhhbmtzLgo+IAo+ID4+IGIuIGlmIGl0IGZhbGxzIGJhY2sg dG8gdGhlIG9sZCBEVCwgYmVzaWRlIHRoZSByZWdtYXAgbG9va3VwIGJlbG93LCBpdCBzZWVtcyB0 aGF0IHdlIGhhdmUgdG8gcHJlc2VydmUgdGhlIGNvZGUgb2YgdGhlIG9sZCBjbG9jayBzZXR0aW5n IGluIG5mY19jbGtfaW5pdCgpLiAgCj4gPiAKPiA+IFllcywgcHJvYmFibHkuCj4gPiAgIAo+ID4+ IGRvIHdlIHN0aWxsIG5lZWQgdG8gYXZvaWQgYnJlYWsgRFQgY29tcGF0aWJpbGl0eT8gIAo+ID4g Cj4gPiBXZSBzaG91bGQgdHJ5IG91ciBiZXN0IHRvIGF2b2lkIGJyZWFraW5nIHRoZSBEVCwgeWVz Lgo+ID4gICAKPiA+Pgo+ID4+IFRoYW5rcy4KPiA+Pgo+ID4+IE9uIDIwMjIvNC8xMSAxMDo0MCwg TGlhbmcgWWFuZyB3cm90ZTogIAo+ID4+Pj4+ICDCoMKgwqDCoMKgIG5mYy0+ZGV2ID0gZGV2Owo+ ID4+Pj4+IC3CoMKgwqAgcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VS Q0VfTUVNLCAwKTsKPiA+Pj4+PiAtwqDCoMKgIG5mYy0+cmVnX2Jhc2UgPSBkZXZtX2lvcmVtYXBf cmVzb3VyY2UoZGV2LCByZXMpOwo+ID4+Pj4+ICvCoMKgwqAgbmZjLT5yZWdfYmFzZSA9IGRldm1f cGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZV9ieW5hbWUocGRldiwgIm5mYyIpOyAgCj4gPj4+Pgo+ ID4+Pj4gVGhpcyBjaGFuZ2Ugc2VlbXMgdW5yZWxhdGVkLiAgCj4gPj4+Cj4gPj4+IFRvIGJlIGNv bnNpc3RlbnQgd2l0aCB0aGUgZm9sbG93aW5nID4gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291 cmNlX2J5bmFtZShwZGV2LCAiZW1tYyIpLiBkbyB5b3UgbWVhbiB0aGF0IHdlID4gZG9uJ3QgbmVl ZCBpdD8+ICAKPiA+Pj4+PiAgwqDCoMKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2Jhc2UpKQo+ ID4+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfYmFzZSk7 Cj4gPj4+Pj4gLcKgwqDCoCBuZmMtPnJlZ19jbGsgPQo+ID4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBz eXNjb25fcmVnbWFwX2xvb2t1cF9ieV9waGFuZGxlKGRldi0+b2Zfbm9kZSwKPiA+Pj4+PiAtwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiYW1sb2dpYyxtbWMt c3lzY29uIik7Cj4gPj4+Pj4gLcKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2NsaykpIHsKPiA+ Pj4+PiAtwqDCoMKgwqDCoMKgwqAgZGV2X2VycihkZXYsICJGYWlsZWQgdG8gbG9va3VwIGNsb2Nr IGJhc2VcbiIpOwo+ID4+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXR1cm4gUFRSX0VSUihuZmMtPnJl Z19jbGspOwo+ID4+Pj4+IC3CoMKgwqAgfQo+ID4+Pj4+ICvCoMKgwqAgbmZjLT5zZF9lbW1jX2Ns b2NrID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCA+Pj4gImVt bWMiKTsKPiA+Pj4+PiArwqDCoMKgIGlmIChJU19FUlIobmZjLT5zZF9lbW1jX2Nsb2NrKSkKPiA+ Pj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5zZF9lbW1jX2Nsb2NrKTsg IAo+ID4+Pj4KPiA+Pj4+IFdoaWxlIEkgYWdyZWUgdGhpcyBpcyBtdWNoIGJldHRlciB0aGFuIHRo ZSBwcmV2aW91cyBzb2x1dGlvbiwgd2UgY2Fubm90Cj4gPj4+PiBicmVhayBEVCBjb21wYXRpYmls aXR5LCBzbyB5b3UgbmVlZCB0byB0cnkgZ2V0dGluZyB0aGUgZW1tYyBjbG9jaywgYnV0Cj4gPj4+ PiBpZiBpdCBmYWlscyB5b3Ugc2hvdWxkIGZhbGxiYWNrIHRvIHRoZSByZWdtYXAgbG9va3VwLiAg Cj4gPj4+Cj4gPj4+IG9rLCBpIHdpbGwgZml4IGl0IG5leHQgdmVyc2lvbi4gdGhhbmtzLiAgCj4g Pj4+ICAgID4+Pj4gICA+Pj4+PiAgwqDCoMKgwqDCoCBpcnEgPSBwbGF0Zm9ybV9nZXRfaXJxKHBk ZXYsIDApOyAgCj4gPiAKPiA+IAo+ID4gVGhhbmtzLAo+ID4gTWlxdcOobAo+ID4gCj4gPiAuICAK CgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0971C433F5 for ; Tue, 19 Apr 2022 15:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7iMMdym/EqjwLLX1aOolE5WApaxU50dVTnDOLP1dMuE=; b=kRb5eZ2zxWEDuL H2XbZ5otLWln2616jfnWO9Mq2vNdSyC8vneIvp4jVoLY1wWNQ0+vW3nDGczDAFtV08NNNe3rtN3VF SdNJRjrcagNK7LFA9zPUCWli9U559EFJnjYlZbUSCEm10I1efgU9VKsNX9td3SMH3OPwIOXHrJDlD zRPFy1rokbmqpB63ok5fgdTCbkSuWRmV4RH3/pWcFchzezPJ8HsqwWxcvHuYVox4L61PjplUkCINF cvs618stRDI3B2PDbaItWChim5CIOsLcJ2RuqYgJl2jFMMvkPPV4tLMs5WA5DkqffYJ+aB45Fmqkn ZRPM+6GlsuhVQl94bStQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngpy7-004k5T-O3; Tue, 19 Apr 2022 15:40:44 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngpjW-004dIV-2q; Tue, 19 Apr 2022 15:25:40 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 59F30FF80D; Tue, 19 Apr 2022 15:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650381932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bq9PeeGKcHRkxdXVgUr01rmzSL3+CeljQ3EucZX0P7Y=; b=D5GBhDkyZrK5yvyrOhTnlTFai3nybJgtqeJ4Btz8MX+iAYbIB8QguBUEXby9NcFEsox2Ay nEBVao0mKpzibIZwXRjI+fegNSQSw7yP0VTNq2TEF9zGIcyMj40seUL5zSgEDw6yP0fImV lJF05G0KenAPpCFxgqJkSYhSYBiG/PZ/bVpCHQ4t0OlvyMid9HQRfk/ROI9Kgcj6DyTUMD xvSthEuLiZuwLSoV+spy5qdHex3A5uN+vsMGrjnOmyQmI94UOSi1NIfHY47bk0U1gnoFxS +z+RfEv5dQrJmZydxKRtn5ikkNVGrQpVuMaMw2rcPP/XoxZz0Iya3GbS7msmUg== Date: Tue, 19 Apr 2022 17:25:28 +0200 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220419172528.2dd75e7b@xps13> In-Reply-To: <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> <20220419102629.1c77aa2a@xps13> <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_082538_501216_AB2181F0 X-CRM114-Status: GOOD ( 28.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIFR1ZSwgMTkgQXByIDIwMjIg MTc6MTc6NDggKzA4MDA6Cgo+IEhlbGxvIE1pcXVlbCwKPiAKPiBPbiAyMDIyLzQvMTkgMTY6MjYs IE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBbIEVYVEVSTkFMIEVNQUlMIF0KPiA+IAo+ID4gSGVs bG8sCj4gPiAKPiA+IGxpYW5nLnlhbmdAYW1sb2dpYy5jb20gd3JvdGUgb24gTW9uLCAxOCBBcHIg MjAyMiAxMTo0MDoxMCArMDgwMDoKPiA+ICAgCj4gPj4gSGkgTWlxdWVsLAo+ID4+Cj4gPj4gaSBo YXZlIHNvbWUgY29uZnVzaW9uIHdoZW4gaSBwcmVwYXJlIHRoZSBwYXRjaGVzLiBmb3IgRFQgY29t cGF0aWJpbGl0eSwgaXQgZmFsbHMgYmFjayB0byB0aGUgb2xkIERUIHdoZW4gZmFpbGVkIHRvIGdl dCByZXNvdXJjZSBieSB0aGUgbmV3IERULCBidXQgdGhlcmUgaXMgc29tZSBwb2ludHM6Cj4gPj4g YS4gb2xkIERUIGRlcGVuZHMgb24gTU1DIHN1YiBjbG9jayBkcml2ZXIsIGJ1dCBpdCBuZXZlciBi ZSBtZXJnZWQsIHNvIGl0IGNhbid0IHdvcmsuICAKPiA+IAo+ID4gSSBkb24ndCBnZXQgd2hhdCB5 b3UgbWVhbiBoZXJlLCBzb3JyeS4gSSBiZWxpZXZlIHRoZXJlIGlzIGEgbmV3IHdheSB0bwo+ID4g ZGVzY3JpYmUgdGhpcyBjbG9jayBidXQgZ3JhYmJpbmcgdGhlIG9uZSBmcm9tIHRoZSBNTUMgc3Rp bGwgd29ya3MsIGRvZXMKPiA+IG5vdCBpdD8KPiA+ICAgCj4gCj4gTm8sIGl0IGRvZXNuJ3QuIGFm dGVyIHRoZSBORkMgZHJpdmVyIHVzaW5nIHRoZSBNTUMgc3ViIGNsb2NrIGZyYW1ld29yayB3YXMg bWVyZ2VkIGludG8gdGhlIG1haW5saW5lIG9mIGtlcm5lbCwgd2UgZGlkbid0IGNvbnRpbnVlIHRv IHN1Ym1pdCB0aGUgc2VyaWVzIG9mIHBhdGNoZXMgYWJvdXQgTU1DIHN1YiBjbG9jayBhZnRlciB2 OS4gd2hlbiBpIGZvdW5kIHRoYXQsIHdlIG1hZGUgYSBkaXNjdXNzaW9uIHRvIGRlY2lkZSB3aGV0 aGVyIHRvIHJlY292ZXIgdGhlIHNlcmllcyBvZiBwYXRjaGVzIGFib3V0IE1NQyBzdWIgY2xvY2sg ZnJhbWV3b3JrLCBmaW5hbGx5LCBzZWUgdGhlIGRlc2NyaXB0aW9uIGZyb20gY292ZXIgbGV0dGVy LCB3ZSBwbGFuIHRvIGFiYW5kb24gaXQgYW5kIGFkb3B0IHRoZSBuZXcgY2xvY2sgc2NoZW1lIGlu IHRoaXMgc2VyaWVzIG9mIHBhdGNoZXMuCgpJIGFtIG5vdCBzdXJlIHRvIGZvbGxvdy4gSXMgdGhl IGN1cnJlbnQgY29kZSBjb21wbGV0ZWx5IGJyb2tlbj8gSQpiZWxpZXZlIGl0IGlzIG5vdCwgc28g SSBkb24ndCB1bmRlcnN0YW5kIHlvdXIgaXNzdWUuCgpDYW4geW91IHBsZWFzZSBzdW1tYXJpemUg dGhlIHNpdHVhdGlvbj8KCj4gCj4gVGhhbmtzLgo+IAo+ID4+IGIuIGlmIGl0IGZhbGxzIGJhY2sg dG8gdGhlIG9sZCBEVCwgYmVzaWRlIHRoZSByZWdtYXAgbG9va3VwIGJlbG93LCBpdCBzZWVtcyB0 aGF0IHdlIGhhdmUgdG8gcHJlc2VydmUgdGhlIGNvZGUgb2YgdGhlIG9sZCBjbG9jayBzZXR0aW5n IGluIG5mY19jbGtfaW5pdCgpLiAgCj4gPiAKPiA+IFllcywgcHJvYmFibHkuCj4gPiAgIAo+ID4+ IGRvIHdlIHN0aWxsIG5lZWQgdG8gYXZvaWQgYnJlYWsgRFQgY29tcGF0aWJpbGl0eT8gIAo+ID4g Cj4gPiBXZSBzaG91bGQgdHJ5IG91ciBiZXN0IHRvIGF2b2lkIGJyZWFraW5nIHRoZSBEVCwgeWVz Lgo+ID4gICAKPiA+Pgo+ID4+IFRoYW5rcy4KPiA+Pgo+ID4+IE9uIDIwMjIvNC8xMSAxMDo0MCwg TGlhbmcgWWFuZyB3cm90ZTogIAo+ID4+Pj4+ICDCoMKgwqDCoMKgIG5mYy0+ZGV2ID0gZGV2Owo+ ID4+Pj4+IC3CoMKgwqAgcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VS Q0VfTUVNLCAwKTsKPiA+Pj4+PiAtwqDCoMKgIG5mYy0+cmVnX2Jhc2UgPSBkZXZtX2lvcmVtYXBf cmVzb3VyY2UoZGV2LCByZXMpOwo+ID4+Pj4+ICvCoMKgwqAgbmZjLT5yZWdfYmFzZSA9IGRldm1f cGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZV9ieW5hbWUocGRldiwgIm5mYyIpOyAgCj4gPj4+Pgo+ ID4+Pj4gVGhpcyBjaGFuZ2Ugc2VlbXMgdW5yZWxhdGVkLiAgCj4gPj4+Cj4gPj4+IFRvIGJlIGNv bnNpc3RlbnQgd2l0aCB0aGUgZm9sbG93aW5nID4gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291 cmNlX2J5bmFtZShwZGV2LCAiZW1tYyIpLiBkbyB5b3UgbWVhbiB0aGF0IHdlID4gZG9uJ3QgbmVl ZCBpdD8+ICAKPiA+Pj4+PiAgwqDCoMKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2Jhc2UpKQo+ ID4+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfYmFzZSk7 Cj4gPj4+Pj4gLcKgwqDCoCBuZmMtPnJlZ19jbGsgPQo+ID4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBz eXNjb25fcmVnbWFwX2xvb2t1cF9ieV9waGFuZGxlKGRldi0+b2Zfbm9kZSwKPiA+Pj4+PiAtwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiYW1sb2dpYyxtbWMt c3lzY29uIik7Cj4gPj4+Pj4gLcKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2NsaykpIHsKPiA+ Pj4+PiAtwqDCoMKgwqDCoMKgwqAgZGV2X2VycihkZXYsICJGYWlsZWQgdG8gbG9va3VwIGNsb2Nr IGJhc2VcbiIpOwo+ID4+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXR1cm4gUFRSX0VSUihuZmMtPnJl Z19jbGspOwo+ID4+Pj4+IC3CoMKgwqAgfQo+ID4+Pj4+ICvCoMKgwqAgbmZjLT5zZF9lbW1jX2Ns b2NrID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCA+Pj4gImVt bWMiKTsKPiA+Pj4+PiArwqDCoMKgIGlmIChJU19FUlIobmZjLT5zZF9lbW1jX2Nsb2NrKSkKPiA+ Pj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5zZF9lbW1jX2Nsb2NrKTsg IAo+ID4+Pj4KPiA+Pj4+IFdoaWxlIEkgYWdyZWUgdGhpcyBpcyBtdWNoIGJldHRlciB0aGFuIHRo ZSBwcmV2aW91cyBzb2x1dGlvbiwgd2UgY2Fubm90Cj4gPj4+PiBicmVhayBEVCBjb21wYXRpYmls aXR5LCBzbyB5b3UgbmVlZCB0byB0cnkgZ2V0dGluZyB0aGUgZW1tYyBjbG9jaywgYnV0Cj4gPj4+ PiBpZiBpdCBmYWlscyB5b3Ugc2hvdWxkIGZhbGxiYWNrIHRvIHRoZSByZWdtYXAgbG9va3VwLiAg Cj4gPj4+Cj4gPj4+IG9rLCBpIHdpbGwgZml4IGl0IG5leHQgdmVyc2lvbi4gdGhhbmtzLiAgCj4g Pj4+ICAgID4+Pj4gICA+Pj4+PiAgwqDCoMKgwqDCoCBpcnEgPSBwbGF0Zm9ybV9nZXRfaXJxKHBk ZXYsIDApOyAgCj4gPiAKPiA+IAo+ID4gVGhhbmtzLAo+ID4gTWlxdcOobAo+ID4gCj4gPiAuICAK CgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK