From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D44E1C433F5 for ; Tue, 19 Apr 2022 18:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344565AbiDSS3H (ORCPT ); Tue, 19 Apr 2022 14:29:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356877AbiDSSWG (ORCPT ); Tue, 19 Apr 2022 14:22:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F7CA3EB98; Tue, 19 Apr 2022 11:14:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1FC01B81983; Tue, 19 Apr 2022 18:14:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92F79C385B0; Tue, 19 Apr 2022 18:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650392065; bh=l9uC7Jd/JtduUprt9DTiagtw6UvvCPakC11dX7OhYYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gn4ckzZxCo8iov6EBz/bn/K81vr0ZYNC3W2kdQmmsUG3FpWCyH/b6fPahyTbC4aAg qwBPqllT3SoT0gVxi0qVtC5KAU6r21oOhvmmGZ7yqE1uyu+W7b/r0kWLrplpnLLjkd KlKXcJr059N7PUI/Pn5RKBtirkqBqOBoZLT1t9jaYs4E8PPbpWtvEKe557mWMLExlX fCBBb2PHd772bT2ehlJ6tMJqihCBs/914+psJJGdMYmUSOVgCtk5vjswawthBlo4BR fpeb65vwrUq19TYlt0VYL+ZuTlgqNbFqB8wi1S5XckrZNemR++yKjv+hhHaUK4DzFS ktXHY83Nwp7eQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lv Ruyi , Zeal Robot , "David S . Miller" , Sasha Levin , madalin.bucur@nxp.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 11/18] dpaa_eth: Fix missing of_node_put in dpaa_get_ts_info() Date: Tue, 19 Apr 2022 14:13:45 -0400 Message-Id: <20220419181353.485719-11-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220419181353.485719-1-sashal@kernel.org> References: <20220419181353.485719-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lv Ruyi [ Upstream commit 1a7eb80d170c28be2928433702256fe2a0bd1e0f ] Both of of_get_parent() and of_parse_phandle() return node pointer with refcount incremented, use of_node_put() on it to decrease refcount when done. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c index 1268996b7030..2f9075429c43 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c @@ -489,11 +489,15 @@ static int dpaa_get_ts_info(struct net_device *net_dev, info->phc_index = -1; fman_node = of_get_parent(mac_node); - if (fman_node) + if (fman_node) { ptp_node = of_parse_phandle(fman_node, "ptimer-handle", 0); + of_node_put(fman_node); + } - if (ptp_node) + if (ptp_node) { ptp_dev = of_find_device_by_node(ptp_node); + of_node_put(ptp_node); + } if (ptp_dev) ptp = platform_get_drvdata(ptp_dev); -- 2.35.1