All of
 help / color / mirror / Atom feed
From: kernel test robot <>
Subject: Re: [PATCH v3 7/8] test_firmware: Error injection for firmware upload
Date: Tue, 19 Apr 2022 21:01:45 +0800	[thread overview]
Message-ID: <> (raw)

[-- Attachment #1: Type: text/plain, Size: 2849 bytes --]

CC: kbuild-all(a)
BCC: lkp(a)
In-Reply-To: <>
References: <>
TO: Russ Weight <>
TO: mcgrof(a)
TO: rafael(a)
TO: linux-kernel(a)
CC: trix(a)
CC: lgoncalv(a)
CC: yilun.xu(a)
CC: hao.wu(a)
CC: matthew.gerlach(a)
CC: basheer.ahmed.muddebihal(a)
CC: tianfei.zhang(a)
CC: Russ Weight <>

Hi Russ,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on shuah-kselftest/next mcgrof/sysctl-next linus/master v5.18-rc3 next-20220419]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: 3123109284176b1532874591f7c81f3837bbdc17
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago
compiler: mipsel-linux-gcc (GCC) 11.2.0
reproduce (cppcheck warning):
        # apt-get install cppcheck
        git checkout 2cf984eba934c1a6b1bcfc317886e89180bcb5e3
        cppcheck --quiet --enable=style,performance,portability --template=gcc FILE

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> lib/test_firmware.c:1071:18: warning: Uninitialized variables:, tst.buf, tst.size, tst.cancel_request, tst.inject, tst.fwl [uninitvar]

vim +1071 lib/test_firmware.c

cb4d12e8d75964 Russ Weight 2022-04-18  1064  
cb4d12e8d75964 Russ Weight 2022-04-18  1065  static void upload_release_all(void)
cb4d12e8d75964 Russ Weight 2022-04-18  1066  {
cb4d12e8d75964 Russ Weight 2022-04-18  1067  	struct test_firmware_upload *tst, *tmp;
cb4d12e8d75964 Russ Weight 2022-04-18  1068  
cb4d12e8d75964 Russ Weight 2022-04-18  1069  	list_for_each_entry_safe(tst, tmp, &test_upload_list, node) {
cb4d12e8d75964 Russ Weight 2022-04-18  1070  		list_del(&tst->node);
cb4d12e8d75964 Russ Weight 2022-04-18 @1071  		upload_release(tst);
cb4d12e8d75964 Russ Weight 2022-04-18  1072  	}
cb4d12e8d75964 Russ Weight 2022-04-18  1073  	test_fw_config->upload_name = NULL;
cb4d12e8d75964 Russ Weight 2022-04-18  1074  }
cb4d12e8d75964 Russ Weight 2022-04-18  1075  

0-DAY CI Kernel Test Service

             reply	other threads:[~2022-04-19 13:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 13:01 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-04-18 22:37 [PATCH v3 0/8] Extend FW framework for user FW uploads Russ Weight
2022-04-18 22:37 ` [PATCH v3 7/8] test_firmware: Error injection for firmware upload Russ Weight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.