All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: sean.anderson@seco.com
Cc: afleming@gmail.com, alexey.brodkin@synopsys.com,
	alison.wang@nxp.com, angelo@sysam.it, bmeng.cn@gmail.com,
	daniel.schwierzeck@gmail.com, iwamatsu@nigauri.org,
	macpaul@andestech.com, manish.tomar@nxp.com, marex@denx.de,
	mario.six@gdsys.cc, mingkai.hu@nxp.com, monstr@monstr.eu,
	olteanv@gmail.com, pramod.kumar_1@nxp.com, priyanka.jain@nxp.com,
	rajesh.bhagat@nxp.com, sjg@chromium.org, smcnutt@psyent.com,
	sr@denx.de, thomas@wytron.com.tw, trini@konsulko.com,
	u-boot@lists.denx.de, wd@denx.de,
	Michael Walle <michael@walle.cc>
Subject: Re: [PATCH 2/2] arch: layerscape: Add SFP binding
Date: Wed, 20 Apr 2022 01:26:07 +0200	[thread overview]
Message-ID: <20220419232607.262671-1-michael@walle.cc> (raw)
In-Reply-To: <20220419205819.3765848-2-sean.anderson@seco.com>

Hi Sean,

> This adds an SFP binding for the processors it is present on. I have
> only tested this for the LS1046A.
> 
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>

There is an upstream binding
Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml

Are you aware of that? Could you submit a patch there to add
your new compatibles? Esp. because you are using a clock which
isn't described in the upstream binding. I'm curious, do you need the
clock? I only know the LS1028A and it seems you don't have to turn on
any clock there. It might also be the case I've missed something.

-michael

  reply	other threads:[~2022-04-19 23:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 20:58 [PATCH 1/2] arm: layerscape: Add sfp driver Sean Anderson
2022-04-19 20:58 ` [PATCH 2/2] arch: layerscape: Add SFP binding Sean Anderson
2022-04-19 23:26   ` Michael Walle [this message]
2022-04-19 23:51     ` Sean Anderson
2022-04-20  8:06       ` Michael Walle
2022-04-21 14:41         ` Sean Anderson
2022-04-19 21:00 ` [PATCH 1/2] arm: layerscape: Add sfp driver Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220419232607.262671-1-michael@walle.cc \
    --to=michael@walle.cc \
    --cc=afleming@gmail.com \
    --cc=alexey.brodkin@synopsys.com \
    --cc=alison.wang@nxp.com \
    --cc=angelo@sysam.it \
    --cc=bmeng.cn@gmail.com \
    --cc=daniel.schwierzeck@gmail.com \
    --cc=iwamatsu@nigauri.org \
    --cc=macpaul@andestech.com \
    --cc=manish.tomar@nxp.com \
    --cc=marex@denx.de \
    --cc=mario.six@gdsys.cc \
    --cc=mingkai.hu@nxp.com \
    --cc=monstr@monstr.eu \
    --cc=olteanv@gmail.com \
    --cc=pramod.kumar_1@nxp.com \
    --cc=priyanka.jain@nxp.com \
    --cc=rajesh.bhagat@nxp.com \
    --cc=sean.anderson@seco.com \
    --cc=sjg@chromium.org \
    --cc=smcnutt@psyent.com \
    --cc=sr@denx.de \
    --cc=thomas@wytron.com.tw \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.