All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "drm/amdkfd: only allow heavy-weight TLB flush on some ASICs for SVM too"
@ 2022-04-20  2:32 Lang Yu
  2022-04-20 16:51 ` philip yang
  0 siblings, 1 reply; 2+ messages in thread
From: Lang Yu @ 2022-04-20  2:32 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alex Deucher, Philip Yang, Felix Kuehling, Huang Rui, Lang Yu

This reverts commit a129dbca92edaeb5a515a0e5b63ada71cf9b981a.

It causes SVM regressions on Vega10 with XNACK-ON. Just revert it
at the moment.

./kfdtest --gtest_filter=KFDSVMRangeTest.MigratePolicyTest

Signed-off-by: Lang Yu <Lang.Yu@amd.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 5afe216cf099..459fa07a3bcc 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -1229,9 +1229,7 @@ svm_range_unmap_from_gpus(struct svm_range *prange, unsigned long start,
 			if (r)
 				break;
 		}
-
-		if (kfd_flush_tlb_after_unmap(pdd->dev))
-			kfd_flush_tlb(pdd, TLB_FLUSH_HEAVYWEIGHT);
+		kfd_flush_tlb(pdd, TLB_FLUSH_HEAVYWEIGHT);
 	}
 
 	return r;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Revert "drm/amdkfd: only allow heavy-weight TLB flush on some ASICs for SVM too"
  2022-04-20  2:32 [PATCH] Revert "drm/amdkfd: only allow heavy-weight TLB flush on some ASICs for SVM too" Lang Yu
@ 2022-04-20 16:51 ` philip yang
  0 siblings, 0 replies; 2+ messages in thread
From: philip yang @ 2022-04-20 16:51 UTC (permalink / raw)
  To: Lang Yu, amd-gfx; +Cc: Alex Deucher, Philip Yang, Felix Kuehling, Huang Rui

[-- Attachment #1: Type: text/html, Size: 1566 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-20 16:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-20  2:32 [PATCH] Revert "drm/amdkfd: only allow heavy-weight TLB flush on some ASICs for SVM too" Lang Yu
2022-04-20 16:51 ` philip yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.