All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ian Cowan <ian@linux.cowan.aero>
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
	elder@kernel.org, gregkh@linuxfoundation.org,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] Staging: greybus: audio manager module: make char array const
Date: Wed, 20 Apr 2022 09:24:46 +0300	[thread overview]
Message-ID: <20220420062446.GA2951@kadam> (raw)
In-Reply-To: <20220420053755.48934-1-ian@linux.cowan.aero>

On Wed, Apr 20, 2022 at 01:37:55AM -0400, Ian Cowan wrote:
> There does exist a warning when running the checkpatch script to
> make this a static variable, but there does not appear to be any advantage
> to make this change.

Heh.  Don't send patches unless there is an advantage.

This patch breaks the build.  You need to at least try to compile your
changes before you send them.

regards,
dan carpenter


      reply	other threads:[~2022-04-20  6:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  5:37 [PATCH] Staging: greybus: audio manager module: make char array const Ian Cowan
2022-04-20  6:24 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220420062446.GA2951@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=ian@linux.cowan.aero \
    --cc=johan@kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.