All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mbenes@suse.cz
Subject: Re: [PATCH 2/2] objtool: Fix code relocs vs weak symbols
Date: Wed, 20 Apr 2022 08:57:20 +0200	[thread overview]
Message-ID: <20220420065720.GA2731@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220420021601.kiughdji3avh2uua@treble>

On Tue, Apr 19, 2022 at 07:16:01PM -0700, Josh Poimboeuf wrote:
> On Tue, Apr 19, 2022 at 10:32:56PM +0200, Peter Zijlstra wrote:
> > +	/* XXX create ? */
> > +	if (symtab_shndx) {
> 
> Not sure what this comment means?

I'm not sure if we will trip the case where the input ELF will not
have/need the extended table, but our output file would need it.

That said, upon thinking about it this morning, it wouldn't be this code
path triggering it I think.

Specifically, we only create section symbols for text sections and
objtool doesn't generate text sections (you've talked me out of that).
So the number of text sections doesn't change, so section index number
shouldn't increase due to all this.

  reply	other threads:[~2022-04-20  6:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 20:32 [PATCH 0/2] objtool: Fix code reloc vs weak symbols Peter Zijlstra
2022-04-19 20:32 ` [PATCH 1/2] objtool: Fix type of reloc::addend Peter Zijlstra
2022-04-22 10:27   ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2022-04-19 20:32 ` [PATCH 2/2] objtool: Fix code relocs vs weak symbols Peter Zijlstra
2022-04-20  2:16   ` Josh Poimboeuf
2022-04-20  6:57     ` Peter Zijlstra [this message]
2022-04-22 10:27   ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2022-04-21 15:48 ` [PATCH 0/2] objtool: Fix code reloc " Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220420065720.GA2731@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.