From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B0AC433F5 for ; Wed, 20 Apr 2022 23:25:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383206AbiDTX2n (ORCPT ); Wed, 20 Apr 2022 19:28:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380110AbiDTX2l (ORCPT ); Wed, 20 Apr 2022 19:28:41 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E40E2B24B for ; Wed, 20 Apr 2022 16:25:54 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id mm4-20020a17090b358400b001cb93d8b137so6224847pjb.2 for ; Wed, 20 Apr 2022 16:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e1hyArb/5whGQ4faeg6YhO5mzcFT0LHHgxgGSNRPGMg=; b=IzXr0U1vcfIgbzGgGTh6dzx0nqn8WMMdbN9zCGPRHGsgRNwmqpeKdhuU6wGXF5Eus0 tnX6M+8p1i/EgZPwRUH7d9fyTDOw6+AymUSFKxGYPNNLKlqV+5h4TYcbImd28Zmn5CNk uNU0UwQac8mauwk90fO5L4zkY9PezSZxF5t4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e1hyArb/5whGQ4faeg6YhO5mzcFT0LHHgxgGSNRPGMg=; b=z722NrxZa3SRcXAZapoewiaUXN4twrmmclUNxUeu4gw9h6vxXqH3haEQxGhRXfvbPi N4G8gIKV4zHqBjj1ZjoCr4GzKVd9iPZ+Oi7P4aVBqww+6zLq0V1fIbph9Fki66EhUgrC C3LdpA5uuQwivPojYkwhnzMXqOD0LLlBJ+TRGqb/bCS2nJEudeh6PZYN+pffUj0KnBiL EqRAdO5avYLG7o0b98Hje/JHo6k6ZqVtFltLraoFpV2UqY6zed0n3ZY+WnMLuaf45+sL zdUtemxSyWWwy3YSkK1Qy5iZhb0cOl7F4NKcuBM0LGWreB3zS2NxNfxx0b0fBoLw57bw w+bQ== X-Gm-Message-State: AOAM531INMIdNszE+Gzi2HzKsvRC9YyjTVRCzXUbZl2TMH90/L0ZRIJh f1a4Pk1RAlvQ/oYsAZGVZ2Z1tA== X-Google-Smtp-Source: ABdhPJzW9o2jnlLh8gq/h5f1Xtg7444K7l2n/xm75BoEkh9+XT5HTYM3lQ/QPMNZwG+qExghHvv9ug== X-Received: by 2002:a17:90b:218d:b0:1d0:90f5:4064 with SMTP id ku13-20020a17090b218d00b001d090f54064mr7158993pjb.95.1650497153809; Wed, 20 Apr 2022 16:25:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id cp14-20020a17090afb8e00b001cd4989ff55sm266911pjb.28.2022.04.20.16.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 16:25:53 -0700 (PDT) Date: Wed, 20 Apr 2022 16:25:52 -0700 From: Kees Cook To: Joao Moreira Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, peterz@infradead.org, jpoimboe@redhat.com, andrew.cooper3@citrix.com, samitolvanen@google.com, mark.rutland@arm.com, hjl.tools@gmail.com, alyssa.milburn@linux.intel.com, ndesaulniers@google.com, gabriel.gomes@linux.intel.com, rick.p.edgecombe@intel.com Subject: Re: [RFC PATCH 11/11] driver/int3400_thermal: Fix prototype matching Message-ID: <202204201625.5BBB91ADB8@keescook> References: <20220420004241.2093-1-joao@overdrivepizza.com> <20220420004241.2093-12-joao@overdrivepizza.com> <202204191946.2843CF71@keescook> <06435f0b44681588052d145a17d60316@overdrivepizza.com> <202204201601.8291F550@keescook> <4dd9a9a3a7fb6f9af0fa04b8d2e3d5a2@overdrivepizza.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4dd9a9a3a7fb6f9af0fa04b8d2e3d5a2@overdrivepizza.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2022 at 04:12:26PM -0700, Joao Moreira wrote: > > > > Ah-ha, thanks. I think this will fix it, but I haven't tested it: > > I tried that, and IIRC, there was an error or warning in the assignment that > happens a bit further in the file. My bad for not having it all properly > tracked. This builds for me without warnings, but maybe there is some weird config I'm missing. -- Kees Cook