From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27582C433EF for ; Wed, 20 Apr 2022 19:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381653AbiDTTSX (ORCPT ); Wed, 20 Apr 2022 15:18:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349026AbiDTTSU (ORCPT ); Wed, 20 Apr 2022 15:18:20 -0400 Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C49BBBE05 for ; Wed, 20 Apr 2022 12:15:32 -0700 (PDT) Received: from pps.filterd (m0109331.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23KILQ2q014792 for ; Wed, 20 Apr 2022 12:15:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=WVbI536hoxZ1wYZdlP7VE8Hmy7spTZOU9Wd2P1breuE=; b=iUO1lZZvub5pAeyuM0FnVILc/ubPRSFS1eGeXf0VRfHI+03lEBYxiIDEcv+di2yrWMxM 2jN2NCHuYoD9MiNvctiA+a8nA9TfVYurOd73weBk23dJa5+Vgz31H7qfmEv7fqUnisVZ gTdx7j+NNrKRBxkEz0UVcnVLaYjy2syo+fA= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3fhn514eh4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 20 Apr 2022 12:15:31 -0700 Received: from twshared16483.05.ash9.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:83::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 20 Apr 2022 12:15:31 -0700 Received: by devvm225.atn0.facebook.com (Postfix, from userid 425415) id 5F17ADE0C4B7; Wed, 20 Apr 2022 12:15:27 -0700 (PDT) From: Stefan Roesch To: , CC: Subject: [PATCH v2 3/6] liburing: return correct ring size for large CQE's Date: Wed, 20 Apr 2022 12:15:21 -0700 Message-ID: <20220420191524.2906409-4-shr@fb.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220420191524.2906409-1-shr@fb.com> References: <20220420191524.2906409-1-shr@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: Dna68v_iriU4LA6mGA0N1qgm35_KC_9Y X-Proofpoint-ORIG-GUID: Dna68v_iriU4LA6mGA0N1qgm35_KC_9Y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-20_05,2022-04-20_01,2022-02-23_01 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Return the correct ring_size when large CQE's are used. Signed-off-by: Stefan Roesch --- src/setup.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/setup.c b/src/setup.c index dd6a712..d2adc7f 100644 --- a/src/setup.c +++ b/src/setup.c @@ -257,8 +257,11 @@ static size_t rings_size(struct io_uring_params *p, = unsigned entries, { size_t pages, sq_size, cq_size; =20 - cq_size =3D KRING_SIZE; - cq_size +=3D cq_entries * sizeof(struct io_uring_cqe); + cq_size =3D sizeof(struct io_uring_cqe); + if (p->flags & IORING_SETUP_CQE32) + cq_size +=3D sizeof(struct io_uring_cqe); + cq_size *=3D cq_entries; + cq_size +=3D KRING_SIZE; cq_size =3D (cq_size + 63) & ~63UL; pages =3D (size_t) 1 << npages(cq_size, page_size); =20 --=20 2.30.2