From: Jagath Jog J <jagathjog1996@gmail.com>
To: dan@dlrobertson.com, jic23@kernel.org, andy.shevchenko@gmail.com
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/9] iio: accel: bma400: Add buffer, step and activity/inactivity
Date: Thu, 21 Apr 2022 02:40:56 +0530 [thread overview]
Message-ID: <20220420211105.14654-1-jagathjog1996@gmail.com> (raw)
This patch series adds trigger buffer support with data ready interrupt,
separate channel for step counter, an event for step change interrupt,
activity recognition and activity/inactivity event support.
changes since v3
1. Removed all the unnecessary mutex locking for regmap.
2. Corrected the mutex locking and unlocking for device private data
members.
3. Mutex locking and unlocking is used to protect the device private
structure members.
4. Using DMA safe buffer for regmap_bulk_write() and regmap_bulk_read().
1/9: Fixed the comment.
3/9: Added () for the function name in the comment.
4/9: Handling error cases with goto in bma400_trigger_handler().
Mutex locking and unlocking is used to protect the data->buffer.
Using DMA safe buffer for regmap_bulk_read().
Mutex locking and unlocking is used to protect the data->status in
bma400_interrupt.
5/9: Using DMA safe buffers to read steps value by allocating memory internally.
Using DMA safe buffers for regmap_bulk_write().
Removed the lock for regmap().
6/9: Removed the duplication of code for enabling step, added function to handle
the step enable.
7/9: Removed the lock for regmap().
Mutex locking and unlocking is used to protect the data members.
8/9: Removed the lock for regmap().
9/9. Added __be16 duration in struct bma400_data.
Fixed the warning - impossible condition '(reg < 0) => (0-255 < 0)'
Fixed error: call to __compiletime_assert_272
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
changes since v2
1. Reordering of header includes in the separate patch.
2. Matching the IIO syntax for multiline comment.
3. Following the preference in the interrupt handler for returning.
4. Add support for activity recognition.
5. Add support for debugfs to access registers from userspace.
6. Add support for activity and inactivity events
changes since v1
1. Added comment section that describes the math for scale calculation.
2. Added separate devm_add_action_or_reset() calls to disable regulator
and to put the sensor in power down mode.
3. Remove the err_reg_disable and out, goto labels and returning directly
if error occurs.
4. Added mutex calls while putting sensor in power down.
5. Added ___cacheline_aligned for device data.
6. Ordering the header includes.
7. Handling erroneous and spurious interrupts in the interrupt handler
by returning IRQ_NONE.
8. Using dev_err_probe() instead of dev_err().
9. Configured the interrupt to open drain.
10. Using le16_to_cpu() to fix the sparse warning.
11. Checking the step change event is enabled or not.
12. Enabling the step change event will also enable the step channel.
13. Using FIELD_GET() instead of bitwise operation.
14. Removal of dead code in the _event_config().
Jagath Jog J (9):
iio: accel: bma400: Fix the scale min and max macro values
iio: accel: bma400: Reordering of header files
iio: accel: bma400: conversion to device-managed function
iio: accel: bma400: Add triggered buffer support
iio: accel: bma400: Add separate channel for step counter
iio: accel: bma400: Add step change event
iio: accel: bma400: Add activity recognition support
iio: accel: bma400: Add debugfs register access support
iio: accel: bma400: Add support for activity and inactivity events
drivers/iio/accel/Kconfig | 2 +
drivers/iio/accel/bma400.h | 50 ++-
drivers/iio/accel/bma400_core.c | 694 +++++++++++++++++++++++++++++---
drivers/iio/accel/bma400_i2c.c | 10 +-
drivers/iio/accel/bma400_spi.c | 8 +-
5 files changed, 697 insertions(+), 67 deletions(-)
--
2.17.1
next reply other threads:[~2022-04-20 21:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 21:10 Jagath Jog J [this message]
2022-04-20 21:10 ` [PATCH v4 1/9] iio: accel: bma400: Fix the scale min and max macro values Jagath Jog J
2022-04-27 12:28 ` Andy Shevchenko
2022-04-20 21:10 ` [PATCH v4 2/9] iio: accel: bma400: Reordering of header files Jagath Jog J
2022-04-20 21:10 ` [PATCH v4 3/9] iio: accel: bma400: conversion to device-managed function Jagath Jog J
2022-04-20 21:11 ` [PATCH v4 4/9] iio: accel: bma400: Add triggered buffer support Jagath Jog J
2022-04-27 12:34 ` Andy Shevchenko
2022-05-01 16:20 ` Jonathan Cameron
2022-05-01 20:25 ` Jagath Jog J
2022-05-07 16:00 ` Jonathan Cameron
2022-04-20 21:11 ` [PATCH v4 5/9] iio: accel: bma400: Add separate channel for step counter Jagath Jog J
2022-04-27 12:34 ` Andy Shevchenko
2022-04-27 21:01 ` Jagath Jog J
2022-04-20 21:11 ` [PATCH v4 6/9] iio: accel: bma400: Add step change event Jagath Jog J
2022-05-01 16:31 ` Jonathan Cameron
2022-05-01 20:27 ` Jagath Jog J
2022-04-20 21:11 ` [PATCH v4 7/9] iio: accel: bma400: Add activity recognition support Jagath Jog J
2022-04-20 21:11 ` [PATCH v4 8/9] iio: accel: bma400: Add debugfs register access support Jagath Jog J
2022-05-01 16:34 ` Jonathan Cameron
2022-04-20 21:11 ` [PATCH v4 9/9] iio: accel: bma400: Add support for activity and inactivity events Jagath Jog J
2022-04-21 6:45 ` kernel test robot
2022-04-24 16:20 ` Jonathan Cameron
2022-04-24 16:20 ` Jonathan Cameron
2022-04-27 3:01 ` Jagath Jog J
2022-04-27 3:01 ` Jagath Jog J
2022-04-27 13:45 ` Andy Shevchenko
2022-04-27 13:45 ` Andy Shevchenko
2022-04-26 11:04 ` [PATCH v4 0/9] iio: accel: bma400: Add buffer, step and activity/inactivity Andy Shevchenko
2022-04-26 11:05 ` Andy Shevchenko
2022-04-26 12:28 ` Jagath Jog J
2022-05-01 16:36 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420211105.14654-1-jagathjog1996@gmail.com \
--to=jagathjog1996@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan@dlrobertson.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.