From: kernel test robot <lkp@intel.com>
To: Pierre Morel <pmorel@linux.ibm.com>, kvm@vger.kernel.org
Cc: kbuild-all@lists.01.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, borntraeger@de.ibm.com,
frankja@linux.ibm.com, cohuck@redhat.com, david@redhat.com,
thuth@redhat.com, imbrenda@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, pmorel@linux.ibm.com, wintera@linux.ibm.com,
seiden@linux.ibm.com, nrb@linux.ibm.com
Subject: Re: [PATCH v8 2/2] s390x: KVM: resetting the Topology-Change-Report
Date: Thu, 21 Apr 2022 14:41:53 +0800 [thread overview]
Message-ID: <202204210249.JUYt00GG-lkp@intel.com> (raw)
In-Reply-To: <20220420113430.11876-3-pmorel@linux.ibm.com>
Hi Pierre,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kvm/master]
[also build test WARNING on v5.18-rc3]
[cannot apply to kvms390/next mst-vhost/linux-next next-20220420]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Pierre-Morel/s390x-KVM-CPU-Topology/20220420-194302
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git master
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20220421/202204210249.JUYt00GG-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0bdeef651636ac2ef4918fb6e3230614e2fb3581
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Pierre-Morel/s390x-KVM-CPU-Topology/20220420-194302
git checkout 0bdeef651636ac2ef4918fb6e3230614e2fb3581
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/kvm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
arch/s390/kvm/kvm-s390.c: In function 'kvm_s390_sca_clear_mtcr':
>> arch/s390/kvm/kvm-s390.c:1773:13: warning: variable 'val' set but not used [-Wunused-but-set-variable]
1773 | int val;
| ^~~
vim +/val +1773 arch/s390/kvm/kvm-s390.c
1758
1759 /**
1760 * kvm_s390_sca_clear_mtcr
1761 * @kvm: guest KVM description
1762 *
1763 * Is only relevant if the topology facility is present,
1764 * the caller should check KVM facility 11
1765 *
1766 * Updates the Multiprocessor Topology-Change-Report to signal
1767 * the guest with a topology change.
1768 */
1769 static int kvm_s390_sca_clear_mtcr(struct kvm *kvm)
1770 {
1771 struct bsca_block *sca = kvm->arch.sca;
1772 struct kvm_vcpu *vcpu;
> 1773 int val;
1774
1775 vcpu = kvm_s390_get_first_vcpu(kvm);
1776 if (!vcpu)
1777 return -ENODEV;
1778
1779 ipte_lock(vcpu);
1780 val = READ_ONCE(sca->utility);
1781 WRITE_ONCE(sca->utility, sca->utility & ~SCA_UTILITY_MTCR);
1782 ipte_unlock(vcpu);
1783
1784 return 0;
1785 }
1786
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-04-21 6:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 11:34 [PATCH v8 0/2] s390x: KVM: CPU Topology Pierre Morel
2022-04-20 11:34 ` [PATCH v8 1/2] s390x: KVM: guest support for topology function Pierre Morel
2022-04-20 12:05 ` Heiko Carstens
2022-04-20 12:13 ` Pierre Morel
2022-04-20 13:22 ` Claudio Imbrenda
2022-04-20 18:25 ` Heiko Carstens
2022-04-20 18:31 ` Pierre Morel
2022-04-20 11:34 ` [PATCH v8 2/2] s390x: KVM: resetting the Topology-Change-Report Pierre Morel
2022-04-21 6:40 ` kernel test robot
2022-04-21 6:41 ` kernel test robot [this message]
2022-04-28 13:50 ` David Hildenbrand
2022-05-04 8:05 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204210249.JUYt00GG-lkp@intel.com \
--to=lkp@intel.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.