All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Axtens <dja@axtens.net>
To: grub-devel@gnu.org
Cc: leif@nuviainc.com, stefanb@linux.ibm.com, ps@pks.im,
	dkiper@net-space.pl, Daniel Axtens <dja@axtens.net>,
	Daniel Kiper <daniel.kiper@oracle.com>
Subject: [PATCH v3 01/15] grub-shell: only pass SeaBIOS fw_opt in for x86 BIOS platforms
Date: Thu, 21 Apr 2022 15:24:13 +1000	[thread overview]
Message-ID: <20220421052427.1389987-2-dja@axtens.net> (raw)
In-Reply-To: <20220421052427.1389987-1-dja@axtens.net>

This breaks the tests on pseries - just restrict it to x86 platforms
that don't specify a BIOS.

Signed-off-by: Daniel Axtens <dja@axtens.net>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
---
v2: Thanks Daniel K and Glenn for feedback.
---
 tests/util/grub-shell.in | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
index 33590baeb13c..4828afb7cc5a 100644
--- a/tests/util/grub-shell.in
+++ b/tests/util/grub-shell.in
@@ -376,7 +376,11 @@ if test -z "$debug"; then
   # workaround unfortunately causes qemu to issue a warning 'externally
   # provided fw_cfg item names should be prefixed with "opt/"', but there
   # doesn't seem to be a better option.
-  qemuopts="${qemuopts} -fw_cfg name=etc/sercon-port,string=0"
+  #
+  # SeaBIOS is used for i386, except on EFI.
+  if [ ${grub_modinfo_target_cpu} == 'i386' ] && [ ${grub_modinfo_platform} != 'efi' ]; then
+    qemuopts="${qemuopts} -fw_cfg name=etc/sercon-port,string=0"
+  fi
 fi
 
 if [ x$boot != xnet ] && [ x$boot != xemu ]; then
-- 
2.32.0



  reply	other threads:[~2022-04-21  5:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21  5:24 [PATCH v3 00/15] Dynamic allocation of memory regions and IBM vTPM v2 Daniel Axtens
2022-04-21  5:24 ` Daniel Axtens [this message]
2022-04-21  5:24 ` [PATCH v3 02/15] mm: assert that we preserve header vs region alignment Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 03/15] mm: when adding a region, merge with region after as well as before Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 04/15] mm: debug support for region operations Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 05/15] mm: Drop unused unloading of modules on OOM Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 06/15] mm: Allow dynamically requesting additional memory regions Daniel Axtens
2022-04-21  6:50   ` Daniel Axtens
2022-04-21 13:32     ` Daniel Kiper
2022-04-21  5:24 ` [PATCH v3 07/15] efi: mm: Always request a fixed number of pages on init Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 08/15] efi: mm: Extract function to add memory regions Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 09/15] efi: mm: Pass up errors from `add_memory_regions ()` Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 10/15] efi: mm: Implement runtime addition of pages Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 11/15] ieee1275: request memory with ibm, client-architecture-support Daniel Axtens
2022-07-19 20:49   ` Stefan Berger
2022-07-20 13:34     ` Daniel Kiper
2022-04-21  5:24 ` [PATCH v3 12/15] ieee1275: drop len -= 1 quirk in heap_init Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 13/15] ieee1275: support runtime memory claiming Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 14/15] [RFC] Add memtool module with memory allocation stress-test Daniel Axtens
2022-04-21  5:24 ` [PATCH v3 15/15] ibmvtpm: Add support for trusted boot using a vTPM 2.0 Daniel Axtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220421052427.1389987-2-dja@axtens.net \
    --to=dja@axtens.net \
    --cc=daniel.kiper@oracle.com \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=leif@nuviainc.com \
    --cc=ps@pks.im \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.