From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B335C433F5 for ; Thu, 21 Apr 2022 11:04:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1388690AbiDULGr (ORCPT ); Thu, 21 Apr 2022 07:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354649AbiDULGn (ORCPT ); Thu, 21 Apr 2022 07:06:43 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 230DE2CE3A for ; Thu, 21 Apr 2022 04:03:54 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id q12so4319520pgj.13 for ; Thu, 21 Apr 2022 04:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=b5cKgnHy5yIWx7IkuUyQsnSmFcYWr+B7twcbgmrD1pA=; b=obvkjUMexbjkc1qj09DfdFfiI7G7jgdbCm5eqjNe5hceKeW3SJk5IVv5dMWanBegdI X6Vg9585ErIRwvA80R7dx/hV2W2UMBriM6ncwqmUfHM/cwrNi8lau2sDMurX0LlfkDH1 HMPR7megoF95tf+lL7wMYRcCDXs5yagS3e5bFYfMuSnmbDUPKPm/gjEZ0GpAdTIE+KeN RBpu2CtLHxwAZMrnZLGlbvJRYeJCimD3dwtlPQ/kZZQet1Z1g9/9K3kxVBviX+0Qa//W dO460VGTqbiM9wkrWJybohcQMcPO6BPDXV7OfqVmzZXka+agjeIJvtBRN85YoudByZIc KDdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=b5cKgnHy5yIWx7IkuUyQsnSmFcYWr+B7twcbgmrD1pA=; b=agdTHxma8A7L2fLCGhLo2tlQNIQB3wIdTDIzbVsG5ieZ1hrR+3p6KMHTzTzQezxh9R r+7qffMXpGCkkffkGu9p8+NSwhw1Cie7j75HDEqiljTiP2rrTK4FEflkAGpjYsrKDeJ9 kRPHmTPx4wr6fu+HeTd7VcTws6khBimLvduTkhtmnhxi+NPvtYAdKZHHMmXftRFS4c4g ndZ+W3YBnI4slbMfTSRI4ESLXT6p/aU9YQyHyr7cGM3f/LXVnWeHVjO+EbQI/P2ry0zS +rlBQNQKwVnGeOHLb8gYR+A15YFSMTud/0XoCmn7xIUfOiidwqJKKzQzhqF79fZXu21J 3BTg== X-Gm-Message-State: AOAM533pzJhXbKouRe3s0V4W6JaoviaTtP75aFpHm/5pD8XGYNbBwJt6 ShYu4cvoT3A9v40nsRcLpjc= X-Google-Smtp-Source: ABdhPJyYZCtFhdhMOk0AYGm3maxZ92nO7efmlTmc2GCYMV8UNCv698p1A6ja1HAXBQTX5iSeqJz19A== X-Received: by 2002:a62:170b:0:b0:50a:6901:b633 with SMTP id 11-20020a62170b000000b0050a6901b633mr23204994pfx.34.1650539033603; Thu, 21 Apr 2022 04:03:53 -0700 (PDT) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id q5-20020a056a00084500b0050ace4a699dsm5657964pfk.95.2022.04.21.04.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 04:03:53 -0700 (PDT) From: Miaoqian Lin To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Miaoqian Lin , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: imx35: Fix refcount leak in mx35_read_cpu_rev Date: Thu, 21 Apr 2022 19:03:44 +0800 Message-Id: <20220421110347.4304-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount. Fixes: f68ea682d1da ("ARM: imx35: Retrieve the IIM base address from devicetree") Signed-off-by: Miaoqian Lin --- arch/arm/mach-imx/cpu-imx35.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/cpu-imx35.c b/arch/arm/mach-imx/cpu-imx35.c index 80e7d8ab9f1b..3ae4a3dc44fb 100644 --- a/arch/arm/mach-imx/cpu-imx35.c +++ b/arch/arm/mach-imx/cpu-imx35.c @@ -22,6 +22,7 @@ static int mx35_read_cpu_rev(void) np = of_find_compatible_node(NULL, NULL, "fsl,imx35-iim"); iim_base = of_iomap(np, 0); BUG_ON(!iim_base); + of_node_put(np); rev = imx_readl(iim_base + MXC_IIMSREV); switch (rev) { -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00566C433F5 for ; Thu, 21 Apr 2022 11:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=rdEHQDelqYzlyLkxHWLD4wXU3YmpNSF2BcF2Dhw1Ar4=; b=mmDXcCa50Qp99i uEw7CI/JJXNZSzptubV9u10F28yt4mJSKE7Qq+ahGDmIg2uOEZMX9K6iXS+A9udKhdlRTVEWZLOT0 O64cHBGdh45PyYrGe7VmqF+FJvl1sJxdJyXHl2v9eoxNc6HPtVBS/4EjBL7oANntTmKH/WnkqAl/C RXtpRS+ndKoLS79tUXIwPtJKF2nTDk1YWEKxSg99T3fUzCvcNF80zjP1DwHJiZYdiRUKvhaCFwtix c3qJ/4OLr6asCDUJZv/6i7pMLgJbAp+ZUw4sIFtLZQdkD6Wd5PLTobxtp9uEjmXAR91tFWsdswKzD CmBe5iW3x0FibrVFQ9sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhUbQ-00D8ER-6E; Thu, 21 Apr 2022 11:04:00 +0000 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhUbN-00D8Ch-3F for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 11:03:58 +0000 Received: by mail-pf1-x430.google.com with SMTP id b15so4694535pfm.5 for ; Thu, 21 Apr 2022 04:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=b5cKgnHy5yIWx7IkuUyQsnSmFcYWr+B7twcbgmrD1pA=; b=obvkjUMexbjkc1qj09DfdFfiI7G7jgdbCm5eqjNe5hceKeW3SJk5IVv5dMWanBegdI X6Vg9585ErIRwvA80R7dx/hV2W2UMBriM6ncwqmUfHM/cwrNi8lau2sDMurX0LlfkDH1 HMPR7megoF95tf+lL7wMYRcCDXs5yagS3e5bFYfMuSnmbDUPKPm/gjEZ0GpAdTIE+KeN RBpu2CtLHxwAZMrnZLGlbvJRYeJCimD3dwtlPQ/kZZQet1Z1g9/9K3kxVBviX+0Qa//W dO460VGTqbiM9wkrWJybohcQMcPO6BPDXV7OfqVmzZXka+agjeIJvtBRN85YoudByZIc KDdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=b5cKgnHy5yIWx7IkuUyQsnSmFcYWr+B7twcbgmrD1pA=; b=PEr1y8XOEWfcY2Ab2iDjh2NZU+NcEru3bLb/ZYsMwT4FDVnQWZZuxoqeI77GWR9EiN 7PT+8bjgzj9MTqCqQE7IO7JKmdGV/wNeUn8bqhdtcsr5MuHMFOs7Ue4CiYRImr738+x3 CGi8NqzHFBphre37snFvuCCpDwQ/Q9sDLfCZM/0oHqlTzuBX6mHjWjSI1NAaEfpFAznt J3cWl27bYpezv0vPsFJAorBn/q/NiB0logV1MkwEkUZ8t8Nd2d0QU4akaz5OKKsSptrR uE8hQmsQdaXDxa7EoYBX+Kpx5P6QHLQrW1+nuqkZe2CknZldf9DRmXzgLmKkgSXrRl8a frdg== X-Gm-Message-State: AOAM530quDVynM5QuluFkU009TLGM4h0G1k0kZQoMJC7ilIz6g73uODM LwX4aACz0PDjDNLgn9gxkK6JBft/P3NxIXO4rqY= X-Google-Smtp-Source: ABdhPJyYZCtFhdhMOk0AYGm3maxZ92nO7efmlTmc2GCYMV8UNCv698p1A6ja1HAXBQTX5iSeqJz19A== X-Received: by 2002:a62:170b:0:b0:50a:6901:b633 with SMTP id 11-20020a62170b000000b0050a6901b633mr23204994pfx.34.1650539033603; Thu, 21 Apr 2022 04:03:53 -0700 (PDT) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id q5-20020a056a00084500b0050ace4a699dsm5657964pfk.95.2022.04.21.04.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 04:03:53 -0700 (PDT) From: Miaoqian Lin To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Miaoqian Lin , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: imx35: Fix refcount leak in mx35_read_cpu_rev Date: Thu, 21 Apr 2022 19:03:44 +0800 Message-Id: <20220421110347.4304-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_040357_197567_BFA2841C X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount. Fixes: f68ea682d1da ("ARM: imx35: Retrieve the IIM base address from devicetree") Signed-off-by: Miaoqian Lin --- arch/arm/mach-imx/cpu-imx35.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/cpu-imx35.c b/arch/arm/mach-imx/cpu-imx35.c index 80e7d8ab9f1b..3ae4a3dc44fb 100644 --- a/arch/arm/mach-imx/cpu-imx35.c +++ b/arch/arm/mach-imx/cpu-imx35.c @@ -22,6 +22,7 @@ static int mx35_read_cpu_rev(void) np = of_find_compatible_node(NULL, NULL, "fsl,imx35-iim"); iim_base = of_iomap(np, 0); BUG_ON(!iim_base); + of_node_put(np); rev = imx_readl(iim_base + MXC_IIMSREV); switch (rev) { -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel