From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CB2EC433EF for ; Thu, 21 Apr 2022 11:54:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C979B83BF4; Thu, 21 Apr 2022 13:54:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="A0v2Q+3k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 66FE083D73; Thu, 21 Apr 2022 13:54:33 +0200 (CEST) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9875483BF4 for ; Thu, 21 Apr 2022 13:54:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tommaso.merciai@amarulasolutions.com Received: by mail-ed1-x52d.google.com with SMTP id g20so6205073edw.6 for ; Thu, 21 Apr 2022 04:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LTf7Eb/s37amIomjkqDzEtb334GhlcQhaCpZ2BtkcxE=; b=A0v2Q+3kRrry0UWL1ZbitsP7iDottaQQ4WEoeMROudafMfKsbFBxNfIhkTxuUm3vWx 6fyiG7b+1q61mdZ/yRgCpG/MNvYUhd+cu3qF32kGLbhxgzloYzgnW+q4Cfhr5i8hppjr J0nHxfHrsLGP5izKl4dNtZOrwA8if7wqz35B4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LTf7Eb/s37amIomjkqDzEtb334GhlcQhaCpZ2BtkcxE=; b=i5L0GnSfhU7gLCtrFgCUcJuUndd7z8u98MB+sXV1zO4iRQb0YkgIiwGVFvQl7Kmvy8 fon8VBi8jHJQ3mqAFfQ3FTqQPlrMyHDqj4QXk3zzORdGu+7g18d3hAsmCVC2IXNoQ76N T7r7GpzYLYG9Hwlp2Po2my/DlvsbOAhskJDg0kUMURSzYdzCW++Covt3lvU9lO+1o85/ k3SeJMHd+2lPmwe5bHkdpQQ7XP3ox59056cdS9Gu4HD+wJ/LwYYtCnYL7vvl/ulz/T2o IPF17U+BwJMJqWUt4FQiw5oFv5huAeZyAJZ5w5QesHFV8Bc0k5RV/ZnjNMntRvHcAMOc zcDg== X-Gm-Message-State: AOAM531H21aqnMuLBJ9hGco4BQvwCITM0lBGegZfw86jz/HwZVQhYCXb L0c5uJ1eTQP3ebUxrIb0Lwdi7us0V3xF/w== X-Google-Smtp-Source: ABdhPJwbKv/KZ8pL0rVZNkVZyQ4mUKpHNvtptvPUdIEMqTpxB8BEpH2WtVP7RORNQ0CJCkyAaHV4UA== X-Received: by 2002:a05:6402:e85:b0:41d:121b:f436 with SMTP id h5-20020a0564020e8500b0041d121bf436mr28798659eda.121.1650542070213; Thu, 21 Apr 2022 04:54:30 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-56-163.cust.vodafonedsl.it. [188.217.56.163]) by smtp.gmail.com with ESMTPSA id dn7-20020a17090794c700b006e8b176143bsm7679959ejc.155.2022.04.21.04.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 04:54:29 -0700 (PDT) Date: Thu, 21 Apr 2022 13:54:27 +0200 From: Tommaso Merciai To: Marek Vasut Cc: Adam Ford , U-Boot Mailing List , Lukasz Majewski , Sean Anderson , Fabio Estevam , Tim Harvey , Michael Trimarchi Subject: Re: imx8mm eLCDIF clock Message-ID: <20220421115427.GE2335@tom-ThinkPad-T14s-Gen-2i> References: <20220421064805.GA2335@tom-ThinkPad-T14s-Gen-2i> <20220421102907.GC2335@tom-ThinkPad-T14s-Gen-2i> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, Apr 21, 2022 at 01:20:58PM +0200, Marek Vasut wrote: > On 4/21/22 13:14, Adam Ford wrote: > > On Thu, Apr 21, 2022 at 5:29 AM Tommaso Merciai > > wrote: > > > > > > On Thu, Apr 21, 2022 at 08:48:05AM +0200, Tommaso Merciai wrote: > > > > > > + Fabio > > > + Tim > > > + Michael > > > + Marek > > > + Adam > > > > > > > Hi, > > > > I'm working on drivers/clk/imx/clk-imx8mm.c to port and bring up eLCDIF > > > > clocks. After port all necessary clocks needed by eLCDIF I found that > > > > IMX8MM_VIDEO_PLL1 clock is not enabled and need the clk_enable to enable > > > > it at the end of the clk-imx8mm probe: > > > > > > > > struct clk *clkp; > > > > > > > > clk_get_by_id(IMX8MM_VIDEO_PLL1, &clkp); > > > > clk_set_rate(clkp, 594000000UL); > > > > clk_enable(clkp); > > > > > > > > What do you think about this solution? > > > > There is a more standard way to do this? > > > > I'm missing somethings? > > > > I think the LCD driver should request the clock and clock rate based > > on settings the device tree. However, I think the bigger issues is > > that you might run into issues with the lack of a disp-blkctrl driver. > > Marek enable the GPC driver fairly recently, but the blkctrl driver > > will be needed to enable the LCD and DSI portions or the system may > > hang. > > Just boot quickly and init the graphics pipeline in Linux ? Hi Marek, Thanks for your feedback. You think make no sense to enable support for the graphics pipeline at U-Boot level? Some customers want this feature for that I think is better to have support for that. What do you think about? Thanks, Tommaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com