From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH] xen/build: Fix MAP rule when called in isolation
Date: Thu, 21 Apr 2022 17:00:39 +0100 [thread overview]
Message-ID: <20220421160039.24564-1-andrew.cooper3@citrix.com> (raw)
Now that `make MAP` might rebuild $(TARGET), it needs removing from
no-dot-config-targets.
Otherwise the build eventually fails with:
CPP arch/x86/asm-macros.i
arch/x86/asm-macros.c:1:10: fatal error: asm/asm-defns.h: No such file or
directory
1 | #include <asm/asm-defns.h>
| ^~~~~~~~~~~~~~~~~
Fixes: e1e72198213b ("xen/build: Fix dependency for the MAP rule")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Anthony PERARD <anthony.perard@citrix.com>
Backporting notes. The original, e1e72198213b, wants backporting as far as we
can go. This patch is only relevant from 6c122d3984a5e onwards, so 4.14,
which is why my main developing/testing on 4.13 didn't spot it.
no-dot-config-targets seems like a very easy way to create breakage...
---
xen/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/Makefile b/xen/Makefile
index 3a4e3bdd0f95..ec34524ed21d 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -215,7 +215,7 @@ export XEN_ROOT := $(abs_srctree)/..
clean-targets := %clean
no-dot-config-targets := $(clean-targets) \
uninstall debug cloc \
- cscope TAGS tags MAP gtags \
+ cscope TAGS tags gtags \
xenversion
config-build := n
--
2.11.0
next reply other threads:[~2022-04-21 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 16:00 Andrew Cooper [this message]
2022-04-21 16:09 ` [PATCH] xen/build: Fix MAP rule when called in isolation Jan Beulich
2022-04-21 16:42 ` Andrew Cooper
2022-04-22 7:04 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421160039.24564-1-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=anthony.perard@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.