From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C9F11FBA for ; Fri, 22 Apr 2022 00:19:49 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id q22so7647489ljh.10 for ; Thu, 21 Apr 2022 17:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cN9ZhLUrf8Ngv6pdmP79a/DexlpcMLtixNmmzcyV9hA=; b=LArRVF1L5S+exersvD6njieFFNEV7araYOj8gZPObmLO8klh3ABsCS7aDto0KIkFkA gryZTmKRKKRbeKGinEDIvMghJVBVWVhHFoTru2RteUmqEI9N4Qz86WJJ+xBMxpWYi2hj X6UQcrAo0+Nsqn+uEsdJ3rb1t2r6SS1RjuGdi3XRhqWYu0EBuWptIuWdI3dqWciJWBw7 /601VPw5EC1WGlFgW7XG5/aOrD1ePUtb0cDN+nHXaQZnZS0QWmDy96aKVGUQRrDsCZSI a523+6DyR7nRYI63ugyMN4sQCCgdAbFrdJqwQxTm4KL/NiPBAzv7T6N5wmNRJcQvXVK1 18QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cN9ZhLUrf8Ngv6pdmP79a/DexlpcMLtixNmmzcyV9hA=; b=vvesbuQf2Kas+iESNJLf++2qdOby2D+/XmiwcLtFyvLZ8Pj5lQgB2WRzS0SvIXHqdC 37C9T9pD6EsK/PezDKDL1KLwijQiLafdaZH6pav1yKp01v0oGESVRWcKSfSbYNlGYQYF Z6fO2WZotJIfre9ifckpnbzwNv2Y3fNSHftG+XYcoTF/LW4tSN90ZFfjof+/hVbu3C/i K0hmfwlikXggr+M3MJE0j1Y93lDP5E6LgIOFt1UVxonjltqsH0+5uBSBa8Ak9N0TEUzh JaSIznLKsfhrpaPUepA4QwjJsmFxXlCj15jRLNs7rTKmkBY5dATUlvfyThUHUfiGOjMc ai9Q== X-Gm-Message-State: AOAM530/gmTz0OGtlL7swovTDcwHKKDki6Qs1ZSgI7QRIyyn/Ooscq2t 7XR2Fcir5cvGx8PHT3qJAlUBxw== X-Google-Smtp-Source: ABdhPJzMTYxtDeWJy9+XjUrtkBWIIe2HSlGBUf31nW/YAGzyb6TtF4NhfgICChBTw+MWha7yN0hDJQ== X-Received: by 2002:a05:651c:12c1:b0:249:7e8c:d5fc with SMTP id 1-20020a05651c12c100b002497e8cd5fcmr1203744lje.33.1650586786839; Thu, 21 Apr 2022 17:19:46 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id u25-20020a197919000000b0046b4f7553dcsm50363lfc.295.2022.04.21.17.19.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 17:19:46 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 67241104429; Fri, 22 Apr 2022 03:21:24 +0300 (+03) Date: Fri, 22 Apr 2022 03:21:24 +0300 From: "Kirill A. Shutemov" To: Borislav Petkov Cc: "Kirill A. Shutemov" , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Dave Hansen , Brijesh Singh , Mike Rapoport , David Hildenbrand , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 3/8] efi/x86: Implement support for unaccepted memory Message-ID: <20220422002124.lwd7b56zko24gbll@box.shutemov.name> References: <20220405234343.74045-1-kirill.shutemov@linux.intel.com> <20220405234343.74045-4-kirill.shutemov@linux.intel.com> <20220418155545.a567xnxa6elglapl@box.shutemov.name> <20220418202431.whvql4w57c7l5vpw@box.shutemov.name> <20220418235015.mnujtlmmlyin7y6m@box.shutemov.name> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 19, 2022 at 09:39:53AM +0200, Borislav Petkov wrote: > On Tue, Apr 19, 2022 at 02:50:15AM +0300, Kirill A. Shutemov wrote: > > I find it strange that you go after which has limited > > exposure while and are there already. > > Funny you should mention that: > > https://lore.kernel.org/r/YlCKWhMJEMUgJmjF@zn.tnic There's still #include in misc.h. You removed one, but there's a second one for some reason. Any plans for ? It includes : In file included from ./include/linux/cpumask.h:12, from ./include/linux/smp.h:13, from ./include/linux/lockdep.h:14, from ./include/linux/mutex.h:17, from ./include/linux/kernfs.h:11, from ./include/linux/sysfs.h:16, from ./include/linux/kobject.h:20, from ./include/linux/of.h:17, from ./include/linux/irqdomain.h:35, from ./include/linux/acpi.h:13, from arch/x86/boot/compressed/misc.h:3 We will get name conflicts if we try to copy stuff. Hm. I also underesitmated what is required to be copied because of the indirect include. The list was only to compile bitmap.c. mem.c (former unaccepted_memory.c) would require more. BTW, do we have a white list of linux/ includes that allowed? minmax.h? math.h? What is the line. Maybe allow what is included directly or indirectly now? (Yes, it is my poor attempt to slide under closing door.) -- Kirill A. Shutemov