From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B80C433FE for ; Fri, 22 Apr 2022 16:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378978AbiDVQU0 (ORCPT ); Fri, 22 Apr 2022 12:20:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378335AbiDVQUX (ORCPT ); Fri, 22 Apr 2022 12:20:23 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC0705DA53; Fri, 22 Apr 2022 09:17:28 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 23MGHCcm121089; Fri, 22 Apr 2022 11:17:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1650644232; bh=iYC92yO0nVNTBrV4ZcAROnLEimDhVCylf0MCz4FDpg8=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=XxG5mI0ikG5jZo4MowM6zesP/gy4T+x3jrUd68nqr/HcbxXAG7jpFJnwWTpjidPJ+ C3NI1cG10RFpY1ZaY+aujncHqwwFUL9xKCHsWPbWhdQIzKLVfsYnm/nbHhbZkHxFLU f571unjgjXI5Qz+xdaA/G4TGYXrLum1bgX3hm8FA= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 23MGHCXr059334 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 22 Apr 2022 11:17:12 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 22 Apr 2022 11:17:11 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 22 Apr 2022 11:17:11 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 23MGHBxn019241; Fri, 22 Apr 2022 11:17:11 -0500 Date: Fri, 22 Apr 2022 11:17:11 -0500 From: Nishanth Menon To: Rahul T R CC: Vignesh Raghavendra , , , , , , , , , Subject: Re: [PATCH v3 0/2] DSS: Add support for DisplayPort Message-ID: <20220422161711.jkderbw5r4wxwgjf@crudeness> References: <20220406165852.13026-1-r-ravikumar@ti.com> <20220422141637.4hz5nrlpjapmqezw@uda0490373> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220422141637.4hz5nrlpjapmqezw@uda0490373> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19:46-20220422, Rahul T R wrote: > On 12:51-20220415, Vignesh Raghavendra wrote: > > > > > > On 06/04/22 10:28 pm, Rahul T R wrote: > > > The following series of patches enables DisplayPort on > > > j721e-evm > > > > > > Tomi Valkeinen (2): > > > arm64: dts: ti: k3-j721e-main: add DP & DP PHY > > > arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm > > > > > > v2: > > > - use phandle with a parameter to refer clocks insted of > > > sub nodes in serdes_wiz node > > > - move phy link node to board DTS file > > > > > > v3: > > > - Fix the regulator node name as per the DT spec > > > - Use Macro for GPIO type > > > > > > boot logs: > > > https://gist.githubusercontent.com/ravi-rahul/1bdbc3f77ab381e486c8394650c2e85d/raw/f04584c30181821c4ee83aee7781a9ba143cd3f3/j7_DP_upstream.log > > > > > > kernel patch verify report: > > > https://gist.githubusercontent.com/ravi-rahul/a982fef3fae03ec0dbdd5cb475a4cb25/raw/c8230370746e9878daf9527c3aa9d82eed7aa33c/report-kernel-patch-verify.txt > > > > Hmm, With dtbs_check I see (on v5.18-rc1 tag) > > > > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: ports: 'port@0' is a required property > > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: ports: 'port@4' is a required property > > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: 'phys' is a required property > > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: 'phy-names' is a required property > > > > This goes away with 2/2 although adds: > > +: Warning (graph_child_address): /bus@100000/dss@4a00000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary > > > > > > Do we need to have empty ports node in j721e-main.dtsi for dp-bridge? And something similar wrt phys as well? > > > > Regards > > Vignesh > > Hi Vignesh, > > Thanks for the review! > Not sure why kernel patch verify did not catch this if you are'nt able to install all the required packages and version of packages, then use the kpv wrapper script for docker container that already packages things. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A448CC433F5 for ; Fri, 22 Apr 2022 16:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tMqqJ3krwwmiQTw/Vu92JGbQcO60FnDUsaGnjk+rR2U=; b=te0dEEG4Qm9aD/ +fzphRZsTU0eKUaIY4x2GAyZvxWbdXYPKTDs1pw2gTea7rOellI2XgO+4yx74J7rn8YRgKQGlPvMv vHPQhqdKzrVqonH5MwpBZ98HpoMkXq0TG+P6pBU/SFolcokJ6biu70uqUw7OeGToyk7sFZlOiwJw6 bH78DNALA7QbMw+5uxo7lrunsZXEHVQA3Fkz1fYVQ8mjaAJIeeaESG+bxSHXdCVs1GF78OPl7FkxO uo9lpILuLPyr98YcMjnTDi4v5FEWPbplLjOj9ru8gyR/Xmn5uXIuBzPGWkYR3+60lMcgkhvWzVRgp QVcyaHqHUWPwu3ZHalKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhvyM-001NPd-Fy; Fri, 22 Apr 2022 16:17:30 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhvyH-001NMU-97 for linux-arm-kernel@lists.infradead.org; Fri, 22 Apr 2022 16:17:27 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 23MGHCcm121089; Fri, 22 Apr 2022 11:17:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1650644232; bh=iYC92yO0nVNTBrV4ZcAROnLEimDhVCylf0MCz4FDpg8=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=XxG5mI0ikG5jZo4MowM6zesP/gy4T+x3jrUd68nqr/HcbxXAG7jpFJnwWTpjidPJ+ C3NI1cG10RFpY1ZaY+aujncHqwwFUL9xKCHsWPbWhdQIzKLVfsYnm/nbHhbZkHxFLU f571unjgjXI5Qz+xdaA/G4TGYXrLum1bgX3hm8FA= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 23MGHCXr059334 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 22 Apr 2022 11:17:12 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 22 Apr 2022 11:17:11 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 22 Apr 2022 11:17:11 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 23MGHBxn019241; Fri, 22 Apr 2022 11:17:11 -0500 Date: Fri, 22 Apr 2022 11:17:11 -0500 From: Nishanth Menon To: Rahul T R CC: Vignesh Raghavendra , , , , , , , , , Subject: Re: [PATCH v3 0/2] DSS: Add support for DisplayPort Message-ID: <20220422161711.jkderbw5r4wxwgjf@crudeness> References: <20220406165852.13026-1-r-ravikumar@ti.com> <20220422141637.4hz5nrlpjapmqezw@uda0490373> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220422141637.4hz5nrlpjapmqezw@uda0490373> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220422_091725_536593_9F5ADB39 X-CRM114-Status: GOOD ( 19.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19:46-20220422, Rahul T R wrote: > On 12:51-20220415, Vignesh Raghavendra wrote: > > > > > > On 06/04/22 10:28 pm, Rahul T R wrote: > > > The following series of patches enables DisplayPort on > > > j721e-evm > > > > > > Tomi Valkeinen (2): > > > arm64: dts: ti: k3-j721e-main: add DP & DP PHY > > > arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm > > > > > > v2: > > > - use phandle with a parameter to refer clocks insted of > > > sub nodes in serdes_wiz node > > > - move phy link node to board DTS file > > > > > > v3: > > > - Fix the regulator node name as per the DT spec > > > - Use Macro for GPIO type > > > > > > boot logs: > > > https://gist.githubusercontent.com/ravi-rahul/1bdbc3f77ab381e486c8394650c2e85d/raw/f04584c30181821c4ee83aee7781a9ba143cd3f3/j7_DP_upstream.log > > > > > > kernel patch verify report: > > > https://gist.githubusercontent.com/ravi-rahul/a982fef3fae03ec0dbdd5cb475a4cb25/raw/c8230370746e9878daf9527c3aa9d82eed7aa33c/report-kernel-patch-verify.txt > > > > Hmm, With dtbs_check I see (on v5.18-rc1 tag) > > > > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: ports: 'port@0' is a required property > > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: ports: 'port@4' is a required property > > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: 'phys' is a required property > > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: 'phy-names' is a required property > > > > This goes away with 2/2 although adds: > > +: Warning (graph_child_address): /bus@100000/dss@4a00000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary > > > > > > Do we need to have empty ports node in j721e-main.dtsi for dp-bridge? And something similar wrt phys as well? > > > > Regards > > Vignesh > > Hi Vignesh, > > Thanks for the review! > Not sure why kernel patch verify did not catch this if you are'nt able to install all the required packages and version of packages, then use the kpv wrapper script for docker container that already packages things. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel