From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BA9F7A for ; Fri, 22 Apr 2022 21:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650662424; x=1682198424; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8oZmbcJgaLEluY4MIs8edkXFbtUVeZ9n1fl2FQ+iUbA=; b=joqrbPIsQ43IDa7ue27QFf3FIVaMURRu/6jQLLniOBj/+I5ndkNnp17k 3zDRTFdcccmbl7V24NB4ucjWwn9cXQhJhkfZB2pzlbCsqf1H0bglAdCr7 vpdxz3280J8UNTTphJR7Ndr5Vja+TW5ByPgQxq8Mlh3wMjf+nkrkdUPoJ MJmgPbqdk/suwzY77CLs/iJgivbjlxbx2cSMkjvD+ry3GwK+5lBHQniFn vWrGLucq56w3HbKhVvGSog2hHbovFTGwKGWt4oxFqV5ilOh1I++/Xv2rR YlB4NyAbCFTg1Hky+SomknkPEMSTOKxNi3kNzAFXAVBQm4BQ71pfu3Ltp w==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="252120042" X-IronPort-AV: E=Sophos;i="5.90,282,1643702400"; d="scan'208";a="252120042" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2022 14:20:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,282,1643702400"; d="scan'208";a="659211292" Received: from lkp-server01.sh.intel.com (HELO 3abc53900bec) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 22 Apr 2022 14:20:14 -0700 Received: from kbuild by 3abc53900bec with local (Exim 4.95) (envelope-from ) id 1ni0hJ-000Aag-Ri; Fri, 22 Apr 2022 21:20:13 +0000 Date: Sat, 23 Apr 2022 05:19:22 +0800 From: kernel test robot To: Quan Nguyen , Lee Jones , Rob Herring , Krzysztof Kozlowski , Jean Delvare , Guenter Roeck , Jonathan Corbet , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Thu Nguyen , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, OpenBMC Maillist Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" Subject: Re: [PATCH v8 8/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro MFD driver Message-ID: <202204230554.4528TqPu-lkp@intel.com> References: <20220422024653.2199489-9-quan@os.amperecomputing.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422024653.2199489-9-quan@os.amperecomputing.com> Hi Quan, I love your patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on groeck-staging/hwmon-next lee-mfd/for-mfd-next v5.18-rc3 next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Quan-Nguyen/Add-Ampere-s-Altra-SMPro-MFD-and-its-child-drivers/20220422-105732 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git c50c29a806113614098efd8da9fd7b48d605ba45 config: arm-randconfig-r004-20220422 (https://download.01.org/0day-ci/archive/20220423/202204230554.4528TqPu-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5bd87350a5ae429baf8f373cb226a57b62f87280) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/09ec873f0dd4611cb2df0150923d8906b9c5b2d1 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Quan-Nguyen/Add-Ampere-s-Altra-SMPro-MFD-and-its-child-drivers/20220422-105732 git checkout 09ec873f0dd4611cb2df0150923d8906b9c5b2d1 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/mach-at91/ drivers/hwmon/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/hwmon/smpro-hwmon.c:376:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] default: ^ drivers/hwmon/smpro-hwmon.c:376:3: note: insert 'break;' to avoid fall-through default: ^ break; 1 warning generated. vim +376 drivers/hwmon/smpro-hwmon.c e1354080fc83378 Quan Nguyen 2022-04-22 359 e1354080fc83378 Quan Nguyen 2022-04-22 360 static umode_t smpro_is_visible(const void *data, enum hwmon_sensor_types type, e1354080fc83378 Quan Nguyen 2022-04-22 361 u32 attr, int channel) e1354080fc83378 Quan Nguyen 2022-04-22 362 { e1354080fc83378 Quan Nguyen 2022-04-22 363 const struct smpro_hwmon *hwmon = data; e1354080fc83378 Quan Nguyen 2022-04-22 364 unsigned int value; e1354080fc83378 Quan Nguyen 2022-04-22 365 int ret; e1354080fc83378 Quan Nguyen 2022-04-22 366 e1354080fc83378 Quan Nguyen 2022-04-22 367 switch (type) { e1354080fc83378 Quan Nguyen 2022-04-22 368 case hwmon_temp: e1354080fc83378 Quan Nguyen 2022-04-22 369 switch (attr) { e1354080fc83378 Quan Nguyen 2022-04-22 370 case hwmon_temp_input: e1354080fc83378 Quan Nguyen 2022-04-22 371 case hwmon_temp_label: e1354080fc83378 Quan Nguyen 2022-04-22 372 case hwmon_temp_crit: e1354080fc83378 Quan Nguyen 2022-04-22 373 ret = regmap_read(hwmon->regmap, temperature[channel].reg, &value); e1354080fc83378 Quan Nguyen 2022-04-22 374 if (ret || value == 0xFFFF) e1354080fc83378 Quan Nguyen 2022-04-22 375 return 0; e1354080fc83378 Quan Nguyen 2022-04-22 @376 default: e1354080fc83378 Quan Nguyen 2022-04-22 377 break; e1354080fc83378 Quan Nguyen 2022-04-22 378 } e1354080fc83378 Quan Nguyen 2022-04-22 379 break; e1354080fc83378 Quan Nguyen 2022-04-22 380 default: e1354080fc83378 Quan Nguyen 2022-04-22 381 break; e1354080fc83378 Quan Nguyen 2022-04-22 382 } e1354080fc83378 Quan Nguyen 2022-04-22 383 e1354080fc83378 Quan Nguyen 2022-04-22 384 return 0444; e1354080fc83378 Quan Nguyen 2022-04-22 385 } e1354080fc83378 Quan Nguyen 2022-04-22 386 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75FB5C433EF for ; Fri, 22 Apr 2022 21:22:11 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KlS694LP1z3bc8 for ; Sat, 23 Apr 2022 07:22:09 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=gYE9voRh; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=lkp@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=gYE9voRh; dkim-atps=neutral Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KlS5P40SCz3bYG for ; Sat, 23 Apr 2022 07:21:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650662489; x=1682198489; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8oZmbcJgaLEluY4MIs8edkXFbtUVeZ9n1fl2FQ+iUbA=; b=gYE9voRh1gRgKXHTwA0eBDrrodQhTAb5rFVzKi3jhq4ZFugGyCO7ricM Be87oAmB1z/2CVIcvpwzMV6omdegxxaExy47zI9n/Y7ZqBKB1hAH9MPjb 5KIxSw9t5JLQVGqzNebqHPH4hQnIHTQ5EbTvtrtDH1XOW6vC3uieMe1P1 +ZzNQ+E8ZjGxfO8R4POqtwOBYeSvXTd4sGj98ZnDBJFTQnsQGmxHhWNiP 9rAlJSCPF95XCSE8qy9pmtpe6p+QVwXCy2AebSPrX5ytkC1JxWvebogDs icRf5tDDWykagw64QHmdLgt57228kYh/2hg3jOyc9o1WHAl5A1Y1n1GJK A==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="246694290" X-IronPort-AV: E=Sophos;i="5.90,282,1643702400"; d="scan'208";a="246694290" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2022 14:20:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,282,1643702400"; d="scan'208";a="659211292" Received: from lkp-server01.sh.intel.com (HELO 3abc53900bec) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 22 Apr 2022 14:20:14 -0700 Received: from kbuild by 3abc53900bec with local (Exim 4.95) (envelope-from ) id 1ni0hJ-000Aag-Ri; Fri, 22 Apr 2022 21:20:13 +0000 Date: Sat, 23 Apr 2022 05:19:22 +0800 From: kernel test robot To: Quan Nguyen , Lee Jones , Rob Herring , Krzysztof Kozlowski , Jean Delvare , Guenter Roeck , Jonathan Corbet , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Thu Nguyen , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, OpenBMC Maillist Subject: Re: [PATCH v8 8/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro MFD driver Message-ID: <202204230554.4528TqPu-lkp@intel.com> References: <20220422024653.2199489-9-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422024653.2199489-9-quan@os.amperecomputing.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Open Source Submission , llvm@lists.linux.dev, kbuild-all@lists.01.org, Phong Vo , "Thang Q . Nguyen" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Quan, I love your patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on groeck-staging/hwmon-next lee-mfd/for-mfd-next v5.18-rc3 next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Quan-Nguyen/Add-Ampere-s-Altra-SMPro-MFD-and-its-child-drivers/20220422-105732 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git c50c29a806113614098efd8da9fd7b48d605ba45 config: arm-randconfig-r004-20220422 (https://download.01.org/0day-ci/archive/20220423/202204230554.4528TqPu-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5bd87350a5ae429baf8f373cb226a57b62f87280) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/09ec873f0dd4611cb2df0150923d8906b9c5b2d1 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Quan-Nguyen/Add-Ampere-s-Altra-SMPro-MFD-and-its-child-drivers/20220422-105732 git checkout 09ec873f0dd4611cb2df0150923d8906b9c5b2d1 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/mach-at91/ drivers/hwmon/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/hwmon/smpro-hwmon.c:376:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] default: ^ drivers/hwmon/smpro-hwmon.c:376:3: note: insert 'break;' to avoid fall-through default: ^ break; 1 warning generated. vim +376 drivers/hwmon/smpro-hwmon.c e1354080fc83378 Quan Nguyen 2022-04-22 359 e1354080fc83378 Quan Nguyen 2022-04-22 360 static umode_t smpro_is_visible(const void *data, enum hwmon_sensor_types type, e1354080fc83378 Quan Nguyen 2022-04-22 361 u32 attr, int channel) e1354080fc83378 Quan Nguyen 2022-04-22 362 { e1354080fc83378 Quan Nguyen 2022-04-22 363 const struct smpro_hwmon *hwmon = data; e1354080fc83378 Quan Nguyen 2022-04-22 364 unsigned int value; e1354080fc83378 Quan Nguyen 2022-04-22 365 int ret; e1354080fc83378 Quan Nguyen 2022-04-22 366 e1354080fc83378 Quan Nguyen 2022-04-22 367 switch (type) { e1354080fc83378 Quan Nguyen 2022-04-22 368 case hwmon_temp: e1354080fc83378 Quan Nguyen 2022-04-22 369 switch (attr) { e1354080fc83378 Quan Nguyen 2022-04-22 370 case hwmon_temp_input: e1354080fc83378 Quan Nguyen 2022-04-22 371 case hwmon_temp_label: e1354080fc83378 Quan Nguyen 2022-04-22 372 case hwmon_temp_crit: e1354080fc83378 Quan Nguyen 2022-04-22 373 ret = regmap_read(hwmon->regmap, temperature[channel].reg, &value); e1354080fc83378 Quan Nguyen 2022-04-22 374 if (ret || value == 0xFFFF) e1354080fc83378 Quan Nguyen 2022-04-22 375 return 0; e1354080fc83378 Quan Nguyen 2022-04-22 @376 default: e1354080fc83378 Quan Nguyen 2022-04-22 377 break; e1354080fc83378 Quan Nguyen 2022-04-22 378 } e1354080fc83378 Quan Nguyen 2022-04-22 379 break; e1354080fc83378 Quan Nguyen 2022-04-22 380 default: e1354080fc83378 Quan Nguyen 2022-04-22 381 break; e1354080fc83378 Quan Nguyen 2022-04-22 382 } e1354080fc83378 Quan Nguyen 2022-04-22 383 e1354080fc83378 Quan Nguyen 2022-04-22 384 return 0444; e1354080fc83378 Quan Nguyen 2022-04-22 385 } e1354080fc83378 Quan Nguyen 2022-04-22 386 -- 0-DAY CI Kernel Test Service https://01.org/lkp