From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A08C433F5 for ; Sat, 23 Apr 2022 04:26:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232874AbiDWE3s (ORCPT ); Sat, 23 Apr 2022 00:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232761AbiDWE3o (ORCPT ); Sat, 23 Apr 2022 00:29:44 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B704E6441; Fri, 22 Apr 2022 21:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650688007; x=1682224007; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2ml0TS+9I0iNoLYUgBGKFcxsSut//WkkULNAjxgIoNc=; b=NRzrpDqJYIzLgQcX8yKOKl0uRU2m2DmZaJMOgPxlbIlz2+x+P8BWCaHm oP4ZYa444DUAMdSLItTYHyK0EVBeeKdMOOTQAFzYNZ/JUMoIrDrwsRyNl gKF0sc46aew04DRLmC+CLftbTlsKttT+r32D8ZBa27+PPp6zqo+xbnIf8 Eh9p/wmG7RmdhPKDtkVmxU4giB75yrLcEvpZhiso0wgMfDsmjrjPelW85 Zp1LYkuiNI0d9SYqjfjqur8INEEXjpJWNHMLEJCPQ38zMsG5+JN5OeDaw c4IYab1KHvWElyq1C7TOH0sI41TQBUK+FD+aqQg1NGUT1TT9W0dxCvfNW Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="325299705" X-IronPort-AV: E=Sophos;i="5.90,283,1643702400"; d="scan'208";a="325299705" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2022 21:26:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,283,1643702400"; d="scan'208";a="703818105" Received: from lkp-server01.sh.intel.com (HELO 3abc53900bec) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 22 Apr 2022 21:26:43 -0700 Received: from kbuild by 3abc53900bec with local (Exim 4.95) (envelope-from ) id 1ni7M3-000Azh-6w; Sat, 23 Apr 2022 04:26:43 +0000 Date: Sat, 23 Apr 2022 12:26:14 +0800 From: kernel test robot To: Junwen Wu , akpm@linux-foundation.org, keescook@chromium.org, adobriyan@gmail.com, fweimer@redhat.com, ddiss@suse.de Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Junwen Wu Subject: Re: [PATCH v1] proc: limit schedstate node write operation Message-ID: <202204231250.LYIILAXn-lkp@intel.com> References: <20220423023104.153004-1-wudaemon@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220423023104.153004-1-wudaemon@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Junwen, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] [also build test WARNING on kees/for-next/pstore linus/master linux/master v5.18-rc3 next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Junwen-Wu/proc-limit-schedstate-node-write-operation/20220423-103457 base: https://github.com/hnaz/linux-mm master config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220423/202204231250.LYIILAXn-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/e7bc039b7c0aa4e9a5bb3ae2340769a451f795db git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Junwen-Wu/proc-limit-schedstate-node-write-operation/20220423-103457 git checkout e7bc039b7c0aa4e9a5bb3ae2340769a451f795db # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/proc/base.c: In function 'sched_write': >> fs/proc/base.c:1468:13: warning: 'strcmp' of a string of length 5 and an array of size 5 evaluates to nonzero [-Wstring-compare] 1468 | if (strcmp(ubuf, "reset") == 0) { | ^~~~~~~~~~~~~~~~~~~~~ vim +/strcmp +1468 fs/proc/base.c 1454 1455 static ssize_t 1456 sched_write(struct file *file, const char __user *buf, 1457 size_t count, loff_t *offset) 1458 { 1459 struct inode *inode = file_inode(file); 1460 struct task_struct *p; 1461 char ubuf[5]; 1462 1463 memset(ubuf, 0, sizeof(ubuf)); 1464 if (count > 5) 1465 count = 0; 1466 if (copy_from_user(ubuf, buf, count)) 1467 return -EFAULT; > 1468 if (strcmp(ubuf, "reset") == 0) { 1469 p = get_proc_task(inode); 1470 if (!p) 1471 return -ESRCH; 1472 proc_sched_set_task(p); 1473 1474 put_task_struct(p); 1475 } 1476 1477 return count; 1478 } 1479 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 481E5C433F5 for ; Sun, 24 Apr 2022 15:43:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232082AbiDXPqn (ORCPT ); Sun, 24 Apr 2022 11:46:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbiDXPqi (ORCPT ); Sun, 24 Apr 2022 11:46:38 -0400 X-Greylist: delayed 907 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 24 Apr 2022 08:43:36 PDT Received: from m12-18.163.com (m12-18.163.com [220.181.12.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A146232EF7; Sun, 24 Apr 2022 08:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=xuJCo hPLpFFq0nMkMgsbwR1ueyZayVeBCU2CJqE14pI=; b=jNQkkiccd/n8seGOBVHS4 m0YAZMfc4LWuwlRnOjvlX1aNv7CljcpvJSThbl52VsZFLGEU95vGyg5xWI+jwvdC XOT+p/3n00a00myuOBiZQ7djO4umHcLO9JfNcv1yUzEP0XgsTlUX8Z+hqSmiRQuq pZBzoOT8A7e6Xj4D7+Icww= Received: from localhost (unknown [113.87.88.166]) by smtp14 (Coremail) with SMTP id EsCowAC3FO6BbGVifODzCg--.55167S2; Sun, 24 Apr 2022 23:28:02 +0800 (CST) From: Junwen Wu To: lkp@intel.com, Junwen Wu , akpm@linux-foundation.org, keescook@chromium.org, adobriyan@gmail.com, fweimer@redhat.com, ddiss@suse.de Cc: kbuild-all@lists.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] proc: limit schedstate node write operation Date: Sun, 24 Apr 2022 15:27:55 +0000 Message-ID: <202204231250.LYIILAXn-lkp@intel.com> (raw) X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220423023104.153004-1-wudaemon@163.com> References: <202204231250.LYIILAXn-lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: EsCowAC3FO6BbGVifODzCg--.55167S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjTRuQ6pUUUUU X-Originating-IP: [113.87.88.166] X-CM-SenderInfo: 5zxgtvxprqqiywtou0bp/1tbisRrsbVXlpdDfGgABsr Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20220424152755.XlKFOAM1-eaPDq6XDux8UQbPy3XXH1M7hPn9guR1W1Q@z> From: kernel test robot >Hi Junwen, >Thank you for the patch! Perhaps something to improve: ooh ,I will fix the warning