From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8871C433F5 for ; Sat, 23 Apr 2022 15:33:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234156AbiDWPgY (ORCPT ); Sat, 23 Apr 2022 11:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230271AbiDWPgW (ORCPT ); Sat, 23 Apr 2022 11:36:22 -0400 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85F771E2C34; Sat, 23 Apr 2022 08:33:25 -0700 (PDT) Received: by mail-qt1-f172.google.com with SMTP id f14so7580083qtq.1; Sat, 23 Apr 2022 08:33:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=qJrUJVGVT6gqJK4KN8HDJusUJ1FB5XVpIwvyKJbnkls=; b=k6FpbbMMBnbTlsX4CQCthBCen/1Kr7VPQfLSHOIvEEGwgwvviL5VLKueOMvS+RNiVt +fa6sYL00wUT4yXeW2tdYTb6aVUVqAQHuJeXFp5aXd8L9cxFoc+zXFObAwI8A8yIi+bt A4ErT1vJiPcoMazNW5xa7QpVKb1lcf7hE4hVBorzf+zVxiIGTfXovdCvxjTQK0Wdwlfs 9zsfcU+0UVUPHY0FIHPGrmxo56T9giQ1mBYXFoz5gPHLJ3kmrBt6YwtNDYGg7zmd48Lo /1zSsH0gIBqLYbpekyQ7tEtQq5RmSbJDWplxxcbuq84C6wDZlmbNTSWcA3kDz43dgY3G M1gQ== X-Gm-Message-State: AOAM531CzIV9tcTdNopeJ3XiOJGcliohb8etJwchhJymI4w+VHryD9PX PL9QCR1s5FKvwOypp6Vf5IU= X-Google-Smtp-Source: ABdhPJydqQZ+KYP1B8EgK79hxqm7VtvY1k4CpTZbNBftmTVxThWugowAhDIPkdk/lE5nCghmUeiGlw== X-Received: by 2002:a05:622a:651:b0:2f2:600:d146 with SMTP id a17-20020a05622a065100b002f20600d146mr6920846qtb.88.1650728004508; Sat, 23 Apr 2022 08:33:24 -0700 (PDT) Received: from dev0025.ash9.facebook.com (fwdproxy-ash-005.fbsv.net. [2a03:2880:20ff:5::face:b00c]) by smtp.gmail.com with ESMTPSA id g11-20020ac84b6b000000b002f35e802a55sm1754224qts.1.2022.04.23.08.33.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 08:33:24 -0700 (PDT) Date: Sat, 23 Apr 2022 08:33:21 -0700 From: David Vernet To: Roman Gushchin Cc: akpm@linux-foundation.org, tj@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, kernel-team@fb.com Subject: Re: [PATCH 1/5] cgroups: Refactor children cgroups in memcg tests Message-ID: <20220423153321.cts6qhlybkghoe2o@dev0025.ash9.facebook.com> References: <20220423113037.gnfysktiuzmfnpmp@dev0025.ash9.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20211029 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 23, 2022 at 08:19:12AM -0700, Roman Gushchin wrote: > > > On Apr 23, 2022, at 4:30 AM, David Vernet wrote: > > > > On Fri, Apr 22, 2022 at 04:04:15PM -0700, Roman Gushchin wrote: > >> > > > > Thanks for the reviews on this patchset, Roman. FYI I think Andrew already > > merged these patches to the -mm tree. I'll send out a follow-on patch that > > fixes everything you pointed out, both here and on the other patches in the > > set. > > The mm tree isn’t a git tree, but a collection of the text patches, managed by Andrew. So you can send a new version and Andrew can update it in place. It’s happening all the time: mostly for adding reviewed-by/acked-by tags etc, but for code updates as well. > It’s not uncommon for some patchset to mature while being in the mm tree, this allows to include them into linux-next and give some more testing, but without doing many reverts/fixups (Andrew is often squashing fixups into the original patch too). So long story short, you can just send a new version, especially because all changes all minor. Ah, that makes sense. Thanks for explaining that. I'll send out a v2 of the patches shortly, then! From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vernet Subject: Re: [PATCH 1/5] cgroups: Refactor children cgroups in memcg tests Date: Sat, 23 Apr 2022 08:33:21 -0700 Message-ID: <20220423153321.cts6qhlybkghoe2o@dev0025.ash9.facebook.com> References: <20220423113037.gnfysktiuzmfnpmp@dev0025.ash9.facebook.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="utf-8" To: Roman Gushchin Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org On Sat, Apr 23, 2022 at 08:19:12AM -0700, Roman Gushchin wrote: > > > On Apr 23, 2022, at 4:30 AM, David Vernet wrote: > > > > On Fri, Apr 22, 2022 at 04:04:15PM -0700, Roman Gushchin wrote: > >> > > > > Thanks for the reviews on this patchset, Roman. FYI I think Andrew already > > merged these patches to the -mm tree. I'll send out a follow-on patch that > > fixes everything you pointed out, both here and on the other patches in the > > set. > > The mm tree isn’t a git tree, but a collection of the text patches, managed by Andrew. So you can send a new version and Andrew can update it in place. It’s happening all the time: mostly for adding reviewed-by/acked-by tags etc, but for code updates as well. > It’s not uncommon for some patchset to mature while being in the mm tree, this allows to include them into linux-next and give some more testing, but without doing many reverts/fixups (Andrew is often squashing fixups into the original patch too). So long story short, you can just send a new version, especially because all changes all minor. Ah, that makes sense. Thanks for explaining that. I'll send out a v2 of the patches shortly, then!