* [PATCH] scsi: qla2xxx: remove unneeded flush_workqueue
@ 2022-04-24 6:24 cgel.zte
2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-24 6:24 UTC (permalink / raw)
To: njavali
Cc: GR-QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi,
linux-kernel, ran jianping, Zeal Robot
From: ran jianping <ran.jianping@zte.com.cn>
All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
drivers/scsi/qla2xxx/qla_os.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 762229d495a8..73073fb08369 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -3933,7 +3933,6 @@ qla2x00_free_device(scsi_qla_host_t *vha)
/* Flush the work queue and remove it */
if (ha->wq) {
- flush_workqueue(ha->wq);
destroy_workqueue(ha->wq);
ha->wq = NULL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qla2xxx: remove unneeded flush_workqueue
2022-04-24 6:24 [PATCH] scsi: qla2xxx: remove unneeded flush_workqueue cgel.zte
@ 2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-05-03 0:51 UTC (permalink / raw)
To: njavali, cgel.zte
Cc: Martin K . Petersen, ran jianping, GR-QLogic-Storage-Upstream,
linux-kernel, jejb, Zeal Robot, linux-scsi
On Sun, 24 Apr 2022 06:24:13 +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: qla2xxx: remove unneeded flush_workqueue
https://git.kernel.org/mkp/scsi/c/cf97628fe1a1
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-04 6:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-24 6:24 [PATCH] scsi: qla2xxx: remove unneeded flush_workqueue cgel.zte
2022-05-03 0:51 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.