All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cindy Lu <lulu@redhat.com>
To: mst@redhat.com, jasowang@redhat.com, lulu@redhat.com,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] vdpa: add the check for id_table in struct vdpa_mgmt_dev
Date: Mon, 25 Apr 2022 14:27:33 +0800	[thread overview]
Message-ID: <20220425062735.172576-1-lulu@redhat.com> (raw)

To support the dynamic ids in vp_vdpa, we need to add the check for
id table. If the id table is NULL, will not set the device type

Signed-off-by: Cindy Lu <lulu@redhat.com>
---
 drivers/vdpa/vdpa.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index 1ea525433a5c..09edd92cede0 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -492,10 +492,13 @@ static int vdpa_mgmtdev_fill(const struct vdpa_mgmt_dev *mdev, struct sk_buff *m
 	if (err)
 		goto msg_err;
 
-	while (mdev->id_table[i].device) {
-		if (mdev->id_table[i].device <= 63)
-			supported_classes |= BIT_ULL(mdev->id_table[i].device);
-		i++;
+	if (mdev->id_table != NULL) {
+		while (mdev->id_table[i].device) {
+			if (mdev->id_table[i].device <= 63)
+				supported_classes |=
+					BIT_ULL(mdev->id_table[i].device);
+			i++;
+		}
 	}
 
 	if (nla_put_u64_64bit(msg, VDPA_ATTR_MGMTDEV_SUPPORTED_CLASSES,
-- 
2.34.1


             reply	other threads:[~2022-04-25  6:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25  6:27 Cindy Lu [this message]
2022-04-25  8:59 ` [PATCH v2 1/2] vdpa: add the check for id_table in struct vdpa_mgmt_dev Jason Wang
2022-04-25  8:59   ` Jason Wang
2022-04-27  2:01   ` Cindy Lu
2022-04-27  4:03     ` Jason Wang
2022-04-27  4:03       ` Jason Wang
2022-04-28  1:56       ` Cindy Lu
2022-04-28  3:07         ` Jason Wang
2022-04-28  3:07           ` Jason Wang
2022-04-28  3:21           ` Cindy Lu
2022-04-28  3:45             ` Jason Wang
2022-04-28  3:45               ` Jason Wang
2022-04-28  7:14               ` Cindy Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220425062735.172576-1-lulu@redhat.com \
    --to=lulu@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.