From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31224C433EF for ; Mon, 25 Apr 2022 07:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232501AbiDYHmq (ORCPT ); Mon, 25 Apr 2022 03:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240010AbiDYHmf (ORCPT ); Mon, 25 Apr 2022 03:42:35 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5150F1EC65; Mon, 25 Apr 2022 00:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650872369; x=1682408369; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3KF/nt6njR142ErCOrFh+78Qmc0uUlvrXI0T2lqSfgI=; b=anMJAV56slPzoLJLm8CV4apSUhYIkAWjSpqH+37f9mCU/xlNLzFYQ8Cd BagUvcKdtmsERH7hg6VeAtd0CC8azIavdVoVI3Hr73P/5IrUHGFGV4Iun OAjQT9cuKFgATku2IIFq0qqsIKBot9S49bTrEzYlPNJARRbQqanhb05hn pLFPP75ftDWwkriWvAgtts5SpAdnOES41GwslhmNE5btu7PwqoLSX1hoo OAWzrRUrYThjfbzg4Sqy49UNaWF4GGJDB0bGx12zw+YkUDsFkciv0Ft4L LRv0FhVkG7whq2Gna3CApYm1cPyvB7aZNmsCJbAW6VyNwLdAGu0v9gKOs A==; X-IronPort-AV: E=McAfee;i="6400,9594,10327"; a="264971399" X-IronPort-AV: E=Sophos;i="5.90,287,1643702400"; d="scan'208";a="264971399" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2022 00:39:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,287,1643702400"; d="scan'208";a="531988427" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.135]) by orsmga006.jf.intel.com with ESMTP; 25 Apr 2022 00:39:20 -0700 Date: Mon, 25 Apr 2022 15:31:39 +0800 From: Xu Yilun To: Moritz Fischer Cc: Tianfei Zhang , hao.wu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net, Matthew Gerlach Subject: Re: [PATCH v7 1/2] fpga: dfl: check feature type before parse irq info Message-ID: <20220425073139.GC363795@yilunxu-OptiPlex-7050> References: <20220419032942.427429-1-tianfei.zhang@intel.com> <20220419032942.427429-2-tianfei.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, Apr 21, 2022 at 07:46:21AM -0700, Moritz Fischer wrote: > On Mon, Apr 18, 2022 at 11:29:41PM -0400, Tianfei Zhang wrote: > > From: Tianfei zhang > > > > Previously the feature IDs defined are unique, no matter > > which feature type. But currently we want to extend its > > usage to have a per-type feature ID space, so this patch > > adds feature type checking as well just before look into > > feature ID for different features which have irq info. > > > > Reviewed-by: Matthew Gerlach > > Acked-by: Wu Hao > Acked-by: Moritz Fischer Acked-by: Xu Yilun > > Signed-off-by: Tianfei zhang > > --- > > v7: > > - Add Reviewed-by and Acked-by tag. > > v4: > > - Fix the git commit from Hao's comments. > > - Split documentation into another patch. > > v3: > > - Remove "Fixes" in commit log with Hao's comment, this is a > > extension not a bug fix. > > v2: > > - add DFL Feature ID Registry in documentation. > > --- > > drivers/fpga/dfl.c | 38 ++++++++++++++++++++++---------------- > > 1 file changed, 22 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c > > index 599bb21d86af..6bff39ff21a0 100644 > > --- a/drivers/fpga/dfl.c > > +++ b/drivers/fpga/dfl.c > > @@ -940,9 +940,12 @@ static int parse_feature_irqs(struct build_feature_devs_info *binfo, > > { > > void __iomem *base = binfo->ioaddr + ofst; > > unsigned int i, ibase, inr = 0; > > + enum dfl_id_type type; > > int virq; > > u64 v; > > > > + type = feature_dev_id_type(binfo->feature_dev); > > + > > /* > > * Ideally DFL framework should only read info from DFL header, but > > * current version DFL only provides mmio resources information for > > @@ -957,22 +960,25 @@ static int parse_feature_irqs(struct build_feature_devs_info *binfo, > > * code will be added. But in order to be compatible to old version > > * DFL, the driver may still fall back to these quirks. > > */ > > - switch (fid) { > > - case PORT_FEATURE_ID_UINT: > > - v = readq(base + PORT_UINT_CAP); > > - ibase = FIELD_GET(PORT_UINT_CAP_FST_VECT, v); > > - inr = FIELD_GET(PORT_UINT_CAP_INT_NUM, v); > > - break; > > - case PORT_FEATURE_ID_ERROR: > > - v = readq(base + PORT_ERROR_CAP); > > - ibase = FIELD_GET(PORT_ERROR_CAP_INT_VECT, v); > > - inr = FIELD_GET(PORT_ERROR_CAP_SUPP_INT, v); > > - break; > > - case FME_FEATURE_ID_GLOBAL_ERR: > > - v = readq(base + FME_ERROR_CAP); > > - ibase = FIELD_GET(FME_ERROR_CAP_INT_VECT, v); > > - inr = FIELD_GET(FME_ERROR_CAP_SUPP_INT, v); > > - break; > > + if (type == PORT_ID) { > > + switch (fid) { > > + case PORT_FEATURE_ID_UINT: > > + v = readq(base + PORT_UINT_CAP); > > + ibase = FIELD_GET(PORT_UINT_CAP_FST_VECT, v); > > + inr = FIELD_GET(PORT_UINT_CAP_INT_NUM, v); > > + break; > > + case PORT_FEATURE_ID_ERROR: > > + v = readq(base + PORT_ERROR_CAP); > > + ibase = FIELD_GET(PORT_ERROR_CAP_INT_VECT, v); > > + inr = FIELD_GET(PORT_ERROR_CAP_SUPP_INT, v); > > + break; > > + } > > + } else if (type == FME_ID) { > > + if (fid == FME_FEATURE_ID_GLOBAL_ERR) { > > + v = readq(base + FME_ERROR_CAP); > > + ibase = FIELD_GET(FME_ERROR_CAP_INT_VECT, v); > > + inr = FIELD_GET(FME_ERROR_CAP_SUPP_INT, v); > > + } > > } > > > > if (!inr) { > > -- > > 2.26.2 > >