From: Sean Nyekjaer <sean@geanix.com>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: dac: ti-dac5571: add support for ti,dac121c081
Date: Mon, 25 Apr 2022 10:16:01 +0200 [thread overview]
Message-ID: <20220425081601.cs42eujnghzxnxgt@Seans-MBP.hinnerup> (raw)
In-Reply-To: <6e63f598-ff54-6cb6-8c7d-83e9d6231af0@axentia.se>
On Mon, Apr 25, 2022 at 08:02:34AM +0200, Peter Rosin wrote:
> It fits right in as a single 12-bit DAC.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
Reviewed-by: Sean Nyekjaer <sean@geanix.com>
> ---
> drivers/iio/dac/Kconfig | 2 +-
> drivers/iio/dac/ti-dac5571.c | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index c0bf0d84197f..d6248b188645 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -417,7 +417,7 @@ config TI_DAC5571
> help
> Driver for the Texas Instruments
> DAC5571, DAC6571, DAC7571, DAC5574, DAC6574, DAC7574, DAC5573,
> - DAC6573, DAC7573, DAC8571, DAC8574.
> + DAC6573, DAC7573, DAC8571, DAC8574, DAC121C081.
> If compiled as a module, it will be called ti-dac5571.
> diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
> index 4a3b8d875518..ce542bd8b69e 100644
> --- a/drivers/iio/dac/ti-dac5571.c
> +++ b/drivers/iio/dac/ti-dac5571.c
> @@ -13,6 +13,7 @@
> * https://www.ti.com/lit/ds/symlink/dac5573.pdf
> * https://www.ti.com/lit/ds/symlink/dac6573.pdf
> * https://www.ti.com/lit/ds/symlink/dac7573.pdf
> + * https://www.ti.com/lit/ds/symlink/dac121c081.pdf
> */
> #include <linux/iio/iio.h>
> @@ -394,6 +395,7 @@ static const struct of_device_id dac5571_of_id[] = {
> {.compatible = "ti,dac5573"},
> {.compatible = "ti,dac6573"},
> {.compatible = "ti,dac7573"},
> + {.compatible = "ti,dac121c081"},
> {}
> };
> MODULE_DEVICE_TABLE(of, dac5571_of_id);
> @@ -408,6 +410,7 @@ static const struct i2c_device_id dac5571_id[] = {
> {"dac5573", quad_8bit},
> {"dac6573", quad_10bit},
> {"dac7573", quad_12bit},
> + {"dac121c081", single_12bit},
> {}
> };
> MODULE_DEVICE_TABLE(i2c, dac5571_id);
> --
> 2.20.1
>
prev parent reply other threads:[~2022-04-25 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 6:00 [PATCH 0/2] Add support for texas dac121c081 to the dac5571 driver Peter Rosin
2022-04-25 6:02 ` [PATCH 1/2] dt-bindings: iio: ti-dac5571: Add ti,dac121c081 Peter Rosin
2022-04-25 8:15 ` Sean Nyekjaer
2022-04-25 16:23 ` Rob Herring
2022-04-25 6:02 ` [PATCH 2/2] iio: dac: ti-dac5571: add support for ti,dac121c081 Peter Rosin
2022-04-25 8:16 ` Sean Nyekjaer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425081601.cs42eujnghzxnxgt@Seans-MBP.hinnerup \
--to=sean@geanix.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.