All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <mike.kravetz@oracle.com>,
	<naoya.horiguchi@nec.com>
Cc: <ying.huang@intel.com>, <hch@lst.de>, <dhowells@redhat.com>,
	<cl@linux.com>, <david@redhat.com>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>, <linmiaohe@huawei.com>
Subject: [PATCH v2 2/4] mm/migration: remove unneeded lock page and PageMovable check
Date: Mon, 25 Apr 2022 21:27:21 +0800	[thread overview]
Message-ID: <20220425132723.34824-3-linmiaohe@huawei.com> (raw)
In-Reply-To: <20220425132723.34824-1-linmiaohe@huawei.com>

When non-lru movable page was freed from under us, __ClearPageMovable must
have been done. Even if it's not done, ClearPageIsolated here won't hurt
as page will be freed anyway. So we can thus remove unneeded lock page and
PageMovable check here.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 mm/migrate.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index b779646665fe..0fc4651b3e39 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1093,12 +1093,8 @@ static int unmap_and_move(new_page_t get_new_page,
 		/* page was freed from under us. So we are done. */
 		ClearPageActive(page);
 		ClearPageUnevictable(page);
-		if (unlikely(__PageMovable(page))) {
-			lock_page(page);
-			if (!PageMovable(page))
-				ClearPageIsolated(page);
-			unlock_page(page);
-		}
+		if (unlikely(__PageMovable(page)))
+			ClearPageIsolated(page);
 		goto out;
 	}
 
-- 
2.23.0


  parent reply	other threads:[~2022-04-25 13:27 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 13:27 [PATCH v2 0/4] A few cleanup and fixup patches for migration Miaohe Lin
2022-04-25 13:27 ` [PATCH v2 1/4] mm/migration: reduce the rcu lock duration Miaohe Lin
2022-04-29  9:54   ` David Hildenbrand
2022-05-09  3:14     ` Miaohe Lin
2022-05-24 12:36     ` Miaohe Lin
2022-05-06  3:23   ` ying.huang
2022-05-09  3:20     ` Miaohe Lin
2022-04-25 13:27 ` Miaohe Lin [this message]
2022-04-29 10:07   ` [PATCH v2 2/4] mm/migration: remove unneeded lock page and PageMovable check David Hildenbrand
2022-05-09  8:51     ` Miaohe Lin
2022-05-11 15:23       ` David Hildenbrand
2022-05-12  2:25         ` Miaohe Lin
2022-05-12  7:10           ` David Hildenbrand
2022-05-12 13:26             ` Miaohe Lin
2022-05-12 16:50               ` David Hildenbrand
2022-05-16  2:44                 ` Miaohe Lin
2022-05-31 11:59                   ` David Hildenbrand
2022-05-31 12:37                     ` Miaohe Lin
2022-06-01 10:31                       ` David Hildenbrand
2022-06-02  7:40                         ` Miaohe Lin
2022-06-02  8:47                           ` David Hildenbrand
2022-06-07  2:20                             ` Miaohe Lin
2022-06-08 10:05                               ` David Hildenbrand
2022-06-08 13:31                                 ` Miaohe Lin
2022-05-24 12:47                 ` Miaohe Lin
2022-04-25 13:27 ` [PATCH v2 3/4] mm/migration: return errno when isolate_huge_page failed Miaohe Lin
2022-04-29 10:08   ` David Hildenbrand
2022-05-09  8:03     ` Miaohe Lin
2022-04-29 11:36   ` Muchun Song
2022-05-09  3:23     ` Miaohe Lin
2022-05-09  4:21       ` Muchun Song
2022-05-09  7:51         ` Miaohe Lin
2022-04-25 13:27 ` [PATCH v2 4/4] mm/migration: fix potential pte_unmap on an not mapped pte Miaohe Lin
2022-04-29  9:48   ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220425132723.34824-3-linmiaohe@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=david@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=naoya.horiguchi@nec.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.