All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-serial@vger.kernel.org,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Vicente Bergas" <vicencb@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Johan Hovold" <johan@kernel.org>,
	heiko@sntech.de, giulio.benetti@micronovasrl.com,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v4 12/13] serial: 8250_lpss: Use 32-bit reads
Date: Mon, 25 Apr 2022 17:34:09 +0300	[thread overview]
Message-ID: <20220425143410.12703-13-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20220425143410.12703-1-ilpo.jarvinen@linux.intel.com>

Use 32-bit reads in order to not lose higher bits of DW UART regs. This
change does not fix any known issue as the high bits are not used for
anything related to 8250 driver (dw8250_readl_ext and dw8250_writel_ext
used within the dwlib are already doing
readl/writel/ioread32be/iowrite32be anyway).

This change is necessary for the next patch that enables 9th bit
address mode. DW UART reports address frames with BIT(8) of LSR.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/tty/serial/8250/8250_lpss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
index 0f5af061e0b4..4ba43bef9933 100644
--- a/drivers/tty/serial/8250/8250_lpss.c
+++ b/drivers/tty/serial/8250/8250_lpss.c
@@ -330,7 +330,7 @@ static int lpss8250_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	uart.port.irq = pci_irq_vector(pdev, 0);
 	uart.port.private_data = &lpss->data;
 	uart.port.type = PORT_16550A;
-	uart.port.iotype = UPIO_MEM;
+	uart.port.iotype = UPIO_MEM32;
 	uart.port.regshift = 2;
 	uart.port.uartclk = lpss->board->base_baud * 16;
 	uart.port.flags = UPF_SHARE_IRQ | UPF_FIXED_PORT | UPF_FIXED_TYPE;
-- 
2.30.2


  parent reply	other threads:[~2022-04-25 14:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 14:33 [PATCH v4 00/13] Add RS485 support to DW UART Ilpo Järvinen
2022-04-25 14:33 ` [PATCH v4 01/13] serial: Store character timing information to uart_port Ilpo Järvinen
2022-04-25 14:33 ` [PATCH v4 02/13] serial: 8250: use THRE & __stop_tx also with DMA Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 03/13] serial: 8250: Handle UART without interrupt on TEMT Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 04/13] serial: 8250_dwlib: RS485 HW half & full duplex support Ilpo Järvinen
2022-04-26 11:29   ` Greg KH
2022-09-20 11:37   ` Lukas Wunner
2022-09-20 12:01     ` Ilpo Järvinen
2022-09-20 12:10       ` Lukas Wunner
2022-04-25 14:34 ` [PATCH v4 05/13] serial: 8250_dwlib: Implement SW half " Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 06/13] dt_bindings: rs485: Add receiver enable polarity Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 07/13] ACPI / property: Document RS485 _DSD properties Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 08/13] serial: termbits: ADDRB to indicate 9th bit addressing mode Ilpo Järvinen
2022-04-25 14:34   ` Ilpo Järvinen
2022-04-25 14:34   ` Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 09/13] serial: General support for multipoint addresses Ilpo Järvinen
2022-04-25 14:34   ` Ilpo Järvinen
2022-04-25 14:34   ` Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 10/13] serial: 8250: make saved LSR larger Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 11/13] serial: 8250: create lsr_save_mask Ilpo Järvinen
2022-04-25 14:34 ` Ilpo Järvinen [this message]
2022-04-25 14:34 ` [PATCH v4 13/13] serial: 8250_dwlib: Support for 9th bit multipoint addressing Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220425143410.12703-13-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=giulio.benetti@micronovasrl.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=heiko@sntech.de \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vicencb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.