From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB24BC433F5 for ; Mon, 25 Apr 2022 17:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243676AbiDYRDD (ORCPT ); Mon, 25 Apr 2022 13:03:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232710AbiDYRC6 (ORCPT ); Mon, 25 Apr 2022 13:02:58 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E28CF1132C3 for ; Mon, 25 Apr 2022 09:59:53 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A571C1FB; Mon, 25 Apr 2022 09:59:53 -0700 (PDT) Received: from bogus (unknown [10.57.11.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F210B3F5A1; Mon, 25 Apr 2022 09:59:51 -0700 (PDT) Date: Mon, 25 Apr 2022 17:59:46 +0100 From: Sudeep Holla To: =?utf-8?B?546L5pOO?= Cc: Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "vincent.guittot@linaro.org" , "peterz@infradead.org" , "dietmar.eggemann@arm.com" Subject: Re: [PATCH V2] arm64: add SCHED_CLUSTER's dependency on ACPI Message-ID: <20220425165946.qb6xilgmjahdh4pa@bogus> References: <1650855303-91388-1-git-send-email-wangqing@vivo.com> <20220425100635.ig4dxvlflglfagpx@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 25, 2022 at 11:18:21AM +0000, 王擎 wrote: > > >> From: Wang Qing > >> > >> cluster sched_domain configured by cpu_topology[].cluster_sibling, > >> which is set by cluster_id, cluster_id can only get from ACPI. > >> > >> If the system does not enable ACPI, cluster_id is always -1, even enable > >> SCHED_CLUSTER is invalid, this is misleading. > >> > >> So we add SCHED_CLUSTER's dependency on ACPI here. > >> > > > >Any reason why this can't be extended to support DT based systems via > >cpu-map in the device tree. IMO we almost have everything w.r.t topology > >in DT and no reason to deviate this feature between ACPI and DT. > > > That's the problem, we parse out "cluster" info according to the > description in cpu-map, but do assign it to package_id, which used to > configure the MC sched domain, not cluster sched domain. > Right, we haven't updated the code after updating the bindings to match ACPI sockets which are the physical package boundaries. Clusters are not the physical boundaries and the current topology code is not 100% aligned with the bindings after Commit 849b384f92bc ("Documentation: DT: arm: add support for sockets defining package boundaries") > That is to say, "cluster" in cpu-map is used to describe the package_id. > We can't get cluster_id from DT. > That is wrong, we have "socket" to describe the package_id now. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7BF9C433F5 for ; Mon, 25 Apr 2022 17:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k75j4tBNzIrYr9SYEC4Dv82ySQ0P56jfsSKcmGya/dE=; b=Ys4PluefyY0uIi ZjHP4gJH2uvFQu/ELEErs9Nzsqr7ERTs5/DUEj+K2i8bmLor488BkLjqv/ErXaU2xSCbLYawAJ9PV 80R+bhEzNqgdLLQYkziOfPpF/+Q4sb0F84i181appi5DP5LgyrkoRFuDuyXSNJ01QkLyig7Fv+TUv beXW1n0xR+ZogsRGs0d9KkBsG7z50WiW4fZhzdIHalYYLSTZOYcwLPCABH1jD8qpAxKl4LTm3Cmjk 0FkRniPNvJJp40XYEgS4BwEDeyBZEzL8xobaZleLmBn1W4u6xfOxbg2BQLLnRMRR4FEmwJOAo2vAb /cyR4iAcoyh/Cx5J3c/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj247-00AX3p-88; Mon, 25 Apr 2022 16:59:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj243-00AX2q-4n for linux-arm-kernel@lists.infradead.org; Mon, 25 Apr 2022 16:59:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A571C1FB; Mon, 25 Apr 2022 09:59:53 -0700 (PDT) Received: from bogus (unknown [10.57.11.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F210B3F5A1; Mon, 25 Apr 2022 09:59:51 -0700 (PDT) Date: Mon, 25 Apr 2022 17:59:46 +0100 From: Sudeep Holla To: =?utf-8?B?546L5pOO?= Cc: Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "vincent.guittot@linaro.org" , "peterz@infradead.org" , "dietmar.eggemann@arm.com" Subject: Re: [PATCH V2] arm64: add SCHED_CLUSTER's dependency on ACPI Message-ID: <20220425165946.qb6xilgmjahdh4pa@bogus> References: <1650855303-91388-1-git-send-email-wangqing@vivo.com> <20220425100635.ig4dxvlflglfagpx@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220425_095955_269051_93C5B589 X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBcHIgMjUsIDIwMjIgYXQgMTE6MTg6MjFBTSArMDAwMCwg546L5pOOIHdyb3RlOgo+ IAo+ID4+IEZyb206IFdhbmcgUWluZyA8d2FuZ3FpbmdAdml2by5jb20+Cj4gPj4gCj4gPj4gY2x1 c3RlciBzY2hlZF9kb21haW4gY29uZmlndXJlZCBieSBjcHVfdG9wb2xvZ3lbXS5jbHVzdGVyX3Np YmxpbmcsIAo+ID4+IHdoaWNoIGlzIHNldCBieSBjbHVzdGVyX2lkLCBjbHVzdGVyX2lkIGNhbiBv bmx5IGdldCBmcm9tIEFDUEkuCj4gPj4gCj4gPj4gSWYgdGhlIHN5c3RlbSBkb2VzIG5vdCBlbmFi bGUgQUNQSSwgY2x1c3Rlcl9pZCBpcyBhbHdheXMgLTEsIGV2ZW4gZW5hYmxlCj4gPj4gU0NIRURf Q0xVU1RFUiBpcyBpbnZhbGlkLCB0aGlzIGlzIG1pc2xlYWRpbmcuIAo+ID4+IAo+ID4+IFNvIHdl IGFkZCBTQ0hFRF9DTFVTVEVSJ3MgZGVwZW5kZW5jeSBvbiBBQ1BJIGhlcmUuCj4gPj4KPiA+Cj4g PkFueSByZWFzb24gd2h5IHRoaXMgY2FuJ3QgYmUgZXh0ZW5kZWQgdG8gc3VwcG9ydCBEVCBiYXNl ZCBzeXN0ZW1zIHZpYQo+ID5jcHUtbWFwIGluIHRoZSBkZXZpY2UgdHJlZS4gSU1PIHdlIGFsbW9z dCBoYXZlIGV2ZXJ5dGhpbmcgdy5yLnQgdG9wb2xvZ3kKPiA+aW4gRFQgYW5kIG5vIHJlYXNvbiB0 byBkZXZpYXRlIHRoaXMgZmVhdHVyZSBiZXR3ZWVuIEFDUEkgYW5kIERULgo+ID4KPiBUaGF0J3Mg dGhlIHByb2JsZW0sIHdlIHBhcnNlIG91dCAiY2x1c3RlciIgaW5mbyBhY2NvcmRpbmcgdG8gdGhl Cj4gZGVzY3JpcHRpb24gaW4gY3B1LW1hcCwgYnV0IGRvIGFzc2lnbiBpdCB0byBwYWNrYWdlX2lk LCB3aGljaCB1c2VkIHRvCj4gY29uZmlndXJlIHRoZSBNQyBzY2hlZCBkb21haW4sIG5vdCBjbHVz dGVyIHNjaGVkIGRvbWFpbi4KPgoKUmlnaHQsIHdlIGhhdmVuJ3QgdXBkYXRlZCB0aGUgY29kZSBh ZnRlciB1cGRhdGluZyB0aGUgYmluZGluZ3MgdG8gbWF0Y2gKQUNQSSBzb2NrZXRzIHdoaWNoIGFy ZSB0aGUgcGh5c2ljYWwgcGFja2FnZSBib3VuZGFyaWVzLiBDbHVzdGVycyBhcmUgbm90CnRoZSBw aHlzaWNhbCBib3VuZGFyaWVzIGFuZCB0aGUgY3VycmVudCB0b3BvbG9neSBjb2RlIGlzIG5vdCAx MDAlIGFsaWduZWQKd2l0aCB0aGUgYmluZGluZ3MgYWZ0ZXIgQ29tbWl0IDg0OWIzODRmOTJiYyAo IkRvY3VtZW50YXRpb246IERUOiBhcm06IGFkZApzdXBwb3J0IGZvciBzb2NrZXRzIGRlZmluaW5n IHBhY2thZ2UgYm91bmRhcmllcyIpCgo+IFRoYXQgaXMgdG8gc2F5LCAiY2x1c3RlciIgaW4gY3B1 LW1hcCBpcyB1c2VkIHRvIGRlc2NyaWJlIHRoZSBwYWNrYWdlX2lkLgo+IFdlIGNhbid0IGdldCBj bHVzdGVyX2lkIGZyb20gRFQuCj4KClRoYXQgaXMgd3JvbmcsIHdlIGhhdmUgInNvY2tldCIgdG8g ZGVzY3JpYmUgdGhlIHBhY2thZ2VfaWQgbm93LgoKLS0KUmVnYXJkcywKU3VkZWVwCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==