Hello,

On Thu, Mar 31, 2022 at 03:31:32PM +0200, Uwe Kleine-König wrote:
> The only effect of returning an error code in an i2c remove callback is
> that the i2c core emits a generic warning and still removes the device.
> 
> So even if disabling the regulator fails it's sensible to further cleanup
> and then return zero to only emit a single error message.
> 
> This patch is a preparation for making i2c remove callbacks return void.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/media/i2c/dw9714.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i2c/dw9714.c
> index cd7008ad8f2f..982ed8afebf5 100644
> --- a/drivers/media/i2c/dw9714.c
> +++ b/drivers/media/i2c/dw9714.c
> @@ -201,7 +201,6 @@ static int dw9714_remove(struct i2c_client *client)
>  		if (ret) {
>  			dev_err(&client->dev,
>  				"Failed to disable vcc: %d\n", ret);
> -			return ret;
>  		}
>  	}
>  	pm_runtime_set_suspended(&client->dev);

Who cares for this driver and so for this patch?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |