From: kernel test robot <lkp@intel.com>
To: cgel.zte@gmail.com, dan.j.williams@intel.com
Cc: kbuild-all@lists.01.org, vishal.l.verma@intel.com,
dave.jiang@intel.com, nvdimm@lists.linux.dev,
linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] device-dax: use kobj_to_dev()
Date: Tue, 26 Apr 2022 00:33:59 +0800 [thread overview]
Message-ID: <202204260044.wlRoUZiW-lkp@intel.com> (raw)
In-Reply-To: <20220425105307.3515215-1-chi.minghao@zte.com.cn>
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.18-rc4 next-20220422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/device-dax-use-kobj_to_dev/20220425-185400
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git af2d861d4cd2a4da5137f795ee3509e6f944a25b
config: i386-randconfig-r016-20220425 (https://download.01.org/0day-ci/archive/20220426/202204260044.wlRoUZiW-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/83eff180ded41da8e042373de81fa823835a1be0
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review cgel-zte-gmail-com/device-dax-use-kobj_to_dev/20220425-185400
git checkout 83eff180ded41da8e042373de81fa823835a1be0
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/dax/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/dax/bus.c: In function 'dax_region_visible':
>> drivers/dax/bus.c:516:9: error: expected ',' or ';' before 'struct'
516 | struct dax_region *dax_region = dev_get_drvdata(dev);
| ^~~~~~
>> drivers/dax/bus.c:518:23: error: 'dax_region' undeclared (first use in this function)
518 | if (is_static(dax_region))
| ^~~~~~~~~~
drivers/dax/bus.c:518:23: note: each undeclared identifier is reported only once for each function it appears in
drivers/dax/bus.c:515:24: warning: unused variable 'dev' [-Wunused-variable]
515 | struct device *dev = kobj_to_dev(kobj)
| ^~~
vim +516 drivers/dax/bus.c
0f3da14a4f0503 Dan Williams 2020-10-13 511
c2f3011ee697f8 Dan Williams 2020-10-13 512 static umode_t dax_region_visible(struct kobject *kobj, struct attribute *a,
c2f3011ee697f8 Dan Williams 2020-10-13 513 int n)
c2f3011ee697f8 Dan Williams 2020-10-13 514 {
83eff180ded41d Minghao Chi 2022-04-25 515 struct device *dev = kobj_to_dev(kobj)
c2f3011ee697f8 Dan Williams 2020-10-13 @516 struct dax_region *dax_region = dev_get_drvdata(dev);
c2f3011ee697f8 Dan Williams 2020-10-13 517
0f3da14a4f0503 Dan Williams 2020-10-13 @518 if (is_static(dax_region))
0f3da14a4f0503 Dan Williams 2020-10-13 519 if (a == &dev_attr_available_size.attr
0f3da14a4f0503 Dan Williams 2020-10-13 520 || a == &dev_attr_create.attr
0f3da14a4f0503 Dan Williams 2020-10-13 521 || a == &dev_attr_seed.attr
0f3da14a4f0503 Dan Williams 2020-10-13 522 || a == &dev_attr_delete.attr)
c2f3011ee697f8 Dan Williams 2020-10-13 523 return 0;
c2f3011ee697f8 Dan Williams 2020-10-13 524 return a->mode;
c2f3011ee697f8 Dan Williams 2020-10-13 525 }
c2f3011ee697f8 Dan Williams 2020-10-13 526
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-04-25 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 10:53 [PATCH] device-dax: use kobj_to_dev() cgel.zte
2022-04-25 16:33 ` kernel test robot [this message]
2022-04-25 18:25 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204260044.wlRoUZiW-lkp@intel.com \
--to=lkp@intel.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.