From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB1DC433EF for ; Tue, 26 Apr 2022 06:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245759AbiDZGoO (ORCPT ); Tue, 26 Apr 2022 02:44:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245641AbiDZGoG (ORCPT ); Tue, 26 Apr 2022 02:44:06 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 097701B784 for ; Mon, 25 Apr 2022 23:40:59 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C686623A; Mon, 25 Apr 2022 23:40:58 -0700 (PDT) Received: from bogus (unknown [10.57.11.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8CC343F5A1; Mon, 25 Apr 2022 23:40:57 -0700 (PDT) Date: Tue, 26 Apr 2022 07:40:53 +0100 From: Sudeep Holla To: =?utf-8?B?546L5pOO?= Cc: Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "vincent.guittot@linaro.org" , "peterz@infradead.org" , "dietmar.eggemann@arm.com" Subject: Re: [PATCH V2] arm64: add SCHED_CLUSTER's dependency on ACPI Message-ID: <20220426064053.h4rwvcdvmwxj2hmt@bogus> References: <1650855303-91388-1-git-send-email-wangqing@vivo.com> <20220425100635.ig4dxvlflglfagpx@bogus> <20220425165946.qb6xilgmjahdh4pa@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2022 at 02:23:25AM +0000, 王擎 wrote: > > >> > >> >> From: Wang Qing > >> >> > >> >> cluster sched_domain configured by cpu_topology[].cluster_sibling, > >> >> which is set by cluster_id, cluster_id can only get from ACPI. > >> >> > >> >> If the system does not enable ACPI, cluster_id is always -1, even enable > >> >> SCHED_CLUSTER is invalid, this is misleading. > >> >> > >> >> So we add SCHED_CLUSTER's dependency on ACPI here. > >> >> > >> > > >> >Any reason why this can't be extended to support DT based systems via > >> >cpu-map in the device tree. IMO we almost have everything w.r.t topology > >> >in DT and no reason to deviate this feature between ACPI and DT. > >> > > >> That's the problem, we parse out "cluster" info according to the > >> description in cpu-map, but do assign it to package_id, which used to > >> configure the MC sched domain, not cluster sched domain. > >> > > > >Right, we haven't updated the code after updating the bindings to match > >ACPI sockets which are the physical package boundaries. Clusters are not > >the physical boundaries and the current topology code is not 100% aligned > >with the bindings after Commit 849b384f92bc ("Documentation: DT: arm: add > >support for sockets defining package boundaries") > > I see, but this commit is a long time ago, why hasn't it been used widely. > Maybe I can help about it if you need. > I assume no one cared or had a requirement for the same. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADFDAC433F5 for ; Tue, 26 Apr 2022 06:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0aMWTKPGt4KsJ14qyuVVqE72NWj0L7XJiPpc1+zYjzI=; b=SoZz0eMmrAbpeT taUUC64AWJ278Qb/3rEdEOnEcsTxLkqhVwdS2NEBiguNpP2nL6Py4WbOfag3TX/zc3Ubn/RU1P830 ejst4yxTNIOHu3VIgKJc8k66XUqaJp7sgqi05faEXaW9gNFbNSHQUmi5qWq0/HV7s8JCtLWkzSM5R ApEJc1Ztr9i4O874kGbZZp3u4b1h1SfeVTIKe6ZZEq1JeHsv4uEr/jpLM4TzE+TBBCnPHemRFfCaa HfK9FMloULO3zLLFh230ABzSMBj5BP2XtRkDWExjkGGie2bLSC3QpN5nC8x78W8G/n9iPt7y8bWHR WArV1UdH6hrok2uTJdAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njEsj-00Cluc-9C; Tue, 26 Apr 2022 06:41:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njEsf-00Clsw-CR for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 06:41:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C686623A; Mon, 25 Apr 2022 23:40:58 -0700 (PDT) Received: from bogus (unknown [10.57.11.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8CC343F5A1; Mon, 25 Apr 2022 23:40:57 -0700 (PDT) Date: Tue, 26 Apr 2022 07:40:53 +0100 From: Sudeep Holla To: =?utf-8?B?546L5pOO?= Cc: Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "vincent.guittot@linaro.org" , "peterz@infradead.org" , "dietmar.eggemann@arm.com" Subject: Re: [PATCH V2] arm64: add SCHED_CLUSTER's dependency on ACPI Message-ID: <20220426064053.h4rwvcdvmwxj2hmt@bogus> References: <1650855303-91388-1-git-send-email-wangqing@vivo.com> <20220425100635.ig4dxvlflglfagpx@bogus> <20220425165946.qb6xilgmjahdh4pa@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220425_234101_536526_105D43C8 X-CRM114-Status: GOOD ( 19.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMjYsIDIwMjIgYXQgMDI6MjM6MjVBTSArMDAwMCwg546L5pOOIHdyb3RlOgo+ IAo+ID4+IAo+ID4+ID4+IEZyb206IFdhbmcgUWluZyA8d2FuZ3FpbmdAdml2by5jb20+Cj4gPj4g Pj4gCj4gPj4gPj4gY2x1c3RlciBzY2hlZF9kb21haW4gY29uZmlndXJlZCBieSBjcHVfdG9wb2xv Z3lbXS5jbHVzdGVyX3NpYmxpbmcsIAo+ID4+ID4+IHdoaWNoIGlzIHNldCBieSBjbHVzdGVyX2lk LCBjbHVzdGVyX2lkIGNhbiBvbmx5IGdldCBmcm9tIEFDUEkuCj4gPj4gPj4gCj4gPj4gPj4gSWYg dGhlIHN5c3RlbSBkb2VzIG5vdCBlbmFibGUgQUNQSSwgY2x1c3Rlcl9pZCBpcyBhbHdheXMgLTEs IGV2ZW4gZW5hYmxlCj4gPj4gPj4gU0NIRURfQ0xVU1RFUiBpcyBpbnZhbGlkLCB0aGlzIGlzIG1p c2xlYWRpbmcuIAo+ID4+ID4+IAo+ID4+ID4+IFNvIHdlIGFkZCBTQ0hFRF9DTFVTVEVSJ3MgZGVw ZW5kZW5jeSBvbiBBQ1BJIGhlcmUuCj4gPj4gPj4KPiA+PiA+Cj4gPj4gPkFueSByZWFzb24gd2h5 IHRoaXMgY2FuJ3QgYmUgZXh0ZW5kZWQgdG8gc3VwcG9ydCBEVCBiYXNlZCBzeXN0ZW1zIHZpYQo+ ID4+ID5jcHUtbWFwIGluIHRoZSBkZXZpY2UgdHJlZS4gSU1PIHdlIGFsbW9zdCBoYXZlIGV2ZXJ5 dGhpbmcgdy5yLnQgdG9wb2xvZ3kKPiA+PiA+aW4gRFQgYW5kIG5vIHJlYXNvbiB0byBkZXZpYXRl IHRoaXMgZmVhdHVyZSBiZXR3ZWVuIEFDUEkgYW5kIERULgo+ID4+ID4KPiA+PiBUaGF0J3MgdGhl IHByb2JsZW0sIHdlIHBhcnNlIG91dCAiY2x1c3RlciIgaW5mbyBhY2NvcmRpbmcgdG8gdGhlCj4g Pj4gZGVzY3JpcHRpb24gaW4gY3B1LW1hcCwgYnV0IGRvIGFzc2lnbiBpdCB0byBwYWNrYWdlX2lk LCB3aGljaCB1c2VkIHRvCj4gPj4gY29uZmlndXJlIHRoZSBNQyBzY2hlZCBkb21haW4sIG5vdCBj bHVzdGVyIHNjaGVkIGRvbWFpbi4KPiA+Pgo+ID4KPiA+UmlnaHQsIHdlIGhhdmVuJ3QgdXBkYXRl ZCB0aGUgY29kZSBhZnRlciB1cGRhdGluZyB0aGUgYmluZGluZ3MgdG8gbWF0Y2gKPiA+QUNQSSBz b2NrZXRzIHdoaWNoIGFyZSB0aGUgcGh5c2ljYWwgcGFja2FnZSBib3VuZGFyaWVzLiBDbHVzdGVy cyBhcmUgbm90Cj4gPnRoZSBwaHlzaWNhbCBib3VuZGFyaWVzIGFuZCB0aGUgY3VycmVudCB0b3Bv bG9neSBjb2RlIGlzIG5vdCAxMDAlIGFsaWduZWQKPiA+d2l0aCB0aGUgYmluZGluZ3MgYWZ0ZXIg Q29tbWl0IDg0OWIzODRmOTJiYyAoIkRvY3VtZW50YXRpb246IERUOiBhcm06IGFkZAo+ID5zdXBw b3J0IGZvciBzb2NrZXRzIGRlZmluaW5nIHBhY2thZ2UgYm91bmRhcmllcyIpCj4KPiBJIHNlZSwg YnV0IHRoaXMgY29tbWl0IGlzIGEgbG9uZyB0aW1lIGFnbywgd2h5IGhhc24ndCBpdCBiZWVuIHVz ZWQgd2lkZWx5Lgo+IE1heWJlIEkgY2FuIGhlbHAgYWJvdXQgaXQgaWYgeW91IG5lZWQuCj4KCkkg YXNzdW1lIG5vIG9uZSBjYXJlZCBvciBoYWQgYSByZXF1aXJlbWVudCBmb3IgdGhlIHNhbWUuCgot LQpSZWdhcmRzLApTdWRlZXAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK