From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 834EEC433EF for ; Tue, 26 Apr 2022 13:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346001AbiDZN2Z (ORCPT ); Tue, 26 Apr 2022 09:28:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232849AbiDZN2X (ORCPT ); Tue, 26 Apr 2022 09:28:23 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 60B9F15837 for ; Tue, 26 Apr 2022 06:25:15 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF237ED1; Tue, 26 Apr 2022 06:25:14 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5BBD3F774; Tue, 26 Apr 2022 06:25:13 -0700 (PDT) Date: Tue, 26 Apr 2022 14:25:11 +0100 From: Sudeep Holla To: =?utf-8?B?546L5pOO?= Cc: Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "vincent.guittot@linaro.org" , "peterz@infradead.org" , "dietmar.eggemann@arm.com" Subject: Re: [PATCH V2] arm64: add SCHED_CLUSTER's dependency on ACPI Message-ID: <20220426132511.7zo4w42kauvrq26n@bogus> References: <1650855303-91388-1-git-send-email-wangqing@vivo.com> <20220425100635.ig4dxvlflglfagpx@bogus> <20220425165946.qb6xilgmjahdh4pa@bogus> <20220426064053.h4rwvcdvmwxj2hmt@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2022 at 06:52:34AM +0000, 王擎 wrote: > > >> > >> >> > >> >> >> From: Wang Qing > >> >> >> > >> >> >> cluster sched_domain configured by cpu_topology[].cluster_sibling, > >> >> >> which is set by cluster_id, cluster_id can only get from ACPI. > >> >> >> > >> >> >> If the system does not enable ACPI, cluster_id is always -1, even enable > >> >> >> SCHED_CLUSTER is invalid, this is misleading. > >> >> >> > >> >> >> So we add SCHED_CLUSTER's dependency on ACPI here. > >> >> >> > >> >> > > >> >> >Any reason why this can't be extended to support DT based systems via > >> >> >cpu-map in the device tree. IMO we almost have everything w.r.t topology > >> >> >in DT and no reason to deviate this feature between ACPI and DT. > >> >> > > >> >> That's the problem, we parse out "cluster" info according to the > >> >> description in cpu-map, but do assign it to package_id, which used to > >> >> configure the MC sched domain, not cluster sched domain. > >> >> > >> > > >> >Right, we haven't updated the code after updating the bindings to match > >> >ACPI sockets which are the physical package boundaries. Clusters are not > >> >the physical boundaries and the current topology code is not 100% aligned > >> >with the bindings after Commit 849b384f92bc ("Documentation: DT: arm: add > >> >support for sockets defining package boundaries") > >> > >> I see, but this commit is a long time ago, why hasn't it been used widely. > >> Maybe I can help about it if you need. > >> > > > >I assume no one cared or had a requirement for the same. > > It took me a while to find the root cause why enabling SCHED_CLUSTER > didn't work. > > We should add SCHED_CLUSTER's dependency before implementation. > Otherwise, everyone who doesn't have ACPI but use SCHED_CLUSTER > will have this problem. > I am fine with that or mark it broken for DT, but ideally I wouldn't want to create unnecessary dependency on ACPI or DT when both supports the feature. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EA57C433F5 for ; Tue, 26 Apr 2022 13:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NizJcqQKxxr+RP6E/vDCCH5QD7r5pSBCYdxxxQGWIWg=; b=DXIMshNvkbSKND h6NBLlusOdKPULMYpxT8cOLFHoYtovTTHRe7JGkbT84PFCoGNxOjJG/wf6eKQMT3MxdcAnMq2aTFl O3fOK8r4V4rIJykqcOFe57NCGGpcrnrmkFNTeaBU9NSf63QKLoMmQ45QdotNEqTVjnVcmmQ/E+Pbv OUbJcwpQsywcHSASy3QVN8itL/nkXq/P3FhtWrzF+dsANhaHHRPhOl5o/VcLWRVrMTaAVc8WC/+K+ YKg7hVE+sMJfe+KQNY3JNeGhCbZed2XFyEWfGjae0L4tzzHhonVHZlQLz9e2RaRCRZOw4rQf2qWl3 W2nZnqsnLqYNhZkBOsAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njLEi-00Eb9a-SY; Tue, 26 Apr 2022 13:28:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njLBt-00EZZQ-O6 for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 13:25:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF237ED1; Tue, 26 Apr 2022 06:25:14 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5BBD3F774; Tue, 26 Apr 2022 06:25:13 -0700 (PDT) Date: Tue, 26 Apr 2022 14:25:11 +0100 From: Sudeep Holla To: =?utf-8?B?546L5pOO?= Cc: Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "vincent.guittot@linaro.org" , "peterz@infradead.org" , "dietmar.eggemann@arm.com" Subject: Re: [PATCH V2] arm64: add SCHED_CLUSTER's dependency on ACPI Message-ID: <20220426132511.7zo4w42kauvrq26n@bogus> References: <1650855303-91388-1-git-send-email-wangqing@vivo.com> <20220425100635.ig4dxvlflglfagpx@bogus> <20220425165946.qb6xilgmjahdh4pa@bogus> <20220426064053.h4rwvcdvmwxj2hmt@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_062517_868882_7E288BCE X-CRM114-Status: GOOD ( 24.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMjYsIDIwMjIgYXQgMDY6NTI6MzRBTSArMDAwMCwg546L5pOOIHdyb3RlOgo+ IAo+ID4+IAo+ID4+ID4+IAo+ID4+ID4+ID4+IEZyb206IFdhbmcgUWluZyA8d2FuZ3FpbmdAdml2 by5jb20+Cj4gPj4gPj4gPj4gCj4gPj4gPj4gPj4gY2x1c3RlciBzY2hlZF9kb21haW4gY29uZmln dXJlZCBieSBjcHVfdG9wb2xvZ3lbXS5jbHVzdGVyX3NpYmxpbmcsIAo+ID4+ID4+ID4+IHdoaWNo IGlzIHNldCBieSBjbHVzdGVyX2lkLCBjbHVzdGVyX2lkIGNhbiBvbmx5IGdldCBmcm9tIEFDUEku Cj4gPj4gPj4gPj4gCj4gPj4gPj4gPj4gSWYgdGhlIHN5c3RlbSBkb2VzIG5vdCBlbmFibGUgQUNQ SSwgY2x1c3Rlcl9pZCBpcyBhbHdheXMgLTEsIGV2ZW4gZW5hYmxlCj4gPj4gPj4gPj4gU0NIRURf Q0xVU1RFUiBpcyBpbnZhbGlkLCB0aGlzIGlzIG1pc2xlYWRpbmcuIAo+ID4+ID4+ID4+IAo+ID4+ ID4+ID4+IFNvIHdlIGFkZCBTQ0hFRF9DTFVTVEVSJ3MgZGVwZW5kZW5jeSBvbiBBQ1BJIGhlcmUu Cj4gPj4gPj4gPj4KPiA+PiA+PiA+Cj4gPj4gPj4gPkFueSByZWFzb24gd2h5IHRoaXMgY2FuJ3Qg YmUgZXh0ZW5kZWQgdG8gc3VwcG9ydCBEVCBiYXNlZCBzeXN0ZW1zIHZpYQo+ID4+ID4+ID5jcHUt bWFwIGluIHRoZSBkZXZpY2UgdHJlZS4gSU1PIHdlIGFsbW9zdCBoYXZlIGV2ZXJ5dGhpbmcgdy5y LnQgdG9wb2xvZ3kKPiA+PiA+PiA+aW4gRFQgYW5kIG5vIHJlYXNvbiB0byBkZXZpYXRlIHRoaXMg ZmVhdHVyZSBiZXR3ZWVuIEFDUEkgYW5kIERULgo+ID4+ID4+ID4KPiA+PiA+PiBUaGF0J3MgdGhl IHByb2JsZW0sIHdlIHBhcnNlIG91dCAiY2x1c3RlciIgaW5mbyBhY2NvcmRpbmcgdG8gdGhlCj4g Pj4gPj4gZGVzY3JpcHRpb24gaW4gY3B1LW1hcCwgYnV0IGRvIGFzc2lnbiBpdCB0byBwYWNrYWdl X2lkLCB3aGljaCB1c2VkIHRvCj4gPj4gPj4gY29uZmlndXJlIHRoZSBNQyBzY2hlZCBkb21haW4s IG5vdCBjbHVzdGVyIHNjaGVkIGRvbWFpbi4KPiA+PiA+Pgo+ID4+ID4KPiA+PiA+UmlnaHQsIHdl IGhhdmVuJ3QgdXBkYXRlZCB0aGUgY29kZSBhZnRlciB1cGRhdGluZyB0aGUgYmluZGluZ3MgdG8g bWF0Y2gKPiA+PiA+QUNQSSBzb2NrZXRzIHdoaWNoIGFyZSB0aGUgcGh5c2ljYWwgcGFja2FnZSBi b3VuZGFyaWVzLiBDbHVzdGVycyBhcmUgbm90Cj4gPj4gPnRoZSBwaHlzaWNhbCBib3VuZGFyaWVz IGFuZCB0aGUgY3VycmVudCB0b3BvbG9neSBjb2RlIGlzIG5vdCAxMDAlIGFsaWduZWQKPiA+PiA+ d2l0aCB0aGUgYmluZGluZ3MgYWZ0ZXIgQ29tbWl0IDg0OWIzODRmOTJiYyAoIkRvY3VtZW50YXRp b246IERUOiBhcm06IGFkZAo+ID4+ID5zdXBwb3J0IGZvciBzb2NrZXRzIGRlZmluaW5nIHBhY2th Z2UgYm91bmRhcmllcyIpCj4gPj4KPiA+PiBJIHNlZSwgYnV0IHRoaXMgY29tbWl0IGlzIGEgbG9u ZyB0aW1lIGFnbywgd2h5IGhhc24ndCBpdCBiZWVuIHVzZWQgd2lkZWx5Lgo+ID4+IE1heWJlIEkg Y2FuIGhlbHAgYWJvdXQgaXQgaWYgeW91IG5lZWQuCj4gPj4KPiA+Cj4gPkkgYXNzdW1lIG5vIG9u ZSBjYXJlZCBvciBoYWQgYSByZXF1aXJlbWVudCBmb3IgdGhlIHNhbWUuCj4gCj4gSXQgdG9vayBt ZSBhIHdoaWxlIHRvIGZpbmQgdGhlIHJvb3QgY2F1c2Ugd2h5IGVuYWJsaW5nIFNDSEVEX0NMVVNU RVIKPiBkaWRuJ3Qgd29yay4KPiAKPiBXZSBzaG91bGQgYWRkIFNDSEVEX0NMVVNURVIncyBkZXBl bmRlbmN5IGJlZm9yZSBpbXBsZW1lbnRhdGlvbi4KPiBPdGhlcndpc2UsIGV2ZXJ5b25lIHdobyBk b2Vzbid0IGhhdmUgQUNQSSBidXQgdXNlIFNDSEVEX0NMVVNURVIgCj4gd2lsbCBoYXZlIHRoaXMg cHJvYmxlbS4KPiAKCkkgYW0gZmluZSB3aXRoIHRoYXQgb3IgbWFyayBpdCBicm9rZW4gZm9yIERU LCBidXQgaWRlYWxseSBJIHdvdWxkbid0CndhbnQgdG8gY3JlYXRlIHVubmVjZXNzYXJ5IGRlcGVu ZGVuY3kgb24gQUNQSSBvciBEVCB3aGVuIGJvdGggc3VwcG9ydHMKdGhlIGZlYXR1cmUuCgotLSAK UmVnYXJkcywKU3VkZWVwCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==